[INFO] cloning repository https://github.com/xlprotips/xl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/xlprotips/xl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxlprotips%2Fxl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxlprotips%2Fxl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9c95ec615129e9af1294917343bd03173dd4685c [INFO] linting xlprotips/xl against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxlprotips%2Fxl" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/xlprotips/xl [INFO] finished tweaking git repo https://github.com/xlprotips/xl [INFO] tweaked toml for git repo https://github.com/xlprotips/xl written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/xlprotips/xl on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/xlprotips/xl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libbz2-rs-sys v0.2.2 [INFO] [stderr] Downloaded bzip2 v0.6.1 [INFO] [stderr] Downloaded deflate64 v0.1.10 [INFO] [stderr] Downloaded libz-rs-sys v0.5.4 [INFO] [stderr] Downloaded ppmd-rust v1.3.0 [INFO] [stderr] Downloaded zip v7.0.0 [INFO] [stderr] Downloaded zlib-rs v0.5.4 [INFO] [stderr] Downloaded lzma-rust2 v0.15.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7fed2d09e2fdcb0b90ca70bdb1c2587fa81025e6810096bf74e22af862cf3de2 [INFO] running `Command { std: "docker" "start" "-a" "7fed2d09e2fdcb0b90ca70bdb1c2587fa81025e6810096bf74e22af862cf3de2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7fed2d09e2fdcb0b90ca70bdb1c2587fa81025e6810096bf74e22af862cf3de2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fed2d09e2fdcb0b90ca70bdb1c2587fa81025e6810096bf74e22af862cf3de2", kill_on_drop: false }` [INFO] [stdout] 7fed2d09e2fdcb0b90ca70bdb1c2587fa81025e6810096bf74e22af862cf3de2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae2e34bbb0f56c9d86bbc0489830c21c3134fd948746e2737da995d75340db62 [INFO] running `Command { std: "docker" "start" "-a" "ae2e34bbb0f56c9d86bbc0489830c21c3134fd948746e2737da995d75340db62", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zlib-rs v0.5.4 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking crc v3.3.0 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling cc v1.2.50 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking libbz2-rs-sys v0.2.2 [INFO] [stderr] Checking time-core v0.1.6 [INFO] [stderr] Checking bumpalo v3.19.1 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking lzma-rust2 v0.15.4 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking bzip2 v0.6.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking libz-rs-sys v0.5.4 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking deflate64 v0.1.10 [INFO] [stderr] Checking ppmd-rust v1.3.0 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking zip v7.0.0 [INFO] [stderr] Checking xl v0.1.82 (/opt/rustwide/workdir) [INFO] [stdout] warning: needless `fn main` in doctest [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | //! fn main () { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main [INFO] [stdout] = note: `#[warn(clippy::needless_doctest_main)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wb.rs:103:63 [INFO] [stdout] | [INFO] [stdout] 103 | fn go(&self) -> SheetNameOrNum<'_> { SheetNameOrNum::Name(*self) } [INFO] [stdout] | ^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wb.rs:311:45 [INFO] [stdout] | [INFO] [stdout] 311 | let zip_file = match fs::File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/wb.rs:345:16 [INFO] [stdout] | [INFO] [stdout] 345 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `file.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/wb.rs:345:16 [INFO] [stdout] | [INFO] [stdout] 345 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `(*file.name())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wb.rs:345:16 [INFO] [stdout] | [INFO] [stdout] 345 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `file.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/wb.rs:390:29 [INFO] [stdout] | [INFO] [stdout] 390 | / ... if att == "preserve" { [INFO] [stdout] 391 | | ... preserve_space = true; [INFO] [stdout] 392 | | ... } else { [INFO] [stdout] 393 | | ... preserve_space = false; [INFO] [stdout] 394 | | ... } [INFO] [stdout] | |_______________________^ help: you can reduce it to: `preserve_space = att == "preserve";` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless `fn main` in doctest [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | //! fn main () { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main [INFO] [stdout] = note: `#[warn(clippy::needless_doctest_main)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wb.rs:103:63 [INFO] [stdout] | [INFO] [stdout] 103 | fn go(&self) -> SheetNameOrNum<'_> { SheetNameOrNum::Name(*self) } [INFO] [stdout] | ^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/utils.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | if !('A'..='Z').contains(&c) { return None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - if !('A'..='Z').contains(&c) { return None } [INFO] [stdout] 28 + if !c.is_ascii_uppercase() { return None } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wb.rs:311:45 [INFO] [stdout] | [INFO] [stdout] 311 | let zip_file = match fs::File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/wb.rs:345:16 [INFO] [stdout] | [INFO] [stdout] 345 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `file.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/wb.rs:345:16 [INFO] [stdout] | [INFO] [stdout] 345 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `(*file.name())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wb.rs:345:16 [INFO] [stdout] | [INFO] [stdout] 345 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `file.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/wb.rs:390:29 [INFO] [stdout] | [INFO] [stdout] 390 | / ... if att == "preserve" { [INFO] [stdout] 391 | | ... preserve_space = true; [INFO] [stdout] 392 | | ... } else { [INFO] [stdout] 393 | | ... preserve_space = false; [INFO] [stdout] 394 | | ... } [INFO] [stdout] | |_______________________^ help: you can reduce it to: `preserve_space = att == "preserve";` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/lib.rs:324:10 [INFO] [stdout] | [INFO] [stdout] 324 | .replace('\n', " ") [INFO] [stdout] | __________^ [INFO] [stdout] 325 | | .replace('\r', " ") [INFO] [stdout] | |___________________________^ help: replace with: `replace(['\n', '\r'], " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wb.rs:574:21 [INFO] [stdout] | [INFO] [stdout] 574 | assert!(!sheets.get("Unknown").is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sheets.get("Unknown").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wb.rs:581:21 [INFO] [stdout] | [INFO] [stdout] 581 | assert!(!sheets.get(0).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sheets.get(0).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/wb.rs:596:24 [INFO] [stdout] | [INFO] [stdout] 596 | let row1 = ws.rows(&mut wb).nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `ws.rows(&mut wb).next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/utils.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | if !('A'..='Z').contains(&c) { return None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - if !('A'..='Z').contains(&c) { return None } [INFO] [stdout] 28 + if !c.is_ascii_uppercase() { return None } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/lib.rs:324:10 [INFO] [stdout] | [INFO] [stdout] 324 | .replace('\n', " ") [INFO] [stdout] | __________^ [INFO] [stdout] 325 | | .replace('\r', " ") [INFO] [stdout] | |___________________________^ help: replace with: `replace(['\n', '\r'], " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.32s [INFO] running `Command { std: "docker" "inspect" "ae2e34bbb0f56c9d86bbc0489830c21c3134fd948746e2737da995d75340db62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae2e34bbb0f56c9d86bbc0489830c21c3134fd948746e2737da995d75340db62", kill_on_drop: false }` [INFO] [stdout] ae2e34bbb0f56c9d86bbc0489830c21c3134fd948746e2737da995d75340db62