[INFO] cloning repository https://github.com/xiuxiu62/c-ish [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/xiuxiu62/c-ish" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxiuxiu62%2Fc-ish", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxiuxiu62%2Fc-ish'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 781268b36e2dc50c1810c2d3926d90eef3d9bdd1 [INFO] linting xiuxiu62/c-ish against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxiuxiu62%2Fc-ish" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/xiuxiu62/c-ish [INFO] finished tweaking git repo https://github.com/xiuxiu62/c-ish [INFO] tweaked toml for git repo https://github.com/xiuxiu62/c-ish written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/xiuxiu62/c-ish on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/xiuxiu62/c-ish already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5e1e2076682a854c46182287415bfd6f619982bc6b69e9fa1e276394152b5d2 [INFO] running `Command { std: "docker" "start" "-a" "e5e1e2076682a854c46182287415bfd6f619982bc6b69e9fa1e276394152b5d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5e1e2076682a854c46182287415bfd6f619982bc6b69e9fa1e276394152b5d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5e1e2076682a854c46182287415bfd6f619982bc6b69e9fa1e276394152b5d2", kill_on_drop: false }` [INFO] [stdout] e5e1e2076682a854c46182287415bfd6f619982bc6b69e9fa1e276394152b5d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8da62bb09efe8e27d84bc4e1879d72939e0b20502c014d7bd212ae5c2986c59f [INFO] running `Command { std: "docker" "start" "-a" "8da62bb09efe8e27d84bc4e1879d72939e0b20502c014d7bd212ae5c2986c59f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Checking c-ish-compiler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lexer/mod.rs:136:23 [INFO] [stdout] | [INFO] [stdout] 136 | const TEST_DATA: &'static str = "void fn hello(void);\nchar* temp = \"hello\";"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lexer/mod.rs:142:26 [INFO] [stdout] | [INFO] [stdout] 142 | const EXPECTED: &'static str = "void fn hello ( void ) ;\nchar* temp = \"hello\" ;\u{A0}"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | const TEST_DATA: &'static str = "void hello(void) { return; } \nchar* temp = \"hello\";"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | const TEST_DATA: &'static str = "void hello(void) { return; } \nchar* temp = \"hello\";"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/lexer/token.rs:389:34 [INFO] [stdout] | [INFO] [stdout] 389 | let rest_allowed = chars.fold(true, |acc, char| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 390 | | acc && (char.is_alphanumeric() || char == '_') [INFO] [stdout] 391 | | }); [INFO] [stdout] | |__________^ help: try: `all(|char| (char.is_alphanumeric() || char == '_'))` [INFO] [stdout] | [INFO] [stdout] = note: the `all` method is short circuiting and may change the program semantics if the iterator has side effects [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer/mod.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | if char == '"' [INFO] [stdout] | ________________^ [INFO] [stdout] 66 | | && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 | | || !inside_string) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 - if char == '"' [INFO] [stdout] 66 - && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 - || !inside_string) [INFO] [stdout] 65 + if !(char != '"' || inside_string && self.peek_back().map(|&(_, char)| char) == Some('\\')) [INFO] [stdout] | [INFO] [stdout] 65 - if char == '"' [INFO] [stdout] 66 - && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 - || !inside_string) [INFO] [stdout] 65 + if (self.peek_back().map(|&(_, char)| char) != Some('\\') || !inside_string) && char == '"' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer/mod.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] | ____________________^ [INFO] [stdout] 67 | | || !inside_string) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 - && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 - || !inside_string) [INFO] [stdout] 66 + && !(inside_string && self.peek_back().map(|&(_, char)| char) == Some('\\')) [INFO] [stdout] | [INFO] [stdout] 66 - && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 - || !inside_string) [INFO] [stdout] 66 + && !inside_string || self.peek_back().map(|&(_, char)| char) != Some('\\') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/lexer/token.rs:389:34 [INFO] [stdout] | [INFO] [stdout] 389 | let rest_allowed = chars.fold(true, |acc, char| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 390 | | acc && (char.is_alphanumeric() || char == '_') [INFO] [stdout] 391 | | }); [INFO] [stdout] | |__________^ help: try: `all(|char| (char.is_alphanumeric() || char == '_'))` [INFO] [stdout] | [INFO] [stdout] = note: the `all` method is short circuiting and may change the program semantics if the iterator has side effects [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer/mod.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | if char == '"' [INFO] [stdout] | ________________^ [INFO] [stdout] 66 | | && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 | | || !inside_string) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 - if char == '"' [INFO] [stdout] 66 - && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 - || !inside_string) [INFO] [stdout] 65 + if !(char != '"' || inside_string && self.peek_back().map(|&(_, char)| char) == Some('\\')) [INFO] [stdout] | [INFO] [stdout] 65 - if char == '"' [INFO] [stdout] 66 - && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 - || !inside_string) [INFO] [stdout] 65 + if (self.peek_back().map(|&(_, char)| char) != Some('\\') || !inside_string) && char == '"' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer/mod.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] | ____________________^ [INFO] [stdout] 67 | | || !inside_string) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 - && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 - || !inside_string) [INFO] [stdout] 66 + && !(inside_string && self.peek_back().map(|&(_, char)| char) == Some('\\')) [INFO] [stdout] | [INFO] [stdout] 66 - && ((inside_string && self.peek_back().map(|&(_, char)| char) != Some('\\')) [INFO] [stdout] 67 - || !inside_string) [INFO] [stdout] 66 + && !inside_string || self.peek_back().map(|&(_, char)| char) != Some('\\') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.20s [INFO] running `Command { std: "docker" "inspect" "8da62bb09efe8e27d84bc4e1879d72939e0b20502c014d7bd212ae5c2986c59f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8da62bb09efe8e27d84bc4e1879d72939e0b20502c014d7bd212ae5c2986c59f", kill_on_drop: false }` [INFO] [stdout] 8da62bb09efe8e27d84bc4e1879d72939e0b20502c014d7bd212ae5c2986c59f