[INFO] cloning repository https://github.com/ximon18/donkey-mule-horse [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ximon18/donkey-mule-horse" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fximon18%2Fdonkey-mule-horse", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fximon18%2Fdonkey-mule-horse'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9dd8ff5d8f438b03559ee90306bb7eae2e649134 [INFO] linting ximon18/donkey-mule-horse against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fximon18%2Fdonkey-mule-horse" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ximon18/donkey-mule-horse [INFO] finished tweaking git repo https://github.com/ximon18/donkey-mule-horse [INFO] tweaked toml for git repo https://github.com/ximon18/donkey-mule-horse written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ximon18/donkey-mule-horse on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ximon18/donkey-mule-horse already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/NLnetLabs/rotonda-store.git` [INFO] [stderr] Updating git repository `https://github.com/NLnetLabs/try-tries-and-trees` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded shrust v0.0.7 [INFO] [stderr] Downloaded array-init v2.0.0 [INFO] [stderr] Downloaded routecore v0.1.0 [INFO] [stderr] Downloaded time-graph-macros v0.1.0 [INFO] [stderr] Downloaded tint v1.0.1 [INFO] [stderr] Downloaded term-table v1.3.2 [INFO] [stderr] Downloaded ip_network_table-deps-treebitmap v0.5.0 [INFO] [stderr] Downloaded ip_network_table v0.2.0 [INFO] [stderr] Downloaded time-graph v0.1.3 [INFO] [stderr] Downloaded raw-cpuid v10.2.0 [INFO] [stderr] Downloaded ptree v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e24632f7842cc3d192d146ba6567793efea9984b12e8296ecfaa97acffd2878d [INFO] running `Command { std: "docker" "start" "-a" "e24632f7842cc3d192d146ba6567793efea9984b12e8296ecfaa97acffd2878d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e24632f7842cc3d192d146ba6567793efea9984b12e8296ecfaa97acffd2878d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e24632f7842cc3d192d146ba6567793efea9984b12e8296ecfaa97acffd2878d", kill_on_drop: false }` [INFO] [stdout] e24632f7842cc3d192d146ba6567793efea9984b12e8296ecfaa97acffd2878d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eba3fb5d4c4ab9244eee0c18ededb2bb5b7046e095d4724a96cac151b98785c4 [INFO] running `Command { std: "docker" "start" "-a" "eba3fb5d4c4ab9244eee0c18ededb2bb5b7046e095d4724a96cac151b98785c4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.33 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.131 [INFO] [stderr] Compiling serde v1.0.131 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling num-bigint v0.3.3 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking fixedbitset v0.4.0 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking raw-cpuid v10.2.0 [INFO] [stderr] Checking rust-ini v0.13.0 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking tint v1.0.1 [INFO] [stderr] Checking bitvec v0.20.4 [INFO] [stderr] Checking array-init v2.0.0 [INFO] [stderr] Checking ip_network_table-deps-treebitmap v0.5.0 [INFO] [stderr] Checking ip_network v0.4.1 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking ip_network_table v0.2.0 [INFO] [stderr] Checking petgraph v0.6.0 [INFO] [stderr] Checking num-format v0.4.0 [INFO] [stderr] Checking term-table v1.3.2 [INFO] [stderr] Compiling rotonda-store v0.3.0-dev (https://github.com/NLnetLabs/rotonda-store.git?rev=6dce6a7e6d0675bb14dc33afd962f8c429d7b6b4#6dce6a7e) [INFO] [stderr] Checking quanta v0.9.3 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking ordered-float v2.8.0 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking serde-hjson v0.9.1 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Compiling time-graph-macros v0.1.0 [INFO] [stderr] Checking time-graph v0.1.3 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking routecore v0.1.0 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking config v0.11.0 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking ptree v0.4.0 [INFO] [stderr] Checking shrust v0.0.7 [INFO] [stderr] Checking trie v0.1.0 (https://github.com/NLnetLabs/try-tries-and-trees#3b993a2a) [INFO] [stderr] Checking donkey-mule-horse v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `generic_const_exprs` is incomplete and may not be safe to use and/or cause compiler crashes [INFO] [stdout] --> src/lib.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(generic_const_exprs)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: see issue #76560 for more information [INFO] [stdout] = note: `#[warn(incomplete_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `generic_const_exprs` is incomplete and may not be safe to use and/or cause compiler crashes [INFO] [stdout] --> src/lib.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(generic_const_exprs)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: see issue #76560 for more information [INFO] [stdout] = note: `#[warn(incomplete_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/treebitmap/node.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 111 | Some(self.ptrvec[idx].into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.ptrvec[idx]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/treebitmap/node.rs:120:18 [INFO] [stdout] | [INFO] [stdout] 120 | Some(self.pfxvec[idx].into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.pfxvec[idx]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/treebitmap/tree.rs:28:53 [INFO] [stdout] | [INFO] [stdout] 28 | let root_node = VariableSizeStrideNode::new(strides[0].into())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `strides[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/treebitmap/tree.rs:84:57 [INFO] [stdout] | [INFO] [stdout] 84 | ... VariableSizeStrideNode::new(self.strides[depth].into()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.strides[depth]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/trie.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | fn children(&self) -> std::borrow::Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 59 | fn children(&self) -> std::borrow::Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/treebitmap/node.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 111 | Some(self.ptrvec[idx].into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.ptrvec[idx]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/treebitmap/node.rs:120:18 [INFO] [stdout] | [INFO] [stdout] 120 | Some(self.pfxvec[idx].into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.pfxvec[idx]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/treebitmap/tree.rs:28:53 [INFO] [stdout] | [INFO] [stdout] 28 | let root_node = VariableSizeStrideNode::new(strides[0].into())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `strides[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/treebitmap/tree.rs:84:57 [INFO] [stdout] | [INFO] [stdout] 84 | ... VariableSizeStrideNode::new(self.strides[depth].into()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.strides[depth]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/trie.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | fn children(&self) -> std::borrow::Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 59 | fn children(&self) -> std::borrow::Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:77:19 [INFO] [stdout] | [INFO] [stdout] 77 | tree.push(0b0000_111u32 << 25, 7).set_meta("P2".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider: `0b000_0111_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | .map(|line| parse_RISwhois_dump_IPv4_line(line)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_RISwhois_dump_IPv4_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:194:28 [INFO] [stdout] | [INFO] [stdout] 194 | if !cursor.left.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `cursor.left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:201:28 [INFO] [stdout] | [INFO] [stdout] 201 | if !cursor.right.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cursor.right.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:197:25 [INFO] [stdout] | [INFO] [stdout] 197 | built_prefix = built_prefix << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `built_prefix <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | first_bit = first_bit << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_bit <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:293:29 [INFO] [stdout] | [INFO] [stdout] 293 | ... cursor_pfx = cursor_pfx << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_pfx <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:294:32 [INFO] [stdout] | [INFO] [stdout] 294 | ... if cursor.prefix == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `cursor.prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:311:32 [INFO] [stdout] | [INFO] [stdout] 311 | ... if cursor.prefix == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `cursor.prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | first_bit = first_bit << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_bit <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:387:39 [INFO] [stdout] | [INFO] [stdout] 387 | if r.contains(&&search_prefix) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `(&search_prefix)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:464:34 [INFO] [stdout] | [INFO] [stdout] 464 | let donkey_trie_insert = graph [INFO] [stdout] | __________________________________^ [INFO] [stdout] 465 | | .spans() [INFO] [stdout] 466 | | .filter(|&s| s.callsite.name() == "donkey_trie_push") [INFO] [stdout] 467 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 464 ~ let donkey_trie_insert = graph [INFO] [stdout] 465 + .spans().find(|&s| s.callsite.name() == "donkey_trie_push") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:469:36 [INFO] [stdout] | [INFO] [stdout] 469 | let rotonda_store_insert = graph [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 470 | | .spans() [INFO] [stdout] 471 | | .filter(|&s| s.callsite.name() == "rotonda_store_insert") [INFO] [stdout] 472 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 469 ~ let rotonda_store_insert = graph [INFO] [stdout] 470 + .spans().find(|&s| s.callsite.name() == "rotonda_store_insert") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:474:41 [INFO] [stdout] | [INFO] [stdout] 474 | let donkey_tree_bitmap_insert = graph [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 475 | | .spans() [INFO] [stdout] 476 | | .filter(|&s| s.callsite.name() == "donkey_tree_bitmap_push") [INFO] [stdout] 477 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 474 ~ let donkey_tree_bitmap_insert = graph [INFO] [stdout] 475 + .spans().find(|&s| s.callsite.name() == "donkey_tree_bitmap_push") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:479:26 [INFO] [stdout] | [INFO] [stdout] 479 | let our_search = graph [INFO] [stdout] | __________________________^ [INFO] [stdout] 480 | | .spans() [INFO] [stdout] 481 | | .filter(|&s| s.callsite.name() == "longest_match") [INFO] [stdout] 482 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 479 ~ let our_search = graph [INFO] [stdout] 480 + .spans().find(|&s| s.callsite.name() == "longest_match") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:484:28 [INFO] [stdout] | [INFO] [stdout] 484 | let their_search = graph [INFO] [stdout] | ____________________________^ [INFO] [stdout] 485 | | .spans() [INFO] [stdout] 486 | | .filter(|&s| s.callsite.name() == "alt_longest_match") [INFO] [stdout] 487 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 484 ~ let their_search = graph [INFO] [stdout] 485 + .spans().find(|&s| s.callsite.name() == "alt_longest_match") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:489:36 [INFO] [stdout] | [INFO] [stdout] 489 | let rotonda_store_search = graph [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 490 | | .spans() [INFO] [stdout] 491 | | .filter(|&s| s.callsite.name() == "rotonda_store_longest_match") [INFO] [stdout] 492 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 489 ~ let rotonda_store_search = graph [INFO] [stdout] 490 + .spans().find(|&s| s.callsite.name() == "rotonda_store_longest_match") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:494:33 [INFO] [stdout] | [INFO] [stdout] 494 | let treebitmap_search = graph [INFO] [stdout] | _________________________________^ [INFO] [stdout] 495 | | .spans() [INFO] [stdout] 496 | | .filter(|&s| s.callsite.name() == "treebitmap_longest_match") [INFO] [stdout] 497 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 494 ~ let treebitmap_search = graph [INFO] [stdout] 495 + .spans().find(|&s| s.callsite.name() == "treebitmap_longest_match") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:499:34 [INFO] [stdout] | [INFO] [stdout] 499 | let simple_trie_search = graph [INFO] [stdout] | __________________________________^ [INFO] [stdout] 500 | | .spans() [INFO] [stdout] 501 | | .filter(|&s| s.callsite.name() == "simple_trie_longest_matching_prefix") [INFO] [stdout] 502 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 499 ~ let simple_trie_search = graph [INFO] [stdout] 500 + .spans().find(|&s| s.callsite.name() == "simple_trie_longest_matching_prefix") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:504:41 [INFO] [stdout] | [INFO] [stdout] 504 | let donkey_tree_bitmap_search = graph [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 505 | | .spans() [INFO] [stdout] 506 | | .filter(|&s| s.callsite.name() == "donkey_tree_bitmap_longest_match") [INFO] [stdout] 507 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 504 ~ let donkey_tree_bitmap_search = graph [INFO] [stdout] 505 + .spans().find(|&s| s.callsite.name() == "donkey_tree_bitmap_longest_match") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.17s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "eba3fb5d4c4ab9244eee0c18ededb2bb5b7046e095d4724a96cac151b98785c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eba3fb5d4c4ab9244eee0c18ededb2bb5b7046e095d4724a96cac151b98785c4", kill_on_drop: false }` [INFO] [stdout] eba3fb5d4c4ab9244eee0c18ededb2bb5b7046e095d4724a96cac151b98785c4