[INFO] cloning repository https://github.com/xgzeng/cloudflare-ddns-service [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/xgzeng/cloudflare-ddns-service" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxgzeng%2Fcloudflare-ddns-service", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxgzeng%2Fcloudflare-ddns-service'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b338483eed20334561d55133a5b31805b4a0c385 [INFO] linting xgzeng/cloudflare-ddns-service against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxgzeng%2Fcloudflare-ddns-service" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/xgzeng/cloudflare-ddns-service [INFO] finished tweaking git repo https://github.com/xgzeng/cloudflare-ddns-service [INFO] tweaked toml for git repo https://github.com/xgzeng/cloudflare-ddns-service written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/xgzeng/cloudflare-ddns-service on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/xgzeng/cloudflare-ddns-service already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jiff-static v0.2.6 [INFO] [stderr] Downloaded ipnetwork v0.21.1 [INFO] [stderr] Downloaded cloudflare v0.14.0 [INFO] [stderr] Downloaded clap v4.5.35 [INFO] [stderr] Downloaded rtnetlink v0.16.0 [INFO] [stderr] Downloaded uuid v1.13.1 [INFO] [stderr] Downloaded clap_builder v4.5.35 [INFO] [stderr] Downloaded netlink-packet-route v0.22.0 [INFO] [stderr] Downloaded jiff v0.2.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a456e30a99615c67059a1a22f69d58723d399599c12d410a1c4ad7ca1b1cddfa [INFO] running `Command { std: "docker" "start" "-a" "a456e30a99615c67059a1a22f69d58723d399599c12d410a1c4ad7ca1b1cddfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a456e30a99615c67059a1a22f69d58723d399599c12d410a1c4ad7ca1b1cddfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a456e30a99615c67059a1a22f69d58723d399599c12d410a1c4ad7ca1b1cddfa", kill_on_drop: false }` [INFO] [stdout] a456e30a99615c67059a1a22f69d58723d399599c12d410a1c4ad7ca1b1cddfa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b9332d1f69ed3329c868223659526fc5ceea7331aaa9d2a0c0918531762d749e [INFO] running `Command { std: "docker" "start" "-a" "b9332d1f69ed3329c868223659526fc5ceea7331aaa9d2a0c0918531762d749e", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.12 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling openssl v0.10.70 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking indexmap v2.7.1 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Compiling native-tls v0.2.13 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Checking clap_builder v4.5.35 [INFO] [stderr] Checking pnet_sys v0.35.0 [INFO] [stderr] Checking jiff v0.2.6 [INFO] [stderr] Checking pnet_base v0.35.0 [INFO] [stderr] Checking hostname v0.4.1 [INFO] [stderr] Checking ipnetwork v0.21.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling openssl-sys v0.9.105 [INFO] [stderr] Checking clap v4.5.35 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Checking tokio v1.44.2 [INFO] [stderr] Checking thiserror v2.0.11 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking netlink-packet-utils v0.5.2 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking netlink-packet-core v0.7.0 [INFO] [stderr] Compiling serde_with_macros v3.12.0 [INFO] [stderr] Checking netlink-packet-route v0.22.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking netlink-sys v0.8.7 [INFO] [stderr] Checking netlink-proto v0.11.5 [INFO] [stderr] Checking rtnetlink v0.16.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.138 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking serde_with v3.12.0 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking uuid v1.13.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking pnet_datalink v0.35.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.15 [INFO] [stderr] Checking cloudflare v0.14.0 [INFO] [stderr] Checking cf-ddns v0.4.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cf_client.rs:142:42 [INFO] [stdout] | [INFO] [stdout] 142 | Credentials::UserAuthToken { token: token }, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use clap; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_yaml; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cf_client.rs:142:42 [INFO] [stdout] | [INFO] [stdout] 142 | Credentials::UserAuthToken { token: token }, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use clap; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_yaml; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 36 | content: ip_v4.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ip_v4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 39 | content: ip_v6.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ip_v6` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:46:49 [INFO] [stdout] | [INFO] [stdout] 46 | DnsContent::A { content } => IpAddr::V4(content.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:47:52 [INFO] [stdout] | [INFO] [stdout] 47 | DnsContent::AAAA { content } => IpAddr::V6(content.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cf_client.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(zone.id.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(zone.id.clone()); [INFO] [stdout] 69 + Ok(zone.id.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cf_client.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return Err(anyhow::anyhow!("No zone found")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Err(anyhow::anyhow!("No zone found")); [INFO] [stdout] 71 + Err(anyhow::anyhow!("No zone found")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cf_client.rs:111:10 [INFO] [stdout] | [INFO] [stdout] 111 | ips: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 ~ ips: &[IpAddr], [INFO] [stdout] 112 | ) -> (Vec, Vec, Vec) { [INFO] [stdout] 113 | let mut records_to_keep: Vec = vec![]; [INFO] [stdout] 114 | let mut records_to_delete: Vec = vec![]; [INFO] [stdout] 115 ~ let mut ips_to_add = ips.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:119:53 [INFO] [stdout] | [INFO] [stdout] 119 | DnsContent::A { content } => IpAddr::V4(content.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:120:56 [INFO] [stdout] | [INFO] [stdout] 120 | DnsContent::AAAA { content } => IpAddr::V6(content.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/myip.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | / !addr.is_multicast() // is_unicast [INFO] [stdout] 73 | | && !addr.is_loopback() [INFO] [stdout] 74 | | && !((addr.segments()[0] & 0xffc0) == 0xfe80) // !is_unicast_link_local [INFO] [stdout] 75 | | && !((addr.segments()[0] & 0xfe00) == 0xfc00) // !is_unique_local [INFO] [stdout] 76 | | && !addr.is_unspecified() [INFO] [stdout] 77 | | && !((addr.segments()[0] == 0x2001) && (addr.segments()[1] == 0xdb8)) [INFO] [stdout] | |_____________________________________________________________________________^ help: try: `!(addr.is_multicast() || addr.is_loopback() || ((addr.segments()[0] & 0xffc0) == 0xfe80) || ((addr.segments()[0] & 0xfe00) == 0xfc00) || addr.is_unspecified() || (addr.segments()[0] == 0x2001) && (addr.segments()[1] == 0xdb8))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 36 | content: ip_v4.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ip_v4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/myip.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | && !((addr.segments()[0] & 0xffc0) == 0xfe80) // !is_unicast_link_local [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((addr.segments()[0] & 0xffc0) != 0xfe80)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/myip.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | && !((addr.segments()[0] & 0xfe00) == 0xfc00) // !is_unique_local [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((addr.segments()[0] & 0xfe00) != 0xfc00)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/myip.rs:135:35 [INFO] [stdout] | [INFO] [stdout] 135 | if !is_unicast_global(&addr_v6) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `addr_v6` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `IpAddr` which implements the `Copy` trait [INFO] [stdout] --> src/myip.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 160 | addrs.push(addr.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 39 | content: ip_v6.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ip_v6` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:46:49 [INFO] [stdout] | [INFO] [stdout] 46 | DnsContent::A { content } => IpAddr::V4(content.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:47:52 [INFO] [stdout] | [INFO] [stdout] 47 | DnsContent::AAAA { content } => IpAddr::V6(content.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cf_client.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(zone.id.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(zone.id.clone()); [INFO] [stdout] 69 + Ok(zone.id.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cf_client.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return Err(anyhow::anyhow!("No zone found")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Err(anyhow::anyhow!("No zone found")); [INFO] [stdout] 71 + Err(anyhow::anyhow!("No zone found")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cf_client.rs:111:10 [INFO] [stdout] | [INFO] [stdout] 111 | ips: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 ~ ips: &[IpAddr], [INFO] [stdout] 112 | ) -> (Vec, Vec, Vec) { [INFO] [stdout] 113 | let mut records_to_keep: Vec = vec![]; [INFO] [stdout] 114 | let mut records_to_delete: Vec = vec![]; [INFO] [stdout] 115 ~ let mut ips_to_add = ips.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:119:53 [INFO] [stdout] | [INFO] [stdout] 119 | DnsContent::A { content } => IpAddr::V4(content.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv6Addr` which implements the `Copy` trait [INFO] [stdout] --> src/cf_client.rs:120:56 [INFO] [stdout] | [INFO] [stdout] 120 | DnsContent::AAAA { content } => IpAddr::V6(content.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/myip.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | / !addr.is_multicast() // is_unicast [INFO] [stdout] 73 | | && !addr.is_loopback() [INFO] [stdout] 74 | | && !((addr.segments()[0] & 0xffc0) == 0xfe80) // !is_unicast_link_local [INFO] [stdout] 75 | | && !((addr.segments()[0] & 0xfe00) == 0xfc00) // !is_unique_local [INFO] [stdout] 76 | | && !addr.is_unspecified() [INFO] [stdout] 77 | | && !((addr.segments()[0] == 0x2001) && (addr.segments()[1] == 0xdb8)) [INFO] [stdout] | |_____________________________________________________________________________^ help: try: `!(addr.is_multicast() || addr.is_loopback() || ((addr.segments()[0] & 0xffc0) == 0xfe80) || ((addr.segments()[0] & 0xfe00) == 0xfc00) || addr.is_unspecified() || (addr.segments()[0] == 0x2001) && (addr.segments()[1] == 0xdb8))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/myip.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | && !((addr.segments()[0] & 0xffc0) == 0xfe80) // !is_unicast_link_local [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((addr.segments()[0] & 0xffc0) != 0xfe80)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/myip.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | && !((addr.segments()[0] & 0xfe00) == 0xfc00) // !is_unique_local [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((addr.segments()[0] & 0xfe00) != 0xfc00)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/myip.rs:135:35 [INFO] [stdout] | [INFO] [stdout] 135 | if !is_unicast_global(&addr_v6) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `addr_v6` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `IpAddr` which implements the `Copy` trait [INFO] [stdout] --> src/myip.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 160 | addrs.push(addr.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 53.20s [INFO] running `Command { std: "docker" "inspect" "b9332d1f69ed3329c868223659526fc5ceea7331aaa9d2a0c0918531762d749e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9332d1f69ed3329c868223659526fc5ceea7331aaa9d2a0c0918531762d749e", kill_on_drop: false }` [INFO] [stdout] b9332d1f69ed3329c868223659526fc5ceea7331aaa9d2a0c0918531762d749e