[INFO] cloning repository https://github.com/xD8A/mirror-proxy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/xD8A/mirror-proxy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FxD8A%2Fmirror-proxy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FxD8A%2Fmirror-proxy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 151c3ac811f3b9163f83f6e169a8ffa98a87a905 [INFO] linting xD8A/mirror-proxy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FxD8A%2Fmirror-proxy" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/xD8A/mirror-proxy [INFO] finished tweaking git repo https://github.com/xD8A/mirror-proxy [INFO] tweaked toml for git repo https://github.com/xD8A/mirror-proxy written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/xD8A/mirror-proxy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/xD8A/mirror-proxy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded env_logger v0.8.2 [INFO] [stderr] Downloaded tokio-macros v1.0.0 [INFO] [stderr] Downloaded bytes v1.0.0 [INFO] [stderr] Downloaded yaml-rust v0.4.4 [INFO] [stderr] Downloaded humantime v2.0.1 [INFO] [stderr] Downloaded serde_yaml v0.8.14 [INFO] [stderr] Downloaded http v0.2.2 [INFO] [stderr] Downloaded hyper v0.14.2 [INFO] [stderr] Downloaded tokio v1.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ed034673b36c3f6dd84c3a373691dc051c9a1b0385a6f84d42cf29aac7ed5f3 [INFO] running `Command { std: "docker" "start" "-a" "7ed034673b36c3f6dd84c3a373691dc051c9a1b0385a6f84d42cf29aac7ed5f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ed034673b36c3f6dd84c3a373691dc051c9a1b0385a6f84d42cf29aac7ed5f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ed034673b36c3f6dd84c3a373691dc051c9a1b0385a6f84d42cf29aac7ed5f3", kill_on_drop: false }` [INFO] [stdout] 7ed034673b36c3f6dd84c3a373691dc051c9a1b0385a6f84d42cf29aac7ed5f3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d87ab42930ae447e129491f1e97a351b2abd8cd3f3ea643a4fe158fc87ff017 [INFO] running `Command { std: "docker" "start" "-a" "3d87ab42930ae447e129491f1e97a351b2abd8cd3f3ea643a4fe158fc87ff017", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling syn v1.0.57 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking bytes v1.0.0 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Checking futures-core v0.3.8 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling tokio v1.0.1 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking pin-project-lite v0.2.0 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Checking futures-task v0.3.8 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking futures-channel v0.3.8 [INFO] [stderr] Checking humantime v2.0.1 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Checking yaml-rust v0.4.4 [INFO] [stderr] Checking dtoa v0.4.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking http v0.2.2 [INFO] [stderr] Checking tracing v0.1.22 [INFO] [stderr] Checking mio v0.7.7 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking env_logger v0.8.2 [INFO] [stderr] Checking http-body v0.4.0 [INFO] [stderr] Checking serde_yaml v0.8.14 [INFO] [stderr] Compiling pin-project-internal v1.0.2 [INFO] [stderr] Compiling tokio-macros v1.0.0 [INFO] [stderr] Checking pin-project v1.0.2 [INFO] [stderr] Checking futures-util v0.3.8 [INFO] [stderr] Checking hyper v0.14.2 [INFO] [stderr] Checking mirror-proxy v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use http; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | const NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | const DEFAULT_IP: &'static str = "127.0.0.1"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use http; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | const NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | const DEFAULT_IP: &'static str = "127.0.0.1"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 125 | if !p.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `p.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | .env(&*env_ip) [INFO] [stdout] | ^^^^^^^^ help: try: `&env_ip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | .env(&*env_port) [INFO] [stdout] | ^^^^^^^^^^ help: try: `&env_port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/main.rs:108:40 [INFO] [stdout] | [INFO] [stdout] 108 | ... Some(v) => match u16::try_from(v.clone()) { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 109 | | ... Ok(v) => Some(v), [INFO] [stdout] 110 | | ... Err(_) => None [INFO] [stdout] 111 | | ... }, [INFO] [stdout] | |_______________________^ help: replace with: `u16::try_from(v.clone()).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:108:60 [INFO] [stdout] | [INFO] [stdout] 108 | ... Some(v) => match u16::try_from(v.clone()) { [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/main.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | / match addrs_iter.next() { [INFO] [stdout] 164 | | Some(v) => Some(v), [INFO] [stdout] 165 | | None => None [INFO] [stdout] 166 | | } [INFO] [stdout] | |_____^ help: replace it with: `addrs_iter.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] = note: `#[warn(clippy::needless_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | / match addrs_iter.next() { [INFO] [stdout] 164 | | Some(v) => Some(v), [INFO] [stdout] 165 | | None => None [INFO] [stdout] 166 | | } [INFO] [stdout] | |_____^ help: try: `addrs_iter.next().map(|v| v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `addr` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 208 | if addr.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = addr` [INFO] [stdout] 209 | let addr = addr.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/main.rs:230:9 [INFO] [stdout] | [INFO] [stdout] 230 | / client.request(req).await.and_then(|resp| { [INFO] [stdout] 231 | | info!("client {:?}: connection closed", peer); [INFO] [stdout] 232 | | Ok(resp) [INFO] [stdout] 233 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 230 ~ client.request(req).await.map(|resp| { [INFO] [stdout] 231 | info!("client {:?}: connection closed", peer); [INFO] [stdout] 232 ~ resp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 125 | if !p.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `p.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | .env(&*env_ip) [INFO] [stdout] | ^^^^^^^^ help: try: `&env_ip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | .env(&*env_port) [INFO] [stdout] | ^^^^^^^^^^ help: try: `&env_port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/main.rs:108:40 [INFO] [stdout] | [INFO] [stdout] 108 | ... Some(v) => match u16::try_from(v.clone()) { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 109 | | ... Ok(v) => Some(v), [INFO] [stdout] 110 | | ... Err(_) => None [INFO] [stdout] 111 | | ... }, [INFO] [stdout] | |_______________________^ help: replace with: `u16::try_from(v.clone()).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:108:60 [INFO] [stdout] | [INFO] [stdout] 108 | ... Some(v) => match u16::try_from(v.clone()) { [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/main.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | / match addrs_iter.next() { [INFO] [stdout] 164 | | Some(v) => Some(v), [INFO] [stdout] 165 | | None => None [INFO] [stdout] 166 | | } [INFO] [stdout] | |_____^ help: replace it with: `addrs_iter.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] = note: `#[warn(clippy::needless_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | / match addrs_iter.next() { [INFO] [stdout] 164 | | Some(v) => Some(v), [INFO] [stdout] 165 | | None => None [INFO] [stdout] 166 | | } [INFO] [stdout] | |_____^ help: try: `addrs_iter.next().map(|v| v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `addr` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 208 | if addr.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = addr` [INFO] [stdout] 209 | let addr = addr.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/main.rs:230:9 [INFO] [stdout] | [INFO] [stdout] 230 | / client.request(req).await.and_then(|resp| { [INFO] [stdout] 231 | | info!("client {:?}: connection closed", peer); [INFO] [stdout] 232 | | Ok(resp) [INFO] [stdout] 233 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 230 ~ client.request(req).await.map(|resp| { [INFO] [stdout] 231 | info!("client {:?}: connection closed", peer); [INFO] [stdout] 232 ~ resp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.78s [INFO] running `Command { std: "docker" "inspect" "3d87ab42930ae447e129491f1e97a351b2abd8cd3f3ea643a4fe158fc87ff017", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d87ab42930ae447e129491f1e97a351b2abd8cd3f3ea643a4fe158fc87ff017", kill_on_drop: false }` [INFO] [stdout] 3d87ab42930ae447e129491f1e97a351b2abd8cd3f3ea643a4fe158fc87ff017