[INFO] cloning repository https://github.com/wkevin/columnrs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wkevin/columnrs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwkevin%2Fcolumnrs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwkevin%2Fcolumnrs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1391bfa9cd2f333a8642e3ebe5f55b2903f157fa [INFO] linting wkevin/columnrs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwkevin%2Fcolumnrs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/wkevin/columnrs [INFO] finished tweaking git repo https://github.com/wkevin/columnrs [INFO] tweaked toml for git repo https://github.com/wkevin/columnrs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/wkevin/columnrs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/wkevin/columnrs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.18 [INFO] [stderr] Downloaded either v1.13.0 [INFO] [stderr] Downloaded predicates-tree v1.0.11 [INFO] [stderr] Downloaded assert_cmd v2.0.16 [INFO] [stderr] Downloaded predicates v3.1.2 [INFO] [stderr] Downloaded serde_derive v1.0.210 [INFO] [stderr] Downloaded tempfile v3.12.0 [INFO] [stderr] Downloaded anstyle-parse v0.2.5 [INFO] [stderr] Downloaded rustix v0.38.37 [INFO] [stderr] Downloaded anstream v0.6.15 [INFO] [stderr] Downloaded serde v1.0.210 [INFO] [stderr] Downloaded anstyle-query v1.1.1 [INFO] [stderr] Downloaded anstyle-wincon v3.0.4 [INFO] [stderr] Downloaded colorchoice v1.0.2 [INFO] [stderr] Downloaded anstyle v1.0.8 [INFO] [stderr] Downloaded predicates-core v1.0.8 [INFO] [stderr] Downloaded clap_builder v4.5.18 [INFO] [stderr] Downloaded syn v2.0.77 [INFO] [stderr] Downloaded regex v1.10.6 [INFO] [stderr] Downloaded fastrand v2.1.1 [INFO] [stderr] Downloaded bstr v1.10.0 [INFO] [stderr] Downloaded libc v0.2.159 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4af5e771a8ef2ecff2faa66f519214b14fa012689a3f11393c9466534a6c7dad [INFO] running `Command { std: "docker" "start" "-a" "4af5e771a8ef2ecff2faa66f519214b14fa012689a3f11393c9466534a6c7dad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4af5e771a8ef2ecff2faa66f519214b14fa012689a3f11393c9466534a6c7dad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4af5e771a8ef2ecff2faa66f519214b14fa012689a3f11393c9466534a6c7dad", kill_on_drop: false }` [INFO] [stdout] 4af5e771a8ef2ecff2faa66f519214b14fa012689a3f11393c9466534a6c7dad [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c790c0b0232aa0119e5e7a875bc99a5289d8547786ca62bf9a67fa9270c3e4e [INFO] running `Command { std: "docker" "start" "-a" "2c790c0b0232aa0119e5e7a875bc99a5289d8547786ca62bf9a67fa9270c3e4e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling assert_cmd v2.0.16 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking columnrs v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / for line in stdin.lock().lines() { [INFO] [stdout] 26 | | if let Ok(line) = line { [INFO] [stdout] 27 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | / if let Ok(line) = line { [INFO] [stdout] 27 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ for line in stdin.lock().lines().flatten() { [INFO] [stdout] 26 + process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | / for line in reader.lines() { [INFO] [stdout] 37 | | if let Ok(line) = line { [INFO] [stdout] 38 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | / if let Ok(line) = line { [INFO] [stdout] 38 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ for line in reader.lines().flatten() { [INFO] [stdout] 37 + process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 91 | let align_left = !is_numeric[j] ||(left_align_numeric && is_numeric[j] && i > 0); // Don't right-align header [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_numeric[j] || left_align_numeric && i > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / for line in stdin.lock().lines() { [INFO] [stdout] 26 | | if let Ok(line) = line { [INFO] [stdout] 27 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | / if let Ok(line) = line { [INFO] [stdout] 27 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ for line in stdin.lock().lines().flatten() { [INFO] [stdout] 26 + process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | / for line in reader.lines() { [INFO] [stdout] 37 | | if let Ok(line) = line { [INFO] [stdout] 38 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | / if let Ok(line) = line { [INFO] [stdout] 38 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ for line in reader.lines().flatten() { [INFO] [stdout] 37 + process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 91 | let align_left = !is_numeric[j] ||(left_align_numeric && is_numeric[j] && i > 0); // Don't right-align header [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_numeric[j] || left_align_numeric && i > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.84s [INFO] running `Command { std: "docker" "inspect" "2c790c0b0232aa0119e5e7a875bc99a5289d8547786ca62bf9a67fa9270c3e4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c790c0b0232aa0119e5e7a875bc99a5289d8547786ca62bf9a67fa9270c3e4e", kill_on_drop: false }` [INFO] [stdout] 2c790c0b0232aa0119e5e7a875bc99a5289d8547786ca62bf9a67fa9270c3e4e