[INFO] cloning repository https://github.com/wkcs/ncc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wkcs/ncc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwkcs%2Fncc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwkcs%2Fncc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1a6f3e3495186536e6cc69d862092c1d64be5579 [INFO] linting wkcs/ncc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwkcs%2Fncc" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/wkcs/ncc [INFO] finished tweaking git repo https://github.com/wkcs/ncc [INFO] tweaked toml for git repo https://github.com/wkcs/ncc written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/wkcs/ncc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/wkcs/ncc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 278266fd0fcbb4e419bf24ded44cd92a26eebaeeb3b9c2ed198728b76cc6ba48 [INFO] running `Command { std: "docker" "start" "-a" "278266fd0fcbb4e419bf24ded44cd92a26eebaeeb3b9c2ed198728b76cc6ba48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "278266fd0fcbb4e419bf24ded44cd92a26eebaeeb3b9c2ed198728b76cc6ba48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "278266fd0fcbb4e419bf24ded44cd92a26eebaeeb3b9c2ed198728b76cc6ba48", kill_on_drop: false }` [INFO] [stdout] 278266fd0fcbb4e419bf24ded44cd92a26eebaeeb3b9c2ed198728b76cc6ba48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e58197457f18d8f1014e3cecbcd462f31c5e953fad23e3ab7d520d0ffdd8d27 [INFO] running `Command { std: "docker" "start" "-a" "2e58197457f18d8f1014e3cecbcd462f31c5e953fad23e3ab7d520d0ffdd8d27", kill_on_drop: false }` [INFO] [stderr] Checking ncc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cmdline.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | val_type: val_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `val_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | loc: loc, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | token_type: token_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:187:29 [INFO] [stdout] | [INFO] [stdout] 187 | ... line: line, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:188:29 [INFO] [stdout] | [INFO] [stdout] 188 | ... column: column, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:220:29 [INFO] [stdout] | [INFO] [stdout] 220 | ... column: column, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inconsistent casing in hexadecimal literal [INFO] [stdout] --> src/main.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | let test4 = 0xaBcdef; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `0xabcdef` or `0xABCDEF` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_case_hex_literals [INFO] [stdout] = note: `#[warn(clippy::mixed_case_hex_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/main.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | let test5 = 01234567; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] = note: `#[warn(clippy::zero_prefixed_literal)]` on by default [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 119 - let test5 = 01234567; [INFO] [stdout] 119 + let test5 = 1234567; [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 119 | let test5 = 0o1234567; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cmdline.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | val_type: val_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `val_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | loc: loc, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | token_type: token_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:187:29 [INFO] [stdout] | [INFO] [stdout] 187 | ... line: line, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:188:29 [INFO] [stdout] | [INFO] [stdout] 188 | ... column: column, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lex.rs:220:29 [INFO] [stdout] | [INFO] [stdout] 220 | ... column: column, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inconsistent casing in hexadecimal literal [INFO] [stdout] --> src/main.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | let test4 = 0xaBcdef; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `0xabcdef` or `0xABCDEF` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_case_hex_literals [INFO] [stdout] = note: `#[warn(clippy::mixed_case_hex_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/main.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | let test5 = 01234567; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] = note: `#[warn(clippy::zero_prefixed_literal)]` on by default [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 119 - let test5 = 01234567; [INFO] [stdout] 119 + let test5 = 1234567; [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 119 | let test5 = 0o1234567; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `value` is never read [INFO] [stdout] --> src/cmdline.rs:272:49 [INFO] [stdout] | [INFO] [stdout] 272 | ... let mut value = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `value` is never read [INFO] [stdout] --> src/cmdline.rs:272:49 [INFO] [stdout] | [INFO] [stdout] 272 | ... let mut value = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bytes` [INFO] [stdout] --> src/lex.rs:400:33 [INFO] [stdout] | [INFO] [stdout] 400 | fn parse_keyword(&mut self, bytes: &[u8]) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lex.rs:452:41 [INFO] [stdout] | [INFO] [stdout] 434 | ' ' | ';' | ',' | '\t' | '\n' | '\x0C' | '\r' | '!'..='/' | ':'..='@' | '['..='`' | '{'..='~' => { [INFO] [stdout] | --------- matches all the relevant values [INFO] [stdout] ... [INFO] [stdout] 452 | 'a'..='z' | 'A'..='Z' | '_' | '0'..='9' => (), [INFO] [stdout] | ^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test` [INFO] [stdout] --> src/main.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | let test = 1.2; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_test` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test2` [INFO] [stdout] --> src/main.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | let test2: f64 = 3.4f64; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_test2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test3` [INFO] [stdout] --> src/main.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let test3 = 0b10101; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_test3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test4` [INFO] [stdout] --> src/main.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | let test4 = 0xaBcdef; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_test4` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test5` [INFO] [stdout] --> src/main.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | let test5 = 01234567; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_test5` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bytes` [INFO] [stdout] --> src/lex.rs:400:33 [INFO] [stdout] | [INFO] [stdout] 400 | fn parse_keyword(&mut self, bytes: &[u8]) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `OptVal` is never constructed [INFO] [stdout] --> src/cmdline.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum CmdValType { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 6 | NoVal, [INFO] [stdout] 7 | OptVal, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmdValType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_value`, `get_value_by_name`, and `get_value_by_index` are never used [INFO] [stdout] --> src/cmdline.rs:337:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl CmdLine { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 337 | pub fn get_value(&self, cmd: &CmdInfo) -> Option<&Vec> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 345 | pub fn get_value_by_name(&self, str: &str) -> Option<&Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn get_value_by_index(&self, index: usize) -> Option<&Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `KVoid`, `KChar`, `KInt`, `KFloat`, and `Kdouble` are never constructed [INFO] [stdout] --> src/lex.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum KeyWordType { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] 7 | KVoid, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 8 | KChar, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 9 | KInt, [INFO] [stdout] | ^^^^ [INFO] [stdout] 10 | KFloat, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 11 | Kdouble, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KeyWordType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `OpAssign` is never constructed [INFO] [stdout] --> src/lex.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub enum OperatorType { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 16 | OpEq, [INFO] [stdout] 17 | OpAssign, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OperatorType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | Operator(OperatorType), [INFO] [stdout] | -------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 31 - Operator(OperatorType), [INFO] [stdout] 31 + Operator(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lex.rs:452:41 [INFO] [stdout] | [INFO] [stdout] 434 | ' ' | ';' | ',' | '\t' | '\n' | '\x0C' | '\r' | '!'..='/' | ':'..='@' | '['..='`' | '{'..='~' => { [INFO] [stdout] | --------- matches all the relevant values [INFO] [stdout] ... [INFO] [stdout] 452 | 'a'..='z' | 'A'..='Z' | '_' | '0'..='9' => (), [INFO] [stdout] | ^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `KeyWord` and `FlotNumber` are never constructed [INFO] [stdout] --> src/lex.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum TokenType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 25 | KeyWord(KeyWordType), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 26 | Number, [INFO] [stdout] 27 | FlotNumber, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_token` and `parse_keyword` are never used [INFO] [stdout] --> src/lex.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 70 | impl Lex { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn add_token(&mut self, loc: Location, token_type: TokenType, source: &str) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 400 | fn parse_keyword(&mut self, bytes: &[u8]) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return cmdline; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return cmdline; [INFO] [stdout] 50 + cmdline [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | val_str: if val_str.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `val_str.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | if (short.len() == 0) && (long.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `short.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:74:35 [INFO] [stdout] | [INFO] [stdout] 74 | if (short.len() == 0) && (long.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `long.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if help.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `help.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return help; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return help; [INFO] [stdout] 132 + help [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:98:16 [INFO] [stdout] | [INFO] [stdout] 98 | if cmd.short.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.short.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if cmd.long.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.long.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return None; [INFO] [stdout] 142 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | return Some(CmdMatchType::Long); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return Some(CmdMatchType::Long); [INFO] [stdout] 152 + Some(CmdMatchType::Long) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 154 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return None; [INFO] [stdout] 154 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:180:17 [INFO] [stdout] | [INFO] [stdout] 180 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return None; [INFO] [stdout] 180 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:158:20 [INFO] [stdout] | [INFO] [stdout] 158 | if cmd.long.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.long.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | if cmd.short.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.short.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test` [INFO] [stdout] --> src/main.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | let test = 1.2; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_test` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test2` [INFO] [stdout] --> src/main.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | let test2: f64 = 3.4f64; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_test2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test3` [INFO] [stdout] --> src/main.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let test3 = 0b10101; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_test3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test4` [INFO] [stdout] --> src/main.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | let test4 = 0xaBcdef; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_test4` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test5` [INFO] [stdout] --> src/main.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | let test5 = 01234567; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_test5` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `OptVal` is never constructed [INFO] [stdout] --> src/cmdline.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum CmdValType { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 6 | NoVal, [INFO] [stdout] 7 | OptVal, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmdValType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_value`, `get_value_by_name`, and `get_value_by_index` are never used [INFO] [stdout] --> src/cmdline.rs:337:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl CmdLine { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 337 | pub fn get_value(&self, cmd: &CmdInfo) -> Option<&Vec> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 345 | pub fn get_value_by_name(&self, str: &str) -> Option<&Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn get_value_by_index(&self, index: usize) -> Option<&Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `KVoid`, `KChar`, `KInt`, `KFloat`, and `Kdouble` are never constructed [INFO] [stdout] --> src/lex.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum KeyWordType { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] 7 | KVoid, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 8 | KChar, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 9 | KInt, [INFO] [stdout] | ^^^^ [INFO] [stdout] 10 | KFloat, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 11 | Kdouble, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KeyWordType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `OpAssign` is never constructed [INFO] [stdout] --> src/lex.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub enum OperatorType { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 16 | OpEq, [INFO] [stdout] 17 | OpAssign, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OperatorType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | Operator(OperatorType), [INFO] [stdout] | -------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 31 - Operator(OperatorType), [INFO] [stdout] 31 + Operator(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `KeyWord` and `FlotNumber` are never constructed [INFO] [stdout] --> src/lex.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum TokenType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 25 | KeyWord(KeyWordType), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 26 | Number, [INFO] [stdout] 27 | FlotNumber, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_token` and `parse_keyword` are never used [INFO] [stdout] --> src/lex.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 70 | impl Lex { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn add_token(&mut self, loc: Location, token_type: TokenType, source: &str) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 400 | fn parse_keyword(&mut self, bytes: &[u8]) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:230:40 [INFO] [stdout] | [INFO] [stdout] 230 | ... if value.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:236:40 [INFO] [stdout] | [INFO] [stdout] 236 | ... if value.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:317:20 [INFO] [stdout] | [INFO] [stdout] 317 | if self.info[index].short.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.info[index].short.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 334 - return false; [INFO] [stdout] 334 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/cmdline.rs:329:20 [INFO] [stdout] | [INFO] [stdout] 329 | if let Some(_) = self.args.get(&index) { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if self.args.get(&index).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 342 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 342 - return None; [INFO] [stdout] 342 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 352 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 352 - return None; [INFO] [stdout] 352 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 - return None; [INFO] [stdout] 360 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return cmdline; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return cmdline; [INFO] [stdout] 50 + cmdline [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | val_str: if val_str.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `val_str.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | if (short.len() == 0) && (long.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `short.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:74:35 [INFO] [stdout] | [INFO] [stdout] 74 | if (short.len() == 0) && (long.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `long.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if help.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `help.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return help; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return help; [INFO] [stdout] 132 + help [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:98:16 [INFO] [stdout] | [INFO] [stdout] 98 | if cmd.short.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.short.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if cmd.long.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.long.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lex.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 72 | / let lex = Lex { [INFO] [stdout] 73 | | file: String::from(file), [INFO] [stdout] 74 | | tokens: Vec::::new(), [INFO] [stdout] 75 | | index: 0, [INFO] [stdout] 76 | | line: 1, [INFO] [stdout] 77 | | column: 1, [INFO] [stdout] 78 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 79 | lex [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 72 ~ [INFO] [stdout] 73 ~ Lex { [INFO] [stdout] 74 + file: String::from(file), [INFO] [stdout] 75 + tokens: Vec::::new(), [INFO] [stdout] 76 + index: 0, [INFO] [stdout] 77 + line: 1, [INFO] [stdout] 78 + column: 1, [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lex.rs:98:29 [INFO] [stdout] | [INFO] [stdout] 98 | _ => str += &format!("{}\n", token.show()).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}\n", token.show()).as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return None; [INFO] [stdout] 142 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | return Some(CmdMatchType::Long); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return Some(CmdMatchType::Long); [INFO] [stdout] 152 + Some(CmdMatchType::Long) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 154 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return None; [INFO] [stdout] 154 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:180:17 [INFO] [stdout] | [INFO] [stdout] 180 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return None; [INFO] [stdout] 180 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:158:20 [INFO] [stdout] | [INFO] [stdout] 158 | if cmd.long.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.long.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | if cmd.short.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd.short.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lex.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | let mut file = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lex.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / match file.read_to_string(&mut src) { [INFO] [stdout] 118 | | Err(why) => { [INFO] [stdout] 119 | | eprintln!("couldn't read {}: {:?}", &self.file, why); [INFO] [stdout] 120 | | std::process::exit(-1); [INFO] [stdout] 121 | | }, [INFO] [stdout] 122 | | Ok(_) => (), [INFO] [stdout] 123 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 117 ~ if let Err(why) = file.read_to_string(&mut src) { [INFO] [stdout] 118 + eprintln!("couldn't read {}: {:?}", &self.file, why); [INFO] [stdout] 119 + std::process::exit(-1); [INFO] [stdout] 120 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:191:57 [INFO] [stdout] | [INFO] [stdout] 191 | source: String::from_utf8_lossy(&bytes[start..self.index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:223:57 [INFO] [stdout] | [INFO] [stdout] 223 | source: String::from_utf8_lossy(&bytes[start..self.index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | if !(bytes[self.index] as char == '\n') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bytes[self.index] as char != '\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 262 | if !(bytes[self.index] as char == ' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bytes[self.index] as char != ' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:230:40 [INFO] [stdout] | [INFO] [stdout] 230 | ... if value.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:236:40 [INFO] [stdout] | [INFO] [stdout] 236 | ... if value.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 282 | if !(bytes[self.index] as char == '\"') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bytes[self.index] as char != '\"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:311:61 [INFO] [stdout] | [INFO] [stdout] 311 | ... source: String::from_utf8_lossy(&bytes[start..self.index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmdline.rs:317:20 [INFO] [stdout] | [INFO] [stdout] 317 | if self.info[index].short.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.info[index].short.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex.rs:338:12 [INFO] [stdout] | [INFO] [stdout] 338 | if !(bytes[self.index] as char == '\'') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bytes[self.index] as char != '\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 334 - return false; [INFO] [stdout] 334 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/cmdline.rs:329:20 [INFO] [stdout] | [INFO] [stdout] 329 | if let Some(_) = self.args.get(&index) { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if self.args.get(&index).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 342 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 342 - return None; [INFO] [stdout] 342 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 352 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 352 - return None; [INFO] [stdout] 352 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmdline.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 - return None; [INFO] [stdout] 360 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:372:61 [INFO] [stdout] | [INFO] [stdout] 372 | ... source: String::from_utf8_lossy(&bytes[start..self.index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:423:53 [INFO] [stdout] | [INFO] [stdout] 423 | source: String::from_utf8_lossy(&bytes[start..index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:443:61 [INFO] [stdout] | [INFO] [stdout] 443 | ... source: String::from_utf8_lossy(&bytes[start..index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lex.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 - return true; [INFO] [stdout] 482 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:476:45 [INFO] [stdout] | [INFO] [stdout] 476 | source: String::from_utf8_lossy(&bytes[self.index..(self.index + 1)].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[self.index..(self.index + 1)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lex.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 72 | / let lex = Lex { [INFO] [stdout] 73 | | file: String::from(file), [INFO] [stdout] 74 | | tokens: Vec::::new(), [INFO] [stdout] 75 | | index: 0, [INFO] [stdout] 76 | | line: 1, [INFO] [stdout] 77 | | column: 1, [INFO] [stdout] 78 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 79 | lex [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 72 ~ [INFO] [stdout] 73 ~ Lex { [INFO] [stdout] 74 + file: String::from(file), [INFO] [stdout] 75 + tokens: Vec::::new(), [INFO] [stdout] 76 + index: 0, [INFO] [stdout] 77 + line: 1, [INFO] [stdout] 78 + column: 1, [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:516:57 [INFO] [stdout] | [INFO] [stdout] 516 | source: String::from_utf8_lossy(&bytes[start..index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lex.rs:98:29 [INFO] [stdout] | [INFO] [stdout] 98 | _ => str += &format!("{}\n", token.show()).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}\n", token.show()).as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lex.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | let mut file = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lex.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / match file.read_to_string(&mut src) { [INFO] [stdout] 118 | | Err(why) => { [INFO] [stdout] 119 | | eprintln!("couldn't read {}: {:?}", &self.file, why); [INFO] [stdout] 120 | | std::process::exit(-1); [INFO] [stdout] 121 | | }, [INFO] [stdout] 122 | | Ok(_) => (), [INFO] [stdout] 123 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 117 ~ if let Err(why) = file.read_to_string(&mut src) { [INFO] [stdout] 118 + eprintln!("couldn't read {}: {:?}", &self.file, why); [INFO] [stdout] 119 + std::process::exit(-1); [INFO] [stdout] 120 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:191:57 [INFO] [stdout] | [INFO] [stdout] 191 | source: String::from_utf8_lossy(&bytes[start..self.index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:223:57 [INFO] [stdout] | [INFO] [stdout] 223 | source: String::from_utf8_lossy(&bytes[start..self.index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | if !(bytes[self.index] as char == '\n') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bytes[self.index] as char != '\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:652:61 [INFO] [stdout] | [INFO] [stdout] 652 | ... source: String::from_utf8_lossy(&bytes[start..index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lex.rs:662:21 [INFO] [stdout] | [INFO] [stdout] 662 | / if !err_token { [INFO] [stdout] 663 | | if !hex_num { [INFO] [stdout] 664 | | if index != start && (bytes[index - 1] as char).is_ascii_digit() { [INFO] [stdout] 665 | | if f_flag { [INFO] [stdout] ... | [INFO] [stdout] 686 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 662 ~ if !err_token [INFO] [stdout] 663 ~ && !hex_num { [INFO] [stdout] 664 | if index != start && (bytes[index - 1] as char).is_ascii_digit() { [INFO] [stdout] ... [INFO] [stdout] 684 | } [INFO] [stdout] 685 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 262 | if !(bytes[self.index] as char == ' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bytes[self.index] as char != ' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 282 | if !(bytes[self.index] as char == '\"') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bytes[self.index] as char != '\"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:311:61 [INFO] [stdout] | [INFO] [stdout] 311 | ... source: String::from_utf8_lossy(&bytes[start..self.index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex.rs:338:12 [INFO] [stdout] | [INFO] [stdout] 338 | if !(bytes[self.index] as char == '\'') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bytes[self.index] as char != '\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | "V0.1.0" [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 ~ "{}\n\nNcc compiler by Nick.Hu -- V0.1.0", [INFO] [stdout] 127 ~ cmdline.help() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:372:61 [INFO] [stdout] | [INFO] [stdout] 372 | ... source: String::from_utf8_lossy(&bytes[start..self.index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:134:51 [INFO] [stdout] | [INFO] [stdout] 134 | println!("Ncc compiler by Nick.Hu -- {}", "V0.1.0"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 134 - println!("Ncc compiler by Nick.Hu -- {}", "V0.1.0"); [INFO] [stdout] 134 + println!("Ncc compiler by Nick.Hu -- V0.1.0"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 138 | if cmdline.others.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cmdline.others.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:423:53 [INFO] [stdout] | [INFO] [stdout] 423 | source: String::from_utf8_lossy(&bytes[start..index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:443:61 [INFO] [stdout] | [INFO] [stdout] 443 | ... source: String::from_utf8_lossy(&bytes[start..index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lex.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 - return true; [INFO] [stdout] 482 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:476:45 [INFO] [stdout] | [INFO] [stdout] 476 | source: String::from_utf8_lossy(&bytes[self.index..(self.index + 1)].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[self.index..(self.index + 1)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:516:57 [INFO] [stdout] | [INFO] [stdout] 516 | source: String::from_utf8_lossy(&bytes[start..index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/lex.rs:652:61 [INFO] [stdout] | [INFO] [stdout] 652 | ... source: String::from_utf8_lossy(&bytes[start..index].to_vec()).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&bytes[start..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lex.rs:662:21 [INFO] [stdout] | [INFO] [stdout] 662 | / if !err_token { [INFO] [stdout] 663 | | if !hex_num { [INFO] [stdout] 664 | | if index != start && (bytes[index - 1] as char).is_ascii_digit() { [INFO] [stdout] 665 | | if f_flag { [INFO] [stdout] ... | [INFO] [stdout] 686 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 662 ~ if !err_token [INFO] [stdout] 663 ~ && !hex_num { [INFO] [stdout] 664 | if index != start && (bytes[index - 1] as char).is_ascii_digit() { [INFO] [stdout] ... [INFO] [stdout] 684 | } [INFO] [stdout] 685 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | "V0.1.0" [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 ~ "{}\n\nNcc compiler by Nick.Hu -- V0.1.0", [INFO] [stdout] 127 ~ cmdline.help() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:134:51 [INFO] [stdout] | [INFO] [stdout] 134 | println!("Ncc compiler by Nick.Hu -- {}", "V0.1.0"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 134 - println!("Ncc compiler by Nick.Hu -- {}", "V0.1.0"); [INFO] [stdout] 134 + println!("Ncc compiler by Nick.Hu -- V0.1.0"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 138 | if cmdline.others.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cmdline.others.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.39s [INFO] running `Command { std: "docker" "inspect" "2e58197457f18d8f1014e3cecbcd462f31c5e953fad23e3ab7d520d0ffdd8d27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e58197457f18d8f1014e3cecbcd462f31c5e953fad23e3ab7d520d0ffdd8d27", kill_on_drop: false }` [INFO] [stdout] 2e58197457f18d8f1014e3cecbcd462f31c5e953fad23e3ab7d520d0ffdd8d27