[INFO] cloning repository https://github.com/wishyoudie/localizer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wishyoudie/localizer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwishyoudie%2Flocalizer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwishyoudie%2Flocalizer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1f022227a35e071b341411f2bba30159b5f567c8 [INFO] linting wishyoudie/localizer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwishyoudie%2Flocalizer" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/wishyoudie/localizer [INFO] finished tweaking git repo https://github.com/wishyoudie/localizer [INFO] tweaked toml for git repo https://github.com/wishyoudie/localizer written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/wishyoudie/localizer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/wishyoudie/localizer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00c51ee073ab09a5c6a38af1121047dc62cbf334ba99f98b16fdbee56084aa90 [INFO] running `Command { std: "docker" "start" "-a" "00c51ee073ab09a5c6a38af1121047dc62cbf334ba99f98b16fdbee56084aa90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00c51ee073ab09a5c6a38af1121047dc62cbf334ba99f98b16fdbee56084aa90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00c51ee073ab09a5c6a38af1121047dc62cbf334ba99f98b16fdbee56084aa90", kill_on_drop: false }` [INFO] [stdout] 00c51ee073ab09a5c6a38af1121047dc62cbf334ba99f98b16fdbee56084aa90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9c744bf89942e628499170503b514fb2d1f37992c6ac17e147d6a77a85d9b83 [INFO] running `Command { std: "docker" "start" "-a" "d9c744bf89942e628499170503b514fb2d1f37992c6ac17e147d6a77a85d9b83", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling serde_json v1.0.138 [INFO] [stderr] Checking ryu v1.0.19 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Checking serde v1.0.217 [INFO] [stderr] Checking sync-locale v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | if !current.get(part).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current.get(part).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | fn create_file_handler(key: &String, value: &String) -> impl Fn(&std::path::Path) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 ~ fn create_file_handler(key: &str, value: &String) -> impl Fn(&std::path::Path) { [INFO] [stdout] 80 ~ let key = key.to_owned().trim().to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:79:45 [INFO] [stdout] | [INFO] [stdout] 79 | fn create_file_handler(key: &String, value: &String) -> impl Fn(&std::path::Path) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 ~ fn create_file_handler(key: &String, value: &str) -> impl Fn(&std::path::Path) { [INFO] [stdout] 80 | let key = key.clone().trim().to_string(); [INFO] [stdout] 81 ~ let value = value.to_owned().trim().to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:90:64 [INFO] [stdout] | [INFO] [stdout] 90 | path.file_name().unwrap().to_str().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | if !current.get(part).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current.get(part).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | fn create_file_handler(key: &String, value: &String) -> impl Fn(&std::path::Path) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 ~ fn create_file_handler(key: &str, value: &String) -> impl Fn(&std::path::Path) { [INFO] [stdout] 80 ~ let key = key.to_owned().trim().to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:79:45 [INFO] [stdout] | [INFO] [stdout] 79 | fn create_file_handler(key: &String, value: &String) -> impl Fn(&std::path::Path) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 ~ fn create_file_handler(key: &String, value: &str) -> impl Fn(&std::path::Path) { [INFO] [stdout] 80 | let key = key.clone().trim().to_string(); [INFO] [stdout] 81 ~ let value = value.to_owned().trim().to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:90:64 [INFO] [stdout] | [INFO] [stdout] 90 | path.file_name().unwrap().to_str().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.52s [INFO] running `Command { std: "docker" "inspect" "d9c744bf89942e628499170503b514fb2d1f37992c6ac17e147d6a77a85d9b83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9c744bf89942e628499170503b514fb2d1f37992c6ac17e147d6a77a85d9b83", kill_on_drop: false }` [INFO] [stdout] d9c744bf89942e628499170503b514fb2d1f37992c6ac17e147d6a77a85d9b83