[INFO] cloning repository https://github.com/winterhearted/autolocalhost [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/winterhearted/autolocalhost" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwinterhearted%2Fautolocalhost", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwinterhearted%2Fautolocalhost'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cabe8511daffba54957f0880d31e49a29dc6344e [INFO] linting winterhearted/autolocalhost against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwinterhearted%2Fautolocalhost" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/winterhearted/autolocalhost [INFO] finished tweaking git repo https://github.com/winterhearted/autolocalhost [INFO] tweaked toml for git repo https://github.com/winterhearted/autolocalhost written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/winterhearted/autolocalhost on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/winterhearted/autolocalhost already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rcgen v0.12.1 [INFO] [stderr] Downloaded hyperlocal v0.8.0 [INFO] [stderr] Downloaded bollard-stubs v1.43.0-rc.2 [INFO] [stderr] Downloaded bollard v0.15.0 [INFO] [stderr] Downloaded jiff-static v0.2.8 [INFO] [stderr] Downloaded handlebars v5.1.2 [INFO] [stderr] Downloaded jiff v0.2.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2599e9ab61925190536e239da16078c57fb8fb4906ef882dc598a76c5f7d1d8b [INFO] running `Command { std: "docker" "start" "-a" "2599e9ab61925190536e239da16078c57fb8fb4906ef882dc598a76c5f7d1d8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2599e9ab61925190536e239da16078c57fb8fb4906ef882dc598a76c5f7d1d8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2599e9ab61925190536e239da16078c57fb8fb4906ef882dc598a76c5f7d1d8b", kill_on_drop: false }` [INFO] [stdout] 2599e9ab61925190536e239da16078c57fb8fb4906ef882dc598a76c5f7d1d8b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10c058b92820ea961d3ed182b557d80101340ae05f846d14779c56afcf888a07 [INFO] running `Command { std: "docker" "start" "-a" "10c058b92820ea961d3ed182b557d80101340ae05f846d14779c56afcf888a07", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking litemap v0.7.5 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.1 [INFO] [stderr] Compiling icu_properties_data v1.5.1 [INFO] [stderr] Compiling icu_normalizer_data v1.5.1 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling zerocopy v0.8.24 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Checking pem v3.0.5 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking jiff v0.2.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking uuid v1.16.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking tokio v1.44.2 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling pest v2.8.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking rcgen v0.12.1 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Compiling pest_meta v2.8.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Compiling pest_generator v2.8.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Compiling pest_derive v2.8.0 [INFO] [stderr] Checking serde_with v3.12.0 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking handlebars v5.1.2 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking tokio-util v0.7.14 [INFO] [stderr] Checking bollard-stubs v1.43.0-rc.2 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyperlocal v0.8.0 [INFO] [stderr] Checking bollard v0.15.0 [INFO] [stderr] Checking autolocalhost v0.2.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/hosts/hosts_file_manager.rs:18:62 [INFO] [stdout] | [INFO] [stdout] 18 | let hosts_file_path = hosts_file_path.unwrap_or_else(|| Self::get_system_hosts_file_path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::get_system_hosts_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/mod.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 252 | return get_data_dir().join("certs"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 252 - return get_data_dir().join("certs"); [INFO] [stdout] 252 + get_data_dir().join("certs") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/mod.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | return get_data_dir().join("ca"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return get_data_dir().join("ca"); [INFO] [stdout] 256 + get_data_dir().join("ca") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/mod.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | return get_log_dir().join("nginx"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return get_log_dir().join("nginx"); [INFO] [stdout] 270 + get_log_dir().join("nginx") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/hosts/hosts_file_manager.rs:18:62 [INFO] [stdout] | [INFO] [stdout] 18 | let hosts_file_path = hosts_file_path.unwrap_or_else(|| Self::get_system_hosts_file_path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::get_system_hosts_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RestartPolicyNameEnum` which implements the `Copy` trait [INFO] [stdout] --> src/nginx/container_manager.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | name: Some(self.restart_policy.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.restart_policy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ssl/certificate_generator.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if !fs::metadata(&ca_cert_path).await.is_ok() || !fs::metadata(&ca_key_path).await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&ca_cert_path).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ssl/certificate_generator.rs:161:58 [INFO] [stdout] | [INFO] [stdout] 161 | if !fs::metadata(&ca_cert_path).await.is_ok() || !fs::metadata(&ca_key_path).await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&ca_key_path).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/mod.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 252 | return get_data_dir().join("certs"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 252 - return get_data_dir().join("certs"); [INFO] [stdout] 252 + get_data_dir().join("certs") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/mod.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | return get_data_dir().join("ca"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return get_data_dir().join("ca"); [INFO] [stdout] 256 + get_data_dir().join("ca") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/installer/mod.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | return get_log_dir().join("nginx"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return get_log_dir().join("nginx"); [INFO] [stdout] 270 + get_log_dir().join("nginx") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RestartPolicyNameEnum` which implements the `Copy` trait [INFO] [stdout] --> src/nginx/container_manager.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | name: Some(self.restart_policy.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.restart_policy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ssl/certificate_generator.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if !fs::metadata(&ca_cert_path).await.is_ok() || !fs::metadata(&ca_key_path).await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&ca_cert_path).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ssl/certificate_generator.rs:161:58 [INFO] [stdout] | [INFO] [stdout] 161 | if !fs::metadata(&ca_cert_path).await.is_ok() || !fs::metadata(&ca_key_path).await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&ca_key_path).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 23s [INFO] running `Command { std: "docker" "inspect" "10c058b92820ea961d3ed182b557d80101340ae05f846d14779c56afcf888a07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10c058b92820ea961d3ed182b557d80101340ae05f846d14779c56afcf888a07", kill_on_drop: false }` [INFO] [stdout] 10c058b92820ea961d3ed182b557d80101340ae05f846d14779c56afcf888a07