[INFO] cloning repository https://github.com/williamspatrick/gerrit-faster [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/williamspatrick/gerrit-faster" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwilliamspatrick%2Fgerrit-faster", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwilliamspatrick%2Fgerrit-faster'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 85447cc32342e0ad20716651c5567f2c7cd4a314 [INFO] linting williamspatrick/gerrit-faster against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwilliamspatrick%2Fgerrit-faster" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/williamspatrick/gerrit-faster [INFO] finished tweaking git repo https://github.com/williamspatrick/gerrit-faster [INFO] tweaked toml for git repo https://github.com/williamspatrick/gerrit-faster written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/williamspatrick/gerrit-faster on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/williamspatrick/gerrit-faster already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded openssl-probe v0.2.0 [INFO] [stderr] Downloaded typesize-derive v0.1.11 [INFO] [stderr] Downloaded mini-moka v0.10.3 [INFO] [stderr] Downloaded zmij v1.0.2 [INFO] [stderr] Downloaded askama_macros v0.15.4 [INFO] [stderr] Downloaded skeptic v0.13.7 [INFO] [stderr] Downloaded typesize v0.1.13 [INFO] [stderr] Downloaded poise_macros v0.6.1 [INFO] [stderr] Downloaded askama v0.15.4 [INFO] [stderr] Downloaded camino v1.1.9 [INFO] [stderr] Downloaded askama_parser v0.15.4 [INFO] [stderr] Downloaded askama_derive v0.15.4 [INFO] [stderr] Downloaded pulldown-cmark v0.9.6 [INFO] [stderr] Downloaded fancy-regex v0.17.0 [INFO] [stderr] Downloaded poise v0.6.1 [INFO] [stderr] Downloaded aws-lc-rs v1.15.2 [INFO] [stderr] Downloaded webpki-root-certs v1.0.4 [INFO] [stderr] Downloaded comfy-table v7.2.2 [INFO] [stderr] Downloaded tempfile v3.21.0 [INFO] [stderr] Downloaded aws-lc-sys v0.35.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9bb13c9b261311e4d7d0ddf16993c09e122b4248648e8907f80315674ce1418d [INFO] running `Command { std: "docker" "start" "-a" "9bb13c9b261311e4d7d0ddf16993c09e122b4248648e8907f80315674ce1418d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9bb13c9b261311e4d7d0ddf16993c09e122b4248648e8907f80315674ce1418d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bb13c9b261311e4d7d0ddf16993c09e122b4248648e8907f80315674ce1418d", kill_on_drop: false }` [INFO] [stdout] 9bb13c9b261311e4d7d0ddf16993c09e122b4248648e8907f80315674ce1418d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a327cae5598b15eb57505c8a111494621ee15a8572b4553ca2444316d6c49cb [INFO] running `Command { std: "docker" "start" "-a" "3a327cae5598b15eb57505c8a111494621ee15a8572b4553ca2444316d6c49cb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Compiling find-msvc-tools v0.1.6 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Compiling aws-lc-rs v1.15.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling zmij v1.0.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling cc v1.2.51 [INFO] [stderr] Compiling rustls v0.23.31 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling winnow v0.7.13 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking data-encoding v2.8.0 [INFO] [stderr] Compiling rustc-hash v2.1.1 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling aws-lc-sys v0.35.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Compiling basic-toml v0.1.10 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking webpki-roots v0.26.8 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking rand_core v0.10.0 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking openssl-probe v0.2.0 [INFO] [stderr] Compiling serenity v0.12.4 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking cpufeatures v0.3.0 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking typemap_rev v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking chacha20 v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Compiling poise_macros v0.6.1 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Compiling askama_parser v0.15.4 [INFO] [stderr] Checking axum-core v0.5.5 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking serde_cow v0.1.2 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking comfy-table v7.2.2 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking rand v0.10.0 [INFO] [stderr] Compiling askama_derive v0.15.4 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking fancy-regex v0.17.0 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Compiling askama_macros v0.15.4 [INFO] [stderr] Checking askama v0.15.4 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking poise v0.6.1 [INFO] [stderr] Checking gerrit-faster v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changes/container.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | review_state: review_state, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `review_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changes/container.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | review_state_updated: review_state_updated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `review_state_updated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changes/container.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | review_state: review_state, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `review_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changes/container.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | review_state_updated: review_state_updated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `review_state_updated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Container` [INFO] [stdout] --> src/changes/container.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Container { [INFO] [stdout] 23 | | Container { [INFO] [stdout] 24 | | changes: HashMap::::new(), [INFO] [stdout] 25 | | changes_by_id: HashMap::::new(), [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for Container { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/changes/filter.rs:77:36 [INFO] [stdout] | [INFO] [stdout] 77 | for (file_path, _file_info) in &revision.files { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 77 - for (file_path, _file_info) in &revision.files { [INFO] [stdout] 77 + for file_path in revision.files.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/changes/report.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .or_insert_with(ChangesByOwner::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/changes/report.rs:141:24 [INFO] [stdout] | [INFO] [stdout] 141 | for (_, change) in &context.lock().unwrap().changes.changes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 141 - for (_, change) in &context.lock().unwrap().changes.changes { [INFO] [stdout] 141 + for change in context.lock().unwrap().changes.changes.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/changes/report.rs:169:24 [INFO] [stdout] | [INFO] [stdout] 169 | for (_, change) in &context.lock().unwrap().changes.changes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 169 - for (_, change) in &context.lock().unwrap().changes.changes { [INFO] [stdout] 169 + for change in context.lock().unwrap().changes.changes.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/changes/serve.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | if let Some(_) = context [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 26 ~ if context [INFO] [stdout] 27 + .get_gerrit() [INFO] [stdout] 28 + .abandon_change( [INFO] [stdout] 29 + &change.id, [INFO] [stdout] 30 + concat!( [INFO] [stdout] 31 + "Automatically abandoned due to inactivity of over two years.\n", [INFO] [stdout] 32 + "Please rebase and reopen if this should still be merged.", [INFO] [stdout] 33 + ).to_string(), [INFO] [stdout] 34 + ) [INFO] [stdout] 35 + .await.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/changes/serve.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !found_verified.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `found_verified.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/changes/serve.rs:50:53 [INFO] [stdout] | [INFO] [stdout] 50 | let one_year_ago = now - chrono::Duration::days(1 * 365); [INFO] [stdout] | ^^^^^^^ help: consider reducing it to: `365` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/changes/serve.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | if let Some(_) = context [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 ~ if context [INFO] [stdout] 77 + .get_gerrit() [INFO] [stdout] 78 + .abandon_change( [INFO] [stdout] 79 + &change.id, [INFO] [stdout] 80 + concat!( [INFO] [stdout] 81 + "Automatically abandoned due to missing or failing CI and inactivity of over one year.\n", [INFO] [stdout] 82 + "Please rebase, resolve CI and reopen if this should still be merged.\n", [INFO] [stdout] 83 + "\n", [INFO] [stdout] 84 + ) [INFO] [stdout] 85 + .to_string() [INFO] [stdout] 86 + + &format!( [INFO] [stdout] 87 + "CI status: {}={}", [INFO] [stdout] 88 + ci_failure.username, [INFO] [stdout] 89 + ci_failure.value [INFO] [stdout] 90 + ) [INFO] [stdout] 91 + ) [INFO] [stdout] 92 + .await.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ServiceContext` [INFO] [stdout] --> src/context.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> ServiceContext { [INFO] [stdout] 16 | | ServiceContext(Arc::new(Mutex::new(ServiceContextData { [INFO] [stdout] 17 | | gerrit: crate::gerrit::connection::new(), [INFO] [stdout] 18 | | changes: Changes::new(), [INFO] [stdout] 19 | | }))) [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for ServiceContext { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `change` after checking its variant with `is_some` [INFO] [stdout] --> src/discord/serve.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 58 | let response = if change.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = change` [INFO] [stdout] ... [INFO] [stdout] 62 | change.unwrap().review_state [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/gerrit/connection.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | return Some(text[MAGIC_PREFIX.len()..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/gerrit/connection.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | if text.starts_with(MAGIC_PREFIX) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 11 ~ if let Some() = text.strip_prefix(MAGIC_PREFIX) { [INFO] [stdout] 12 ~ return Some(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/gerrit/connection.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 134 | .expect(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 135 | | "Failed to parse JSON response for all_open_changes. Response content: {}", [INFO] [stdout] 136 | | result [INFO] [stdout] 137 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 134 ~ .unwrap_or_else(|_| panic!("Failed to parse JSON response for all_open_changes. Response content: {}", [INFO] [stdout] 135 + result)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/gerrit/connection.rs:154:14 [INFO] [stdout] | [INFO] [stdout] 154 | .expect(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 155 | | "Failed to parse JSON response for recent_changes. Response content: {}", [INFO] [stdout] 156 | | result [INFO] [stdout] 157 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 154 ~ .unwrap_or_else(|_| panic!("Failed to parse JSON response for recent_changes. Response content: {}", [INFO] [stdout] 155 + result)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Container` [INFO] [stdout] --> src/changes/container.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Container { [INFO] [stdout] 23 | | Container { [INFO] [stdout] 24 | | changes: HashMap::::new(), [INFO] [stdout] 25 | | changes_by_id: HashMap::::new(), [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for Container { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/gerrit/connection.rs:196:18 [INFO] [stdout] | [INFO] [stdout] 196 | .expect(&format!( [INFO] [stdout] | __________________^ [INFO] [stdout] 197 | | "Failed to parse JSON response for abandon_change. Response content: {}", [INFO] [stdout] 198 | | result [INFO] [stdout] 199 | | )) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 196 ~ .unwrap_or_else(|_| panic!("Failed to parse JSON response for abandon_change. Response content: {}", [INFO] [stdout] 197 + result)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/changes/filter.rs:77:36 [INFO] [stdout] | [INFO] [stdout] 77 | for (file_path, _file_info) in &revision.files { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 77 - for (file_path, _file_info) in &revision.files { [INFO] [stdout] 77 + for file_path in revision.files.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/changes/report.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .or_insert_with(ChangesByOwner::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/changes/report.rs:141:24 [INFO] [stdout] | [INFO] [stdout] 141 | for (_, change) in &context.lock().unwrap().changes.changes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 141 - for (_, change) in &context.lock().unwrap().changes.changes { [INFO] [stdout] 141 + for change in context.lock().unwrap().changes.changes.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/changes/report.rs:169:24 [INFO] [stdout] | [INFO] [stdout] 169 | for (_, change) in &context.lock().unwrap().changes.changes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 169 - for (_, change) in &context.lock().unwrap().changes.changes { [INFO] [stdout] 169 + for change in context.lock().unwrap().changes.changes.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/webserver/serve.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | interval.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/changes/serve.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | if let Some(_) = context [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 26 ~ if context [INFO] [stdout] 27 + .get_gerrit() [INFO] [stdout] 28 + .abandon_change( [INFO] [stdout] 29 + &change.id, [INFO] [stdout] 30 + concat!( [INFO] [stdout] 31 + "Automatically abandoned due to inactivity of over two years.\n", [INFO] [stdout] 32 + "Please rebase and reopen if this should still be merged.", [INFO] [stdout] 33 + ).to_string(), [INFO] [stdout] 34 + ) [INFO] [stdout] 35 + .await.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/changes/serve.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !found_verified.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `found_verified.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/changes/serve.rs:50:53 [INFO] [stdout] | [INFO] [stdout] 50 | let one_year_ago = now - chrono::Duration::days(1 * 365); [INFO] [stdout] | ^^^^^^^ help: consider reducing it to: `365` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/changes/serve.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | if let Some(_) = context [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 ~ if context [INFO] [stdout] 77 + .get_gerrit() [INFO] [stdout] 78 + .abandon_change( [INFO] [stdout] 79 + &change.id, [INFO] [stdout] 80 + concat!( [INFO] [stdout] 81 + "Automatically abandoned due to missing or failing CI and inactivity of over one year.\n", [INFO] [stdout] 82 + "Please rebase, resolve CI and reopen if this should still be merged.\n", [INFO] [stdout] 83 + "\n", [INFO] [stdout] 84 + ) [INFO] [stdout] 85 + .to_string() [INFO] [stdout] 86 + + &format!( [INFO] [stdout] 87 + "CI status: {}={}", [INFO] [stdout] 88 + ci_failure.username, [INFO] [stdout] 89 + ci_failure.value [INFO] [stdout] 90 + ) [INFO] [stdout] 91 + ) [INFO] [stdout] 92 + .await.is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ServiceContext` [INFO] [stdout] --> src/context.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> ServiceContext { [INFO] [stdout] 16 | | ServiceContext(Arc::new(Mutex::new(ServiceContextData { [INFO] [stdout] 17 | | gerrit: crate::gerrit::connection::new(), [INFO] [stdout] 18 | | changes: Changes::new(), [INFO] [stdout] 19 | | }))) [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for ServiceContext { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `change` after checking its variant with `is_some` [INFO] [stdout] --> src/discord/serve.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 58 | let response = if change.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = change` [INFO] [stdout] ... [INFO] [stdout] 62 | change.unwrap().review_state [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/gerrit/connection.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | return Some(text[MAGIC_PREFIX.len()..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/gerrit/connection.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | if text.starts_with(MAGIC_PREFIX) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 11 ~ if let Some() = text.strip_prefix(MAGIC_PREFIX) { [INFO] [stdout] 12 ~ return Some(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/gerrit/connection.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 134 | .expect(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 135 | | "Failed to parse JSON response for all_open_changes. Response content: {}", [INFO] [stdout] 136 | | result [INFO] [stdout] 137 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 134 ~ .unwrap_or_else(|_| panic!("Failed to parse JSON response for all_open_changes. Response content: {}", [INFO] [stdout] 135 + result)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/gerrit/connection.rs:154:14 [INFO] [stdout] | [INFO] [stdout] 154 | .expect(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 155 | | "Failed to parse JSON response for recent_changes. Response content: {}", [INFO] [stdout] 156 | | result [INFO] [stdout] 157 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 154 ~ .unwrap_or_else(|_| panic!("Failed to parse JSON response for recent_changes. Response content: {}", [INFO] [stdout] 155 + result)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/gerrit/connection.rs:196:18 [INFO] [stdout] | [INFO] [stdout] 196 | .expect(&format!( [INFO] [stdout] | __________________^ [INFO] [stdout] 197 | | "Failed to parse JSON response for abandon_change. Response content: {}", [INFO] [stdout] 198 | | result [INFO] [stdout] 199 | | )) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 196 ~ .unwrap_or_else(|_| panic!("Failed to parse JSON response for abandon_change. Response content: {}", [INFO] [stdout] 197 + result)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/webserver/serve.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | interval.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 22s [INFO] running `Command { std: "docker" "inspect" "3a327cae5598b15eb57505c8a111494621ee15a8572b4553ca2444316d6c49cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a327cae5598b15eb57505c8a111494621ee15a8572b4553ca2444316d6c49cb", kill_on_drop: false }` [INFO] [stdout] 3a327cae5598b15eb57505c8a111494621ee15a8572b4553ca2444316d6c49cb