[INFO] cloning repository https://github.com/whyando/aoc-2025 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/whyando/aoc-2025" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhyando%2Faoc-2025", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhyando%2Faoc-2025'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3c2bce6c85970a8857479211498a259bb8dfc27c [INFO] linting whyando/aoc-2025/3c2bce6c85970a8857479211498a259bb8dfc27c against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhyando%2Faoc-2025" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-3-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/whyando/aoc-2025 [INFO] finished tweaking git repo https://github.com/whyando/aoc-2025 [INFO] tweaked toml for git repo https://github.com/whyando/aoc-2025 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/whyando/aoc-2025 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/whyando/aoc-2025 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sprs v0.11.4 [INFO] [stderr] Downloaded microlp v0.2.11 [INFO] [stderr] Downloaded ndarray v0.17.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ebd1c524c6bc8cce41ea2f3c6e8d3dd3bc32a11921cbece4dfa95ef8cfe49da1 [INFO] running `Command { std: "docker" "start" "-a" "ebd1c524c6bc8cce41ea2f3c6e8d3dd3bc32a11921cbece4dfa95ef8cfe49da1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ebd1c524c6bc8cce41ea2f3c6e8d3dd3bc32a11921cbece4dfa95ef8cfe49da1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebd1c524c6bc8cce41ea2f3c6e8d3dd3bc32a11921cbece4dfa95ef8cfe49da1", kill_on_drop: false }` [INFO] [stdout] ebd1c524c6bc8cce41ea2f3c6e8d3dd3bc32a11921cbece4dfa95ef8cfe49da1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a68a249b39729c856c1f7bfd1a8240589bb0e279a1938cc03057c6c9556ab8c [INFO] running `Command { std: "docker" "start" "-a" "4a68a249b39729c856c1f7bfd1a8240589bb0e279a1938cc03057c6c9556ab8c", kill_on_drop: false }` [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking ndarray v0.17.1 [INFO] [stderr] Checking sprs v0.11.4 [INFO] [stderr] Checking microlp v0.2.11 [INFO] [stderr] Checking aoc-2025 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day01.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | x = x - steps; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `x -= steps` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day01.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | x = x + steps; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `x += steps` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day02.rs:156:26 [INFO] [stdout] | [INFO] [stdout] 156 | assert_eq!(solve(&test_input), (1227775554, 4174379265)); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `test_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `line` [INFO] [stdout] --> src/day03.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | for i in 0..line.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 20 - for i in 0..line.len() - 1 { [INFO] [stdout] 20 + for (i, ) in line.iter().enumerate().take(line.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `line` [INFO] [stdout] --> src/day03.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | for i in largest_index + 1..line.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 27 - for i in largest_index + 1..line.len() { [INFO] [stdout] 27 + for in line.iter().skip(largest_index + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `line` [INFO] [stdout] --> src/day03.rs:43:26 [INFO] [stdout] | [INFO] [stdout] 43 | for i in min_index..line.len() - (12 - digit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 43 - for i in min_index..line.len() - (12 - digit) { [INFO] [stdout] 43 + for (i, ) in line.iter().enumerate().take(line.len() - (12 - digit)).skip(min_index) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `line` [INFO] [stdout] --> src/day03.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 83 | for i in 0..n - 1 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 83 - for i in 0..n - 1 { [INFO] [stdout] 83 + for (i, ) in line.iter().enumerate().take(n - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `line` [INFO] [stdout] --> src/day03.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 90 | for i in largest_index + 1..n { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 90 - for i in largest_index + 1..n { [INFO] [stdout] 90 + for in line.iter().take(n).skip(largest_index + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `line` [INFO] [stdout] --> src/day03.rs:102:22 [INFO] [stdout] | [INFO] [stdout] 102 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 102 - for i in 0..n { [INFO] [stdout] 102 + for (i, ) in line.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/day03.rs:121:22 [INFO] [stdout] | [INFO] [stdout] 121 | for i in 0..12 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 121 - for i in 0..12 { [INFO] [stdout] 121 + for in &v { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/day05.rs:96:26 [INFO] [stdout] | [INFO] [stdout] 96 | assert_eq!(solve(&test_input.to_vec()), (3, 14)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `test_input.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | for j in op_idx..last_op_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 58 - for j in op_idx..last_op_idx { [INFO] [stdout] 58 + for in lines.iter().take(last_op_idx).skip(op_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 66 | for j in op_idx..last_op_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 66 - for j in op_idx..last_op_idx { [INFO] [stdout] 66 + for in lines.iter().take(last_op_idx).skip(op_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:68:26 [INFO] [stdout] | [INFO] [stdout] 68 | for i in 0..HEIGHT { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 68 - for i in 0..HEIGHT { [INFO] [stdout] 68 + for in lines.iter().take(HEIGHT) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:81:26 [INFO] [stdout] | [INFO] [stdout] 81 | for j in op_idx..last_op_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 81 - for j in op_idx..last_op_idx { [INFO] [stdout] 81 + for in lines.iter().take(last_op_idx).skip(op_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 90 | for j in op_idx..last_op_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 90 - for j in op_idx..last_op_idx { [INFO] [stdout] 90 + for in lines.iter().take(last_op_idx).skip(op_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:92:26 [INFO] [stdout] | [INFO] [stdout] 92 | for i in 0..HEIGHT { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 92 - for i in 0..HEIGHT { [INFO] [stdout] 92 + for in lines.iter().take(HEIGHT) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day07.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 2 - Ok(std::fs::read(path)?) [INFO] [stdout] 2 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/day07.rs:59:32 [INFO] [stdout] | [INFO] [stdout] 59 | assert_eq!(solve::<15>(&test_input.to_vec()), (21, 40)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `test_input.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day08.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 4 - Ok(std::fs::read(path)?) [INFO] [stdout] 4 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/day08.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | edges.sort_unstable_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 113 - edges.sort_unstable_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] 113 + edges.sort_unstable_by_key(|a| a.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/day08.rs:177:26 [INFO] [stdout] | [INFO] [stdout] 177 | assert_eq!(solve(&test_input.to_vec(), 10), (40, 25272)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `test_input.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day09.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 4 - Ok(std::fs::read(path)?) [INFO] [stdout] 4 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/day09.rs:264:26 [INFO] [stdout] | [INFO] [stdout] 264 | assert_eq!(solve(&test_input.to_vec()), (50, 24)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `test_input.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day10.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 4 - Ok(std::fs::read(path)?) [INFO] [stdout] 4 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day01.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | x = x - steps; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `x -= steps` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day01.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | x = x + steps; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `x += steps` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/day10.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|s| parse_u64(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `vars` [INFO] [stdout] --> src/day10.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 112 | for j in 0..n_buttons { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 112 - for j in 0..n_buttons { [INFO] [stdout] 112 + for (j, ) in vars.iter().enumerate().take(n_buttons) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/day10.rs:191:26 [INFO] [stdout] | [INFO] [stdout] 191 | assert_eq!(solve(&test_input.to_vec()), (7, 33)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `test_input.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day11.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 4 - Ok(std::fs::read(path)?) [INFO] [stdout] 4 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `line` [INFO] [stdout] --> src/day03.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | for i in 0..line.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 20 - for i in 0..line.len() - 1 { [INFO] [stdout] 20 + for (i, ) in line.iter().enumerate().take(line.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `line` [INFO] [stdout] --> src/day03.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | for i in largest_index + 1..line.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 27 - for i in largest_index + 1..line.len() { [INFO] [stdout] 27 + for in line.iter().skip(largest_index + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `line` [INFO] [stdout] --> src/day03.rs:43:26 [INFO] [stdout] | [INFO] [stdout] 43 | for i in min_index..line.len() - (12 - digit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 43 - for i in min_index..line.len() - (12 - digit) { [INFO] [stdout] 43 + for (i, ) in line.iter().enumerate().take(line.len() - (12 - digit)).skip(min_index) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `line` [INFO] [stdout] --> src/day03.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 83 | for i in 0..n - 1 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 83 - for i in 0..n - 1 { [INFO] [stdout] 83 + for (i, ) in line.iter().enumerate().take(n - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `line` [INFO] [stdout] --> src/day03.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 90 | for i in largest_index + 1..n { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 90 - for i in largest_index + 1..n { [INFO] [stdout] 90 + for in line.iter().take(n).skip(largest_index + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `line` [INFO] [stdout] --> src/day03.rs:102:22 [INFO] [stdout] | [INFO] [stdout] 102 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 102 - for i in 0..n { [INFO] [stdout] 102 + for (i, ) in line.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/day03.rs:121:22 [INFO] [stdout] | [INFO] [stdout] 121 | for i in 0..12 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 121 - for i in 0..12 { [INFO] [stdout] 121 + for in &v { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/day11.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | assert_eq!(solve(&test_input.to_vec()), (5, 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `test_input.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/day11.rs:161:26 [INFO] [stdout] | [INFO] [stdout] 161 | assert_eq!(solve(&test_input.to_vec()), (0, 2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `test_input.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day12.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 2 - Ok(std::fs::read(path)?) [INFO] [stdout] 2 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/day12.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | / if let Some(x_pos) = dim_str.find('x') { [INFO] [stdout] 78 | | if let (Ok(width), Ok(height)) = ( [INFO] [stdout] 79 | | dim_str[..x_pos].parse::(), [INFO] [stdout] 80 | | dim_str[x_pos + 1..].trim().parse::(), [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 77 ~ if let Some(x_pos) = dim_str.find('x') [INFO] [stdout] 78 ~ && let (Ok(width), Ok(height)) = ( [INFO] [stdout] 79 | dim_str[..x_pos].parse::(), [INFO] [stdout] ... [INFO] [stdout] 93 | }); [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/day12.rs:177:26 [INFO] [stdout] | [INFO] [stdout] 177 | assert_eq!(solve(&test_input.to_vec()), (0, 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `test_input.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | for j in op_idx..last_op_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 58 - for j in op_idx..last_op_idx { [INFO] [stdout] 58 + for in lines.iter().take(last_op_idx).skip(op_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 66 | for j in op_idx..last_op_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 66 - for j in op_idx..last_op_idx { [INFO] [stdout] 66 + for in lines.iter().take(last_op_idx).skip(op_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:68:26 [INFO] [stdout] | [INFO] [stdout] 68 | for i in 0..HEIGHT { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 68 - for i in 0..HEIGHT { [INFO] [stdout] 68 + for in lines.iter().take(HEIGHT) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:81:26 [INFO] [stdout] | [INFO] [stdout] 81 | for j in op_idx..last_op_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 81 - for j in op_idx..last_op_idx { [INFO] [stdout] 81 + for in lines.iter().take(last_op_idx).skip(op_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 90 | for j in op_idx..last_op_idx { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 90 - for j in op_idx..last_op_idx { [INFO] [stdout] 90 + for in lines.iter().take(last_op_idx).skip(op_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/day06.rs:92:26 [INFO] [stdout] | [INFO] [stdout] 92 | for i in 0..HEIGHT { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 92 - for i in 0..HEIGHT { [INFO] [stdout] 92 + for in lines.iter().take(HEIGHT) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day07.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 2 - Ok(std::fs::read(path)?) [INFO] [stdout] 2 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day08.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 4 - Ok(std::fs::read(path)?) [INFO] [stdout] 4 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/day08.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | edges.sort_unstable_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 113 - edges.sort_unstable_by(|a, b| a.1.cmp(&b.1)); [INFO] [stdout] 113 + edges.sort_unstable_by_key(|a| a.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day09.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 4 - Ok(std::fs::read(path)?) [INFO] [stdout] 4 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day10.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 4 - Ok(std::fs::read(path)?) [INFO] [stdout] 4 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/day10.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|s| parse_u64(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `vars` [INFO] [stdout] --> src/day10.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 112 | for j in 0..n_buttons { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 112 - for j in 0..n_buttons { [INFO] [stdout] 112 + for (j, ) in vars.iter().enumerate().take(n_buttons) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day11.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 4 - Ok(std::fs::read(path)?) [INFO] [stdout] 4 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/day12.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | Ok(std::fs::read(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 2 - Ok(std::fs::read(path)?) [INFO] [stdout] 2 + std::fs::read(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/day12.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | / if let Some(x_pos) = dim_str.find('x') { [INFO] [stdout] 78 | | if let (Ok(width), Ok(height)) = ( [INFO] [stdout] 79 | | dim_str[..x_pos].parse::(), [INFO] [stdout] 80 | | dim_str[x_pos + 1..].trim().parse::(), [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 77 ~ if let Some(x_pos) = dim_str.find('x') [INFO] [stdout] 78 ~ && let (Ok(width), Ok(height)) = ( [INFO] [stdout] 79 | dim_str[..x_pos].parse::(), [INFO] [stdout] ... [INFO] [stdout] 93 | }); [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.46s [INFO] running `Command { std: "docker" "inspect" "4a68a249b39729c856c1f7bfd1a8240589bb0e279a1938cc03057c6c9556ab8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a68a249b39729c856c1f7bfd1a8240589bb0e279a1938cc03057c6c9556ab8c", kill_on_drop: false }` [INFO] [stdout] 4a68a249b39729c856c1f7bfd1a8240589bb0e279a1938cc03057c6c9556ab8c