[INFO] cloning repository https://github.com/whoisyurii/christ-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/whoisyurii/christ-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhoisyurii%2Fchrist-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhoisyurii%2Fchrist-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d4b58604c62be319074f011026e5eb423388dd26 [INFO] linting whoisyurii/christ-cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhoisyurii%2Fchrist-cli" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/whoisyurii/christ-cli [INFO] finished tweaking git repo https://github.com/whoisyurii/christ-cli [INFO] tweaked toml for git repo https://github.com/whoisyurii/christ-cli written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/whoisyurii/christ-cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/whoisyurii/christ-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded socket2 v0.6.2 [INFO] [stderr] Downloaded tokio-macros v2.6.1 [INFO] [stderr] Downloaded simple-easing v1.0.2 [INFO] [stderr] Downloaded instability v0.3.11 [INFO] [stderr] Downloaded darling_macro v0.23.0 [INFO] [stderr] Downloaded darling v0.23.0 [INFO] [stderr] Downloaded indoc v2.0.7 [INFO] [stderr] Downloaded anstyle-query v1.1.5 [INFO] [stderr] Downloaded anstyle-wincon v3.0.11 [INFO] [stderr] Downloaded dirs-sys v0.4.1 [INFO] [stderr] Downloaded directories v5.0.1 [INFO] [stderr] Downloaded is_terminal_polyfill v1.70.2 [INFO] [stderr] Downloaded clap_lex v1.0.0 [INFO] [stderr] Downloaded castaway v0.2.4 [INFO] [stderr] Downloaded once_cell_polyfill v1.70.2 [INFO] [stderr] Downloaded directories v6.0.0 [INFO] [stderr] Downloaded anstream v0.6.21 [INFO] [stderr] Downloaded confy v0.6.1 [INFO] [stderr] Downloaded colorsys v0.6.7 [INFO] [stderr] Downloaded signal-hook-mio v0.2.5 [INFO] [stderr] Downloaded anstyle v1.0.13 [INFO] [stderr] Downloaded clap_derive v4.5.55 [INFO] [stderr] Downloaded zeroize v1.8.2 [INFO] [stderr] Downloaded getrandom v0.2.17 [INFO] [stderr] Downloaded futures-channel v0.3.32 [INFO] [stderr] Downloaded quinn-udp v0.5.14 [INFO] [stderr] Downloaded rustls-pki-types v1.14.0 [INFO] [stderr] Downloaded ipnet v2.12.0 [INFO] [stderr] Downloaded signal-hook v0.3.18 [INFO] [stderr] Downloaded ryu v1.0.23 [INFO] [stderr] Downloaded darling_core v0.23.0 [INFO] [stderr] Downloaded clap v4.5.60 [INFO] [stderr] Downloaded quinn v0.11.9 [INFO] [stderr] Downloaded rustls-webpki v0.103.9 [INFO] [stderr] Downloaded hyper-util v0.1.20 [INFO] [stderr] Downloaded tower v0.5.3 [INFO] [stderr] Downloaded http v1.4.0 [INFO] [stderr] Downloaded tachyonfx v0.9.3 [INFO] [stderr] Downloaded hyper v1.8.1 [INFO] [stderr] Downloaded clap_builder v4.5.60 [INFO] [stderr] Downloaded reqwest v0.12.28 [INFO] [stderr] Downloaded iri-string v0.7.10 [INFO] [stderr] Downloaded webpki-roots v1.0.6 [INFO] [stderr] Downloaded quinn-proto v0.11.13 [INFO] [stderr] Downloaded tower-http v0.6.8 [INFO] [stderr] Downloaded bon-macros v3.9.0 [INFO] [stderr] Downloaded compact_str v0.8.1 [INFO] [stderr] Downloaded bon v3.9.0 [INFO] [stderr] Downloaded rustls v0.23.37 [INFO] [stderr] Downloaded tokio v1.50.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd44d7dcf8f994cbbb0e05e86cfd2f41b6b18dc0ac83dc2dd6ad7f651fb23fe6 [INFO] running `Command { std: "docker" "start" "-a" "fd44d7dcf8f994cbbb0e05e86cfd2f41b6b18dc0ac83dc2dd6ad7f651fb23fe6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd44d7dcf8f994cbbb0e05e86cfd2f41b6b18dc0ac83dc2dd6ad7f651fb23fe6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd44d7dcf8f994cbbb0e05e86cfd2f41b6b18dc0ac83dc2dd6ad7f651fb23fe6", kill_on_drop: false }` [INFO] [stdout] fd44d7dcf8f994cbbb0e05e86cfd2f41b6b18dc0ac83dc2dd6ad7f651fb23fe6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 134b145cf03e2afdb9fe4283cf438ad628d57acb90be9690ed9adef5fd959098 [INFO] running `Command { std: "docker" "start" "-a" "134b145cf03e2afdb9fe4283cf438ad628d57acb90be9690ed9adef5fd959098", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking colorsys v0.6.7 [INFO] [stderr] Checking simple-easing v1.0.2 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling bon-macros v3.9.0 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking bon v3.9.0 [INFO] [stderr] Checking tachyonfx v0.9.3 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking confy v0.6.1 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking christ-cli v0.5.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/api/bolls.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 221 | if id >= 1 && id <= 66 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `(1..=66).contains(&id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/app.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / enum AppMode { [INFO] [stdout] 14 | | Banner(BannerState), [INFO] [stdout] | | ------------------- the second-largest variant contains at least 8 bytes [INFO] [stdout] 15 | | Browser(BrowserState), [INFO] [stdout] | | --------------------- the largest variant contains at least 384 bytes [INFO] [stdout] 16 | | } [INFO] [stdout] | |_^ the entire enum is at least 384 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 15 - Browser(BrowserState), [INFO] [stdout] 15 + Browser(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | / match &mut self.mode { [INFO] [stdout] 79 | | AppMode::Browser(ref mut state) => { [INFO] [stdout] 80 | | if has_saved_session { [INFO] [stdout] 81 | | state.restore(&saved); [INFO] [stdout] ... | [INFO] [stdout] 86 | | _ => {} [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 78 ~ if let AppMode::Browser(ref mut state) = &mut self.mode { [INFO] [stdout] 79 + if has_saved_session { [INFO] [stdout] 80 + state.restore(&saved); [INFO] [stdout] 81 + } [INFO] [stdout] 82 + state.current_chapter = initial_chapter.clone(); [INFO] [stdout] 83 + state.localized_books = localized_books.clone(); [INFO] [stdout] 84 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/data/books.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / for book in BOOKS { [INFO] [stdout] 103 | | if book.name.to_lowercase().starts_with(&input) && input.len() >= 3 { [INFO] [stdout] 104 | | return Some(book); [INFO] [stdout] ... | [INFO] [stdout] 108 | | None [INFO] [stdout] | |________^ help: replace with an iterator: `BOOKS.iter().find(|&book| book.name.to_lowercase().starts_with(&input) && input.len() >= 3).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/api/bolls.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 221 | if id >= 1 && id <= 66 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `(1..=66).contains(&id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data/reference.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] 111 + if !(i >= len || chars[i - 1] != ' ' || !chars[i].is_ascii_digit()) { [INFO] [stdout] | [INFO] [stdout] 111 - if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] 111 + if i < len && chars[i - 1] == ' ' && chars[i].is_ascii_digit() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data/reference.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] 111 + if !(i >= len || chars[i - 1] != ' ') && chars[i].is_ascii_digit() { [INFO] [stdout] | [INFO] [stdout] 111 - if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] 111 + if i < len && chars[i - 1] == ' ' && chars[i].is_ascii_digit() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/app.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / enum AppMode { [INFO] [stdout] 14 | | Banner(BannerState), [INFO] [stdout] | | ------------------- the second-largest variant contains at least 8 bytes [INFO] [stdout] 15 | | Browser(BrowserState), [INFO] [stdout] | | --------------------- the largest variant contains at least 384 bytes [INFO] [stdout] 16 | | } [INFO] [stdout] | |_^ the entire enum is at least 384 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 15 - Browser(BrowserState), [INFO] [stdout] 15 + Browser(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | / match &mut self.mode { [INFO] [stdout] 79 | | AppMode::Browser(ref mut state) => { [INFO] [stdout] 80 | | if has_saved_session { [INFO] [stdout] 81 | | state.restore(&saved); [INFO] [stdout] ... | [INFO] [stdout] 86 | | _ => {} [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 78 ~ if let AppMode::Browser(ref mut state) = &mut self.mode { [INFO] [stdout] 79 + if has_saved_session { [INFO] [stdout] 80 + state.restore(&saved); [INFO] [stdout] 81 + } [INFO] [stdout] 82 + state.current_chapter = initial_chapter.clone(); [INFO] [stdout] 83 + state.localized_books = localized_books.clone(); [INFO] [stdout] 84 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/store/cache.rs:206:36 [INFO] [stdout] | [INFO] [stdout] 206 | ... if id >= 1 && id <= 66 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `(1..=66).contains(&id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ui/browser.rs:463:46 [INFO] [stdout] | [INFO] [stdout] 463 | let name = truncate_display_name(&state.book_display_name(i), max_name_width); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `state.book_display_name(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/data/books.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / for book in BOOKS { [INFO] [stdout] 103 | | if book.name.to_lowercase().starts_with(&input) && input.len() >= 3 { [INFO] [stdout] 104 | | return Some(book); [INFO] [stdout] ... | [INFO] [stdout] 108 | | None [INFO] [stdout] | |________^ help: replace with an iterator: `BOOKS.iter().find(|&book| book.name.to_lowercase().starts_with(&input) && input.len() >= 3).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/ui/browser.rs:847:22 [INFO] [stdout] | [INFO] [stdout] 847 | let pct = if total > 0 { [INFO] [stdout] | ^^^^^^^^^ check performed here [INFO] [stdout] 848 | (completed * 100) / total [INFO] [stdout] | ------------------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ui/theme.rs:49:1 [INFO] [stdout] | [INFO] [stdout] 49 | / impl Default for ThemeName { [INFO] [stdout] 50 | | fn default() -> Self { [INFO] [stdout] 51 | | ThemeName::Slate [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Default)] [INFO] [stdout] 20 | pub enum ThemeName { [INFO] [stdout] 21 ~ #[default] [INFO] [stdout] 22 ~ Slate, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data/reference.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] 111 + if !(i >= len || chars[i - 1] != ' ' || !chars[i].is_ascii_digit()) { [INFO] [stdout] | [INFO] [stdout] 111 - if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] 111 + if i < len && chars[i - 1] == ' ' && chars[i].is_ascii_digit() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data/reference.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] 111 + if !(i >= len || chars[i - 1] != ' ') && chars[i].is_ascii_digit() { [INFO] [stdout] | [INFO] [stdout] 111 - if i < len && chars[i - 1] == ' ' && i < len && chars[i].is_ascii_digit() { [INFO] [stdout] 111 + if i < len && chars[i - 1] == ' ' && chars[i].is_ascii_digit() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/store/cache.rs:206:36 [INFO] [stdout] | [INFO] [stdout] 206 | ... if id >= 1 && id <= 66 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `(1..=66).contains(&id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ui/browser.rs:819:20 [INFO] [stdout] | [INFO] [stdout] 819 | let keybinds = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 820 | | ("\u{2190}\u{2192}/hl", "panels"), [INFO] [stdout] 821 | | ("\u{2191}\u{2193}/jk", "navigate"), [INFO] [stdout] 822 | | ("Enter", "select"), [INFO] [stdout] ... | [INFO] [stdout] 826 | | ("qq", "quit"), [INFO] [stdout] 827 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 819 ~ let keybinds = [("\u{2190}\u{2192}/hl", "panels"), [INFO] [stdout] 820 + ("\u{2191}\u{2193}/jk", "navigate"), [INFO] [stdout] 821 + ("Enter", "select"), [INFO] [stdout] 822 + ("/", "search"), [INFO] [stdout] 823 + ("t", theme_name.label()), [INFO] [stdout] 824 + ("v", translation), [INFO] [stdout] 825 ~ ("qq", "quit")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ui/browser.rs:463:46 [INFO] [stdout] | [INFO] [stdout] 463 | let name = truncate_display_name(&state.book_display_name(i), max_name_width); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `state.book_display_name(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/ui/browser.rs:847:22 [INFO] [stdout] | [INFO] [stdout] 847 | let pct = if total > 0 { [INFO] [stdout] | ^^^^^^^^^ check performed here [INFO] [stdout] 848 | (completed * 100) / total [INFO] [stdout] | ------------------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ui/theme.rs:49:1 [INFO] [stdout] | [INFO] [stdout] 49 | / impl Default for ThemeName { [INFO] [stdout] 50 | | fn default() -> Self { [INFO] [stdout] 51 | | ThemeName::Slate [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Default)] [INFO] [stdout] 20 | pub enum ThemeName { [INFO] [stdout] 21 ~ #[default] [INFO] [stdout] 22 ~ Slate, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ui/browser.rs:819:20 [INFO] [stdout] | [INFO] [stdout] 819 | let keybinds = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 820 | | ("\u{2190}\u{2192}/hl", "panels"), [INFO] [stdout] 821 | | ("\u{2191}\u{2193}/jk", "navigate"), [INFO] [stdout] 822 | | ("Enter", "select"), [INFO] [stdout] ... | [INFO] [stdout] 826 | | ("qq", "quit"), [INFO] [stdout] 827 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 819 ~ let keybinds = [("\u{2190}\u{2192}/hl", "panels"), [INFO] [stdout] 820 + ("\u{2191}\u{2193}/jk", "navigate"), [INFO] [stdout] 821 + ("Enter", "select"), [INFO] [stdout] 822 + ("/", "search"), [INFO] [stdout] 823 + ("t", theme_name.label()), [INFO] [stdout] 824 + ("v", translation), [INFO] [stdout] 825 ~ ("qq", "quit")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.84s [INFO] running `Command { std: "docker" "inspect" "134b145cf03e2afdb9fe4283cf438ad628d57acb90be9690ed9adef5fd959098", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "134b145cf03e2afdb9fe4283cf438ad628d57acb90be9690ed9adef5fd959098", kill_on_drop: false }` [INFO] [stdout] 134b145cf03e2afdb9fe4283cf438ad628d57acb90be9690ed9adef5fd959098