[INFO] cloning repository https://github.com/watsthis/ripgrep [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/watsthis/ripgrep" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwatsthis%2Fripgrep", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwatsthis%2Fripgrep'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7461cbc761f5fad06b57a532986de5ae00308a81 [INFO] linting watsthis/ripgrep against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwatsthis%2Fripgrep" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/watsthis/ripgrep [INFO] removed 0 missing tests [INFO] finished tweaking git repo https://github.com/watsthis/ripgrep [INFO] tweaked toml for git repo https://github.com/watsthis/ripgrep written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/watsthis/ripgrep on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/watsthis/ripgrep already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tikv-jemallocator v0.6.1 [INFO] [stderr] Downloaded unicode-ident v1.0.20 [INFO] [stderr] Downloaded derive_arbitrary v1.4.2 [INFO] [stderr] Downloaded lexopt v0.3.1 [INFO] [stderr] Downloaded arbitrary v1.4.2 [INFO] [stderr] Downloaded pcre2 v0.2.11 [INFO] [stderr] Downloaded encoding_rs_io v0.1.7 [INFO] [stderr] Downloaded cc v1.2.41 [INFO] [stderr] Downloaded bstr v1.12.0 [INFO] [stderr] Downloaded syn v2.0.107 [INFO] [stderr] Downloaded pcre2-sys v0.2.10 [INFO] [stderr] Downloaded tikv-jemalloc-sys v0.6.1+5.3.0-1-ge13ca993e8ccb9ba9847cc330696e02839f328f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91e9f8bdd10cc3251b8d45b9d63c27f630cd517a20f24c7ad161f48c47df7622 [INFO] running `Command { std: "docker" "start" "-a" "91e9f8bdd10cc3251b8d45b9d63c27f630cd517a20f24c7ad161f48c47df7622", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91e9f8bdd10cc3251b8d45b9d63c27f630cd517a20f24c7ad161f48c47df7622", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91e9f8bdd10cc3251b8d45b9d63c27f630cd517a20f24c7ad161f48c47df7622", kill_on_drop: false }` [INFO] [stdout] 91e9f8bdd10cc3251b8d45b9d63c27f630cd517a20f24c7ad161f48c47df7622 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a945c36f18590f4155048d27983cb2b5a0994ac10416417ffcebad427091c91 [INFO] running `Command { std: "docker" "start" "-a" "8a945c36f18590f4155048d27983cb2b5a0994ac10416417ffcebad427091c91", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking grep-matcher v0.1.8 (/opt/rustwide/workdir/crates/matcher) [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.4 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Compiling unicode-ident v1.0.20 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/matcher/src/lib.rs:253:40 [INFO] [stdout] | [INFO] [stdout] 253 | LineTerminatorImp::CRLF => &[b'\r', b'\n'], [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `b"\r\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling ripgrep v15.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking lexopt v0.3.1 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/matcher/src/interpolate.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if replacement.get(1).map_or(false, |&b| b == b'$') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 31 - if replacement.get(1).map_or(false, |&b| b == b'$') { [INFO] [stdout] 31 + if replacement.get(1).is_some_and(|&b| b == b'$') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/matcher/src/interpolate.rs:109:11 [INFO] [stdout] | [INFO] [stdout] 109 | while replacement.get(cap_end).map_or(false, is_valid_cap_letter) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 109 - while replacement.get(cap_end).map_or(false, is_valid_cap_letter) { [INFO] [stdout] 109 + while replacement.get(cap_end).is_some_and(is_valid_cap_letter) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/matcher/src/interpolate.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | if !replacement.get(cap_end).map_or(false, |&b| b == b'}') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 122 - if !replacement.get(cap_end).map_or(false, |&b| b == b'}') { [INFO] [stdout] 122 + if !replacement.get(cap_end).is_some_and(|&b| b == b'}') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/matcher/src/interpolate.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | / match *b { [INFO] [stdout] 140 | | b'0'..=b'9' | b'a'..=b'z' | b'A'..=b'Z' | b'_' => true, [INFO] [stdout] 141 | | _ => false, [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 139 - match *b { [INFO] [stdout] 140 - b'0'..=b'9' | b'a'..=b'z' | b'A'..=b'Z' | b'_' => true, [INFO] [stdout] 141 - _ => false, [INFO] [stdout] 142 - } [INFO] [stdout] 139 + matches!(*b, b'0'..=b'9' | b'a'..=b'z' | b'A'..=b'Z' | b'_') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CRLF` contains a capitalized acronym [INFO] [stdout] --> crates/matcher/src/lib.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | CRLF, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Crlf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/matcher/src/lib.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | slice.last().map_or(false, |&b| b == self.as_byte()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 264 - slice.last().map_or(false, |&b| b == self.as_byte()) [INFO] [stdout] 264 + slice.last().is_some_and(|&b| b == self.as_byte()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NoCaptures` [INFO] [stdout] --> crates/matcher/src/lib.rs:473:5 [INFO] [stdout] | [INFO] [stdout] 473 | / pub fn new() -> NoCaptures { [INFO] [stdout] 474 | | NoCaptures(()) [INFO] [stdout] 475 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 470 + impl Default for NoCaptures { [INFO] [stdout] 471 + fn default() -> Self { [INFO] [stdout] 472 + Self::new() [INFO] [stdout] 473 + } [INFO] [stdout] 474 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/matcher/src/lib.rs:1133:6 [INFO] [stdout] | [INFO] [stdout] 1133 | impl<'a, M: Matcher> Matcher for &'a M { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1133 - impl<'a, M: Matcher> Matcher for &'a M { [INFO] [stdout] 1133 + impl Matcher for &M { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Compiling syn v2.0.107 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Compiling cc v1.2.41 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling pcre2-sys v0.2.10 [INFO] [stderr] Checking pcre2 v0.2.11 [INFO] [stderr] Checking grep-pcre2 v0.1.9 (/opt/rustwide/workdir/crates/pcre2) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RegexMatcherBuilder` [INFO] [stdout] --> crates/pcre2/src/matcher.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> RegexMatcherBuilder { [INFO] [stdout] 23 | | RegexMatcherBuilder { [INFO] [stdout] 24 | | builder: RegexBuilder::new(), [INFO] [stdout] 25 | | case_smart: false, [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for RegexMatcherBuilder { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> crates/pcre2/src/matcher.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | self.names.get(name).map(|i| *i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.names.get(name).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RegexMatcherBuilder` [INFO] [stdout] --> crates/pcre2/src/matcher.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> RegexMatcherBuilder { [INFO] [stdout] 23 | | RegexMatcherBuilder { [INFO] [stdout] 24 | | builder: RegexBuilder::new(), [INFO] [stdout] 25 | | case_smart: false, [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for RegexMatcherBuilder { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> crates/pcre2/src/matcher.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | self.names.get(name).map(|i| *i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.names.get(name).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/pcre2/src/matcher.rs:495:13 [INFO] [stdout] | [INFO] [stdout] 495 | / match m { [INFO] [stdout] 496 | | LineMatchKind::Confirmed(_) => true, [INFO] [stdout] 497 | | _ => false, [INFO] [stdout] 498 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 495 - match m { [INFO] [stdout] 496 - LineMatchKind::Confirmed(_) => true, [INFO] [stdout] 497 - _ => false, [INFO] [stdout] 498 - } [INFO] [stdout] 495 + matches!(m, LineMatchKind::Confirmed(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/matcher/src/lib.rs:253:40 [INFO] [stdout] | [INFO] [stdout] 253 | LineTerminatorImp::CRLF => &[b'\r', b'\n'], [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `b"\r\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> crates/matcher/tests/util.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | self.names.get(name).map(|i| *i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.names.get(name).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/matcher/src/interpolate.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if replacement.get(1).map_or(false, |&b| b == b'$') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 31 - if replacement.get(1).map_or(false, |&b| b == b'$') { [INFO] [stdout] 31 + if replacement.get(1).is_some_and(|&b| b == b'$') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/matcher/src/interpolate.rs:109:11 [INFO] [stdout] | [INFO] [stdout] 109 | while replacement.get(cap_end).map_or(false, is_valid_cap_letter) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 109 - while replacement.get(cap_end).map_or(false, is_valid_cap_letter) { [INFO] [stdout] 109 + while replacement.get(cap_end).is_some_and(is_valid_cap_letter) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/matcher/src/interpolate.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | if !replacement.get(cap_end).map_or(false, |&b| b == b'}') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 122 - if !replacement.get(cap_end).map_or(false, |&b| b == b'}') { [INFO] [stdout] 122 + if !replacement.get(cap_end).is_some_and(|&b| b == b'}') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/matcher/src/interpolate.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | / match *b { [INFO] [stdout] 140 | | b'0'..=b'9' | b'a'..=b'z' | b'A'..=b'Z' | b'_' => true, [INFO] [stdout] 141 | | _ => false, [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 139 - match *b { [INFO] [stdout] 140 - b'0'..=b'9' | b'a'..=b'z' | b'A'..=b'Z' | b'_' => true, [INFO] [stdout] 141 - _ => false, [INFO] [stdout] 142 - } [INFO] [stdout] 139 + matches!(*b, b'0'..=b'9' | b'a'..=b'z' | b'A'..=b'Z' | b'_') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CRLF` contains a capitalized acronym [INFO] [stdout] --> crates/matcher/src/lib.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | CRLF, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Crlf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/matcher/src/lib.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | slice.last().map_or(false, |&b| b == self.as_byte()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 264 - slice.last().map_or(false, |&b| b == self.as_byte()) [INFO] [stdout] 264 + slice.last().is_some_and(|&b| b == self.as_byte()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NoCaptures` [INFO] [stdout] --> crates/matcher/src/lib.rs:473:5 [INFO] [stdout] | [INFO] [stdout] 473 | / pub fn new() -> NoCaptures { [INFO] [stdout] 474 | | NoCaptures(()) [INFO] [stdout] 475 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 470 + impl Default for NoCaptures { [INFO] [stdout] 471 + fn default() -> Self { [INFO] [stdout] 472 + Self::new() [INFO] [stdout] 473 + } [INFO] [stdout] 474 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/matcher/src/lib.rs:1133:6 [INFO] [stdout] | [INFO] [stdout] 1133 | impl<'a, M: Matcher> Matcher for &'a M { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1133 - impl<'a, M: Matcher> Matcher for &'a M { [INFO] [stdout] 1133 + impl Matcher for &M { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking globset v0.4.18 (/opt/rustwide/workdir/crates/globset) [INFO] [stderr] Checking grep-regex v0.1.14 (/opt/rustwide/workdir/crates/regex) [INFO] [stderr] Checking grep-searcher v0.1.16 (/opt/rustwide/workdir/crates/searcher) [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/regex/src/non_matching.rs:142:57 [INFO] [stdout] | [INFO] [stdout] 142 | assert_eq!(sparse(&extract("a")), sparse_except(&[b'a'])); [INFO] [stdout] | ^^^^^^^ help: try: `b"a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/regex/src/non_matching.rs:152:58 [INFO] [stdout] | [INFO] [stdout] 152 | assert_eq!(sparse(&extract(r"^")), sparse_except(&[b'\n'])); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/regex/src/non_matching.rs:153:58 [INFO] [stdout] | [INFO] [stdout] 153 | assert_eq!(sparse(&extract(r"$")), sparse_except(&[b'\n'])); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/regex/src/non_matching.rs:154:59 [INFO] [stdout] | [INFO] [stdout] 154 | assert_eq!(sparse(&extract(r"\A")), sparse_except(&[b'\n'])); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/regex/src/non_matching.rs:155:59 [INFO] [stdout] | [INFO] [stdout] 155 | assert_eq!(sparse(&extract(r"\z")), sparse_except(&[b'\n'])); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/regex/src/non_matching.rs:156:62 [INFO] [stdout] | [INFO] [stdout] 156 | assert_eq!(sparse(&extract(r"(?m)^")), sparse_except(&[b'\n'])); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> crates/regex/src/non_matching.rs:157:62 [INFO] [stdout] | [INFO] [stdout] 157 | assert_eq!(sparse(&extract(r"(?m)$")), sparse_except(&[b'\n'])); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> crates/globset/src/fnv.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | self.0 = self.0 ^ u64::from(byte); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.0 ^= u64::from(byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.tokens.get(0)` [INFO] [stdout] --> crates/globset/src/glob.rs:357:28 [INFO] [stdout] | [INFO] [stdout] 357 | let start = match *self.tokens.get(0)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.tokens.get(0)` [INFO] [stdout] --> crates/globset/src/glob.rs:467:38 [INFO] [stdout] | [INFO] [stdout] 467 | let (start, entire) = match *self.tokens.get(0)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> crates/regex/src/ast.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 56 | fn from_ast_impl(&mut self, ast: &Ast) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.tokens.get(0)` [INFO] [stdout] --> crates/globset/src/glob.rs:514:28 [INFO] [stdout] | [INFO] [stdout] 514 | let start = match *self.tokens.get(0)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:581:19 [INFO] [stdout] | [INFO] [stdout] 581 | glob: &self.glob, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:687:39 [INFO] [stdout] | [INFO] [stdout] 687 | self.tokens_to_regex(options, &self, &mut re); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/globset/src/glob.rs:707:25 [INFO] [stdout] | [INFO] [stdout] 707 | re.push_str("."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `re.push('.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> crates/regex/src/ast.rs:92:27 [INFO] [stdout] | [INFO] [stdout] 92 | fn from_ast_class_set(&mut self, ast: &ast::ClassSet) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> crates/regex/src/ast.rs:107:32 [INFO] [stdout] | [INFO] [stdout] 107 | fn from_ast_class_set_item(&mut self, ast: &ast::ClassSetItem) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:747:55 [INFO] [stdout] | [INFO] [stdout] 747 | self.tokens_to_regex(options, &pat, &mut altre); [INFO] [stdout] | ^^^^ help: change this to: `pat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> crates/globset/src/glob.rs:857:20 [INFO] [stdout] | [INFO] [stdout] 857 | return Ok(pat.push(tok)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 857 ~ return { [INFO] [stdout] 858 + let _: () = pat.push(tok); [INFO] [stdout] 859 + Ok(()) [INFO] [stdout] 860 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/globset/src/glob.rs:872:18 [INFO] [stdout] | [INFO] [stdout] 872 | Some(ref pat) => Ok(!pat.is_empty()), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 872 - Some(ref pat) => Ok(!pat.is_empty()), [INFO] [stdout] 872 + Some(pat) => Ok(!pat.is_empty()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> crates/globset/src/glob.rs:883:13 [INFO] [stdout] | [INFO] [stdout] 883 | Ok(self.branches.push(Tokens::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 883 ~ self.branches.push(Tokens::default()); [INFO] [stdout] 884 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/globset/src/glob.rs:909:17 [INFO] [stdout] | [INFO] [stdout] 909 | if !self.peek().map_or(true, is_separator) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 909 - if !self.peek().map_or(true, is_separator) { [INFO] [stdout] 909 + if !self.peek().is_none_or(is_separator) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/globset/src/glob.rs:914:25 [INFO] [stdout] | [INFO] [stdout] 914 | assert!(self.bump().map_or(true, is_separator)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 914 - assert!(self.bump().map_or(true, is_separator)); [INFO] [stdout] 914 + assert!(self.bump().is_none_or(is_separator)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> crates/regex/src/ast.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 134 | fn from_ast_literal(&mut self, ast: &ast::Literal) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/globset/src/glob.rs:919:9 [INFO] [stdout] | [INFO] [stdout] 919 | / if !prev.map(is_separator).unwrap_or(false) { [INFO] [stdout] 920 | | if self.branches.len() <= 1 [INFO] [stdout] 921 | | || (prev != Some(',') && prev != Some('{')) [INFO] [stdout] ... | [INFO] [stdout] 927 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 919 ~ if !prev.map(is_separator).unwrap_or(false) [INFO] [stdout] 920 ~ && (self.branches.len() <= 1 [INFO] [stdout] 921 ~ || (prev != Some(',') && prev != Some('{'))) [INFO] [stdout] 922 | { [INFO] [stdout] ... [INFO] [stdout] 925 | return Ok(()); [INFO] [stdout] 926 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> crates/globset/src/glob.rs:996:27 [INFO] [stdout] | [INFO] [stdout] 996 | return if self.opts.allow_unclosed_class == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.opts.allow_unclosed_class` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:1022:43 [INFO] [stdout] | [INFO] [stdout] 1022 | add_to_last_range(&self.glob, r, '-')?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:1034:29 [INFO] [stdout] | [INFO] [stdout] 1034 | ... &self.glob, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> crates/globset/src/glob.rs:1061:9 [INFO] [stdout] | [INFO] [stdout] 1061 | self.chars.peek().map(|&ch| ch) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.chars.peek().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/regex/src/config.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | / if let Some(lineterm) = self.line_terminator { [INFO] [stdout] 137 | | if has_line_terminator(lineterm, p) { [INFO] [stdout] 138 | | return false; [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 136 ~ if let Some(lineterm) = self.line_terminator [INFO] [stdout] 137 ~ && has_line_terminator(lineterm, p) { [INFO] [stdout] 138 | return false; [INFO] [stdout] 139 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> crates/globset/src/pathutil.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 50 | let last_dot_at = match name.rfind_byte(b'.') { [INFO] [stdout] | _______________________^ [INFO] [stdout] 51 | | None => return None, [INFO] [stdout] 52 | | Some(i) => i, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ help: try instead: `name.rfind_byte(b'.')?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| &**s)` on an `Option` value [INFO] [stdout] --> crates/globset/src/lib.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | self.glob.as_ref().map(|s| &**s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.glob.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> crates/regex/src/config.rs:180:13 [INFO] [stdout] | [INFO] [stdout] 179 | let hir = Hir::alternation(alts); [INFO] [stdout] | --------------------------------- unnecessary `let` binding [INFO] [stdout] 180 | hir [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 179 ~ [INFO] [stdout] 180 ~ Hir::alternation(alts) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> crates/regex/src/config.rs:253:34 [INFO] [stdout] | [INFO] [stdout] 253 | .dfa_size_limit(Some(1 * (1 << 20))) [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `((1 << 20))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/regex/src/literal.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / if re.is_accelerated() { [INFO] [stdout] 73 | | if !chir.hir().properties().look_set().contains_word_unicode() { [INFO] [stdout] 74 | | log::trace!( [INFO] [stdout] 75 | | "skipping inner literal extraction, \ [INFO] [stdout] ... | [INFO] [stdout] 80 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if re.is_accelerated() [INFO] [stdout] 73 ~ && !chir.hir().properties().look_set().contains_word_unicode() { [INFO] [stdout] 74 | log::trace!( [INFO] [stdout] ... [INFO] [stdout] 78 | return InnerLiterals::none(); [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GlobSetBuilder` [INFO] [stdout] --> crates/globset/src/lib.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 574 | / pub fn new() -> GlobSetBuilder { [INFO] [stdout] 575 | | GlobSetBuilder { pats: vec![] } [INFO] [stdout] 576 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 570 + impl Default for GlobSetBuilder { [INFO] [stdout] 571 + fn default() -> Self { [INFO] [stdout] 572 + Self::new() [INFO] [stdout] 573 + } [INFO] [stdout] 574 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/globset/src/lib.rs:641:37 [INFO] [stdout] | [INFO] [stdout] 641 | if self.path.len() <= max { &*self.path } else { &self.path[..max] } [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/globset/src/lib.rs:646:13 [INFO] [stdout] | [INFO] [stdout] 646 | &*self.path [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> crates/globset/src/lib.rs:867:21 [INFO] [stdout] | [INFO] [stdout] 867 | for &(_, ref re) in regexes { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 867 - for &(_, ref re) in regexes { [INFO] [stdout] 867 + for (_, re) in regexes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:383:12 [INFO] [stdout] | [INFO] [stdout] 383 | if seq1 [INFO] [stdout] | ____________^ [INFO] [stdout] 384 | | .max_cross_len(&seq2) [INFO] [stdout] 385 | | .map_or(false, |len| len > self.limit_total) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 385 - .map_or(false, |len| len > self.limit_total) [INFO] [stdout] 385 + .is_some_and(|len| len > self.limit_total) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:390:17 [INFO] [stdout] | [INFO] [stdout] 390 | assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 390 - assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); [INFO] [stdout] 390 + assert!(seq1.len().is_none_or(|x| x <= self.limit_total)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 399 | if seq1.max_union_len(seq2).map_or(false, |len| len > self.limit_total) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 399 - if seq1.max_union_len(seq2).map_or(false, |len| len > self.limit_total) [INFO] [stdout] 399 + if seq1.max_union_len(seq2).is_some_and(|len| len > self.limit_total) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:419:16 [INFO] [stdout] | [INFO] [stdout] 419 | if seq1 [INFO] [stdout] | ________________^ [INFO] [stdout] 420 | | .max_union_len(seq2) [INFO] [stdout] 421 | | .map_or(false, |len| len > self.limit_total) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 421 - .map_or(false, |len| len > self.limit_total) [INFO] [stdout] 421 + .is_some_and(|len| len > self.limit_total) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:427:17 [INFO] [stdout] | [INFO] [stdout] 427 | assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 427 - assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); [INFO] [stdout] 427 + assert!(seq1.len().is_none_or(|x| x <= self.limit_total)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ignore v0.4.25 (/opt/rustwide/workdir/crates/ignore) [INFO] [stderr] Checking grep-cli v0.1.12 (/opt/rustwide/workdir/crates/cli) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | const EXT: &'static str = "some/a/bigger/path/to/the/crazy/needle.txt"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | const EXT_PAT: &'static str = "*.txt"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | const SHORT: &'static str = "some/needle.txt"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:15:19 [INFO] [stdout] | [INFO] [stdout] 15 | const SHORT_PAT: &'static str = "some/**/needle.txt"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 17 | const LONG: &'static str = "some/a/bigger/path/to/the/crazy/needle.txt"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | const LONG_PAT: &'static str = "some/**/needle.txt"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | const MANY_SHORT_GLOBS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:75:36 [INFO] [stdout] | [INFO] [stdout] 75 | const MANY_SHORT_GLOBS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/globset/benches/bench.rs:93:27 [INFO] [stdout] | [INFO] [stdout] 93 | const MANY_SHORT_SEARCH: &'static str = "98m-blah.csv.idx"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> crates/regex/src/ast.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 56 | fn from_ast_impl(&mut self, ast: &Ast) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> crates/regex/src/ast.rs:92:27 [INFO] [stdout] | [INFO] [stdout] 92 | fn from_ast_class_set(&mut self, ast: &ast::ClassSet) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> crates/regex/src/ast.rs:107:32 [INFO] [stdout] | [INFO] [stdout] 107 | fn from_ast_class_set_item(&mut self, ast: &ast::ClassSetItem) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> crates/regex/src/ast.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 134 | fn from_ast_literal(&mut self, ast: &ast::Literal) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().count()` on a `Vec` [INFO] [stdout] --> crates/globset/benches/bench.rs:112:29 [INFO] [stdout] | [INFO] [stdout] 112 | b.iter(|| assert_eq!(2, set.matches(MANY_SHORT_SEARCH).iter().count())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `set.matches(MANY_SHORT_SEARCH).len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_count [INFO] [stdout] = note: `#[warn(clippy::iter_count)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/regex/src/config.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | / if let Some(lineterm) = self.line_terminator { [INFO] [stdout] 137 | | if has_line_terminator(lineterm, p) { [INFO] [stdout] 138 | | return false; [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 136 ~ if let Some(lineterm) = self.line_terminator [INFO] [stdout] 137 ~ && has_line_terminator(lineterm, p) { [INFO] [stdout] 138 | return false; [INFO] [stdout] 139 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> crates/regex/src/config.rs:180:13 [INFO] [stdout] | [INFO] [stdout] 179 | let hir = Hir::alternation(alts); [INFO] [stdout] | --------------------------------- unnecessary `let` binding [INFO] [stdout] 180 | hir [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 179 ~ [INFO] [stdout] 180 ~ Hir::alternation(alts) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> crates/regex/src/config.rs:253:34 [INFO] [stdout] | [INFO] [stdout] 253 | .dfa_size_limit(Some(1 * (1 << 20))) [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `((1 << 20))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | / impl Default for BufferAllocation { [INFO] [stdout] 30 | | fn default() -> BufferAllocation { [INFO] [stdout] 31 | | BufferAllocation::Eager [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Default)] [INFO] [stdout] 18 | pub(crate) enum BufferAllocation { [INFO] [stdout] 19 | /// Attempt to expand the size of the buffer until either at least the next [INFO] [stdout] ... [INFO] [stdout] 22 | /// This is the default. [INFO] [stdout] 23 ~ #[default] [INFO] [stdout] 24 ~ Eager, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | io::Error::new(io::ErrorKind::Other, msg) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 39 - io::Error::new(io::ErrorKind::Other, msg) [INFO] [stdout] 39 + io::Error::other(msg) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:66:1 [INFO] [stdout] | [INFO] [stdout] 66 | / impl Default for BinaryDetection { [INFO] [stdout] 67 | | fn default() -> BinaryDetection { [INFO] [stdout] 68 | | BinaryDetection::None [INFO] [stdout] 69 | | } [INFO] [stdout] 70 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 51 + #[derive(Default)] [INFO] [stdout] 52 | pub(crate) enum BinaryDetection { [INFO] [stdout] 53 | /// No binary detection is performed. Data reported by the line buffer may [INFO] [stdout] 54 | /// contain arbitrary bytes. [INFO] [stdout] 55 ~ #[default] [INFO] [stdout] 56 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / match *self { [INFO] [stdout] 77 | | BinaryDetection::Quit(_) => true, [INFO] [stdout] 78 | | _ => false, [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 76 - match *self { [INFO] [stdout] 77 - BinaryDetection::Quit(_) => true, [INFO] [stdout] 78 - _ => false, [INFO] [stdout] 79 - } [INFO] [stdout] 76 + matches!(*self, BinaryDetection::Quit(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/regex/src/literal.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / if re.is_accelerated() { [INFO] [stdout] 73 | | if !chir.hir().properties().look_set().contains_word_unicode() { [INFO] [stdout] 74 | | log::trace!( [INFO] [stdout] 75 | | "skipping inner literal extraction, \ [INFO] [stdout] ... | [INFO] [stdout] 80 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if re.is_accelerated() [INFO] [stdout] 73 ~ && !chir.hir().properties().look_set().contains_word_unicode() { [INFO] [stdout] 74 | log::trace!( [INFO] [stdout] ... [INFO] [stdout] 78 | return InnerLiterals::none(); [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:383:12 [INFO] [stdout] | [INFO] [stdout] 383 | if seq1 [INFO] [stdout] | ____________^ [INFO] [stdout] 384 | | .max_cross_len(&seq2) [INFO] [stdout] 385 | | .map_or(false, |len| len > self.limit_total) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 385 - .map_or(false, |len| len > self.limit_total) [INFO] [stdout] 385 + .is_some_and(|len| len > self.limit_total) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:390:17 [INFO] [stdout] | [INFO] [stdout] 390 | assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 390 - assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); [INFO] [stdout] 390 + assert!(seq1.len().is_none_or(|x| x <= self.limit_total)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 399 | if seq1.max_union_len(seq2).map_or(false, |len| len > self.limit_total) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 399 - if seq1.max_union_len(seq2).map_or(false, |len| len > self.limit_total) [INFO] [stdout] 399 + if seq1.max_union_len(seq2).is_some_and(|len| len > self.limit_total) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:419:16 [INFO] [stdout] | [INFO] [stdout] 419 | if seq1 [INFO] [stdout] | ________________^ [INFO] [stdout] 420 | | .max_union_len(seq2) [INFO] [stdout] 421 | | .map_or(false, |len| len > self.limit_total) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 421 - .map_or(false, |len| len > self.limit_total) [INFO] [stdout] 421 + .is_some_and(|len| len > self.limit_total) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/regex/src/literal.rs:427:17 [INFO] [stdout] | [INFO] [stdout] 427 | assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 427 - assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); [INFO] [stdout] 427 + assert!(seq1.len().is_none_or(|x| x <= self.limit_total)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> crates/ignore/src/types.rs:483:22 [INFO] [stdout] | [INFO] [stdout] 483 | static MSG: &'static str = "adding a default type should never fail"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `bytes.get(0)` [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:546:15 [INFO] [stdout] | [INFO] [stdout] 546 | while bytes.get(0) == Some(&src) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/decompress.rs:60:34 [INFO] [stdout] | [INFO] [stdout] 60 | CommandError::io(io::Error::new(io::ErrorKind::Other, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 60 - CommandError::io(io::Error::new(io::ErrorKind::Other, err)) [INFO] [stdout] 60 + CommandError::io(io::Error::other(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/decompress.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | CommandError::io(io::Error::new(io::ErrorKind::Other, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 66 - CommandError::io(io::Error::new(io::ErrorKind::Other, err)) [INFO] [stdout] 66 + CommandError::io(io::Error::other(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/cli/src/decompress.rs:487:5 [INFO] [stdout] | [INFO] [stdout] 487 | return Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 487 - return Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))); [INFO] [stdout] 487 + Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/decompress.rs:464:37 [INFO] [stdout] | [INFO] [stdout] 464 | return Err(CommandError::io(io::Error::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 465 | | io::ErrorKind::Other, [INFO] [stdout] 466 | | msg, [INFO] [stdout] 467 | | ))); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 464 ~ return Err(CommandError::io(io::Error::other( [INFO] [stdout] 465 ~ msg, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/decompress.rs:487:33 [INFO] [stdout] | [INFO] [stdout] 487 | return Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 487 - return Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))); [INFO] [stdout] 487 + return Err(CommandError::io(io::Error::other(msg))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/hostname.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | return Err(io::Error::new(io::ErrorKind::Other, msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 52 - return Err(io::Error::new(io::ErrorKind::Other, msg)); [INFO] [stdout] 52 + return Err(io::Error::other(msg)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/hostname.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | return Err(io::Error::new(io::ErrorKind::Other, msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 70 - return Err(io::Error::new(io::ErrorKind::Other, msg)); [INFO] [stdout] 70 + return Err(io::Error::other(msg)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/human.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | std::io::Error::new(std::io::ErrorKind::Other, size_err) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 67 - std::io::Error::new(std::io::ErrorKind::Other, size_err) [INFO] [stdout] 67 + std::io::Error::other(size_err) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:111:31 [INFO] [stdout] | [INFO] [stdout] 111 | self.sink.binary_data(&self.searcher, binary_byte_offset) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | Err(err) => return Err(S::Error::error_message(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 149 - Err(err) => return Err(S::Error::error_message(err)), [INFO] [stdout] 149 + Err(err) => Err(S::Error::error_message(err)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | Ok(None) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - Ok(None) => return Ok(None), [INFO] [stdout] 150 + Ok(None) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:156:25 [INFO] [stdout] | [INFO] [stdout] 156 | self.sink.begin(&self.searcher) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 165 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 203 | / let consumed = [INFO] [stdout] 204 | | std::cmp::max(context_start, self.last_line_visited); [INFO] [stdout] | |_____________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 205 | consumed [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 203 ~ [INFO] [stdout] 204 ~ std::cmp::max(context_start, self.last_line_visited) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | io::Error::new(io::ErrorKind::Other, paterr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 41 - io::Error::new(io::ErrorKind::Other, paterr) [INFO] [stdout] 41 + io::Error::other(paterr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / io::Error::new( [INFO] [stdout] 86 | | io::ErrorKind::Other, [INFO] [stdout] 87 | | format!("{}: {}", path.display(), err), [INFO] [stdout] 88 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 85 ~ io::Error::other( [INFO] [stdout] 86 ~ format!("{}: {}", path.display(), err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | / io::Error::new( [INFO] [stdout] 92 | | io::ErrorKind::Other, [INFO] [stdout] 93 | | format!("{}:{}", path.display(), err), [INFO] [stdout] 94 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 91 ~ io::Error::other( [INFO] [stdout] 92 ~ format!("{}:{}", path.display(), err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::Error::new(io::ErrorKind::Other, format!(":{}", err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 108 - io::Error::new(io::ErrorKind::Other, format!(":{}", err)) [INFO] [stdout] 108 + io::Error::other(format!(":{}", err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:151:29 [INFO] [stdout] | [INFO] [stdout] 151 | Err(err) => Err(io::Error::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 152 | | io::ErrorKind::Other, [INFO] [stdout] 153 | | format!("{}: {}", line_number, err), [INFO] [stdout] 154 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 151 ~ Err(err) => Err(io::Error::other( [INFO] [stdout] 152 ~ format!("{}: {}", line_number, err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/process.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | io::Error::new(io::ErrorKind::Other, cmderr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 76 - io::Error::new(io::ErrorKind::Other, cmderr) [INFO] [stdout] 76 + io::Error::other(cmderr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:373:20 [INFO] [stdout] | [INFO] [stdout] 373 | } else if self.config.passthru { [INFO] [stdout] | ____________________^ [INFO] [stdout] 374 | | if !self.sink_other_context(buf, &line)? { [INFO] [stdout] 375 | | return Ok(false); [INFO] [stdout] 376 | | } [INFO] [stdout] 377 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 373 ~ } else if self.config.passthru [INFO] [stdout] 374 ~ && !self.sink_other_context(buf, &line)? { [INFO] [stdout] 375 | return Ok(false); [INFO] [stdout] 376 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:537:13 [INFO] [stdout] | [INFO] [stdout] 537 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:567:13 [INFO] [stdout] | [INFO] [stdout] 567 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:598:13 [INFO] [stdout] | [INFO] [stdout] 598 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:628:13 [INFO] [stdout] | [INFO] [stdout] 628 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:657:37 [INFO] [stdout] | [INFO] [stdout] 657 | self.sink.context_break(&self.searcher) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:711:9 [INFO] [stdout] | [INFO] [stdout] 711 | self.config.max_matches.map_or(false, |limit| self.count() >= limit) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 711 - self.config.max_matches.map_or(false, |limit| self.count() >= limit) [INFO] [stdout] 711 + self.config.max_matches.is_some_and(|limit| self.count() >= limit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/searcher/src/searcher/glue.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / if !already_binary { [INFO] [stdout] 70 | | if let Some(offset) = self.rdr.binary_byte_offset() { [INFO] [stdout] 71 | | if !self.core.binary_data(offset)? { [INFO] [stdout] 72 | | return Ok(false); [INFO] [stdout] ... | [INFO] [stdout] 75 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ if !already_binary [INFO] [stdout] 70 ~ && let Some(offset) = self.rdr.binary_byte_offset() { [INFO] [stdout] 71 | if !self.core.binary_data(offset)? { [INFO] [stdout] 72 | return Ok(false); [INFO] [stdout] 73 | } [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/searcher/src/searcher/glue.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | / if let Some(offset) = self.rdr.binary_byte_offset() { [INFO] [stdout] 71 | | if !self.core.binary_data(offset)? { [INFO] [stdout] 72 | | return Ok(false); [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 70 ~ if let Some(offset) = self.rdr.binary_byte_offset() [INFO] [stdout] 71 ~ && !self.core.binary_data(offset)? { [INFO] [stdout] 72 | return Ok(false); [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:560:22 [INFO] [stdout] | [INFO] [stdout] 560 | const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/regex/src/matcher.rs:642:13 [INFO] [stdout] | [INFO] [stdout] 642 | / match m { [INFO] [stdout] 643 | | LineMatchKind::Confirmed(_) => true, [INFO] [stdout] 644 | | _ => false, [INFO] [stdout] 645 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 642 - match m { [INFO] [stdout] 643 - LineMatchKind::Confirmed(_) => true, [INFO] [stdout] 644 - _ => false, [INFO] [stdout] 645 - } [INFO] [stdout] 642 + matches!(m, LineMatchKind::Confirmed(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/regex/src/matcher.rs:648:13 [INFO] [stdout] | [INFO] [stdout] 648 | / match m { [INFO] [stdout] 649 | | LineMatchKind::Candidate(_) => true, [INFO] [stdout] 650 | | _ => false, [INFO] [stdout] 651 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 648 - match m { [INFO] [stdout] 649 - LineMatchKind::Candidate(_) => true, [INFO] [stdout] 650 - _ => false, [INFO] [stdout] 651 - } [INFO] [stdout] 648 + matches!(m, LineMatchKind::Candidate(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/searcher/src/lines.rs:203:22 [INFO] [stdout] | [INFO] [stdout] 203 | const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Searcher` [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:632:5 [INFO] [stdout] | [INFO] [stdout] 632 | / pub fn new() -> Searcher { [INFO] [stdout] 633 | | SearcherBuilder::new().build() [INFO] [stdout] 634 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 627 + impl Default for Searcher { [INFO] [stdout] 628 + fn default() -> Self { [INFO] [stdout] 629 + Self::new() [INFO] [stdout] 630 + } [INFO] [stdout] 631 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/ignore/src/gitignore.rs:708:18 [INFO] [stdout] | [INFO] [stdout] 708 | const ROOT: &'static str = "/home/foobar/rust/rg"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:706:17 [INFO] [stdout] | [INFO] [stdout] 706 | &*self.multi_line_buffer.borrow(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&self.multi_line_buffer.borrow()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/decompress.rs:60:34 [INFO] [stdout] | [INFO] [stdout] 60 | CommandError::io(io::Error::new(io::ErrorKind::Other, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 60 - CommandError::io(io::Error::new(io::ErrorKind::Other, err)) [INFO] [stdout] 60 + CommandError::io(io::Error::other(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/decompress.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | CommandError::io(io::Error::new(io::ErrorKind::Other, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 66 - CommandError::io(io::Error::new(io::ErrorKind::Other, err)) [INFO] [stdout] 66 + CommandError::io(io::Error::other(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:755:17 [INFO] [stdout] | [INFO] [stdout] 755 | &*self.multi_line_buffer.borrow(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&self.multi_line_buffer.borrow()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:761:54 [INFO] [stdout] | [INFO] [stdout] 761 | let rdr = LineBufferReader::new(decoder, &mut *line_buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut line_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/cli/src/decompress.rs:487:5 [INFO] [stdout] | [INFO] [stdout] 487 | return Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 487 - return Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))); [INFO] [stdout] 487 + Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/decompress.rs:464:37 [INFO] [stdout] | [INFO] [stdout] 464 | return Err(CommandError::io(io::Error::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 465 | | io::ErrorKind::Other, [INFO] [stdout] 466 | | msg, [INFO] [stdout] 467 | | ))); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 464 ~ return Err(CommandError::io(io::Error::other( [INFO] [stdout] 465 ~ msg, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/ignore/src/overrides.rs:190:18 [INFO] [stdout] | [INFO] [stdout] 190 | const ROOT: &'static str = "/home/andrew/foo"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/decompress.rs:487:33 [INFO] [stdout] | [INFO] [stdout] 487 | return Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 487 - return Err(CommandError::io(io::Error::new(io::ErrorKind::Other, msg))); [INFO] [stdout] 487 + return Err(CommandError::io(io::Error::other(msg))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/searcher/src/searcher/glue.rs:362:22 [INFO] [stdout] | [INFO] [stdout] 362 | const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:900:9 [INFO] [stdout] | [INFO] [stdout] 900 | / if let Some(line_term) = matcher.line_terminator() { [INFO] [stdout] 901 | | if line_term == self.line_terminator() { [INFO] [stdout] 902 | | return false; [INFO] [stdout] 903 | | } [INFO] [stdout] 904 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 900 ~ if let Some(line_term) = matcher.line_terminator() [INFO] [stdout] 901 ~ && line_term == self.line_terminator() { [INFO] [stdout] 902 | return false; [INFO] [stdout] 903 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> crates/ignore/src/types.rs:483:22 [INFO] [stdout] | [INFO] [stdout] 483 | static MSG: &'static str = "adding a default type should never fail"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/searcher/src/searcher/glue.rs:371:18 [INFO] [stdout] | [INFO] [stdout] 371 | const CODE: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:965:35 [INFO] [stdout] | [INFO] [stdout] 965 | read_from.read_to_end(&mut *buf).map_err(S::Error::error_io)?; [INFO] [stdout] | ^^^^^^^^^ help: try: `&mut buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:990:34 [INFO] [stdout] | [INFO] [stdout] 990 | .read_to_end(&mut *buf) [INFO] [stdout] | ^^^^^^^^^ help: try: `&mut buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/searcher/src/sink.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | io::Error::new(io::ErrorKind::Other, message.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 44 - io::Error::new(io::ErrorKind::Other, message.to_string()) [INFO] [stdout] 44 + io::Error::other(message.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/searcher/src/sink.rs:225:6 [INFO] [stdout] | [INFO] [stdout] 225 | impl<'a, S: Sink> Sink for &'a mut S { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 225 - impl<'a, S: Sink> Sink for &'a mut S { [INFO] [stdout] 225 + impl Sink for &mut S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/searcher/src/searcher/glue.rs:1499:26 [INFO] [stdout] | [INFO] [stdout] 1499 | const SHERLOCK: &'static [u8] = b"\ [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/hostname.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | return Err(io::Error::new(io::ErrorKind::Other, msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 52 - return Err(io::Error::new(io::ErrorKind::Other, msg)); [INFO] [stdout] 52 + return Err(io::Error::other(msg)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/hostname.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | return Err(io::Error::new(io::ErrorKind::Other, msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 70 - return Err(io::Error::new(io::ErrorKind::Other, msg)); [INFO] [stdout] 70 + return Err(io::Error::other(msg)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/human.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | std::io::Error::new(std::io::ErrorKind::Other, size_err) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 67 - std::io::Error::new(std::io::ErrorKind::Other, size_err) [INFO] [stdout] 67 + std::io::Error::other(size_err) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | io::Error::new(io::ErrorKind::Other, paterr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 41 - io::Error::new(io::ErrorKind::Other, paterr) [INFO] [stdout] 41 + io::Error::other(paterr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/sink.rs:566:35 [INFO] [stdout] | [INFO] [stdout] 566 | (self.0)(line_number, &matched) [INFO] [stdout] | ^^^^^^^^ help: change this to: `matched` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / io::Error::new( [INFO] [stdout] 86 | | io::ErrorKind::Other, [INFO] [stdout] 87 | | format!("{}: {}", path.display(), err), [INFO] [stdout] 88 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 85 ~ io::Error::other( [INFO] [stdout] 86 ~ format!("{}: {}", path.display(), err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | / io::Error::new( [INFO] [stdout] 92 | | io::ErrorKind::Other, [INFO] [stdout] 93 | | format!("{}:{}", path.display(), err), [INFO] [stdout] 94 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 91 ~ io::Error::other( [INFO] [stdout] 92 ~ format!("{}:{}", path.display(), err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::Error::new(io::ErrorKind::Other, format!(":{}", err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 108 - io::Error::new(io::ErrorKind::Other, format!(":{}", err)) [INFO] [stdout] 108 + io::Error::other(format!(":{}", err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/pattern.rs:151:29 [INFO] [stdout] | [INFO] [stdout] 151 | Err(err) => Err(io::Error::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 152 | | io::ErrorKind::Other, [INFO] [stdout] 153 | | format!("{}: {}", line_number, err), [INFO] [stdout] 154 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 151 ~ Err(err) => Err(io::Error::other( [INFO] [stdout] 152 ~ format!("{}: {}", line_number, err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/cli/src/process.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | io::Error::new(io::ErrorKind::Other, cmderr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 76 - io::Error::new(io::ErrorKind::Other, cmderr) [INFO] [stdout] 76 + io::Error::other(cmderr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking grep-printer v0.3.1 (/opt/rustwide/workdir/crates/printer) [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/searcher/examples/search-stdin.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | return Err(From::from(format!("Usage: search-stdin "))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Usage: search-stdin ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/printer/src/json.rs:908:22 [INFO] [stdout] | [INFO] [stdout] 908 | const SHERLOCK: &'static [u8] = b"\ [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/printer/src/json.rs:925:24 [INFO] [stdout] | [INFO] [stdout] 925 | const BINARY: &'static [u8] = b"\ [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/printer/src/standard.rs:1753:22 [INFO] [stdout] | [INFO] [stdout] 1753 | const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/printer/src/standard.rs:1763:27 [INFO] [stdout] | [INFO] [stdout] 1763 | const SHERLOCK_CRLF: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/printer/src/summary.rs:799:22 [INFO] [stdout] | [INFO] [stdout] 799 | const SHERLOCK: &'static [u8] = b"\ [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/dir.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | / if let Some(weak) = compiled.get(parent.as_os_str()) { [INFO] [stdout] 216 | | if let Some(prebuilt) = weak.upgrade() { [INFO] [stdout] 217 | | ig = Ignore(prebuilt); [INFO] [stdout] 218 | | continue; [INFO] [stdout] 219 | | } [INFO] [stdout] 220 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if let Some(weak) = compiled.get(parent.as_os_str()) [INFO] [stdout] 216 ~ && let Some(prebuilt) = weak.upgrade() { [INFO] [stdout] 217 | ig = Ignore(prebuilt); [INFO] [stdout] 218 | continue; [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:274:17 [INFO] [stdout] | [INFO] [stdout] 274 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:275:17 [INFO] [stdout] | [INFO] [stdout] 275 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 286 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:287:17 [INFO] [stdout] | [INFO] [stdout] 287 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 299 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:313:25 [INFO] [stdout] | [INFO] [stdout] 313 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/dir.rs:473:9 [INFO] [stdout] | [INFO] [stdout] 473 | / if self.0.opts.parents { [INFO] [stdout] 474 | | if let Some(abs_parent_path) = self.absolute_base() { [INFO] [stdout] ... | [INFO] [stdout] 534 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 473 ~ if self.0.opts.parents [INFO] [stdout] 474 ~ && let Some(abs_parent_path) = self.absolute_base() { [INFO] [stdout] 475 | // What we want to do here is take the absolute base path of [INFO] [stdout] ... [INFO] [stdout] 532 | } [INFO] [stdout] 533 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/ignore/src/dir.rs:539:37 [INFO] [stdout] | [INFO] [stdout] 539 | m_explicit = gi.matched(&path, is_dir).map(IgnoreMatch::gitignore); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/ignore/src/dir.rs:544:26 [INFO] [stdout] | [INFO] [stdout] 544 | .matched(&path, is_dir) [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/dir.rs:898:9 [INFO] [stdout] | [INFO] [stdout] 898 | if !git_type.map_or(false, |ft| ft.is_file()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 898 - if !git_type.map_or(false, |ft| ft.is_file()) { [INFO] [stdout] 898 + if !git_type.is_some_and(|ft| ft.is_file()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> crates/globset/src/fnv.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | self.0 = self.0 ^ u64::from(byte); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.0 ^= u64::from(byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|p| &**p)` on an `Option` value [INFO] [stdout] --> crates/ignore/src/gitignore.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | self.from.as_ref().map(|p| &**p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.from.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/ignore/src/gitignore.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | &*self.root [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&self.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/ignore/src/gitignore.rs:259:53 [INFO] [stdout] | [INFO] [stdout] 259 | self.set.matches_candidate_into(&candidate, &mut *matches); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&mut matches` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/gitignore.rs:294:9 [INFO] [stdout] | [INFO] [stdout] 294 | / if self.root != Path::new(".") && !is_file_name(path) { [INFO] [stdout] 295 | | if let Some(p) = strip_prefix(&self.root, path) { [INFO] [stdout] 296 | | path = p; [INFO] [stdout] ... | [INFO] [stdout] 302 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 294 ~ if self.root != Path::new(".") && !is_file_name(path) [INFO] [stdout] 295 ~ && let Some(p) = strip_prefix(&self.root, path) { [INFO] [stdout] 296 | path = p; [INFO] [stdout] ... [INFO] [stdout] 300 | } [INFO] [stdout] 301 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.tokens.get(0)` [INFO] [stdout] --> crates/globset/src/glob.rs:357:28 [INFO] [stdout] | [INFO] [stdout] 357 | let start = match *self.tokens.get(0)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/ignore/src/gitignore.rs:351:46 [INFO] [stdout] | [INFO] [stdout] 351 | matches: Some(Arc::new(Pool::new(|| vec![]))), [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/gitignore.rs:416:71 [INFO] [stdout] | [INFO] [stdout] 416 | if let Err(err) = self.add_line(Some(path.to_path_buf()), &line) { [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.tokens.get(0)` [INFO] [stdout] --> crates/globset/src/glob.rs:467:38 [INFO] [stdout] | [INFO] [stdout] 467 | let (start, entire) = match *self.tokens.get(0)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.tokens.get(0)` [INFO] [stdout] --> crates/globset/src/glob.rs:514:28 [INFO] [stdout] | [INFO] [stdout] 514 | let start = match *self.tokens.get(0)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.tokens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/ignore/src/gitignore.rs:575:5 [INFO] [stdout] | [INFO] [stdout] 575 | / match gitconfig_home_contents().and_then(|x| parse_excludes_file(&x)) { [INFO] [stdout] 576 | | Some(path) => return Some(path), [INFO] [stdout] 577 | | None => {} [INFO] [stdout] 578 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(path) = gitconfig_home_contents().and_then(|x| parse_excludes_file(&x)) { return Some(path) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/ignore/src/gitignore.rs:579:5 [INFO] [stdout] | [INFO] [stdout] 579 | / match gitconfig_xdg_contents().and_then(|x| parse_excludes_file(&x)) { [INFO] [stdout] 580 | | Some(path) => return Some(path), [INFO] [stdout] 581 | | None => {} [INFO] [stdout] 582 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(path) = gitconfig_xdg_contents().and_then(|x| parse_excludes_file(&x)) { return Some(path) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:581:19 [INFO] [stdout] | [INFO] [stdout] 581 | glob: &self.glob, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> crates/ignore/src/gitignore.rs:589:16 [INFO] [stdout] | [INFO] [stdout] 589 | let home = match home_dir() { [INFO] [stdout] | ________________^ [INFO] [stdout] 590 | | None => return None, [INFO] [stdout] 591 | | Some(home) => home, [INFO] [stdout] 592 | | }; [INFO] [stdout] | |_____^ help: try instead: `home_dir()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:687:39 [INFO] [stdout] | [INFO] [stdout] 687 | self.tokens_to_regex(options, &self, &mut re); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/globset/src/glob.rs:707:25 [INFO] [stdout] | [INFO] [stdout] 707 | re.push_str("."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `re.push('.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:747:55 [INFO] [stdout] | [INFO] [stdout] 747 | self.tokens_to_regex(options, &pat, &mut altre); [INFO] [stdout] | ^^^^ help: change this to: `pat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `name.as_bytes().get(0)` [INFO] [stdout] --> crates/ignore/src/pathutil.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | name.as_bytes().get(0) == Some(&b'.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `name.as_bytes().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/pathutil.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | Some(&Path::new(OsStr::from_bytes(&path[prefix.len()..]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(OsStr::from_bytes(&path[prefix.len()..]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/ignore/src/pathutil.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | pub(crate) fn file_name<'a, P: AsRef + ?Sized>( [INFO] [stdout] | ^^ [INFO] [stdout] 114 | path: &'a P, [INFO] [stdout] | ^^ [INFO] [stdout] 115 | ) -> Option<&'a OsStr> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 113 ~ pub(crate) fn file_name + ?Sized>( [INFO] [stdout] 114 ~ path: &P, [INFO] [stdout] 115 ~ ) -> Option<&OsStr> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> crates/globset/src/glob.rs:857:20 [INFO] [stdout] | [INFO] [stdout] 857 | return Ok(pat.push(tok)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 857 ~ return { [INFO] [stdout] 858 + let _: () = pat.push(tok); [INFO] [stdout] 859 + Ok(()) [INFO] [stdout] 860 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/ignore/src/pathutil.rs:120:24 [INFO] [stdout] | [INFO] [stdout] 120 | if path.is_empty() { [INFO] [stdout] | ________________________^ [INFO] [stdout] 121 | | return None; [INFO] [stdout] 122 | | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/ignore/src/pathutil.rs:122:50 [INFO] [stdout] | [INFO] [stdout] 122 | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 123 | | return None; [INFO] [stdout] 124 | | } else if path.last() == Some(&b'.') { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/ignore/src/pathutil.rs:122:50 [INFO] [stdout] | [INFO] [stdout] 122 | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 123 | | return None; [INFO] [stdout] 124 | | } else if path.last() == Some(&b'.') { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/ignore/src/pathutil.rs:124:42 [INFO] [stdout] | [INFO] [stdout] 124 | } else if path.last() == Some(&b'.') { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 125 | | return None; [INFO] [stdout] 126 | | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/ignore/src/pathutil.rs:124:42 [INFO] [stdout] | [INFO] [stdout] 124 | } else if path.last() == Some(&b'.') { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 125 | | return None; [INFO] [stdout] 126 | | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/ignore/src/pathutil.rs:126:72 [INFO] [stdout] | [INFO] [stdout] 126 | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 127 | | return None; [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/globset/src/glob.rs:872:18 [INFO] [stdout] | [INFO] [stdout] 872 | Some(ref pat) => Ok(!pat.is_empty()), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 872 - Some(ref pat) => Ok(!pat.is_empty()), [INFO] [stdout] 872 + Some(pat) => Ok(!pat.is_empty()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> crates/ignore/src/pathutil.rs:126:34 [INFO] [stdout] | [INFO] [stdout] 126 | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 126 - } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] 126 + } else if path.len() >= 2 && path[path.len() - 2..] == b".."[..] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> crates/globset/src/glob.rs:883:13 [INFO] [stdout] | [INFO] [stdout] 883 | Ok(self.branches.push(Tokens::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 883 ~ self.branches.push(Tokens::default()); [INFO] [stdout] 884 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/globset/src/glob.rs:909:17 [INFO] [stdout] | [INFO] [stdout] 909 | if !self.peek().map_or(true, is_separator) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 909 - if !self.peek().map_or(true, is_separator) { [INFO] [stdout] 909 + if !self.peek().is_none_or(is_separator) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/globset/src/glob.rs:914:25 [INFO] [stdout] | [INFO] [stdout] 914 | assert!(self.bump().map_or(true, is_separator)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 914 - assert!(self.bump().map_or(true, is_separator)); [INFO] [stdout] 914 + assert!(self.bump().is_none_or(is_separator)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/globset/src/glob.rs:919:9 [INFO] [stdout] | [INFO] [stdout] 919 | / if !prev.map(is_separator).unwrap_or(false) { [INFO] [stdout] 920 | | if self.branches.len() <= 1 [INFO] [stdout] 921 | | || (prev != Some(',') && prev != Some('{')) [INFO] [stdout] ... | [INFO] [stdout] 927 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 919 ~ if !prev.map(is_separator).unwrap_or(false) [INFO] [stdout] 920 ~ && (self.branches.len() <= 1 [INFO] [stdout] 921 ~ || (prev != Some(',') && prev != Some('{'))) [INFO] [stdout] 922 | { [INFO] [stdout] ... [INFO] [stdout] 925 | return Ok(()); [INFO] [stdout] 926 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> crates/globset/src/glob.rs:996:27 [INFO] [stdout] | [INFO] [stdout] 996 | return if self.opts.allow_unclosed_class == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.opts.allow_unclosed_class` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:1022:43 [INFO] [stdout] | [INFO] [stdout] 1022 | add_to_last_range(&self.glob, r, '-')?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/ignore/src/types.rs:234:41 [INFO] [stdout] | [INFO] [stdout] 234 | matches: Arc::new(Pool::new(|| vec![])), [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/globset/src/glob.rs:1034:29 [INFO] [stdout] | [INFO] [stdout] 1034 | ... &self.glob, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/ignore/src/types.rs:283:37 [INFO] [stdout] | [INFO] [stdout] 283 | self.set.matches_into(name, &mut *matches); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&mut matches` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> crates/globset/src/glob.rs:1061:9 [INFO] [stdout] | [INFO] [stdout] 1061 | self.chars.peek().map(|&ch| ch) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.chars.peek().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TypesBuilder` [INFO] [stdout] --> crates/ignore/src/types.rs:316:5 [INFO] [stdout] | [INFO] [stdout] 316 | / pub fn new() -> TypesBuilder { [INFO] [stdout] 317 | | TypesBuilder { types: HashMap::new(), selections: vec![] } [INFO] [stdout] 318 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 310 + impl Default for TypesBuilder { [INFO] [stdout] 311 + fn default() -> Self { [INFO] [stdout] 312 + Self::new() [INFO] [stdout] 313 + } [INFO] [stdout] 314 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/ignore/src/types.rs:360:41 [INFO] [stdout] | [INFO] [stdout] 360 | matches: Arc::new(Pool::new(|| vec![])), [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> crates/ignore/src/types.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | /// given name with the given glob. [INFO] [stdout] | ^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> crates/ignore/src/types.rs:438:9 [INFO] [stdout] | [INFO] [stdout] 438 | /// This defines an 'include' definition that associates the given name [INFO] [stdout] | ^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> crates/ignore/src/types.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | /// with the definitions of the given existing types. [INFO] [stdout] | ^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/types.rs:440:9 [INFO] [stdout] | [INFO] [stdout] 440 | /// Names may not include any characters that are not [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 440 | /// Names may not include any characters that are not [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/types.rs:441:9 [INFO] [stdout] | [INFO] [stdout] 441 | /// Unicode letters or numbers. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 441 | /// Unicode letters or numbers. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/ignore/src/walk.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | / match *self { [INFO] [stdout] 166 | | DirEntryInner::Stdin => true, [INFO] [stdout] 167 | | _ => false, [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 165 - match *self { [INFO] [stdout] 166 - DirEntryInner::Stdin => true, [INFO] [stdout] 167 - _ => false, [INFO] [stdout] 168 - } [INFO] [stdout] 165 + matches!(*self, DirEntryInner::Stdin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/ignore/src/walk.rs:175:37 [INFO] [stdout] | [INFO] [stdout] 175 | let err = Error::Io(io::Error::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 176 | | io::ErrorKind::Other, [INFO] [stdout] 177 | | " has no metadata", [INFO] [stdout] 178 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 175 ~ let err = Error::Io(io::Error::other( [INFO] [stdout] 176 ~ " has no metadata", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Error` [INFO] [stdout] --> crates/ignore/src/walk.rs:302:34 [INFO] [stdout] | [INFO] [stdout] 302 | .map_err(|err| Error::Io(io::Error::from(err)).with_path(&self.path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Error` [INFO] [stdout] --> crates/ignore/src/walk.rs:327:33 [INFO] [stdout] | [INFO] [stdout] 327 | let err = Error::Io(io::Error::from(err)).with_path(ent.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:456:5 [INFO] [stdout] | [INFO] [stdout] 456 | /// then matching stops. The path is then only skipped if the glob that matched [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 456 | /// then matching stops. The path is then only skipped if the glob that matched [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:457:5 [INFO] [stdout] | [INFO] [stdout] 457 | /// the path is an ignore glob. (An override glob is a whitelist glob unless it [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 457 | /// the path is an ignore glob. (An override glob is a whitelist glob unless it [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | /// starts with a `!`, in which case it is an ignore glob.) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 458 | /// starts with a `!`, in which case it is an ignore glob.) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:460:5 [INFO] [stdout] | [INFO] [stdout] 460 | /// git ignore files (`.gitignore`, `.git/info/exclude` and the configured [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 460 | /// git ignore files (`.gitignore`, `.git/info/exclude` and the configured [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:461:5 [INFO] [stdout] | [INFO] [stdout] 461 | /// global gitignore file), plain `.ignore` files, which have the same format [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 461 | /// global gitignore file), plain `.ignore` files, which have the same format [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:462:5 [INFO] [stdout] | [INFO] [stdout] 462 | /// as gitignore files, or explicitly added ignore files. The precedence order [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 462 | /// as gitignore files, or explicitly added ignore files. The precedence order [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:463:5 [INFO] [stdout] | [INFO] [stdout] 463 | /// is: `.ignore`, `.gitignore`, `.git/info/exclude`, global gitignore and [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 463 | /// is: `.ignore`, `.gitignore`, `.git/info/exclude`, global gitignore and [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:464:5 [INFO] [stdout] | [INFO] [stdout] 464 | /// finally explicitly added ignore files. Note that precedence between [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 464 | /// finally explicitly added ignore files. Note that precedence between [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:465:5 [INFO] [stdout] | [INFO] [stdout] 465 | /// different types of ignore files is not impacted by the directory hierarchy; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 465 | /// different types of ignore files is not impacted by the directory hierarchy; [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:466:5 [INFO] [stdout] | [INFO] [stdout] 466 | /// any `.ignore` file overrides all `.gitignore` files. Within each precedence [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 466 | /// any `.ignore` file overrides all `.gitignore` files. Within each precedence [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:467:5 [INFO] [stdout] | [INFO] [stdout] 467 | /// level, more nested ignore files have a higher precedence than less nested [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 467 | /// level, more nested ignore files have a higher precedence than less nested [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:468:5 [INFO] [stdout] | [INFO] [stdout] 468 | /// ignore files. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 468 | /// ignore files. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:470:5 [INFO] [stdout] | [INFO] [stdout] 470 | /// is stopped and the path is skipped. If it yields a whitelist match, then [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 470 | /// is stopped and the path is skipped. If it yields a whitelist match, then [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:471:5 [INFO] [stdout] | [INFO] [stdout] 471 | /// matching continues. A whitelist match can be overridden by a later matcher. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 471 | /// matching continues. A whitelist match can be overridden by a later matcher. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:473:5 [INFO] [stdout] | [INFO] [stdout] 473 | /// the path. As above, if it yields an ignore match, then all matching is [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 473 | /// the path. As above, if it yields an ignore match, then all matching is [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:474:5 [INFO] [stdout] | [INFO] [stdout] 474 | /// stopped and the path is skipped. If it yields a whitelist match, then [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 474 | /// stopped and the path is skipped. If it yields a whitelist match, then [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:475:5 [INFO] [stdout] | [INFO] [stdout] 475 | /// matching continues. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 475 | /// matching continues. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:477:5 [INFO] [stdout] | [INFO] [stdout] 477 | /// path is skipped. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 477 | /// path is skipped. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:479:5 [INFO] [stdout] | [INFO] [stdout] 479 | /// against the max filesize limit. If it exceeds the limit, it is skipped. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 479 | /// against the max filesize limit. If it exceeds the limit, it is skipped. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:481:5 [INFO] [stdout] | [INFO] [stdout] 481 | /// iterator. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 481 | /// iterator. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/ignore/src/walk.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 511 | ByName(Arc Ordering + Send + Sync + 'static>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/ignore/src/walk.rs:512:12 [INFO] [stdout] | [INFO] [stdout] 512 | ByPath(Arc Ordering + Send + Sync + 'static>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.max_filesize` after checking its variant with `is_some` [INFO] [stdout] --> crates/ignore/src/walk.rs:1080:17 [INFO] [stdout] | [INFO] [stdout] 1078 | if self.max_filesize.is_some() && !ent.is_dir() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] 1079 | return Ok(skip_filesize( [INFO] [stdout] 1080 | self.max_filesize.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/walk.rs:1073:9 [INFO] [stdout] | [INFO] [stdout] 1073 | / if let Some(ref stdout) = self.skip { [INFO] [stdout] 1074 | | if path_equals(ent, stdout)? { [INFO] [stdout] 1075 | | return Ok(true); [INFO] [stdout] 1076 | | } [INFO] [stdout] 1077 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1073 ~ if let Some(ref stdout) = self.skip [INFO] [stdout] 1074 ~ && path_equals(ent, stdout)? { [INFO] [stdout] 1075 | return Ok(true); [INFO] [stdout] 1076 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/walk.rs:1085:9 [INFO] [stdout] | [INFO] [stdout] 1085 | / if let Some(Filter(filter)) = &self.filter { [INFO] [stdout] 1086 | | if !filter(ent) { [INFO] [stdout] 1087 | | return Ok(true); [INFO] [stdout] 1088 | | } [INFO] [stdout] 1089 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1085 ~ if let Some(Filter(filter)) = &self.filter [INFO] [stdout] 1086 ~ && !filter(ent) { [INFO] [stdout] 1087 | return Ok(true); [INFO] [stdout] 1088 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/ignore/src/walk.rs:1261:6 [INFO] [stdout] | [INFO] [stdout] 1261 | impl<'a, 's, P: ParallelVisitorBuilder<'s>> ParallelVisitorBuilder<'s> [INFO] [stdout] | ^^ [INFO] [stdout] 1262 | for &'a mut P [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1261 ~ impl<'s, P: ParallelVisitorBuilder<'s>> ParallelVisitorBuilder<'s> [INFO] [stdout] 1262 ~ for &mut P [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/walk.rs:1474:9 [INFO] [stdout] | [INFO] [stdout] 1474 | self.dent.file_type().map_or(false, |ft| ft.is_symlink()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1474 - self.dent.file_type().map_or(false, |ft| ft.is_symlink()) [INFO] [stdout] 1474 + self.dent.file_type().is_some_and(|ft| ft.is_symlink()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/walk.rs:1701:12 [INFO] [stdout] | [INFO] [stdout] 1701 | if self.max_depth.map_or(false, |max| depth >= max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1701 - if self.max_depth.map_or(false, |max| depth >= max) { [INFO] [stdout] 1701 + if self.max_depth.is_some_and(|max| depth >= max) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.max_filesize` after checking its variant with `is_some` [INFO] [stdout] --> crates/ignore/src/walk.rs:1784:21 [INFO] [stdout] | [INFO] [stdout] 1782 | if self.max_filesize.is_some() && !dent.is_dir() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] 1783 | skip_filesize( [INFO] [stdout] 1784 | self.max_filesize.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/walk.rs:1752:26 [INFO] [stdout] | [INFO] [stdout] 1752 | let is_symlink = dent.file_type().map_or(false, |ft| ft.is_symlink()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1752 - let is_symlink = dent.file_type().map_or(false, |ft| ft.is_symlink()); [INFO] [stdout] 1752 + let is_symlink = dent.file_type().is_some_and(|ft| ft.is_symlink()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/walk.rs:1761:13 [INFO] [stdout] | [INFO] [stdout] 1761 | / if dent.is_dir() { [INFO] [stdout] 1762 | | if let Err(err) = check_symlink_loop(ig, dent.path(), depth) { [INFO] [stdout] 1763 | | return self.visitor.visit(Err(err)); [INFO] [stdout] 1764 | | } [INFO] [stdout] 1765 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1761 ~ if dent.is_dir() [INFO] [stdout] 1762 ~ && let Err(err) = check_symlink_loop(ig, dent.path(), depth) { [INFO] [stdout] 1763 | return self.visitor.visit(Err(err)); [INFO] [stdout] 1764 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> crates/ignore/src/walk.rs:1922:20 [INFO] [stdout] | [INFO] [stdout] 1922 | let filesize = match *ent { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1923 | | Some(ref md) => Some(md.len()), [INFO] [stdout] 1924 | | None => None, [INFO] [stdout] 1925 | | }; [INFO] [stdout] | |_____^ help: try: `(*ent).as_ref().map(|md| md.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/walk.rs:2013:5 [INFO] [stdout] | [INFO] [stdout] 2013 | dent.path().metadata().ok().map_or(false, |md| md.file_type().is_dir()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 2013 - dent.path().metadata().ok().map_or(false, |md| md.file_type().is_dir()) [INFO] [stdout] 2013 + dent.path().metadata().ok().is_some_and(|md| md.file_type().is_dir()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/ignore/tests/gitignore_skip_bom.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | const IGNORE_FILE: &'static str = "tests/gitignore_skip_bom.gitignore"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/ignore/tests/gitignore_matched_path_or_any_parents_tests.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | const IGNORE_FILE: &'static str = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> crates/ignore/tests/gitignore_matched_path_or_any_parents_tests.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | / impl Default for BufferAllocation { [INFO] [stdout] 30 | | fn default() -> BufferAllocation { [INFO] [stdout] 31 | | BufferAllocation::Eager [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Default)] [INFO] [stdout] 18 | pub(crate) enum BufferAllocation { [INFO] [stdout] 19 | /// Attempt to expand the size of the buffer until either at least the next [INFO] [stdout] ... [INFO] [stdout] 22 | /// This is the default. [INFO] [stdout] 23 ~ #[default] [INFO] [stdout] 24 ~ Eager, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | io::Error::new(io::ErrorKind::Other, msg) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 39 - io::Error::new(io::ErrorKind::Other, msg) [INFO] [stdout] 39 + io::Error::other(msg) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:66:1 [INFO] [stdout] | [INFO] [stdout] 66 | / impl Default for BinaryDetection { [INFO] [stdout] 67 | | fn default() -> BinaryDetection { [INFO] [stdout] 68 | | BinaryDetection::None [INFO] [stdout] 69 | | } [INFO] [stdout] 70 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 51 + #[derive(Default)] [INFO] [stdout] 52 | pub(crate) enum BinaryDetection { [INFO] [stdout] 53 | /// No binary detection is performed. Data reported by the line buffer may [INFO] [stdout] 54 | /// contain arbitrary bytes. [INFO] [stdout] 55 ~ #[default] [INFO] [stdout] 56 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / match *self { [INFO] [stdout] 77 | | BinaryDetection::Quit(_) => true, [INFO] [stdout] 78 | | _ => false, [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 76 - match *self { [INFO] [stdout] 77 - BinaryDetection::Quit(_) => true, [INFO] [stdout] 78 - _ => false, [INFO] [stdout] 79 - } [INFO] [stdout] 76 + matches!(*self, BinaryDetection::Quit(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `bytes.get(0)` [INFO] [stdout] --> crates/searcher/src/line_buffer.rs:546:15 [INFO] [stdout] | [INFO] [stdout] 546 | while bytes.get(0) == Some(&src) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:111:31 [INFO] [stdout] | [INFO] [stdout] 111 | self.sink.binary_data(&self.searcher, binary_byte_offset) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | Err(err) => return Err(S::Error::error_message(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 149 - Err(err) => return Err(S::Error::error_message(err)), [INFO] [stdout] 149 + Err(err) => Err(S::Error::error_message(err)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | Ok(None) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - Ok(None) => return Ok(None), [INFO] [stdout] 150 + Ok(None) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:156:25 [INFO] [stdout] | [INFO] [stdout] 156 | self.sink.begin(&self.searcher) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 165 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 203 | / let consumed = [INFO] [stdout] 204 | | std::cmp::max(context_start, self.last_line_visited); [INFO] [stdout] | |_____________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 205 | consumed [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 203 ~ [INFO] [stdout] 204 ~ std::cmp::max(context_start, self.last_line_visited) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:373:20 [INFO] [stdout] | [INFO] [stdout] 373 | } else if self.config.passthru { [INFO] [stdout] | ____________________^ [INFO] [stdout] 374 | | if !self.sink_other_context(buf, &line)? { [INFO] [stdout] 375 | | return Ok(false); [INFO] [stdout] 376 | | } [INFO] [stdout] 377 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 373 ~ } else if self.config.passthru [INFO] [stdout] 374 ~ && !self.sink_other_context(buf, &line)? { [INFO] [stdout] 375 | return Ok(false); [INFO] [stdout] 376 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:537:13 [INFO] [stdout] | [INFO] [stdout] 537 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:567:13 [INFO] [stdout] | [INFO] [stdout] 567 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:598:13 [INFO] [stdout] | [INFO] [stdout] 598 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:628:13 [INFO] [stdout] | [INFO] [stdout] 628 | &self.searcher, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:657:37 [INFO] [stdout] | [INFO] [stdout] 657 | self.sink.context_break(&self.searcher) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/searcher/src/searcher/core.rs:711:9 [INFO] [stdout] | [INFO] [stdout] 711 | self.config.max_matches.map_or(false, |limit| self.count() >= limit) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 711 - self.config.max_matches.map_or(false, |limit| self.count() >= limit) [INFO] [stdout] 711 + self.config.max_matches.is_some_and(|limit| self.count() >= limit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/searcher/src/searcher/glue.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / if !already_binary { [INFO] [stdout] 70 | | if let Some(offset) = self.rdr.binary_byte_offset() { [INFO] [stdout] 71 | | if !self.core.binary_data(offset)? { [INFO] [stdout] 72 | | return Ok(false); [INFO] [stdout] ... | [INFO] [stdout] 75 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ if !already_binary [INFO] [stdout] 70 ~ && let Some(offset) = self.rdr.binary_byte_offset() { [INFO] [stdout] 71 | if !self.core.binary_data(offset)? { [INFO] [stdout] 72 | return Ok(false); [INFO] [stdout] 73 | } [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/searcher/src/searcher/glue.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | / if let Some(offset) = self.rdr.binary_byte_offset() { [INFO] [stdout] 71 | | if !self.core.binary_data(offset)? { [INFO] [stdout] 72 | | return Ok(false); [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 70 ~ if let Some(offset) = self.rdr.binary_byte_offset() [INFO] [stdout] 71 ~ && !self.core.binary_data(offset)? { [INFO] [stdout] 72 | return Ok(false); [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Searcher` [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:632:5 [INFO] [stdout] | [INFO] [stdout] 632 | / pub fn new() -> Searcher { [INFO] [stdout] 633 | | SearcherBuilder::new().build() [INFO] [stdout] 634 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 627 + impl Default for Searcher { [INFO] [stdout] 628 + fn default() -> Self { [INFO] [stdout] 629 + Self::new() [INFO] [stdout] 630 + } [INFO] [stdout] 631 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:706:17 [INFO] [stdout] | [INFO] [stdout] 706 | &*self.multi_line_buffer.borrow(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&self.multi_line_buffer.borrow()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:755:17 [INFO] [stdout] | [INFO] [stdout] 755 | &*self.multi_line_buffer.borrow(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&self.multi_line_buffer.borrow()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:761:54 [INFO] [stdout] | [INFO] [stdout] 761 | let rdr = LineBufferReader::new(decoder, &mut *line_buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut line_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:900:9 [INFO] [stdout] | [INFO] [stdout] 900 | / if let Some(line_term) = matcher.line_terminator() { [INFO] [stdout] 901 | | if line_term == self.line_terminator() { [INFO] [stdout] 902 | | return false; [INFO] [stdout] 903 | | } [INFO] [stdout] 904 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 900 ~ if let Some(line_term) = matcher.line_terminator() [INFO] [stdout] 901 ~ && line_term == self.line_terminator() { [INFO] [stdout] 902 | return false; [INFO] [stdout] 903 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:965:35 [INFO] [stdout] | [INFO] [stdout] 965 | read_from.read_to_end(&mut *buf).map_err(S::Error::error_io)?; [INFO] [stdout] | ^^^^^^^^^ help: try: `&mut buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/searcher/src/searcher/mod.rs:990:34 [INFO] [stdout] | [INFO] [stdout] 990 | .read_to_end(&mut *buf) [INFO] [stdout] | ^^^^^^^^^ help: try: `&mut buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/searcher/src/sink.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | io::Error::new(io::ErrorKind::Other, message.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 44 - io::Error::new(io::ErrorKind::Other, message.to_string()) [INFO] [stdout] 44 + io::Error::other(message.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/searcher/src/sink.rs:225:6 [INFO] [stdout] | [INFO] [stdout] 225 | impl<'a, S: Sink> Sink for &'a mut S { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 225 - impl<'a, S: Sink> Sink for &'a mut S { [INFO] [stdout] 225 + impl Sink for &mut S { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/searcher/src/sink.rs:566:35 [INFO] [stdout] | [INFO] [stdout] 566 | (self.0)(line_number, &matched) [INFO] [stdout] | ^^^^^^^^ help: change this to: `matched` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> crates/searcher/src/testutil.rs:98:62 [INFO] [stdout] | [INFO] [stdout] 98 | .find_byte(self.line_term.unwrap().as_byte()) [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 99 | | .map(|i| i) [INFO] [stdout] | |___________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> crates/searcher/src/testutil.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | writeln!(self.0, "")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> crates/globset/src/pathutil.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 50 | let last_dot_at = match name.rfind_byte(b'.') { [INFO] [stdout] | _______________________^ [INFO] [stdout] 51 | | None => return None, [INFO] [stdout] 52 | | Some(i) => i, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ help: try instead: `name.rfind_byte(b'.')?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Color` which implements the `Copy` trait [INFO] [stdout] --> crates/printer/src/color.rs:276:35 [INFO] [stdout] | [INFO] [stdout] 276 | cspec.set_fg(Some(color.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Color` which implements the `Copy` trait [INFO] [stdout] --> crates/printer/src/color.rs:279:35 [INFO] [stdout] | [INFO] [stdout] 279 | cspec.set_bg(Some(color.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| &**s)` on an `Option` value [INFO] [stdout] --> crates/globset/src/lib.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | self.glob.as_ref().map(|s| &**s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.glob.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GlobSetBuilder` [INFO] [stdout] --> crates/globset/src/lib.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 574 | / pub fn new() -> GlobSetBuilder { [INFO] [stdout] 575 | | GlobSetBuilder { pats: vec![] } [INFO] [stdout] 576 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 570 + impl Default for GlobSetBuilder { [INFO] [stdout] 571 + fn default() -> Self { [INFO] [stdout] 572 + Self::new() [INFO] [stdout] 573 + } [INFO] [stdout] 574 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/globset/src/lib.rs:641:37 [INFO] [stdout] | [INFO] [stdout] 641 | if self.path.len() <= max { &*self.path } else { &self.path[..max] } [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/globset/src/lib.rs:646:13 [INFO] [stdout] | [INFO] [stdout] 646 | &*self.path [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> crates/globset/src/lib.rs:867:21 [INFO] [stdout] | [INFO] [stdout] 867 | for &(_, ref re) in regexes { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 867 - for &(_, ref re) in regexes { [INFO] [stdout] 867 + for (_, re) in regexes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/printer/src/hyperlink/mod.rs:495:43 [INFO] [stdout] | [INFO] [stdout] 495 | let is_valid_scheme_char = |byte| match byte { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 496 | | b'0'..=b'9' | b'A'..=b'Z' | b'a'..=b'z' | b'+' | b'-' | b'.' => { [INFO] [stdout] 497 | | true [INFO] [stdout] ... | [INFO] [stdout] 500 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 495 - let is_valid_scheme_char = |byte| match byte { [INFO] [stdout] 496 - b'0'..=b'9' | b'A'..=b'Z' | b'a'..=b'z' | b'+' | b'-' | b'.' => { [INFO] [stdout] 497 - true [INFO] [stdout] 498 - } [INFO] [stdout] 499 - _ => false, [INFO] [stdout] 500 - }; [INFO] [stdout] 495 + let is_valid_scheme_char = |byte| matches!(byte, b'0'..=b'9' | b'A'..=b'Z' | b'a'..=b'z' | b'+' | b'-' | b'.'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> crates/printer/src/hyperlink/mod.rs:947:30 [INFO] [stdout] | [INFO] [stdout] 947 | HYPERLINK_PATTERN_ALIASES.iter().cloned().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/dir.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | / if let Some(weak) = compiled.get(parent.as_os_str()) { [INFO] [stdout] 216 | | if let Some(prebuilt) = weak.upgrade() { [INFO] [stdout] 217 | | ig = Ignore(prebuilt); [INFO] [stdout] 218 | | continue; [INFO] [stdout] 219 | | } [INFO] [stdout] 220 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if let Some(weak) = compiled.get(parent.as_os_str()) [INFO] [stdout] 216 ~ && let Some(prebuilt) = weak.upgrade() { [INFO] [stdout] 217 | ig = Ignore(prebuilt); [INFO] [stdout] 218 | continue; [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JSONBuilder` [INFO] [stdout] --> crates/printer/src/json.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | / pub fn new() -> JSONBuilder { [INFO] [stdout] 61 | | JSONBuilder { config: Config::default() } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for JSONBuilder { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:274:17 [INFO] [stdout] | [INFO] [stdout] 274 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:275:17 [INFO] [stdout] | [INFO] [stdout] 275 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 286 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:287:17 [INFO] [stdout] | [INFO] [stdout] 287 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 299 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/dir.rs:313:25 [INFO] [stdout] | [INFO] [stdout] 313 | &dir, [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/json.rs:588:5 [INFO] [stdout] | [INFO] [stdout] 588 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 588 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/json.rs:590:5 [INFO] [stdout] | [INFO] [stdout] 590 | /// borrows. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 590 | /// borrows. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/json.rs:592:5 [INFO] [stdout] | [INFO] [stdout] 592 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 592 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/json.rs:594:5 [INFO] [stdout] | [INFO] [stdout] 594 | /// output to. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 594 | /// output to. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/dir.rs:473:9 [INFO] [stdout] | [INFO] [stdout] 473 | / if self.0.opts.parents { [INFO] [stdout] 474 | | if let Some(abs_parent_path) = self.absolute_base() { [INFO] [stdout] ... | [INFO] [stdout] 534 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 473 ~ if self.0.opts.parents [INFO] [stdout] 474 ~ && let Some(abs_parent_path) = self.absolute_base() { [INFO] [stdout] 475 | // What we want to do here is take the absolute base path of [INFO] [stdout] ... [INFO] [stdout] 532 | } [INFO] [stdout] 533 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/ignore/src/dir.rs:539:37 [INFO] [stdout] | [INFO] [stdout] 539 | m_explicit = gi.matched(&path, is_dir).map(IgnoreMatch::gitignore); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/ignore/src/dir.rs:544:26 [INFO] [stdout] | [INFO] [stdout] 544 | .matched(&path, is_dir) [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/dir.rs:898:9 [INFO] [stdout] | [INFO] [stdout] 898 | if !git_type.map_or(false, |ft| ft.is_file()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 898 - if !git_type.map_or(false, |ft| ft.is_file()) { [INFO] [stdout] 898 + if !git_type.is_some_and(|ft| ft.is_file()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> crates/printer/src/json.rs:695:66 [INFO] [stdout] | [INFO] [stdout] 695 | (*self.json.config.replacement).as_ref().map(|r| &*r).unwrap(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 695 - (*self.json.config.replacement).as_ref().map(|r| &*r).unwrap(); [INFO] [stdout] 695 + (*self.json.config.replacement).as_ref().map(|r| r).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 695 | (*self.json.config.replacement).as_ref().map(|r| &**r).unwrap(); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/json.rs:790:9 [INFO] [stdout] | [INFO] [stdout] 790 | / if searcher.binary_detection().quit_byte().is_some() { [INFO] [stdout] 791 | | if let Some(ref path) = self.path { [INFO] [stdout] 792 | | log::debug!( [INFO] [stdout] 793 | | "ignoring {path}: found binary data at \ [INFO] [stdout] ... | [INFO] [stdout] 798 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 790 ~ if searcher.binary_detection().quit_byte().is_some() [INFO] [stdout] 791 ~ && let Some(ref path) = self.path { [INFO] [stdout] 792 | log::debug!( [INFO] [stdout] ... [INFO] [stdout] 796 | ); [INFO] [stdout] 797 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/printer/src/json.rs:791:25 [INFO] [stdout] | [INFO] [stdout] 791 | if let Some(ref path) = self.path { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 791 - if let Some(ref path) = self.path { [INFO] [stdout] 791 + if let Some(path) = self.path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> crates/printer/src/jsont.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | while let Some(chunk) = it.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for chunk in it.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> crates/printer/src/jsont.rs:244:22 [INFO] [stdout] | [INFO] [stdout] 244 | let index4 = (group24 >> 0) & 0b111_111; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider reducing it to: `group24` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> crates/printer/src/jsont.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | / match it.remainder() { [INFO] [stdout] 251 | | &[] => {} [INFO] [stdout] 252 | | &[byte0] => { [INFO] [stdout] 253 | | let group8 = usize::from(byte0); [INFO] [stdout] ... | [INFO] [stdout] 271 | | _ => unreachable!("remainder must have length < 3"), [INFO] [stdout] 272 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 250 ~ match *it.remainder() { [INFO] [stdout] 251 ~ [] => {} [INFO] [stdout] 252 ~ [byte0] => { [INFO] [stdout] 253 | let group8 = usize::from(byte0); [INFO] [stdout] ... [INFO] [stdout] 260 | } [INFO] [stdout] 261 ~ [byte0, byte1] => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PathPrinterBuilder` [INFO] [stdout] --> crates/printer/src/path.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / pub fn new() -> PathPrinterBuilder { [INFO] [stdout] 40 | | PathPrinterBuilder { config: Config::default() } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for PathPrinterBuilder { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/path.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | /// with the other printers in this crate. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 138 | /// with the other printers in this crate. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/path.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | /// with the other printers in this crate. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 140 | /// with the other printers in this crate. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> crates/printer/src/path.rs:151:38 [INFO] [stdout] | [INFO] [stdout] 151 | let ppath = PrinterPath::new(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|p| &**p)` on an `Option` value [INFO] [stdout] --> crates/ignore/src/gitignore.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | self.from.as_ref().map(|p| &**p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.from.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `StandardBuilder` [INFO] [stdout] --> crates/printer/src/standard.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | / pub fn new() -> StandardBuilder { [INFO] [stdout] 106 | | StandardBuilder { config: Config::default() } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 103 + impl Default for StandardBuilder { [INFO] [stdout] 104 + fn default() -> Self { [INFO] [stdout] 105 + Self::new() [INFO] [stdout] 106 + } [INFO] [stdout] 107 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/ignore/src/gitignore.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | &*self.root [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&self.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/ignore/src/gitignore.rs:259:53 [INFO] [stdout] | [INFO] [stdout] 259 | self.set.matches_candidate_into(&candidate, &mut *matches); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&mut matches` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/gitignore.rs:294:9 [INFO] [stdout] | [INFO] [stdout] 294 | / if self.root != Path::new(".") && !is_file_name(path) { [INFO] [stdout] 295 | | if let Some(p) = strip_prefix(&self.root, path) { [INFO] [stdout] 296 | | path = p; [INFO] [stdout] ... | [INFO] [stdout] 302 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 294 ~ if self.root != Path::new(".") && !is_file_name(path) [INFO] [stdout] 295 ~ && let Some(p) = strip_prefix(&self.root, path) { [INFO] [stdout] 296 | path = p; [INFO] [stdout] ... [INFO] [stdout] 300 | } [INFO] [stdout] 301 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/ignore/src/gitignore.rs:351:46 [INFO] [stdout] | [INFO] [stdout] 351 | matches: Some(Arc::new(Pool::new(|| vec![]))), [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/gitignore.rs:416:71 [INFO] [stdout] | [INFO] [stdout] 416 | if let Err(err) = self.add_line(Some(path.to_path_buf()), &line) { [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/ignore/src/gitignore.rs:575:5 [INFO] [stdout] | [INFO] [stdout] 575 | / match gitconfig_home_contents().and_then(|x| parse_excludes_file(&x)) { [INFO] [stdout] 576 | | Some(path) => return Some(path), [INFO] [stdout] 577 | | None => {} [INFO] [stdout] 578 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(path) = gitconfig_home_contents().and_then(|x| parse_excludes_file(&x)) { return Some(path) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/ignore/src/gitignore.rs:579:5 [INFO] [stdout] | [INFO] [stdout] 579 | / match gitconfig_xdg_contents().and_then(|x| parse_excludes_file(&x)) { [INFO] [stdout] 580 | | Some(path) => return Some(path), [INFO] [stdout] 581 | | None => {} [INFO] [stdout] 582 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(path) = gitconfig_xdg_contents().and_then(|x| parse_excludes_file(&x)) { return Some(path) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> crates/ignore/src/gitignore.rs:589:16 [INFO] [stdout] | [INFO] [stdout] 589 | let home = match home_dir() { [INFO] [stdout] | ________________^ [INFO] [stdout] 590 | | None => return None, [INFO] [stdout] 591 | | Some(home) => home, [INFO] [stdout] 592 | | }; [INFO] [stdout] | |_____^ help: try instead: `home_dir()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/standard.rs:631:5 [INFO] [stdout] | [INFO] [stdout] 631 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 631 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/standard.rs:633:5 [INFO] [stdout] | [INFO] [stdout] 633 | /// borrows. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 633 | /// borrows. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/standard.rs:635:5 [INFO] [stdout] | [INFO] [stdout] 635 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 635 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/standard.rs:637:5 [INFO] [stdout] | [INFO] [stdout] 637 | /// output to. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 637 | /// output to. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/standard.rs:784:9 [INFO] [stdout] | [INFO] [stdout] 784 | / if searcher.binary_detection().convert_byte().is_some() { [INFO] [stdout] 785 | | if self.binary_byte_offset.is_some() { [INFO] [stdout] 786 | | return Ok(false); [INFO] [stdout] 787 | | } [INFO] [stdout] 788 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 784 ~ if searcher.binary_detection().convert_byte().is_some() [INFO] [stdout] 785 ~ && self.binary_byte_offset.is_some() { [INFO] [stdout] 786 | return Ok(false); [INFO] [stdout] 787 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/standard.rs:805:9 [INFO] [stdout] | [INFO] [stdout] 805 | / if searcher.binary_detection().convert_byte().is_some() { [INFO] [stdout] 806 | | if self.binary_byte_offset.is_some() { [INFO] [stdout] 807 | | return Ok(false); [INFO] [stdout] 808 | | } [INFO] [stdout] 809 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 805 ~ if searcher.binary_detection().convert_byte().is_some() [INFO] [stdout] 806 ~ && self.binary_byte_offset.is_some() { [INFO] [stdout] 807 | return Ok(false); [INFO] [stdout] 808 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/standard.rs:828:9 [INFO] [stdout] | [INFO] [stdout] 828 | / if searcher.binary_detection().quit_byte().is_some() { [INFO] [stdout] 829 | | if let Some(ref path) = self.path { [INFO] [stdout] 830 | | log::debug!( [INFO] [stdout] 831 | | "ignoring {path}: found binary data at \ [INFO] [stdout] ... | [INFO] [stdout] 836 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 828 ~ if searcher.binary_detection().quit_byte().is_some() [INFO] [stdout] 829 ~ && let Some(ref path) = self.path { [INFO] [stdout] 830 | log::debug!( [INFO] [stdout] ... [INFO] [stdout] 834 | ); [INFO] [stdout] 835 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/printer/src/standard.rs:1524:30 [INFO] [stdout] | [INFO] [stdout] 1524 | trim_line_terminator(&self.searcher, buf, line); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/printer/src/standard.rs:1563:9 [INFO] [stdout] | [INFO] [stdout] 1563 | self.config().max_columns.map_or(false, |m| line.len() as u64 > m) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1563 - self.config().max_columns.map_or(false, |m| line.len() as u64 > m) [INFO] [stdout] 1563 + self.config().max_columns.is_some_and(|m| line.len() as u64 > m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `name.as_bytes().get(0)` [INFO] [stdout] --> crates/ignore/src/pathutil.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | name.as_bytes().get(0) == Some(&b'.') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `name.as_bytes().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/pathutil.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | Some(&Path::new(OsStr::from_bytes(&path[prefix.len()..]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(OsStr::from_bytes(&path[prefix.len()..]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/ignore/src/pathutil.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | pub(crate) fn file_name<'a, P: AsRef + ?Sized>( [INFO] [stdout] | ^^ [INFO] [stdout] 114 | path: &'a P, [INFO] [stdout] | ^^ [INFO] [stdout] 115 | ) -> Option<&'a OsStr> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 113 ~ pub(crate) fn file_name + ?Sized>( [INFO] [stdout] 114 ~ path: &P, [INFO] [stdout] 115 ~ ) -> Option<&OsStr> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/ignore/src/pathutil.rs:120:24 [INFO] [stdout] | [INFO] [stdout] 120 | if path.is_empty() { [INFO] [stdout] | ________________________^ [INFO] [stdout] 121 | | return None; [INFO] [stdout] 122 | | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/ignore/src/pathutil.rs:122:50 [INFO] [stdout] | [INFO] [stdout] 122 | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 123 | | return None; [INFO] [stdout] 124 | | } else if path.last() == Some(&b'.') { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/ignore/src/pathutil.rs:122:50 [INFO] [stdout] | [INFO] [stdout] 122 | } else if path.len() == 1 && path[0] == b'.' { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 123 | | return None; [INFO] [stdout] 124 | | } else if path.last() == Some(&b'.') { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/ignore/src/pathutil.rs:124:42 [INFO] [stdout] | [INFO] [stdout] 124 | } else if path.last() == Some(&b'.') { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 125 | | return None; [INFO] [stdout] 126 | | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/ignore/src/pathutil.rs:124:42 [INFO] [stdout] | [INFO] [stdout] 124 | } else if path.last() == Some(&b'.') { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 125 | | return None; [INFO] [stdout] 126 | | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/ignore/src/pathutil.rs:126:72 [INFO] [stdout] | [INFO] [stdout] 126 | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 127 | | return None; [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> crates/ignore/src/pathutil.rs:126:34 [INFO] [stdout] | [INFO] [stdout] 126 | } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 126 - } else if path.len() >= 2 && &path[path.len() - 2..] == &b".."[..] { [INFO] [stdout] 126 + } else if path.len() >= 2 && path[path.len() - 2..] == b".."[..] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SummaryBuilder` [INFO] [stdout] --> crates/printer/src/summary.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | / pub fn new() -> SummaryBuilder { [INFO] [stdout] 154 | | SummaryBuilder { config: Config::default() } [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 151 + impl Default for SummaryBuilder { [INFO] [stdout] 152 + fn default() -> Self { [INFO] [stdout] 153 + Self::new() [INFO] [stdout] 154 + } [INFO] [stdout] 155 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/ignore/src/types.rs:234:41 [INFO] [stdout] | [INFO] [stdout] 234 | matches: Arc::new(Pool::new(|| vec![])), [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/summary.rs:476:5 [INFO] [stdout] | [INFO] [stdout] 476 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 476 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/ignore/src/types.rs:283:37 [INFO] [stdout] | [INFO] [stdout] 283 | self.set.matches_into(name, &mut *matches); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&mut matches` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/summary.rs:478:5 [INFO] [stdout] | [INFO] [stdout] 478 | /// borrows. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 478 | /// borrows. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/summary.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 480 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 480 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/summary.rs:482:5 [INFO] [stdout] | [INFO] [stdout] 482 | /// output to. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 482 | /// output to. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TypesBuilder` [INFO] [stdout] --> crates/ignore/src/types.rs:316:5 [INFO] [stdout] | [INFO] [stdout] 316 | / pub fn new() -> TypesBuilder { [INFO] [stdout] 317 | | TypesBuilder { types: HashMap::new(), selections: vec![] } [INFO] [stdout] 318 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 310 + impl Default for TypesBuilder { [INFO] [stdout] 311 + fn default() -> Self { [INFO] [stdout] 312 + Self::new() [INFO] [stdout] 313 + } [INFO] [stdout] 314 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/ignore/src/types.rs:360:41 [INFO] [stdout] | [INFO] [stdout] 360 | matches: Arc::new(Pool::new(|| vec![])), [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> crates/ignore/src/types.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | /// given name with the given glob. [INFO] [stdout] | ^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/summary.rs:684:9 [INFO] [stdout] | [INFO] [stdout] 684 | / if searcher.binary_detection().quit_byte().is_some() { [INFO] [stdout] 685 | | if let Some(ref path) = self.path { [INFO] [stdout] 686 | | log::debug!( [INFO] [stdout] 687 | | "ignoring {path}: found binary data at \ [INFO] [stdout] ... | [INFO] [stdout] 692 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 684 ~ if searcher.binary_detection().quit_byte().is_some() [INFO] [stdout] 685 ~ && let Some(ref path) = self.path { [INFO] [stdout] 686 | log::debug!( [INFO] [stdout] ... [INFO] [stdout] 690 | ); [INFO] [stdout] 691 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> crates/ignore/src/types.rs:438:9 [INFO] [stdout] | [INFO] [stdout] 438 | /// This defines an 'include' definition that associates the given name [INFO] [stdout] | ^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> crates/ignore/src/types.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | /// with the definitions of the given existing types. [INFO] [stdout] | ^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/types.rs:440:9 [INFO] [stdout] | [INFO] [stdout] 440 | /// Names may not include any characters that are not [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 440 | /// Names may not include any characters that are not [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/types.rs:441:9 [INFO] [stdout] | [INFO] [stdout] 441 | /// Unicode letters or numbers. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 441 | /// Unicode letters or numbers. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/printer/src/util.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn replace_all<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] 52 | &'a mut self, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 51 ~ pub(crate) fn replace_all( [INFO] [stdout] 52 ~ &mut self, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/printer/src/util.rs:61:62 [INFO] [stdout] | [INFO] [stdout] 61 | let is_multi_line = searcher.multi_line_with_matcher(&matcher); [INFO] [stdout] | ^^^^^^^^ help: change this to: `matcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/printer/src/util.rs:115:31 [INFO] [stdout] | [INFO] [stdout] 115 | pub(crate) fn replacement<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] 116 | &'a self, [INFO] [stdout] | ^^ [INFO] [stdout] 117 | ) -> Option<(&'a [u8], &'a [Match])> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 115 ~ pub(crate) fn replacement( [INFO] [stdout] 116 ~ &self, [INFO] [stdout] 117 ~ ) -> Option<(&[u8], &[Match])> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/printer/src/util.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 458 | / match b { [INFO] [stdout] 459 | | b'\t' | b'\n' | b'\x0B' | b'\x0C' | b'\r' | b' ' => true, [INFO] [stdout] 460 | | _ => false, [INFO] [stdout] 461 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 458 - match b { [INFO] [stdout] 459 - b'\t' | b'\n' | b'\x0B' | b'\x0C' | b'\r' | b' ' => true, [INFO] [stdout] 460 - _ => false, [INFO] [stdout] 461 - } [INFO] [stdout] 458 + matches!(b, b'\t' | b'\n' | b'\x0B' | b'\x0C' | b'\r' | b' ') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Color` which implements the `Copy` trait [INFO] [stdout] --> crates/printer/src/color.rs:276:35 [INFO] [stdout] | [INFO] [stdout] 276 | cspec.set_fg(Some(color.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Color` which implements the `Copy` trait [INFO] [stdout] --> crates/printer/src/color.rs:279:35 [INFO] [stdout] | [INFO] [stdout] 279 | cspec.set_bg(Some(color.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/ignore/src/walk.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | / match *self { [INFO] [stdout] 166 | | DirEntryInner::Stdin => true, [INFO] [stdout] 167 | | _ => false, [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 165 - match *self { [INFO] [stdout] 166 - DirEntryInner::Stdin => true, [INFO] [stdout] 167 - _ => false, [INFO] [stdout] 168 - } [INFO] [stdout] 165 + matches!(*self, DirEntryInner::Stdin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/ignore/src/walk.rs:175:37 [INFO] [stdout] | [INFO] [stdout] 175 | let err = Error::Io(io::Error::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 176 | | io::ErrorKind::Other, [INFO] [stdout] 177 | | " has no metadata", [INFO] [stdout] 178 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 175 ~ let err = Error::Io(io::Error::other( [INFO] [stdout] 176 ~ " has no metadata", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Error` [INFO] [stdout] --> crates/ignore/src/walk.rs:302:34 [INFO] [stdout] | [INFO] [stdout] 302 | .map_err(|err| Error::Io(io::Error::from(err)).with_path(&self.path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Error` [INFO] [stdout] --> crates/ignore/src/walk.rs:327:33 [INFO] [stdout] | [INFO] [stdout] 327 | let err = Error::Io(io::Error::from(err)).with_path(ent.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:456:5 [INFO] [stdout] | [INFO] [stdout] 456 | /// then matching stops. The path is then only skipped if the glob that matched [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 456 | /// then matching stops. The path is then only skipped if the glob that matched [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:457:5 [INFO] [stdout] | [INFO] [stdout] 457 | /// the path is an ignore glob. (An override glob is a whitelist glob unless it [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 457 | /// the path is an ignore glob. (An override glob is a whitelist glob unless it [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | /// starts with a `!`, in which case it is an ignore glob.) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 458 | /// starts with a `!`, in which case it is an ignore glob.) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:460:5 [INFO] [stdout] | [INFO] [stdout] 460 | /// git ignore files (`.gitignore`, `.git/info/exclude` and the configured [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 460 | /// git ignore files (`.gitignore`, `.git/info/exclude` and the configured [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:461:5 [INFO] [stdout] | [INFO] [stdout] 461 | /// global gitignore file), plain `.ignore` files, which have the same format [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 461 | /// global gitignore file), plain `.ignore` files, which have the same format [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:462:5 [INFO] [stdout] | [INFO] [stdout] 462 | /// as gitignore files, or explicitly added ignore files. The precedence order [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 462 | /// as gitignore files, or explicitly added ignore files. The precedence order [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:463:5 [INFO] [stdout] | [INFO] [stdout] 463 | /// is: `.ignore`, `.gitignore`, `.git/info/exclude`, global gitignore and [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 463 | /// is: `.ignore`, `.gitignore`, `.git/info/exclude`, global gitignore and [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:464:5 [INFO] [stdout] | [INFO] [stdout] 464 | /// finally explicitly added ignore files. Note that precedence between [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 464 | /// finally explicitly added ignore files. Note that precedence between [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:465:5 [INFO] [stdout] | [INFO] [stdout] 465 | /// different types of ignore files is not impacted by the directory hierarchy; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 465 | /// different types of ignore files is not impacted by the directory hierarchy; [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:466:5 [INFO] [stdout] | [INFO] [stdout] 466 | /// any `.ignore` file overrides all `.gitignore` files. Within each precedence [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 466 | /// any `.ignore` file overrides all `.gitignore` files. Within each precedence [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:467:5 [INFO] [stdout] | [INFO] [stdout] 467 | /// level, more nested ignore files have a higher precedence than less nested [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 467 | /// level, more nested ignore files have a higher precedence than less nested [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:468:5 [INFO] [stdout] | [INFO] [stdout] 468 | /// ignore files. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 468 | /// ignore files. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:470:5 [INFO] [stdout] | [INFO] [stdout] 470 | /// is stopped and the path is skipped. If it yields a whitelist match, then [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 470 | /// is stopped and the path is skipped. If it yields a whitelist match, then [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:471:5 [INFO] [stdout] | [INFO] [stdout] 471 | /// matching continues. A whitelist match can be overridden by a later matcher. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 471 | /// matching continues. A whitelist match can be overridden by a later matcher. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:473:5 [INFO] [stdout] | [INFO] [stdout] 473 | /// the path. As above, if it yields an ignore match, then all matching is [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 473 | /// the path. As above, if it yields an ignore match, then all matching is [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:474:5 [INFO] [stdout] | [INFO] [stdout] 474 | /// stopped and the path is skipped. If it yields a whitelist match, then [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 474 | /// stopped and the path is skipped. If it yields a whitelist match, then [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:475:5 [INFO] [stdout] | [INFO] [stdout] 475 | /// matching continues. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 475 | /// matching continues. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:477:5 [INFO] [stdout] | [INFO] [stdout] 477 | /// path is skipped. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 477 | /// path is skipped. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:479:5 [INFO] [stdout] | [INFO] [stdout] 479 | /// against the max filesize limit. If it exceeds the limit, it is skipped. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 479 | /// against the max filesize limit. If it exceeds the limit, it is skipped. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/ignore/src/walk.rs:481:5 [INFO] [stdout] | [INFO] [stdout] 481 | /// iterator. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 481 | /// iterator. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/ignore/src/walk.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 511 | ByName(Arc Ordering + Send + Sync + 'static>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/ignore/src/walk.rs:512:12 [INFO] [stdout] | [INFO] [stdout] 512 | ByPath(Arc Ordering + Send + Sync + 'static>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking grep v0.4.1 (/opt/rustwide/workdir/crates/grep) [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/printer/src/hyperlink/mod.rs:495:43 [INFO] [stdout] | [INFO] [stdout] 495 | let is_valid_scheme_char = |byte| match byte { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 496 | | b'0'..=b'9' | b'A'..=b'Z' | b'a'..=b'z' | b'+' | b'-' | b'.' => { [INFO] [stdout] 497 | | true [INFO] [stdout] ... | [INFO] [stdout] 500 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 495 - let is_valid_scheme_char = |byte| match byte { [INFO] [stdout] 496 - b'0'..=b'9' | b'A'..=b'Z' | b'a'..=b'z' | b'+' | b'-' | b'.' => { [INFO] [stdout] 497 - true [INFO] [stdout] 498 - } [INFO] [stdout] 499 - _ => false, [INFO] [stdout] 500 - }; [INFO] [stdout] 495 + let is_valid_scheme_char = |byte| matches!(byte, b'0'..=b'9' | b'A'..=b'Z' | b'a'..=b'z' | b'+' | b'-' | b'.'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.max_filesize` after checking its variant with `is_some` [INFO] [stdout] --> crates/ignore/src/walk.rs:1080:17 [INFO] [stdout] | [INFO] [stdout] 1078 | if self.max_filesize.is_some() && !ent.is_dir() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] 1079 | return Ok(skip_filesize( [INFO] [stdout] 1080 | self.max_filesize.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/walk.rs:1073:9 [INFO] [stdout] | [INFO] [stdout] 1073 | / if let Some(ref stdout) = self.skip { [INFO] [stdout] 1074 | | if path_equals(ent, stdout)? { [INFO] [stdout] 1075 | | return Ok(true); [INFO] [stdout] 1076 | | } [INFO] [stdout] 1077 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1073 ~ if let Some(ref stdout) = self.skip [INFO] [stdout] 1074 ~ && path_equals(ent, stdout)? { [INFO] [stdout] 1075 | return Ok(true); [INFO] [stdout] 1076 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/walk.rs:1085:9 [INFO] [stdout] | [INFO] [stdout] 1085 | / if let Some(Filter(filter)) = &self.filter { [INFO] [stdout] 1086 | | if !filter(ent) { [INFO] [stdout] 1087 | | return Ok(true); [INFO] [stdout] 1088 | | } [INFO] [stdout] 1089 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1085 ~ if let Some(Filter(filter)) = &self.filter [INFO] [stdout] 1086 ~ && !filter(ent) { [INFO] [stdout] 1087 | return Ok(true); [INFO] [stdout] 1088 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> crates/printer/src/hyperlink/mod.rs:947:30 [INFO] [stdout] | [INFO] [stdout] 947 | HYPERLINK_PATTERN_ALIASES.iter().cloned().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/ignore/src/walk.rs:1261:6 [INFO] [stdout] | [INFO] [stdout] 1261 | impl<'a, 's, P: ParallelVisitorBuilder<'s>> ParallelVisitorBuilder<'s> [INFO] [stdout] | ^^ [INFO] [stdout] 1262 | for &'a mut P [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1261 ~ impl<'s, P: ParallelVisitorBuilder<'s>> ParallelVisitorBuilder<'s> [INFO] [stdout] 1262 ~ for &mut P [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/walk.rs:1474:9 [INFO] [stdout] | [INFO] [stdout] 1474 | self.dent.file_type().map_or(false, |ft| ft.is_symlink()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1474 - self.dent.file_type().map_or(false, |ft| ft.is_symlink()) [INFO] [stdout] 1474 + self.dent.file_type().is_some_and(|ft| ft.is_symlink()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/walk.rs:1701:12 [INFO] [stdout] | [INFO] [stdout] 1701 | if self.max_depth.map_or(false, |max| depth >= max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1701 - if self.max_depth.map_or(false, |max| depth >= max) { [INFO] [stdout] 1701 + if self.max_depth.is_some_and(|max| depth >= max) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.max_filesize` after checking its variant with `is_some` [INFO] [stdout] --> crates/ignore/src/walk.rs:1784:21 [INFO] [stdout] | [INFO] [stdout] 1782 | if self.max_filesize.is_some() && !dent.is_dir() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] 1783 | skip_filesize( [INFO] [stdout] 1784 | self.max_filesize.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/walk.rs:1752:26 [INFO] [stdout] | [INFO] [stdout] 1752 | let is_symlink = dent.file_type().map_or(false, |ft| ft.is_symlink()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1752 - let is_symlink = dent.file_type().map_or(false, |ft| ft.is_symlink()); [INFO] [stdout] 1752 + let is_symlink = dent.file_type().is_some_and(|ft| ft.is_symlink()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/ignore/src/walk.rs:1761:13 [INFO] [stdout] | [INFO] [stdout] 1761 | / if dent.is_dir() { [INFO] [stdout] 1762 | | if let Err(err) = check_symlink_loop(ig, dent.path(), depth) { [INFO] [stdout] 1763 | | return self.visitor.visit(Err(err)); [INFO] [stdout] 1764 | | } [INFO] [stdout] 1765 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1761 ~ if dent.is_dir() [INFO] [stdout] 1762 ~ && let Err(err) = check_symlink_loop(ig, dent.path(), depth) { [INFO] [stdout] 1763 | return self.visitor.visit(Err(err)); [INFO] [stdout] 1764 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JSONBuilder` [INFO] [stdout] --> crates/printer/src/json.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | / pub fn new() -> JSONBuilder { [INFO] [stdout] 61 | | JSONBuilder { config: Config::default() } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for JSONBuilder { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> crates/ignore/src/walk.rs:1922:20 [INFO] [stdout] | [INFO] [stdout] 1922 | let filesize = match *ent { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1923 | | Some(ref md) => Some(md.len()), [INFO] [stdout] 1924 | | None => None, [INFO] [stdout] 1925 | | }; [INFO] [stdout] | |_____^ help: try: `(*ent).as_ref().map(|md| md.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/ignore/src/walk.rs:2013:5 [INFO] [stdout] | [INFO] [stdout] 2013 | dent.path().metadata().ok().map_or(false, |md| md.file_type().is_dir()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 2013 - dent.path().metadata().ok().map_or(false, |md| md.file_type().is_dir()) [INFO] [stdout] 2013 + dent.path().metadata().ok().is_some_and(|md| md.file_type().is_dir()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/json.rs:588:5 [INFO] [stdout] | [INFO] [stdout] 588 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 588 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/json.rs:590:5 [INFO] [stdout] | [INFO] [stdout] 590 | /// borrows. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 590 | /// borrows. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/json.rs:592:5 [INFO] [stdout] | [INFO] [stdout] 592 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 592 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/json.rs:594:5 [INFO] [stdout] | [INFO] [stdout] 594 | /// output to. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 594 | /// output to. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> crates/printer/src/json.rs:695:66 [INFO] [stdout] | [INFO] [stdout] 695 | (*self.json.config.replacement).as_ref().map(|r| &*r).unwrap(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 695 - (*self.json.config.replacement).as_ref().map(|r| &*r).unwrap(); [INFO] [stdout] 695 + (*self.json.config.replacement).as_ref().map(|r| r).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 695 | (*self.json.config.replacement).as_ref().map(|r| &**r).unwrap(); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/ignore/src/walk.rs:2175:44 [INFO] [stdout] | [INFO] [stdout] 2175 | builder.add_custom_ignore_filename(&custom_ignore); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `custom_ignore` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/ignore/src/walk.rs:2195:44 [INFO] [stdout] | [INFO] [stdout] 2195 | builder.add_custom_ignore_filename(&custom_ignore); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `custom_ignore` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/json.rs:790:9 [INFO] [stdout] | [INFO] [stdout] 790 | / if searcher.binary_detection().quit_byte().is_some() { [INFO] [stdout] 791 | | if let Some(ref path) = self.path { [INFO] [stdout] 792 | | log::debug!( [INFO] [stdout] 793 | | "ignoring {path}: found binary data at \ [INFO] [stdout] ... | [INFO] [stdout] 798 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 790 ~ if searcher.binary_detection().quit_byte().is_some() [INFO] [stdout] 791 ~ && let Some(ref path) = self.path { [INFO] [stdout] 792 | log::debug!( [INFO] [stdout] ... [INFO] [stdout] 796 | ); [INFO] [stdout] 797 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/printer/src/json.rs:791:25 [INFO] [stdout] | [INFO] [stdout] 791 | if let Some(ref path) = self.path { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 791 - if let Some(ref path) = self.path { [INFO] [stdout] 791 + if let Some(path) = self.path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/walk.rs:2309:13 [INFO] [stdout] | [INFO] [stdout] 2309 | &builder.min_depth(Some(0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `builder.min_depth(Some(0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/walk.rs:2314:13 [INFO] [stdout] | [INFO] [stdout] 2314 | &builder.min_depth(Some(1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `builder.min_depth(Some(1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/walk.rs:2382:13 [INFO] [stdout] | [INFO] [stdout] 2382 | &builder.follow_links(true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `builder.follow_links(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `walk::Walk` [INFO] [stdout] --> crates/ignore/src/walk.rs:2393:21 [INFO] [stdout] | [INFO] [stdout] 2393 | let dents = WalkBuilder::new(td.path().join("foo")) [INFO] [stdout] | _____________________^ [INFO] [stdout] 2394 | | .build() [INFO] [stdout] 2395 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 2393 ~ let dents = WalkBuilder::new(td.path().join("foo")) [INFO] [stdout] 2394 + .build() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/walk.rs:2417:33 [INFO] [stdout] | [INFO] [stdout] 2417 | assert_paths(td.path(), &builder.follow_links(true), &["a", "a/b"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `builder.follow_links(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/ignore/src/walk.rs:2464:25 [INFO] [stdout] | [INFO] [stdout] 2464 | if fs::read_dir(&dir_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/ignore/src/walk.rs:2469:40 [INFO] [stdout] | [INFO] [stdout] 2469 | let builder = WalkBuilder::new(&dir_path); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/ignore/src/walk.rs:2489:13 [INFO] [stdout] | [INFO] [stdout] 2489 | / &WalkBuilder::new(td.path()) [INFO] [stdout] 2490 | | .filter_entry(|entry| entry.file_name() != OsStr::new("a")), [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 2489 ~ WalkBuilder::new(td.path()) [INFO] [stdout] 2490 ~ .filter_entry(|entry| entry.file_name() != OsStr::new("a")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> crates/printer/src/jsont.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | while let Some(chunk) = it.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for chunk in it.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> crates/printer/src/jsont.rs:244:22 [INFO] [stdout] | [INFO] [stdout] 244 | let index4 = (group24 >> 0) & 0b111_111; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider reducing it to: `group24` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> crates/printer/src/jsont.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | / match it.remainder() { [INFO] [stdout] 251 | | &[] => {} [INFO] [stdout] 252 | | &[byte0] => { [INFO] [stdout] 253 | | let group8 = usize::from(byte0); [INFO] [stdout] ... | [INFO] [stdout] 271 | | _ => unreachable!("remainder must have length < 3"), [INFO] [stdout] 272 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 250 ~ match *it.remainder() { [INFO] [stdout] 251 ~ [] => {} [INFO] [stdout] 252 ~ [byte0] => { [INFO] [stdout] 253 | let group8 = usize::from(byte0); [INFO] [stdout] ... [INFO] [stdout] 260 | } [INFO] [stdout] 261 ~ [byte0, byte1] => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PathPrinterBuilder` [INFO] [stdout] --> crates/printer/src/path.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / pub fn new() -> PathPrinterBuilder { [INFO] [stdout] 40 | | PathPrinterBuilder { config: Config::default() } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for PathPrinterBuilder { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/path.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | /// with the other printers in this crate. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 138 | /// with the other printers in this crate. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/path.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | /// with the other printers in this crate. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 140 | /// with the other printers in this crate. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> crates/printer/src/path.rs:151:38 [INFO] [stdout] | [INFO] [stdout] 151 | let ppath = PrinterPath::new(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:542:31 [INFO] [stdout] | [INFO] [stdout] 542 | matched!(match1, types(), vec!["rust"], vec![], "lib.rs"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:542:45 [INFO] [stdout] | [INFO] [stdout] 542 | matched!(match1, types(), vec!["rust"], vec![], "lib.rs"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:543:31 [INFO] [stdout] | [INFO] [stdout] 543 | matched!(match2, types(), vec!["html"], vec![], "index.html"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["html"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:543:45 [INFO] [stdout] | [INFO] [stdout] 543 | matched!(match2, types(), vec!["html"], vec![], "index.html"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:544:31 [INFO] [stdout] | [INFO] [stdout] 544 | matched!(match3, types(), vec!["html"], vec![], "index.htm"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["html"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:544:45 [INFO] [stdout] | [INFO] [stdout] 544 | matched!(match3, types(), vec!["html"], vec![], "index.htm"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:545:31 [INFO] [stdout] | [INFO] [stdout] 545 | matched!(match4, types(), vec!["html", "rust"], vec![], "main.rs"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["html", "rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:545:53 [INFO] [stdout] | [INFO] [stdout] 545 | matched!(match4, types(), vec!["html", "rust"], vec![], "main.rs"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:546:31 [INFO] [stdout] | [INFO] [stdout] 546 | matched!(match5, types(), vec![], vec![], "index.html"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:546:39 [INFO] [stdout] | [INFO] [stdout] 546 | matched!(match5, types(), vec![], vec![], "index.html"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:547:31 [INFO] [stdout] | [INFO] [stdout] 547 | matched!(match6, types(), vec![], vec!["rust"], "index.html"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:547:39 [INFO] [stdout] | [INFO] [stdout] 547 | matched!(match6, types(), vec![], vec!["rust"], "index.html"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:548:31 [INFO] [stdout] | [INFO] [stdout] 548 | matched!(match7, types(), vec!["foo"], vec!["rust"], "main.foo"); [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `["foo"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:548:44 [INFO] [stdout] | [INFO] [stdout] 548 | matched!(match7, types(), vec!["foo"], vec!["rust"], "main.foo"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:549:31 [INFO] [stdout] | [INFO] [stdout] 549 | matched!(match8, types(), vec!["combo"], vec![], "index.html"); [INFO] [stdout] | ^^^^^^^^^^^^^ help: you can use an array directly: `["combo"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:549:46 [INFO] [stdout] | [INFO] [stdout] 549 | matched!(match8, types(), vec!["combo"], vec![], "index.html"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:550:31 [INFO] [stdout] | [INFO] [stdout] 550 | matched!(match9, types(), vec!["combo"], vec![], "lib.rs"); [INFO] [stdout] | ^^^^^^^^^^^^^ help: you can use an array directly: `["combo"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:550:46 [INFO] [stdout] | [INFO] [stdout] 550 | matched!(match9, types(), vec!["combo"], vec![], "lib.rs"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:551:32 [INFO] [stdout] | [INFO] [stdout] 551 | matched!(match10, types(), vec!["py"], vec![], "main.py"); [INFO] [stdout] | ^^^^^^^^^^ help: you can use an array directly: `["py"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:551:44 [INFO] [stdout] | [INFO] [stdout] 551 | matched!(match10, types(), vec!["py"], vec![], "main.py"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:552:32 [INFO] [stdout] | [INFO] [stdout] 552 | matched!(match11, types(), vec!["python"], vec![], "main.py"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use an array directly: `["python"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:552:48 [INFO] [stdout] | [INFO] [stdout] 552 | matched!(match11, types(), vec!["python"], vec![], "main.py"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:554:39 [INFO] [stdout] | [INFO] [stdout] 554 | matched!(not, matchnot1, types(), vec!["rust"], vec![], "index.html"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:554:53 [INFO] [stdout] | [INFO] [stdout] 554 | matched!(not, matchnot1, types(), vec!["rust"], vec![], "index.html"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `StandardBuilder` [INFO] [stdout] --> crates/printer/src/standard.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | / pub fn new() -> StandardBuilder { [INFO] [stdout] 106 | | StandardBuilder { config: Config::default() } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 103 + impl Default for StandardBuilder { [INFO] [stdout] 104 + fn default() -> Self { [INFO] [stdout] 105 + Self::new() [INFO] [stdout] 106 + } [INFO] [stdout] 107 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:555:39 [INFO] [stdout] | [INFO] [stdout] 555 | matched!(not, matchnot2, types(), vec![], vec!["rust"], "main.rs"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:555:47 [INFO] [stdout] | [INFO] [stdout] 555 | matched!(not, matchnot2, types(), vec![], vec!["rust"], "main.rs"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:556:39 [INFO] [stdout] | [INFO] [stdout] 556 | matched!(not, matchnot3, types(), vec!["foo"], vec!["rust"], "main.rs"); [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `["foo"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:556:52 [INFO] [stdout] | [INFO] [stdout] 556 | matched!(not, matchnot3, types(), vec!["foo"], vec!["rust"], "main.rs"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:557:39 [INFO] [stdout] | [INFO] [stdout] 557 | matched!(not, matchnot4, types(), vec!["rust"], vec!["foo"], "main.rs"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:557:53 [INFO] [stdout] | [INFO] [stdout] 557 | matched!(not, matchnot4, types(), vec!["rust"], vec!["foo"], "main.rs"); [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `["foo"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:558:39 [INFO] [stdout] | [INFO] [stdout] 558 | matched!(not, matchnot5, types(), vec!["rust"], vec!["foo"], "main.foo"); [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `["rust"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:558:53 [INFO] [stdout] | [INFO] [stdout] 558 | matched!(not, matchnot5, types(), vec!["rust"], vec!["foo"], "main.foo"); [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `["foo"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:559:39 [INFO] [stdout] | [INFO] [stdout] 559 | matched!(not, matchnot6, types(), vec!["combo"], vec![], "leftpad.js"); [INFO] [stdout] | ^^^^^^^^^^^^^ help: you can use an array directly: `["combo"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:559:54 [INFO] [stdout] | [INFO] [stdout] 559 | matched!(not, matchnot6, types(), vec!["combo"], vec![], "leftpad.js"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:560:39 [INFO] [stdout] | [INFO] [stdout] 560 | matched!(not, matchnot7, types(), vec!["py"], vec![], "index.html"); [INFO] [stdout] | ^^^^^^^^^^ help: you can use an array directly: `["py"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:560:51 [INFO] [stdout] | [INFO] [stdout] 560 | matched!(not, matchnot7, types(), vec!["py"], vec![], "index.html"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:561:39 [INFO] [stdout] | [INFO] [stdout] 561 | matched!(not, matchnot8, types(), vec!["python"], vec![], "doc.md"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use an array directly: `["python"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/ignore/src/types.rs:561:55 [INFO] [stdout] | [INFO] [stdout] 561 | matched!(not, matchnot8, types(), vec!["python"], vec![], "doc.md"); [INFO] [stdout] | ^^^^^^ help: you can use an array directly: `[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/standard.rs:631:5 [INFO] [stdout] | [INFO] [stdout] 631 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 631 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/standard.rs:633:5 [INFO] [stdout] | [INFO] [stdout] 633 | /// borrows. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 633 | /// borrows. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/standard.rs:635:5 [INFO] [stdout] | [INFO] [stdout] 635 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 635 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/standard.rs:637:5 [INFO] [stdout] | [INFO] [stdout] 637 | /// output to. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 637 | /// output to. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/standard.rs:784:9 [INFO] [stdout] | [INFO] [stdout] 784 | / if searcher.binary_detection().convert_byte().is_some() { [INFO] [stdout] 785 | | if self.binary_byte_offset.is_some() { [INFO] [stdout] 786 | | return Ok(false); [INFO] [stdout] 787 | | } [INFO] [stdout] 788 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 784 ~ if searcher.binary_detection().convert_byte().is_some() [INFO] [stdout] 785 ~ && self.binary_byte_offset.is_some() { [INFO] [stdout] 786 | return Ok(false); [INFO] [stdout] 787 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/standard.rs:805:9 [INFO] [stdout] | [INFO] [stdout] 805 | / if searcher.binary_detection().convert_byte().is_some() { [INFO] [stdout] 806 | | if self.binary_byte_offset.is_some() { [INFO] [stdout] 807 | | return Ok(false); [INFO] [stdout] 808 | | } [INFO] [stdout] 809 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 805 ~ if searcher.binary_detection().convert_byte().is_some() [INFO] [stdout] 806 ~ && self.binary_byte_offset.is_some() { [INFO] [stdout] 807 | return Ok(false); [INFO] [stdout] 808 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/standard.rs:828:9 [INFO] [stdout] | [INFO] [stdout] 828 | / if searcher.binary_detection().quit_byte().is_some() { [INFO] [stdout] 829 | | if let Some(ref path) = self.path { [INFO] [stdout] 830 | | log::debug!( [INFO] [stdout] 831 | | "ignoring {path}: found binary data at \ [INFO] [stdout] ... | [INFO] [stdout] 836 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 828 ~ if searcher.binary_detection().quit_byte().is_some() [INFO] [stdout] 829 ~ && let Some(ref path) = self.path { [INFO] [stdout] 830 | log::debug!( [INFO] [stdout] ... [INFO] [stdout] 834 | ); [INFO] [stdout] 835 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/printer/src/standard.rs:1524:30 [INFO] [stdout] | [INFO] [stdout] 1524 | trim_line_terminator(&self.searcher, buf, line); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.searcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/printer/src/standard.rs:1563:9 [INFO] [stdout] | [INFO] [stdout] 1563 | self.config().max_columns.map_or(false, |m| line.len() as u64 > m) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1563 - self.config().max_columns.map_or(false, |m| line.len() as u64 > m) [INFO] [stdout] 1563 + self.config().max_columns.is_some_and(|m| line.len() as u64 > m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/grep/examples/simplegrep.rs:33:50 [INFO] [stdout] | [INFO] [stdout] 33 | let matcher = RegexMatcher::new_line_matcher(&pattern)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `pattern` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | if crate::messages::messages() { [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | crate::messages::set_errored(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 94 | if crate::messages::messages() && crate::messages::ignore_messages() { [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/mod.rs:5:20 [INFO] [stdout] | [INFO] [stdout] 5 | static ENCODINGS: &'static str = include_str!("encodings.sh"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE_FULL: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:45:23 [INFO] [stdout] | [INFO] [stdout] 45 | const TEMPLATE_CASE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:52:31 [INFO] [stdout] | [INFO] [stdout] 52 | const TEMPLATE_CASE_CHOICES: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/fish.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE: &'static str = "complete -c rg !SHORT! -l !LONG! -d '!DOC!'"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/fish.rs:8:26 [INFO] [stdout] | [INFO] [stdout] 8 | const TEMPLATE_NEGATED: &'static str = "complete -c rg -l !NEGATED! -n '__rg_contains_opt !LONG! !SHORT!' -d '!DOC!'\n"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 37 | const TEMPLATE_FLAG: &'static str = "[CompletionResult]::new('!DASH_NAME!', '!NAME!', [CompletionResultType]::ParameterName, '!DOC!')"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/help.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | const TEMPLATE_SHORT: &'static str = include_str!("template.short.help"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/help.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | const TEMPLATE_LONG: &'static str = include_str!("template.long.help"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/man.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | const TEMPLATE: &'static str = include_str!("template.rg.1"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/logger.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | const LOGGER: &'static Logger = &Logger(()); [INFO] [stdout] | -^^^^^^^------- help: consider removing `'static`: `&Logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SummaryBuilder` [INFO] [stdout] --> crates/printer/src/summary.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | / pub fn new() -> SummaryBuilder { [INFO] [stdout] 154 | | SummaryBuilder { config: Config::default() } [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 151 + impl Default for SummaryBuilder { [INFO] [stdout] 152 + fn default() -> Self { [INFO] [stdout] 153 + Self::new() [INFO] [stdout] 154 + } [INFO] [stdout] 155 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/summary.rs:476:5 [INFO] [stdout] | [INFO] [stdout] 476 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 476 | /// no file path is given, then this is `'static`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/summary.rs:478:5 [INFO] [stdout] | [INFO] [stdout] 478 | /// borrows. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 478 | /// borrows. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/summary.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 480 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 480 | /// `grep_searcher::Searcher` that is reporting results to this sink. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/printer/src/summary.rs:482:5 [INFO] [stdout] | [INFO] [stdout] 482 | /// output to. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 482 | /// output to. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/printer/src/summary.rs:684:9 [INFO] [stdout] | [INFO] [stdout] 684 | / if searcher.binary_detection().quit_byte().is_some() { [INFO] [stdout] 685 | | if let Some(ref path) = self.path { [INFO] [stdout] 686 | | log::debug!( [INFO] [stdout] 687 | | "ignoring {path}: found binary data at \ [INFO] [stdout] ... | [INFO] [stdout] 692 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 684 ~ if searcher.binary_detection().quit_byte().is_some() [INFO] [stdout] 685 ~ && let Some(ref path) = self.path { [INFO] [stdout] 686 | log::debug!( [INFO] [stdout] ... [INFO] [stdout] 690 | ); [INFO] [stdout] 691 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/printer/src/util.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn replace_all<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] 52 | &'a mut self, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 51 ~ pub(crate) fn replace_all( [INFO] [stdout] 52 ~ &mut self, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/printer/src/util.rs:61:62 [INFO] [stdout] | [INFO] [stdout] 61 | let is_multi_line = searcher.multi_line_with_matcher(&matcher); [INFO] [stdout] | ^^^^^^^^ help: change this to: `matcher` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> crates/printer/src/util.rs:115:31 [INFO] [stdout] | [INFO] [stdout] 115 | pub(crate) fn replacement<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] 116 | &'a self, [INFO] [stdout] | ^^ [INFO] [stdout] 117 | ) -> Option<(&'a [u8], &'a [Match])> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 115 ~ pub(crate) fn replacement( [INFO] [stdout] 116 ~ &self, [INFO] [stdout] 117 ~ ) -> Option<(&[u8], &[Match])> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> crates/printer/src/util.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 458 | / match b { [INFO] [stdout] 459 | | b'\t' | b'\n' | b'\x0B' | b'\x0C' | b'\r' | b' ' => true, [INFO] [stdout] 460 | | _ => false, [INFO] [stdout] 461 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 458 - match b { [INFO] [stdout] 459 - b'\t' | b'\n' | b'\x0B' | b'\x0C' | b'\r' | b' ' => true, [INFO] [stdout] 460 - _ => false, [INFO] [stdout] 461 - } [INFO] [stdout] 458 + matches!(b, b'\t' | b'\n' | b'\x0B' | b'\x0C' | b'\r' | b' ') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> tests/macros.rs:6:30 [INFO] [stdout] | [INFO] [stdout] 6 | let (dir, cmd) = crate::util::setup(stringify!($name)); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/hay.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | pub const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/hay.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | pub const SHERLOCK_CRLF: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> tests/util.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | static TEST_DIR: &'static str = "ripgrep-tests"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | if crate::messages::messages() { [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | crate::messages::set_errored(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 94 | if crate::messages::messages() && crate::messages::ignore_messages() { [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/binary.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | const HAY: &'static [u8] = include_bytes!("./data/sherlock-nul.txt"); [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/mod.rs:5:20 [INFO] [stdout] | [INFO] [stdout] 5 | static ENCODINGS: &'static str = include_str!("encodings.sh"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE_FULL: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:45:23 [INFO] [stdout] | [INFO] [stdout] 45 | const TEMPLATE_CASE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:52:31 [INFO] [stdout] | [INFO] [stdout] 52 | const TEMPLATE_CASE_CHOICES: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/fish.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE: &'static str = "complete -c rg !SHORT! -l !LONG! -d '!DOC!'"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/fish.rs:8:26 [INFO] [stdout] | [INFO] [stdout] 8 | const TEMPLATE_NEGATED: &'static str = "complete -c rg -l !NEGATED! -n '__rg_contains_opt !LONG! !SHORT!' -d '!DOC!'\n"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 37 | const TEMPLATE_FLAG: &'static str = "[CompletionResult]::new('!DASH_NAME!', '!NAME!', [CompletionResultType]::ParameterName, '!DOC!')"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/feature.rs:623:22 [INFO] [stdout] | [INFO] [stdout] 623 | const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/feature.rs:649:22 [INFO] [stdout] | [INFO] [stdout] 649 | const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/help.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | const TEMPLATE_SHORT: &'static str = include_str!("template.short.help"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/help.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | const TEMPLATE_LONG: &'static str = include_str!("template.long.help"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/man.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | const TEMPLATE: &'static str = include_str!("template.rg.1"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/logger.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | const LOGGER: &'static Logger = &Logger(()); [INFO] [stdout] | -^^^^^^^------- help: consider removing `'static`: `&Logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | .replace("!LONG!", &long) [INFO] [stdout] | ^^^^^ help: change this to: `long` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/core/flags/complete/fish.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | completion.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `completion.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/core/flags/complete/fish.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | completion.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `completion.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:67:43 [INFO] [stdout] | [INFO] [stdout] 67 | .replace("!NEGATED!", &negated) [INFO] [stdout] | ^^^^^^^^ help: change this to: `negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:69:40 [INFO] [stdout] | [INFO] [stdout] 69 | .replace("!LONG!", &long) [INFO] [stdout] | ^^^^^ help: change this to: `long` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:57:36 [INFO] [stdout] | [INFO] [stdout] 57 | .replace("!NAME!", &name) [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:79:40 [INFO] [stdout] | [INFO] [stdout] 79 | .replace("!NAME!", &negated) [INFO] [stdout] | ^^^^^^^^ help: change this to: `negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | Namely, the zsh completions take application level context about flag [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 9 | Namely, the zsh completions take application level context about flag [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | compatibility into account. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | compatibility into account. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | isn't included in the zsh completions. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 12 | isn't included in the zsh completions. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | works and how it can be extended. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 14 | works and how it can be extended. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/core/flags/config.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | match std::fs::File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/core/flags/defs.rs:3038:9 [INFO] [stdout] | [INFO] [stdout] 3038 | &*BORROWED [INFO] [stdout] | ^^^^^^^^^^ help: try: `&BORROWED` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/flags/defs.rs:3436:8 [INFO] [stdout] | [INFO] [stdout] 3436 | struct JSON; [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/doc/help.rs:118:34 [INFO] [stdout] | [INFO] [stdout] 118 | generate_long_flag(flag, &mut cat); [INFO] [stdout] | ^^^^^^^^ help: change this to: `cat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/core/flags/doc/help.rs:229:28 [INFO] [stdout] | [INFO] [stdout] 229 | lines.push(format!("{item_label}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `item_label.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/core/flags/doc/help.rs:236:28 [INFO] [stdout] | [INFO] [stdout] 236 | lines.push(format!("{pieces}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `pieces.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/doc/man.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | generate_flag(flag, &mut cat); [INFO] [stdout] | ^^^^^^^^ help: change this to: `cat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/core/flags/hiargs.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | / match low.mode { [INFO] [stdout] 128 | | Mode::Search(ref mut mode) => match *mode { [INFO] [stdout] 129 | | // treat `-v --count-matches` as `-v --count` [INFO] [stdout] 130 | | SearchMode::CountMatches if low.invert_match => { [INFO] [stdout] ... | [INFO] [stdout] 139 | | _ => {} [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 127 ~ if let Mode::Search(ref mut mode) = low.mode { match *mode { [INFO] [stdout] 128 + // treat `-v --count-matches` as `-v --count` [INFO] [stdout] 129 + SearchMode::CountMatches if low.invert_match => { [INFO] [stdout] 130 + *mode = SearchMode::Count; [INFO] [stdout] 131 + } [INFO] [stdout] 132 + // treat `-o --count` as `--count-matches` [INFO] [stdout] 133 + SearchMode::Count if low.only_matching => { [INFO] [stdout] 134 + *mode = SearchMode::CountMatches; [INFO] [stdout] 135 + } [INFO] [stdout] 136 + _ => {} [INFO] [stdout] 137 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> crates/core/flags/hiargs.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | let with_filename = low [INFO] [stdout] | _____________________________^ [INFO] [stdout] 177 | | .with_filename [INFO] [stdout] 178 | | .unwrap_or_else(|| low.vimgrep || !paths.is_one_file); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 178 - .unwrap_or_else(|| low.vimgrep || !paths.is_one_file); [INFO] [stdout] 178 + .unwrap_or(low.vimgrep || !paths.is_one_file); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/core/flags/hiargs.rs:207:47 [INFO] [stdout] | [INFO] [stdout] 207 | | SearchMode::CountMatches => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - | SearchMode::CountMatches => return false, [INFO] [stdout] 207 + | SearchMode::CountMatches => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/core/flags/hiargs.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | SearchMode::JSON => return true, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - SearchMode::JSON => return true, [INFO] [stdout] 208 + SearchMode::JSON => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:552:24 [INFO] [stdout] | [INFO] [stdout] 552 | .separator(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:623:30 [INFO] [stdout] | [INFO] [stdout] 623 | .path_terminator(self.path_terminator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_terminator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:634:29 [INFO] [stdout] | [INFO] [stdout] 634 | .separator_path(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:661:30 [INFO] [stdout] | [INFO] [stdout] 661 | .path_terminator(self.path_terminator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_terminator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:663:29 [INFO] [stdout] | [INFO] [stdout] 663 | .separator_path(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/core/flags/hiargs.rs:786:36 [INFO] [stdout] | [INFO] [stdout] 786 | haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 786 - haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] 786 + haystacks.sort_by(|h1, ref h2| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/core/flags/hiargs.rs:786:44 [INFO] [stdout] | [INFO] [stdout] 786 | haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 786 - haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] 786 + haystacks.sort_by(|ref h1, h2| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/hiargs.rs:1228:21 [INFO] [stdout] | [INFO] [stdout] 1228 | builder.add(&glob)?; [INFO] [stdout] | ^^^^^ help: change this to: `glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/flags/lowargs.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | JSON, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:254:1 [INFO] [stdout] | [INFO] [stdout] 254 | / impl Default for BinaryMode { [INFO] [stdout] 255 | | fn default() -> BinaryMode { [INFO] [stdout] 256 | | BinaryMode::Auto [INFO] [stdout] 257 | | } [INFO] [stdout] 258 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 233 + #[derive(Default)] [INFO] [stdout] 234 | pub(crate) enum BinaryMode { [INFO] [stdout] 235 | /// Automatically determine the binary mode to use. Essentially, when [INFO] [stdout] ... [INFO] [stdout] 239 | /// a file is classified as binary, searching will immediately stop. [INFO] [stdout] 240 ~ #[default] [INFO] [stdout] 241 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:290:1 [INFO] [stdout] | [INFO] [stdout] 290 | / impl Default for BufferMode { [INFO] [stdout] 291 | | fn default() -> BufferMode { [INFO] [stdout] 292 | | BufferMode::Auto [INFO] [stdout] 293 | | } [INFO] [stdout] 294 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 273 + #[derive(Default)] [INFO] [stdout] 274 | pub(crate) enum BufferMode { [INFO] [stdout] 275 | /// Select the buffer mode, 'line' or 'block', automatically based on [INFO] [stdout] 276 | /// whether stdout is connected to a tty. [INFO] [stdout] 277 ~ #[default] [INFO] [stdout] 278 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:311:1 [INFO] [stdout] | [INFO] [stdout] 311 | / impl Default for CaseMode { [INFO] [stdout] 312 | | fn default() -> CaseMode { [INFO] [stdout] 313 | | CaseMode::Sensitive [INFO] [stdout] 314 | | } [INFO] [stdout] 315 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 300 + #[derive(Default)] [INFO] [stdout] 301 | pub(crate) enum CaseMode { [INFO] [stdout] 302 | /// Patterns are matched case sensitively. i.e., `a` does not match `A`. [INFO] [stdout] 303 ~ #[default] [INFO] [stdout] 304 ~ Sensitive, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:338:1 [INFO] [stdout] | [INFO] [stdout] 338 | / impl Default for ColorChoice { [INFO] [stdout] 339 | | fn default() -> ColorChoice { [INFO] [stdout] 340 | | ColorChoice::Auto [INFO] [stdout] 341 | | } [INFO] [stdout] 342 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 321 + #[derive(Default)] [INFO] [stdout] 322 | pub(crate) enum ColorChoice { [INFO] [stdout] 323 | /// Color and hyperlinks will never be used. [INFO] [stdout] ... [INFO] [stdout] 326 | /// tty. [INFO] [stdout] 327 ~ #[default] [INFO] [stdout] 328 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | / impl Default for EncodingMode { [INFO] [stdout] 545 | | fn default() -> EncodingMode { [INFO] [stdout] 546 | | EncodingMode::Auto [INFO] [stdout] 547 | | } [INFO] [stdout] 548 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 533 + #[derive(Default)] [INFO] [stdout] 534 | pub(crate) enum EncodingMode { [INFO] [stdout] 535 | /// Use only BOM sniffing to auto-detect an encoding. [INFO] [stdout] 536 ~ #[default] [INFO] [stdout] 537 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:569:1 [INFO] [stdout] | [INFO] [stdout] 569 | / impl Default for EngineChoice { [INFO] [stdout] 570 | | fn default() -> EngineChoice { [INFO] [stdout] 571 | | EngineChoice::Default [INFO] [stdout] 572 | | } [INFO] [stdout] 573 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 554 + #[derive(Default)] [INFO] [stdout] 555 | pub(crate) enum EngineChoice { [INFO] [stdout] 556 | /// Uses the default regex engine: Rust's `regex` crate. [INFO] [stdout] ... [INFO] [stdout] 559 | /// the implementation of the `regex` crate.) [INFO] [stdout] 560 ~ #[default] [INFO] [stdout] 561 ~ Default, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:669:1 [INFO] [stdout] | [INFO] [stdout] 669 | / impl Default for MmapMode { [INFO] [stdout] 670 | | fn default() -> MmapMode { [INFO] [stdout] 671 | | MmapMode::Auto [INFO] [stdout] 672 | | } [INFO] [stdout] 673 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 655 + #[derive(Default)] [INFO] [stdout] 656 | pub(crate) enum MmapMode { [INFO] [stdout] 657 | /// This instructs ripgrep to use heuristics for selecting when to and not [INFO] [stdout] 658 | /// to use memory maps for searching. [INFO] [stdout] 659 ~ #[default] [INFO] [stdout] 660 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/core/flags/parse.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | if let Err(err) = parser.parse(final_args.into_iter(), &mut low) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> crates/core/flags/parse.rs:223:12 [INFO] [stdout] | [INFO] [stdout] 223 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 107 - if let Err(err) = parser.parse(final_args.into_iter(), &mut low) { [INFO] [stdout] 107 + if let Err(err) = parser.parse(final_args, &mut low) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:233:43 [INFO] [stdout] | [INFO] [stdout] 233 | lexopt::Arg::Short(ch) if ch == 'h' => { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - lexopt::Arg::Short(ch) if ch == 'h' => { [INFO] [stdout] 233 + lexopt::Arg::Short('h') => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:239:43 [INFO] [stdout] | [INFO] [stdout] 239 | lexopt::Arg::Short(ch) if ch == 'V' => { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 239 - lexopt::Arg::Short(ch) if ch == 'V' => { [INFO] [stdout] 239 + lexopt::Arg::Short('V') => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:246:44 [INFO] [stdout] | [INFO] [stdout] 246 | lexopt::Arg::Long(name) if name == "help" => { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 - lexopt::Arg::Long(name) if name == "help" => { [INFO] [stdout] 246 + lexopt::Arg::Long("help") => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:252:44 [INFO] [stdout] | [INFO] [stdout] 252 | lexopt::Arg::Long(name) if name == "version" => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 252 - lexopt::Arg::Long(name) if name == "version" => { [INFO] [stdout] 252 + lexopt::Arg::Long("version") => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/core/haystack.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | self.dent.file_type().map_or(false, |ft| ft.is_file()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 158 - self.dent.file_type().map_or(false, |ft| ft.is_file()) [INFO] [stdout] 158 + self.dent.file_type().is_some_and(|ft| ft.is_file()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/search.rs:210:5 [INFO] [stdout] | [INFO] [stdout] 210 | JSON(grep::printer::JSON), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/core/search.rs:285:12 [INFO] [stdout] | [INFO] [stdout] 285 | if !self.config.preprocessor.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.config.preprocessor.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/core/search.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | / io::Error::new( [INFO] [stdout] 308 | | io::ErrorKind::Other, [INFO] [stdout] 309 | | format!( [INFO] [stdout] 310 | | "preprocessor command could not start: '{cmd:?}': {err}", [INFO] [stdout] 311 | | ), [INFO] [stdout] 312 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 307 ~ io::Error::other( [INFO] [stdout] 308 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/core/search.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | / io::Error::new( [INFO] [stdout] 316 | | io::ErrorKind::Other, [INFO] [stdout] 317 | | format!("preprocessor command failed: '{cmd:?}': {err}"), [INFO] [stdout] 318 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 315 ~ io::Error::other( [INFO] [stdout] 316 ~ format!("preprocessor command failed: '{cmd:?}': {err}"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:392:24 [INFO] [stdout] | [INFO] [stdout] 392 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:400:24 [INFO] [stdout] | [INFO] [stdout] 400 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:429:24 [INFO] [stdout] | [INFO] [stdout] 429 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:437:24 [INFO] [stdout] | [INFO] [stdout] 437 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `print` doesn't need a mutable reference [INFO] [stdout] --> crates/core/main.rs:226:30 [INFO] [stdout] | [INFO] [stdout] 226 | let _ = bufwtr.print(&mut wtr); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 226 - let _ = bufwtr.print(&mut wtr); [INFO] [stdout] 226 + let _ = bufwtr.print(&wtr); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/main.rs:226:30 [INFO] [stdout] | [INFO] [stdout] 226 | let _ = bufwtr.print(&mut wtr); [INFO] [stdout] | ^^^^^^^^ help: change this to: `wtr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> crates/core/main.rs:459:9 [INFO] [stdout] | [INFO] [stdout] 459 | write!(wtr, "\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 459 - write!(wtr, "\n") [INFO] [stdout] 459 + writeln!(wtr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | .replace("!LONG!", &long) [INFO] [stdout] | ^^^^^ help: change this to: `long` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/core/flags/complete/fish.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | completion.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `completion.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/core/flags/complete/fish.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | completion.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `completion.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:67:43 [INFO] [stdout] | [INFO] [stdout] 67 | .replace("!NEGATED!", &negated) [INFO] [stdout] | ^^^^^^^^ help: change this to: `negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:69:40 [INFO] [stdout] | [INFO] [stdout] 69 | .replace("!LONG!", &long) [INFO] [stdout] | ^^^^^ help: change this to: `long` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:57:36 [INFO] [stdout] | [INFO] [stdout] 57 | .replace("!NAME!", &name) [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:79:40 [INFO] [stdout] | [INFO] [stdout] 79 | .replace("!NAME!", &negated) [INFO] [stdout] | ^^^^^^^^ help: change this to: `negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | Namely, the zsh completions take application level context about flag [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 9 | Namely, the zsh completions take application level context about flag [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | compatibility into account. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | compatibility into account. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | isn't included in the zsh completions. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 12 | isn't included in the zsh completions. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | works and how it can be extended. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 14 | works and how it can be extended. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/core/flags/config.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | match std::fs::File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:621:5 [INFO] [stdout] | [INFO] [stdout] 621 | assert_eq!(false, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 621 - assert_eq!(false, args.byte_offset); [INFO] [stdout] 621 + assert!(!args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:624:5 [INFO] [stdout] | [INFO] [stdout] 624 | assert_eq!(true, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 624 - assert_eq!(true, args.byte_offset); [INFO] [stdout] 624 + assert!(args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:627:5 [INFO] [stdout] | [INFO] [stdout] 627 | assert_eq!(true, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 627 - assert_eq!(true, args.byte_offset); [INFO] [stdout] 627 + assert!(args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:630:5 [INFO] [stdout] | [INFO] [stdout] 630 | assert_eq!(false, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 630 - assert_eq!(false, args.byte_offset); [INFO] [stdout] 630 + assert!(!args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:633:5 [INFO] [stdout] | [INFO] [stdout] 633 | assert_eq!(true, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 633 - assert_eq!(true, args.byte_offset); [INFO] [stdout] 633 + assert!(args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1431:5 [INFO] [stdout] | [INFO] [stdout] 1431 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1431 - assert_eq!(false, args.crlf); [INFO] [stdout] 1431 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1434:5 [INFO] [stdout] | [INFO] [stdout] 1434 | assert_eq!(true, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1434 - assert_eq!(true, args.crlf); [INFO] [stdout] 1434 + assert!(args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1435:5 [INFO] [stdout] | [INFO] [stdout] 1435 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1435 - assert_eq!(false, args.null_data); [INFO] [stdout] 1435 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1438:5 [INFO] [stdout] | [INFO] [stdout] 1438 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1438 - assert_eq!(false, args.crlf); [INFO] [stdout] 1438 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1439:5 [INFO] [stdout] | [INFO] [stdout] 1439 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1439 - assert_eq!(true, args.null_data); [INFO] [stdout] 1439 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1442:5 [INFO] [stdout] | [INFO] [stdout] 1442 | assert_eq!(true, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1442 - assert_eq!(true, args.crlf); [INFO] [stdout] 1442 + assert!(args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1443:5 [INFO] [stdout] | [INFO] [stdout] 1443 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1443 - assert_eq!(false, args.null_data); [INFO] [stdout] 1443 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1446:5 [INFO] [stdout] | [INFO] [stdout] 1446 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1446 - assert_eq!(false, args.crlf); [INFO] [stdout] 1446 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1447:5 [INFO] [stdout] | [INFO] [stdout] 1447 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1447 - assert_eq!(true, args.null_data); [INFO] [stdout] 1447 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1450:5 [INFO] [stdout] | [INFO] [stdout] 1450 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1450 - assert_eq!(false, args.crlf); [INFO] [stdout] 1450 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1451:5 [INFO] [stdout] | [INFO] [stdout] 1451 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1451 - assert_eq!(false, args.null_data); [INFO] [stdout] 1451 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2324:5 [INFO] [stdout] | [INFO] [stdout] 2324 | assert_eq!(false, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2324 - assert_eq!(false, args.fixed_strings); [INFO] [stdout] 2324 + assert!(!args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2327:5 [INFO] [stdout] | [INFO] [stdout] 2327 | assert_eq!(true, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2327 - assert_eq!(true, args.fixed_strings); [INFO] [stdout] 2327 + assert!(args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2330:5 [INFO] [stdout] | [INFO] [stdout] 2330 | assert_eq!(true, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2330 - assert_eq!(true, args.fixed_strings); [INFO] [stdout] 2330 + assert!(args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2333:5 [INFO] [stdout] | [INFO] [stdout] 2333 | assert_eq!(false, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2333 - assert_eq!(false, args.fixed_strings); [INFO] [stdout] 2333 + assert!(!args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2336:5 [INFO] [stdout] | [INFO] [stdout] 2336 | assert_eq!(true, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2336 - assert_eq!(true, args.fixed_strings); [INFO] [stdout] 2336 + assert!(args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2382:5 [INFO] [stdout] | [INFO] [stdout] 2382 | assert_eq!(false, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2382 - assert_eq!(false, args.follow); [INFO] [stdout] 2382 + assert!(!args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2385:5 [INFO] [stdout] | [INFO] [stdout] 2385 | assert_eq!(true, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2385 - assert_eq!(true, args.follow); [INFO] [stdout] 2385 + assert!(args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2388:5 [INFO] [stdout] | [INFO] [stdout] 2388 | assert_eq!(true, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2388 - assert_eq!(true, args.follow); [INFO] [stdout] 2388 + assert!(args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2391:5 [INFO] [stdout] | [INFO] [stdout] 2391 | assert_eq!(false, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2391 - assert_eq!(false, args.follow); [INFO] [stdout] 2391 + assert!(!args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2394:5 [INFO] [stdout] | [INFO] [stdout] 2394 | assert_eq!(true, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2394 - assert_eq!(true, args.follow); [INFO] [stdout] 2394 + assert!(args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2629:5 [INFO] [stdout] | [INFO] [stdout] 2629 | assert_eq!(false, args.glob_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2629 - assert_eq!(false, args.glob_case_insensitive); [INFO] [stdout] 2629 + assert!(!args.glob_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2632:5 [INFO] [stdout] | [INFO] [stdout] 2632 | assert_eq!(true, args.glob_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2632 - assert_eq!(true, args.glob_case_insensitive); [INFO] [stdout] 2632 + assert!(args.glob_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2639:5 [INFO] [stdout] | [INFO] [stdout] 2639 | assert_eq!(false, args.glob_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2639 - assert_eq!(false, args.glob_case_insensitive); [INFO] [stdout] 2639 + assert!(!args.glob_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2646:5 [INFO] [stdout] | [INFO] [stdout] 2646 | assert_eq!(true, args.glob_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2646 - assert_eq!(true, args.glob_case_insensitive); [INFO] [stdout] 2646 + assert!(args.glob_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2820:5 [INFO] [stdout] | [INFO] [stdout] 2820 | assert_eq!(false, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2820 - assert_eq!(false, args.hidden); [INFO] [stdout] 2820 + assert!(!args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2823:5 [INFO] [stdout] | [INFO] [stdout] 2823 | assert_eq!(true, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2823 - assert_eq!(true, args.hidden); [INFO] [stdout] 2823 + assert!(args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2826:5 [INFO] [stdout] | [INFO] [stdout] 2826 | assert_eq!(true, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2826 - assert_eq!(true, args.hidden); [INFO] [stdout] 2826 + assert!(args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2829:5 [INFO] [stdout] | [INFO] [stdout] 2829 | assert_eq!(false, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2829 - assert_eq!(false, args.hidden); [INFO] [stdout] 2829 + assert!(!args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2832:5 [INFO] [stdout] | [INFO] [stdout] 2832 | assert_eq!(true, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2832 - assert_eq!(true, args.hidden); [INFO] [stdout] 2832 + assert!(args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/core/flags/defs.rs:3038:9 [INFO] [stdout] | [INFO] [stdout] 3038 | &*BORROWED [INFO] [stdout] | ^^^^^^^^^^ help: try: `&BORROWED` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3308:5 [INFO] [stdout] | [INFO] [stdout] 3308 | assert_eq!(false, args.ignore_file_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3308 - assert_eq!(false, args.ignore_file_case_insensitive); [INFO] [stdout] 3308 + assert!(!args.ignore_file_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3311:5 [INFO] [stdout] | [INFO] [stdout] 3311 | assert_eq!(true, args.ignore_file_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3311 - assert_eq!(true, args.ignore_file_case_insensitive); [INFO] [stdout] 3311 + assert!(args.ignore_file_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3318:5 [INFO] [stdout] | [INFO] [stdout] 3318 | assert_eq!(false, args.ignore_file_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3318 - assert_eq!(false, args.ignore_file_case_insensitive); [INFO] [stdout] 3318 + assert!(!args.ignore_file_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3325:5 [INFO] [stdout] | [INFO] [stdout] 3325 | assert_eq!(true, args.ignore_file_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3325 - assert_eq!(true, args.ignore_file_case_insensitive); [INFO] [stdout] 3325 + assert!(args.ignore_file_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3367:5 [INFO] [stdout] | [INFO] [stdout] 3367 | assert_eq!(false, args.include_zero); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3367 - assert_eq!(false, args.include_zero); [INFO] [stdout] 3367 + assert!(!args.include_zero); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3370:5 [INFO] [stdout] | [INFO] [stdout] 3370 | assert_eq!(true, args.include_zero); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3370 - assert_eq!(true, args.include_zero); [INFO] [stdout] 3370 + assert!(args.include_zero); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3373:5 [INFO] [stdout] | [INFO] [stdout] 3373 | assert_eq!(false, args.include_zero); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3373 - assert_eq!(false, args.include_zero); [INFO] [stdout] 3373 + assert!(!args.include_zero); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3422:5 [INFO] [stdout] | [INFO] [stdout] 3422 | assert_eq!(false, args.invert_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3422 - assert_eq!(false, args.invert_match); [INFO] [stdout] 3422 + assert!(!args.invert_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3425:5 [INFO] [stdout] | [INFO] [stdout] 3425 | assert_eq!(true, args.invert_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3425 - assert_eq!(true, args.invert_match); [INFO] [stdout] 3425 + assert!(args.invert_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3428:5 [INFO] [stdout] | [INFO] [stdout] 3428 | assert_eq!(true, args.invert_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3428 - assert_eq!(true, args.invert_match); [INFO] [stdout] 3428 + assert!(args.invert_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3431:5 [INFO] [stdout] | [INFO] [stdout] 3431 | assert_eq!(false, args.invert_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3431 - assert_eq!(false, args.invert_match); [INFO] [stdout] 3431 + assert!(!args.invert_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/flags/defs.rs:3436:8 [INFO] [stdout] | [INFO] [stdout] 3436 | struct JSON; [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3861:5 [INFO] [stdout] | [INFO] [stdout] 3861 | assert_eq!(false, args.max_columns_preview); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3861 - assert_eq!(false, args.max_columns_preview); [INFO] [stdout] 3861 + assert!(!args.max_columns_preview); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3864:5 [INFO] [stdout] | [INFO] [stdout] 3864 | assert_eq!(true, args.max_columns_preview); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3864 - assert_eq!(true, args.max_columns_preview); [INFO] [stdout] 3864 + assert!(args.max_columns_preview); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3869:5 [INFO] [stdout] | [INFO] [stdout] 3869 | assert_eq!(false, args.max_columns_preview); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3869 - assert_eq!(false, args.max_columns_preview); [INFO] [stdout] 3869 + assert!(!args.max_columns_preview); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4200:5 [INFO] [stdout] | [INFO] [stdout] 4200 | assert_eq!(false, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4200 - assert_eq!(false, args.multiline); [INFO] [stdout] 4200 + assert!(!args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4203:5 [INFO] [stdout] | [INFO] [stdout] 4203 | assert_eq!(true, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4203 - assert_eq!(true, args.multiline); [INFO] [stdout] 4203 + assert!(args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4206:5 [INFO] [stdout] | [INFO] [stdout] 4206 | assert_eq!(true, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4206 - assert_eq!(true, args.multiline); [INFO] [stdout] 4206 + assert!(args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4209:5 [INFO] [stdout] | [INFO] [stdout] 4209 | assert_eq!(false, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4209 - assert_eq!(false, args.multiline); [INFO] [stdout] 4209 + assert!(!args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4264:5 [INFO] [stdout] | [INFO] [stdout] 4264 | assert_eq!(false, args.multiline_dotall); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4264 - assert_eq!(false, args.multiline_dotall); [INFO] [stdout] 4264 + assert!(!args.multiline_dotall); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4267:5 [INFO] [stdout] | [INFO] [stdout] 4267 | assert_eq!(true, args.multiline_dotall); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4267 - assert_eq!(true, args.multiline_dotall); [INFO] [stdout] 4267 + assert!(args.multiline_dotall); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4271:5 [INFO] [stdout] | [INFO] [stdout] 4271 | assert_eq!(false, args.multiline_dotall); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4271 - assert_eq!(false, args.multiline_dotall); [INFO] [stdout] 4271 + assert!(!args.multiline_dotall); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4313:5 [INFO] [stdout] | [INFO] [stdout] 4313 | assert_eq!(false, args.no_config); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4313 - assert_eq!(false, args.no_config); [INFO] [stdout] 4313 + assert!(!args.no_config); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4316:5 [INFO] [stdout] | [INFO] [stdout] 4316 | assert_eq!(true, args.no_config); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4316 - assert_eq!(true, args.no_config); [INFO] [stdout] 4316 + assert!(args.no_config); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4370:5 [INFO] [stdout] | [INFO] [stdout] 4370 | assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4370 - assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] 4370 + assert!(!args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4371:5 [INFO] [stdout] | [INFO] [stdout] 4371 | assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4371 - assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] 4371 + assert!(!args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4372:5 [INFO] [stdout] | [INFO] [stdout] 4372 | assert_eq!(false, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4372 - assert_eq!(false, args.no_ignore_global); [INFO] [stdout] 4372 + assert!(!args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4373:5 [INFO] [stdout] | [INFO] [stdout] 4373 | assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4373 - assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] 4373 + assert!(!args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4374:5 [INFO] [stdout] | [INFO] [stdout] 4374 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4374 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 4374 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4377:5 [INFO] [stdout] | [INFO] [stdout] 4377 | assert_eq!(true, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4377 - assert_eq!(true, args.no_ignore_dot); [INFO] [stdout] 4377 + assert!(args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4378:5 [INFO] [stdout] | [INFO] [stdout] 4378 | assert_eq!(true, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4378 - assert_eq!(true, args.no_ignore_exclude); [INFO] [stdout] 4378 + assert!(args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4379:5 [INFO] [stdout] | [INFO] [stdout] 4379 | assert_eq!(true, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4379 - assert_eq!(true, args.no_ignore_global); [INFO] [stdout] 4379 + assert!(args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4380:5 [INFO] [stdout] | [INFO] [stdout] 4380 | assert_eq!(true, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4380 - assert_eq!(true, args.no_ignore_parent); [INFO] [stdout] 4380 + assert!(args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4381:5 [INFO] [stdout] | [INFO] [stdout] 4381 | assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4381 - assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] 4381 + assert!(args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4384:5 [INFO] [stdout] | [INFO] [stdout] 4384 | assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4384 - assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] 4384 + assert!(!args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4385:5 [INFO] [stdout] | [INFO] [stdout] 4385 | assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4385 - assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] 4385 + assert!(!args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4386:5 [INFO] [stdout] | [INFO] [stdout] 4386 | assert_eq!(false, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4386 - assert_eq!(false, args.no_ignore_global); [INFO] [stdout] 4386 + assert!(!args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4387:5 [INFO] [stdout] | [INFO] [stdout] 4387 | assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4387 - assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] 4387 + assert!(!args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4388:5 [INFO] [stdout] | [INFO] [stdout] 4388 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4388 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 4388 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4431:5 [INFO] [stdout] | [INFO] [stdout] 4431 | assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4431 - assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] 4431 + assert!(!args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4434:5 [INFO] [stdout] | [INFO] [stdout] 4434 | assert_eq!(true, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4434 - assert_eq!(true, args.no_ignore_dot); [INFO] [stdout] 4434 + assert!(args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4437:5 [INFO] [stdout] | [INFO] [stdout] 4437 | assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4437 - assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] 4437 + assert!(!args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4477:5 [INFO] [stdout] | [INFO] [stdout] 4477 | assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4477 - assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] 4477 + assert!(!args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4480:5 [INFO] [stdout] | [INFO] [stdout] 4480 | assert_eq!(true, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4480 - assert_eq!(true, args.no_ignore_exclude); [INFO] [stdout] 4480 + assert!(args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4484:5 [INFO] [stdout] | [INFO] [stdout] 4484 | assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4484 - assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] 4484 + assert!(!args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4524:5 [INFO] [stdout] | [INFO] [stdout] 4524 | assert_eq!(false, args.no_ignore_files); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4524 - assert_eq!(false, args.no_ignore_files); [INFO] [stdout] 4524 + assert!(!args.no_ignore_files); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4527:5 [INFO] [stdout] | [INFO] [stdout] 4527 | assert_eq!(true, args.no_ignore_files); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4527 - assert_eq!(true, args.no_ignore_files); [INFO] [stdout] 4527 + assert!(args.no_ignore_files); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4530:5 [INFO] [stdout] | [INFO] [stdout] 4530 | assert_eq!(false, args.no_ignore_files); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4530 - assert_eq!(false, args.no_ignore_files); [INFO] [stdout] 4530 + assert!(!args.no_ignore_files); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4571:5 [INFO] [stdout] | [INFO] [stdout] 4571 | assert_eq!(false, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4571 - assert_eq!(false, args.no_ignore_global); [INFO] [stdout] 4571 + assert!(!args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4574:5 [INFO] [stdout] | [INFO] [stdout] 4574 | assert_eq!(true, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4574 - assert_eq!(true, args.no_ignore_global); [INFO] [stdout] 4574 + assert!(args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4578:5 [INFO] [stdout] | [INFO] [stdout] 4578 | assert_eq!(false, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4578 - assert_eq!(false, args.no_ignore_global); [INFO] [stdout] 4578 + assert!(!args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4620:5 [INFO] [stdout] | [INFO] [stdout] 4620 | assert_eq!(false, args.no_ignore_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4620 - assert_eq!(false, args.no_ignore_messages); [INFO] [stdout] 4620 + assert!(!args.no_ignore_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4623:5 [INFO] [stdout] | [INFO] [stdout] 4623 | assert_eq!(true, args.no_ignore_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4623 - assert_eq!(true, args.no_ignore_messages); [INFO] [stdout] 4623 + assert!(args.no_ignore_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4627:5 [INFO] [stdout] | [INFO] [stdout] 4627 | assert_eq!(false, args.no_ignore_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4627 - assert_eq!(false, args.no_ignore_messages); [INFO] [stdout] 4627 + assert!(!args.no_ignore_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4669:5 [INFO] [stdout] | [INFO] [stdout] 4669 | assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4669 - assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] 4669 + assert!(!args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4672:5 [INFO] [stdout] | [INFO] [stdout] 4672 | assert_eq!(true, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4672 - assert_eq!(true, args.no_ignore_parent); [INFO] [stdout] 4672 + assert!(args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4676:5 [INFO] [stdout] | [INFO] [stdout] 4676 | assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4676 - assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] 4676 + assert!(!args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4726:5 [INFO] [stdout] | [INFO] [stdout] 4726 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4726 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 4726 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4729:5 [INFO] [stdout] | [INFO] [stdout] 4729 | assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4729 - assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] 4729 + assert!(args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4732:5 [INFO] [stdout] | [INFO] [stdout] 4732 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4732 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 4732 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4773:5 [INFO] [stdout] | [INFO] [stdout] 4773 | assert_eq!(false, args.no_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4773 - assert_eq!(false, args.no_messages); [INFO] [stdout] 4773 + assert!(!args.no_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4776:5 [INFO] [stdout] | [INFO] [stdout] 4776 | assert_eq!(true, args.no_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4776 - assert_eq!(true, args.no_messages); [INFO] [stdout] 4776 + assert!(args.no_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4779:5 [INFO] [stdout] | [INFO] [stdout] 4779 | assert_eq!(false, args.no_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4779 - assert_eq!(false, args.no_messages); [INFO] [stdout] 4779 + assert!(!args.no_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4820:5 [INFO] [stdout] | [INFO] [stdout] 4820 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4820 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4820 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4823:5 [INFO] [stdout] | [INFO] [stdout] 4823 | assert_eq!(true, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4823 - assert_eq!(true, args.no_unicode); [INFO] [stdout] 4823 + assert!(args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4827:5 [INFO] [stdout] | [INFO] [stdout] 4827 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4827 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4827 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4875:5 [INFO] [stdout] | [INFO] [stdout] 4875 | assert_eq!(false, args.no_require_git); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4875 - assert_eq!(false, args.no_require_git); [INFO] [stdout] 4875 + assert!(!args.no_require_git); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4878:5 [INFO] [stdout] | [INFO] [stdout] 4878 | assert_eq!(true, args.no_require_git); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4878 - assert_eq!(true, args.no_require_git); [INFO] [stdout] 4878 + assert!(args.no_require_git); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4881:5 [INFO] [stdout] | [INFO] [stdout] 4881 | assert_eq!(false, args.no_require_git); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4881 - assert_eq!(false, args.no_require_git); [INFO] [stdout] 4881 + assert!(!args.no_require_git); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4948:5 [INFO] [stdout] | [INFO] [stdout] 4948 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4948 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4948 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4951:5 [INFO] [stdout] | [INFO] [stdout] 4951 | assert_eq!(true, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4951 - assert_eq!(true, args.no_unicode); [INFO] [stdout] 4951 + assert!(args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4954:5 [INFO] [stdout] | [INFO] [stdout] 4954 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4954 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4954 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4957:5 [INFO] [stdout] | [INFO] [stdout] 4957 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4957 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4957 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4960:5 [INFO] [stdout] | [INFO] [stdout] 4960 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4960 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4960 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5003:5 [INFO] [stdout] | [INFO] [stdout] 5003 | assert_eq!(false, args.null); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5003 - assert_eq!(false, args.null); [INFO] [stdout] 5003 + assert!(!args.null); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5006:5 [INFO] [stdout] | [INFO] [stdout] 5006 | assert_eq!(true, args.null); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5006 - assert_eq!(true, args.null); [INFO] [stdout] 5006 + assert!(args.null); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5009:5 [INFO] [stdout] | [INFO] [stdout] 5009 | assert_eq!(true, args.null); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5009 - assert_eq!(true, args.null); [INFO] [stdout] 5009 + assert!(args.null); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5059:5 [INFO] [stdout] | [INFO] [stdout] 5059 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5059 - assert_eq!(false, args.null_data); [INFO] [stdout] 5059 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5062:5 [INFO] [stdout] | [INFO] [stdout] 5062 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5062 - assert_eq!(true, args.null_data); [INFO] [stdout] 5062 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5065:5 [INFO] [stdout] | [INFO] [stdout] 5065 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5065 - assert_eq!(false, args.null_data); [INFO] [stdout] 5065 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5066:5 [INFO] [stdout] | [INFO] [stdout] 5066 | assert_eq!(true, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5066 - assert_eq!(true, args.crlf); [INFO] [stdout] 5066 + assert!(args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5069:5 [INFO] [stdout] | [INFO] [stdout] 5069 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5069 - assert_eq!(true, args.null_data); [INFO] [stdout] 5069 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5070:5 [INFO] [stdout] | [INFO] [stdout] 5070 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5070 - assert_eq!(false, args.crlf); [INFO] [stdout] 5070 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5073:5 [INFO] [stdout] | [INFO] [stdout] 5073 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5073 - assert_eq!(true, args.null_data); [INFO] [stdout] 5073 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5074:5 [INFO] [stdout] | [INFO] [stdout] 5074 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5074 - assert_eq!(false, args.crlf); [INFO] [stdout] 5074 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5127:5 [INFO] [stdout] | [INFO] [stdout] 5127 | assert_eq!(false, args.one_file_system); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5127 - assert_eq!(false, args.one_file_system); [INFO] [stdout] 5127 + assert!(!args.one_file_system); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5130:5 [INFO] [stdout] | [INFO] [stdout] 5130 | assert_eq!(true, args.one_file_system); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5130 - assert_eq!(true, args.one_file_system); [INFO] [stdout] 5130 + assert!(args.one_file_system); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5134:5 [INFO] [stdout] | [INFO] [stdout] 5134 | assert_eq!(false, args.one_file_system); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5134 - assert_eq!(false, args.one_file_system); [INFO] [stdout] 5134 + assert!(!args.one_file_system); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5175:5 [INFO] [stdout] | [INFO] [stdout] 5175 | assert_eq!(false, args.only_matching); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5175 - assert_eq!(false, args.only_matching); [INFO] [stdout] 5175 + assert!(!args.only_matching); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5178:5 [INFO] [stdout] | [INFO] [stdout] 5178 | assert_eq!(true, args.only_matching); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5178 - assert_eq!(true, args.only_matching); [INFO] [stdout] 5178 + assert!(args.only_matching); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5181:5 [INFO] [stdout] | [INFO] [stdout] 5181 | assert_eq!(true, args.only_matching); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5181 - assert_eq!(true, args.only_matching); [INFO] [stdout] 5181 + assert!(args.only_matching); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5737:5 [INFO] [stdout] | [INFO] [stdout] 5737 | assert_eq!(false, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5737 - assert_eq!(false, args.quiet); [INFO] [stdout] 5737 + assert!(!args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5740:5 [INFO] [stdout] | [INFO] [stdout] 5740 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5740 - assert_eq!(true, args.quiet); [INFO] [stdout] 5740 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5743:5 [INFO] [stdout] | [INFO] [stdout] 5743 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5743 - assert_eq!(true, args.quiet); [INFO] [stdout] 5743 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5747:5 [INFO] [stdout] | [INFO] [stdout] 5747 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5747 - assert_eq!(true, args.quiet); [INFO] [stdout] 5747 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5750:5 [INFO] [stdout] | [INFO] [stdout] 5750 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5750 - assert_eq!(true, args.quiet); [INFO] [stdout] 5750 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5753:5 [INFO] [stdout] | [INFO] [stdout] 5753 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5753 - assert_eq!(true, args.quiet); [INFO] [stdout] 5753 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5756:5 [INFO] [stdout] | [INFO] [stdout] 5756 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5756 - assert_eq!(true, args.quiet); [INFO] [stdout] 5756 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5759:5 [INFO] [stdout] | [INFO] [stdout] 5759 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5759 - assert_eq!(true, args.quiet); [INFO] [stdout] 5759 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6115:5 [INFO] [stdout] | [INFO] [stdout] 6115 | assert_eq!(false, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6115 - assert_eq!(false, args.search_zip); [INFO] [stdout] 6115 + assert!(!args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6118:5 [INFO] [stdout] | [INFO] [stdout] 6118 | assert_eq!(true, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6118 - assert_eq!(true, args.search_zip); [INFO] [stdout] 6118 + assert!(args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6121:5 [INFO] [stdout] | [INFO] [stdout] 6121 | assert_eq!(true, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6121 - assert_eq!(true, args.search_zip); [INFO] [stdout] 6121 + assert!(args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6124:5 [INFO] [stdout] | [INFO] [stdout] 6124 | assert_eq!(false, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6124 - assert_eq!(false, args.search_zip); [INFO] [stdout] 6124 + assert!(!args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6128:5 [INFO] [stdout] | [INFO] [stdout] 6128 | assert_eq!(false, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6128 - assert_eq!(false, args.search_zip); [INFO] [stdout] 6128 + assert!(!args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6132:5 [INFO] [stdout] | [INFO] [stdout] 6132 | assert_eq!(true, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6132 - assert_eq!(true, args.search_zip); [INFO] [stdout] 6132 + assert!(args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6136:5 [INFO] [stdout] | [INFO] [stdout] 6136 | assert_eq!(false, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6136 - assert_eq!(false, args.search_zip); [INFO] [stdout] 6136 + assert!(!args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6561:5 [INFO] [stdout] | [INFO] [stdout] 6561 | assert_eq!(false, args.stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6561 - assert_eq!(false, args.stats); [INFO] [stdout] 6561 + assert!(!args.stats); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6564:5 [INFO] [stdout] | [INFO] [stdout] 6564 | assert_eq!(true, args.stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6564 - assert_eq!(true, args.stats); [INFO] [stdout] 6564 + assert!(args.stats); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6567:5 [INFO] [stdout] | [INFO] [stdout] 6567 | assert_eq!(false, args.stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6567 - assert_eq!(false, args.stats); [INFO] [stdout] 6567 + assert!(!args.stats); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6610:5 [INFO] [stdout] | [INFO] [stdout] 6610 | assert_eq!(false, args.stop_on_nonmatch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6610 - assert_eq!(false, args.stop_on_nonmatch); [INFO] [stdout] 6610 + assert!(!args.stop_on_nonmatch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [WARN] too many lines in the log, truncating it