[INFO] cloning repository https://github.com/wannawatchmecode/swizzy_decent [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wannawatchmecode/swizzy_decent" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwannawatchmecode%2Fswizzy_decent", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwannawatchmecode%2Fswizzy_decent'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 443337e0a36f4a2fe3ab7ea78a3a7c13402c2678 [INFO] linting wannawatchmecode/swizzy_decent against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwannawatchmecode%2Fswizzy_decent" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/wannawatchmecode/swizzy_decent [INFO] finished tweaking git repo https://github.com/wannawatchmecode/swizzy_decent [INFO] tweaked toml for git repo https://github.com/wannawatchmecode/swizzy_decent written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/wannawatchmecode/swizzy_decent on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/wannawatchmecode/swizzy_decent already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anstream v0.6.13 [INFO] [stderr] Downloaded uuid v1.8.0 [INFO] [stderr] Downloaded cc v1.0.94 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 47f43a72f57f6d556e7418392fc0e42a8cee5f04b4aa31b2453226ce595566ff [INFO] running `Command { std: "docker" "start" "-a" "47f43a72f57f6d556e7418392fc0e42a8cee5f04b4aa31b2453226ce595566ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "47f43a72f57f6d556e7418392fc0e42a8cee5f04b4aa31b2453226ce595566ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47f43a72f57f6d556e7418392fc0e42a8cee5f04b4aa31b2453226ce595566ff", kill_on_drop: false }` [INFO] [stdout] 47f43a72f57f6d556e7418392fc0e42a8cee5f04b4aa31b2453226ce595566ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd157dc2334b5a90b4bfd777d95a59fc5a919b52e151f668997807ffa7c91171 [INFO] running `Command { std: "docker" "start" "-a" "cd157dc2334b5a90b4bfd777d95a59fc5a919b52e151f668997807ffa7c91171", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking swizzy_decent v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Ipv4Addr` [INFO] [stdout] --> src/main.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::{IpAddr, Ipv4Addr, SocketAddr}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::mpsc` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::sync::mpsc; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::sleep` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::thread::sleep; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | use std::time::{Duration, SystemTime, UNIX_EPOCH}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DeserializePacket` and `SerializePacket` [INFO] [stdout] --> src/main.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::health_check::{DeserializePacket, HEALTH_CHECK_SYN_OPCODE, HealthCheckPacket, SerializePacket}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HealthCheckNetworkBroker` [INFO] [stdout] --> src/main.rs:13:68 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::health_check_network_broker::{build_health_check_stack, HealthCheckNetworkBroker, HealthCheckNetworkBrokerMessage}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::health_check_network_handlers::HealthCheckNetworkBrokerMessageListener` [INFO] [stdout] --> src/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::health_check_network_handlers::HealthCheckNetworkBrokerMessageListener; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IP`, `NetworkDetailsStore`, `RECEIVER_PORT`, `SENDER_PORT`, `health_check_receiver`, and `health_check_sender` [INFO] [stdout] --> src/main.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::network::{health_check_receiver, health_check_sender, IP, NetworkDetailsStore, RECEIVER_PORT, SENDER_PORT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::info` [INFO] [stdout] --> src/health_check_network_broker.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use log::info; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IP`, `RECEIVER_PORT`, and `SENDER_PORT` [INFO] [stdout] --> src/health_check_network_broker.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::network::{IP, NetworkDetailsStore, RECEIVER_PORT, SENDER_PORT}; [INFO] [stdout] | ^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::health_check_network_handlers::HealthCheckNetworkBrokerMessageListener` [INFO] [stdout] --> src/example.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::health_check_network_handlers::HealthCheckNetworkBrokerMessageListener; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ipv4Addr` [INFO] [stdout] --> src/main.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::{IpAddr, Ipv4Addr, SocketAddr}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::mpsc` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::sync::mpsc; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::sleep` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::thread::sleep; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | use std::time::{Duration, SystemTime, UNIX_EPOCH}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DeserializePacket` and `SerializePacket` [INFO] [stdout] --> src/main.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::health_check::{DeserializePacket, HEALTH_CHECK_SYN_OPCODE, HealthCheckPacket, SerializePacket}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HealthCheckNetworkBroker` [INFO] [stdout] --> src/main.rs:13:68 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::health_check_network_broker::{build_health_check_stack, HealthCheckNetworkBroker, HealthCheckNetworkBrokerMessage}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::health_check_network_handlers::HealthCheckNetworkBrokerMessageListener` [INFO] [stdout] --> src/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::health_check_network_handlers::HealthCheckNetworkBrokerMessageListener; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IP`, `NetworkDetailsStore`, `RECEIVER_PORT`, `SENDER_PORT`, `health_check_receiver`, and `health_check_sender` [INFO] [stdout] --> src/main.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::network::{health_check_receiver, health_check_sender, IP, NetworkDetailsStore, RECEIVER_PORT, SENDER_PORT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::info` [INFO] [stdout] --> src/health_check_network_broker.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use log::info; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IP`, `RECEIVER_PORT`, and `SENDER_PORT` [INFO] [stdout] --> src/health_check_network_broker.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::network::{IP, NetworkDetailsStore, RECEIVER_PORT, SENDER_PORT}; [INFO] [stdout] | ^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::health_check_network_handlers::HealthCheckNetworkBrokerMessageListener` [INFO] [stdout] --> src/example.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::health_check_network_handlers::HealthCheckNetworkBrokerMessageListener; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `response_object` is never read [INFO] [stdout] --> src/network.rs:203:13 [INFO] [stdout] | [INFO] [stdout] 203 | response_object.header = HEALTH_CHECK_ACK_OPCODE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/health_check_network_handlers.rs:88:36 [INFO] [stdout] | [INFO] [stdout] 88 | fn health_check_syn_opcode_handler(context: HealthCheckHandlerContext, params: OpcodeHandlerParams) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/health_check_network_handlers.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | let mut existing_record_retrieve_result = context.network_details_store.get_network_details_by_ip(¶ms.message.remote_addr.i... [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/health_check_network_handlers.rs:136:37 [INFO] [stdout] | [INFO] [stdout] 136 | fn health_check_noop_opcode_handler(context: HealthCheckHandlerContext, params: OpcodeHandlerParams) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `params` [INFO] [stdout] --> src/health_check_network_handlers.rs:136:73 [INFO] [stdout] | [INFO] [stdout] 136 | fn health_check_noop_opcode_handler(context: HealthCheckHandlerContext, params: OpcodeHandlerParams) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_params` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `message` [INFO] [stdout] --> src/example.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let message = HealthCheckNetworkBrokerMessage { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_message` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `health_check_network_handlers::HealthCheckHandlerContext<'_>` is more private than the item `health_check_network_handlers::get_health_check_handler_map` [INFO] [stdout] --> src/health_check_network_handlers.rs:146:1 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn get_health_check_handler_map() -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `health_check_network_handlers::get_health_check_handler_map` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `health_check_network_handlers::HealthCheckHandlerContext<'_>` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/health_check_network_handlers.rs:140:1 [INFO] [stdout] | [INFO] [stdout] 140 | struct HealthCheckHandlerContext<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `IP` is never used [INFO] [stdout] --> src/network.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub const IP: Ipv4Addr = Ipv4Addr::new(127,0,0,1); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `RECEIVER_PORT` is never used [INFO] [stdout] --> src/network.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | pub const RECEIVER_PORT: u16 = 3451; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SENDER_PORT` is never used [INFO] [stdout] --> src/network.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | pub const SENDER_PORT: u16 = 3450; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `AtRisk` and `Unhealthy` are never constructed [INFO] [stdout] --> src/network.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub enum HealthStatus { [INFO] [stdout] | ------------ variants in this enum [INFO] [stdout] 13 | Healthy, [INFO] [stdout] 14 | AtRisk, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 15 | Unhealthy, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HealthStatus` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `health_check_receiver` is never used [INFO] [stdout] --> src/network.rs:135:8 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn health_check_receiver() -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `health_check_sender` is never used [INFO] [stdout] --> src/network.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn health_check_sender() -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_request_sender` is never used [INFO] [stdout] --> src/health_check_network_broker.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl HealthCheckNetworkBroker { [INFO] [stdout] | ----------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | pub fn get_request_sender(self) -> Sender{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HealthCheckFactory` is never constructed [INFO] [stdout] --> src/health_check_network_broker.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | pub struct HealthCheckFactory { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main_with_stacks` is never used [INFO] [stdout] --> src/example.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | fn main_with_stacks() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `single_instance_main` is never used [INFO] [stdout] --> src/example.rs:86:4 [INFO] [stdout] | [INFO] [stdout] 86 | fn single_instance_main() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main_health_check_broker_example` is never used [INFO] [stdout] --> src/example.rs:251:4 [INFO] [stdout] | [INFO] [stdout] 251 | fn main_health_check_broker_example() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main_receiver_poc` is never used [INFO] [stdout] --> src/example.rs:297:4 [INFO] [stdout] | [INFO] [stdout] 297 | fn main_receiver_poc() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main_serialization` is never used [INFO] [stdout] --> src/example.rs:311:4 [INFO] [stdout] | [INFO] [stdout] 311 | fn main_serialization() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return HashSet::from([HEALTH_CHECK_SYN_OPCODE, HEALTH_CHECK_ACK_OPCODE]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return HashSet::from([HEALTH_CHECK_SYN_OPCODE, HEALTH_CHECK_ACK_OPCODE]); [INFO] [stdout] 25 + HashSet::from([HEALTH_CHECK_SYN_OPCODE, HEALTH_CHECK_ACK_OPCODE]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return serialized [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return serialized [INFO] [stdout] 42 + serialized [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return result [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return result [INFO] [stdout] 76 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/health_check.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / for i in 0..NONCE_SIZE_BYTES { [INFO] [stdout] 69 | | nonce[i] = raw[i+NONCE_INDEX]; [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `nonce[..NONCE_SIZE_BYTES].copy_from_slice(&raw[NONCE_INDEX..(NONCE_SIZE_BYTES + NONCE_INDEX)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/health_check.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | header: header.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/network.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / return NetworkDetailsStore { [INFO] [stdout] 59 | | host_map: Mutex::new(actual_map), [INFO] [stdout] 60 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 ~ NetworkDetailsStore { [INFO] [stdout] 59 + host_map: Mutex::new(actual_map), [INFO] [stdout] 60 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/network.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return Ok(record.unwrap().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return Ok(record.unwrap().clone()) [INFO] [stdout] 70 + Ok(record.unwrap().clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/network.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / for i in 0..HEALTH_CHECK_PACKET_SIZE { [INFO] [stdout] 167 | | buf[i] = raw[i]; [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `buf[..HEALTH_CHECK_PACKET_SIZE].copy_from_slice(&raw[..HEALTH_CHECK_PACKET_SIZE]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/network.rs:170:29 [INFO] [stdout] | [INFO] [stdout] 170 | socket.send_to(buf, &src)?; [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/network.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | / for i in 0..HEALTH_CHECK_PACKET_SIZE { [INFO] [stdout] 185 | | buf[i] = raw[i]; [INFO] [stdout] 186 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `buf[..HEALTH_CHECK_PACKET_SIZE].copy_from_slice(&raw[..HEALTH_CHECK_PACKET_SIZE]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/network.rs:188:40 [INFO] [stdout] | [INFO] [stdout] 188 | let _amt = socket.send_to(buf, &dst)?; [INFO] [stdout] | ^^^^ help: change this to: `dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check_network_broker.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return self.request_sender.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return self.request_sender.clone() [INFO] [stdout] 79 + self.request_sender.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/health_check_network_broker.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | / for i in 0..HEALTH_CHECK_PACKET_SIZE { [INFO] [stdout] 112 | | buf[i] = raw[i]; [INFO] [stdout] 113 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `buf[..HEALTH_CHECK_PACKET_SIZE].copy_from_slice(&raw[..HEALTH_CHECK_PACKET_SIZE]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/health_check_network_broker.rs:116:40 [INFO] [stdout] | [INFO] [stdout] 116 | let _amt = socket.send_to(buf, &dst)?; [INFO] [stdout] | ^^^^ help: change this to: `dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check_network_broker.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | / return HealthCheckStack { [INFO] [stdout] 140 | | request_sender: network_broker.request_sender.clone(), [INFO] [stdout] 141 | | network_broker, [INFO] [stdout] 142 | | health_check_network_broker_message_listener, [INFO] [stdout] 143 | | // network_details_store [INFO] [stdout] 144 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 ~ HealthCheckStack { [INFO] [stdout] 140 + request_sender: network_broker.request_sender.clone(), [INFO] [stdout] 141 + network_broker, [INFO] [stdout] 142 + health_check_network_broker_message_listener, [INFO] [stdout] 143 + // network_details_store [INFO] [stdout] 144 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check_network_broker.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | / return HealthCheckStack::new( [INFO] [stdout] 197 | | network_broker, [INFO] [stdout] 198 | | health_check_network_broker_message_listener [INFO] [stdout] 199 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 ~ HealthCheckStack::new( [INFO] [stdout] 197 + network_broker, [INFO] [stdout] 198 + health_check_network_broker_message_listener [INFO] [stdout] 199 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/health_check_network_handlers.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / /** [INFO] [stdout] 32 | | [INFO] [stdout] 33 | | */ [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/health_check_network_handlers.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 104 | if !existing_record_retrieve_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `existing_record_retrieve_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `existing_record_retrieve_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/health_check_network_handlers.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 104 | if !existing_record_retrieve_result.is_ok() { [INFO] [stdout] | --------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 119 | new_record = existing_record_retrieve_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `IpAddr` which implements the `Copy` trait [INFO] [stdout] --> src/health_check_network_handlers.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 107 | addr: params.message.remote_addr.ip().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `params.message.remote_addr.ip()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check_network_handlers.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return map; [INFO] [stdout] 151 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/example.rs:91:31 [INFO] [stdout] | [INFO] [stdout] 91 | let ip = IpAddr::from_str(&ip_address_str.as_str()).expect("Valid IP address"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ip_address_str.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return Uuid::new_v4().into_bytes() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return Uuid::new_v4().into_bytes() [INFO] [stdout] 4 + Uuid::new_v4().into_bytes() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 64 | let ip = IpAddr::from_str(&ip_address_str.as_str()).expect("Valid IP address"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ip_address_str.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `CALLS` should have a snake case name [INFO] [stdout] --> src/example.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | let CALLS = 10; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `calls` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/example.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | first_handle.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = first_handle.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/example.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | second_handle.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = second_handle.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/example.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | health_check_receiver(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 300 | let _ = health_check_receiver(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/example.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | health_check_sender(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 304 | let _ = health_check_sender(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `store` [INFO] [stdout] --> src/network.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let store = NetworkDetailsStore::new(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_store` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/network.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | let mut store = NetworkDetailsStore::new(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `response_object` is never read [INFO] [stdout] --> src/network.rs:203:13 [INFO] [stdout] | [INFO] [stdout] 203 | response_object.header = HEALTH_CHECK_ACK_OPCODE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/health_check_network_handlers.rs:88:36 [INFO] [stdout] | [INFO] [stdout] 88 | fn health_check_syn_opcode_handler(context: HealthCheckHandlerContext, params: OpcodeHandlerParams) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/health_check_network_handlers.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | let mut existing_record_retrieve_result = context.network_details_store.get_network_details_by_ip(¶ms.message.remote_addr.i... [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/health_check_network_handlers.rs:136:37 [INFO] [stdout] | [INFO] [stdout] 136 | fn health_check_noop_opcode_handler(context: HealthCheckHandlerContext, params: OpcodeHandlerParams) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `params` [INFO] [stdout] --> src/health_check_network_handlers.rs:136:73 [INFO] [stdout] | [INFO] [stdout] 136 | fn health_check_noop_opcode_handler(context: HealthCheckHandlerContext, params: OpcodeHandlerParams) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_params` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `message` [INFO] [stdout] --> src/example.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let message = HealthCheckNetworkBrokerMessage { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_message` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `health_check_network_handlers::HealthCheckHandlerContext<'_>` is more private than the item `health_check_network_handlers::get_health_check_handler_map` [INFO] [stdout] --> src/health_check_network_handlers.rs:146:1 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn get_health_check_handler_map() -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `health_check_network_handlers::get_health_check_handler_map` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `health_check_network_handlers::HealthCheckHandlerContext<'_>` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/health_check_network_handlers.rs:140:1 [INFO] [stdout] | [INFO] [stdout] 140 | struct HealthCheckHandlerContext<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `RECEIVER_PORT` is never used [INFO] [stdout] --> src/network.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | pub const RECEIVER_PORT: u16 = 3451; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SENDER_PORT` is never used [INFO] [stdout] --> src/network.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | pub const SENDER_PORT: u16 = 3450; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `AtRisk` and `Unhealthy` are never constructed [INFO] [stdout] --> src/network.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub enum HealthStatus { [INFO] [stdout] | ------------ variants in this enum [INFO] [stdout] 13 | Healthy, [INFO] [stdout] 14 | AtRisk, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 15 | Unhealthy, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HealthStatus` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `health_check_receiver` is never used [INFO] [stdout] --> src/network.rs:135:8 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn health_check_receiver() -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `health_check_sender` is never used [INFO] [stdout] --> src/network.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn health_check_sender() -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_request_sender` is never used [INFO] [stdout] --> src/health_check_network_broker.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl HealthCheckNetworkBroker { [INFO] [stdout] | ----------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | pub fn get_request_sender(self) -> Sender{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HealthCheckFactory` is never constructed [INFO] [stdout] --> src/health_check_network_broker.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | pub struct HealthCheckFactory { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main_with_stacks` is never used [INFO] [stdout] --> src/example.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | fn main_with_stacks() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `single_instance_main` is never used [INFO] [stdout] --> src/example.rs:86:4 [INFO] [stdout] | [INFO] [stdout] 86 | fn single_instance_main() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main_health_check_broker_example` is never used [INFO] [stdout] --> src/example.rs:251:4 [INFO] [stdout] | [INFO] [stdout] 251 | fn main_health_check_broker_example() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main_receiver_poc` is never used [INFO] [stdout] --> src/example.rs:297:4 [INFO] [stdout] | [INFO] [stdout] 297 | fn main_receiver_poc() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main_serialization` is never used [INFO] [stdout] --> src/example.rs:311:4 [INFO] [stdout] | [INFO] [stdout] 311 | fn main_serialization() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return HashSet::from([HEALTH_CHECK_SYN_OPCODE, HEALTH_CHECK_ACK_OPCODE]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return HashSet::from([HEALTH_CHECK_SYN_OPCODE, HEALTH_CHECK_ACK_OPCODE]); [INFO] [stdout] 25 + HashSet::from([HEALTH_CHECK_SYN_OPCODE, HEALTH_CHECK_ACK_OPCODE]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return serialized [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return serialized [INFO] [stdout] 42 + serialized [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return result [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return result [INFO] [stdout] 76 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/health_check.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / for i in 0..NONCE_SIZE_BYTES { [INFO] [stdout] 69 | | nonce[i] = raw[i+NONCE_INDEX]; [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `nonce[..NONCE_SIZE_BYTES].copy_from_slice(&raw[NONCE_INDEX..(NONCE_SIZE_BYTES + NONCE_INDEX)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/health_check.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | header: header.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/network.rs:81:1 [INFO] [stdout] | [INFO] [stdout] 81 | mod network_tests { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 135 | pub fn health_check_receiver() -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 175 | pub fn health_check_sender() -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/network.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / return NetworkDetailsStore { [INFO] [stdout] 59 | | host_map: Mutex::new(actual_map), [INFO] [stdout] 60 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 ~ NetworkDetailsStore { [INFO] [stdout] 59 + host_map: Mutex::new(actual_map), [INFO] [stdout] 60 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/network.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return Ok(record.unwrap().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return Ok(record.unwrap().clone()) [INFO] [stdout] 70 + Ok(record.unwrap().clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/network.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / for i in 0..HEALTH_CHECK_PACKET_SIZE { [INFO] [stdout] 167 | | buf[i] = raw[i]; [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `buf[..HEALTH_CHECK_PACKET_SIZE].copy_from_slice(&raw[..HEALTH_CHECK_PACKET_SIZE]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/network.rs:170:29 [INFO] [stdout] | [INFO] [stdout] 170 | socket.send_to(buf, &src)?; [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/network.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | / for i in 0..HEALTH_CHECK_PACKET_SIZE { [INFO] [stdout] 185 | | buf[i] = raw[i]; [INFO] [stdout] 186 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `buf[..HEALTH_CHECK_PACKET_SIZE].copy_from_slice(&raw[..HEALTH_CHECK_PACKET_SIZE]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/network.rs:188:40 [INFO] [stdout] | [INFO] [stdout] 188 | let _amt = socket.send_to(buf, &dst)?; [INFO] [stdout] | ^^^^ help: change this to: `dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check_network_broker.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return self.request_sender.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return self.request_sender.clone() [INFO] [stdout] 79 + self.request_sender.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/health_check_network_broker.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | / for i in 0..HEALTH_CHECK_PACKET_SIZE { [INFO] [stdout] 112 | | buf[i] = raw[i]; [INFO] [stdout] 113 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `buf[..HEALTH_CHECK_PACKET_SIZE].copy_from_slice(&raw[..HEALTH_CHECK_PACKET_SIZE]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/health_check_network_broker.rs:116:40 [INFO] [stdout] | [INFO] [stdout] 116 | let _amt = socket.send_to(buf, &dst)?; [INFO] [stdout] | ^^^^ help: change this to: `dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check_network_broker.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | / return HealthCheckStack { [INFO] [stdout] 140 | | request_sender: network_broker.request_sender.clone(), [INFO] [stdout] 141 | | network_broker, [INFO] [stdout] 142 | | health_check_network_broker_message_listener, [INFO] [stdout] 143 | | // network_details_store [INFO] [stdout] 144 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 ~ HealthCheckStack { [INFO] [stdout] 140 + request_sender: network_broker.request_sender.clone(), [INFO] [stdout] 141 + network_broker, [INFO] [stdout] 142 + health_check_network_broker_message_listener, [INFO] [stdout] 143 + // network_details_store [INFO] [stdout] 144 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check_network_broker.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | / return HealthCheckStack::new( [INFO] [stdout] 197 | | network_broker, [INFO] [stdout] 198 | | health_check_network_broker_message_listener [INFO] [stdout] 199 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 ~ HealthCheckStack::new( [INFO] [stdout] 197 + network_broker, [INFO] [stdout] 198 + health_check_network_broker_message_listener [INFO] [stdout] 199 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/health_check_network_handlers.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / /** [INFO] [stdout] 32 | | [INFO] [stdout] 33 | | */ [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/health_check_network_handlers.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 104 | if !existing_record_retrieve_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `existing_record_retrieve_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `existing_record_retrieve_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/health_check_network_handlers.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 104 | if !existing_record_retrieve_result.is_ok() { [INFO] [stdout] | --------------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 119 | new_record = existing_record_retrieve_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `IpAddr` which implements the `Copy` trait [INFO] [stdout] --> src/health_check_network_handlers.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 107 | addr: params.message.remote_addr.ip().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `params.message.remote_addr.ip()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/health_check_network_handlers.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return map; [INFO] [stdout] 151 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/example.rs:91:31 [INFO] [stdout] | [INFO] [stdout] 91 | let ip = IpAddr::from_str(&ip_address_str.as_str()).expect("Valid IP address"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ip_address_str.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return Uuid::new_v4().into_bytes() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return Uuid::new_v4().into_bytes() [INFO] [stdout] 4 + Uuid::new_v4().into_bytes() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 64 | let ip = IpAddr::from_str(&ip_address_str.as_str()).expect("Valid IP address"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ip_address_str.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/network.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | store.get_network_details_by_ip(&dummy_record.addr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 130 | let _ = store.get_network_details_by_ip(&dummy_record.addr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `CALLS` should have a snake case name [INFO] [stdout] --> src/example.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | let CALLS = 10; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `calls` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/example.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | first_handle.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = first_handle.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/example.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | second_handle.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = second_handle.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/example.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | health_check_receiver(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 300 | let _ = health_check_receiver(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/example.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | health_check_sender(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 304 | let _ = health_check_sender(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.16s [INFO] running `Command { std: "docker" "inspect" "cd157dc2334b5a90b4bfd777d95a59fc5a919b52e151f668997807ffa7c91171", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd157dc2334b5a90b4bfd777d95a59fc5a919b52e151f668997807ffa7c91171", kill_on_drop: false }` [INFO] [stdout] cd157dc2334b5a90b4bfd777d95a59fc5a919b52e151f668997807ffa7c91171