[INFO] cloning repository https://github.com/waffleattack/AdventOfCode [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/waffleattack/AdventOfCode" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwaffleattack%2FAdventOfCode", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwaffleattack%2FAdventOfCode'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5f79d129b7f2f266f105fd18412b41d245a08562 [INFO] linting waffleattack/AdventOfCode against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwaffleattack%2FAdventOfCode" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/waffleattack/AdventOfCode [INFO] finished tweaking git repo https://github.com/waffleattack/AdventOfCode [INFO] tweaked toml for git repo https://github.com/waffleattack/AdventOfCode written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/waffleattack/AdventOfCode on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/waffleattack/AdventOfCode already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4896bbc081a4e118586a5378d4b274f770082fa3e540f73580ded712185f82ef [INFO] running `Command { std: "docker" "start" "-a" "4896bbc081a4e118586a5378d4b274f770082fa3e540f73580ded712185f82ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4896bbc081a4e118586a5378d4b274f770082fa3e540f73580ded712185f82ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4896bbc081a4e118586a5378d4b274f770082fa3e540f73580ded712185f82ef", kill_on_drop: false }` [INFO] [stdout] 4896bbc081a4e118586a5378d4b274f770082fa3e540f73580ded712185f82ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd210a3cb0d5eaf60458189d9b2a4878681c6e9ff99450ebcd1ba66f692c41b8 [INFO] running `Command { std: "docker" "start" "-a" "bd210a3cb0d5eaf60458189d9b2a4878681c6e9ff99450ebcd1ba66f692c41b8", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking advent_of_code v0.9.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template/commands/all.rs:170:26 [INFO] [stdout] | [INFO] [stdout] 170 | let str_timing = line [INFO] [stdout] | __________________________^ [INFO] [stdout] 171 | | .split(" samples)") [INFO] [stdout] 172 | | .next()? [INFO] [stdout] 173 | | .split('(') [INFO] [stdout] 174 | | .last()? [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 174 - .last()? [INFO] [stdout] 174 + .next_back()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/template/commands/scaffold.rs:42:36 [INFO] [stdout] | [INFO] [stdout] 42 | OpenOptions::new().write(true).create(true).open(path) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/template/runner.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 54 | let bench_iterations = cmp::min( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 55 | | 10000, [INFO] [stdout] 56 | | cmp::max( [INFO] [stdout] 57 | | Duration::from_secs(1).as_nanos() / cmp::max(base_time.as_nanos(), 10), [INFO] [stdout] 58 | | 10, [INFO] [stdout] 59 | | ), [INFO] [stdout] 60 | | ); [INFO] [stdout] | |_____^ help: replace with clamp: `(Duration::from_secs(1).as_nanos() / cmp::max(base_time.as_nanos(), 10)).clamp(10, 10000)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template/commands/all.rs:170:26 [INFO] [stdout] | [INFO] [stdout] 170 | let str_timing = line [INFO] [stdout] | __________________________^ [INFO] [stdout] 171 | | .split(" samples)") [INFO] [stdout] 172 | | .next()? [INFO] [stdout] 173 | | .split('(') [INFO] [stdout] 174 | | .last()? [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 174 - .last()? [INFO] [stdout] 174 + .next_back()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/template/commands/scaffold.rs:42:36 [INFO] [stdout] | [INFO] [stdout] 42 | OpenOptions::new().write(true).create(true).open(path) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/template/runner.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 54 | let bench_iterations = cmp::min( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 55 | | 10000, [INFO] [stdout] 56 | | cmp::max( [INFO] [stdout] 57 | | Duration::from_secs(1).as_nanos() / cmp::max(base_time.as_nanos(), 10), [INFO] [stdout] 58 | | 10, [INFO] [stdout] 59 | | ), [INFO] [stdout] 60 | | ); [INFO] [stdout] | |_____^ help: replace with clamp: `(Duration::from_secs(1).as_nanos() / cmp::max(base_time.as_nanos(), 10)).clamp(10, 10000)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).all(identity)` [INFO] [stdout] --> src/bin/02.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|x| { [INFO] [stdout] | __________________^ [INFO] [stdout] 15 | | x.split(",") [INFO] [stdout] 16 | | .map(|y| { [INFO] [stdout] 17 | | let mut nums = y.split(" "); [INFO] [stdout] ... | [INFO] [stdout] 32 | | }) [INFO] [stdout] 33 | | .all(|x| x) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.all(...)` instead [INFO] [stdout] | [INFO] [stdout] 14 ~ .all(|x| { [INFO] [stdout] 15 + x.split(",") [INFO] [stdout] 16 + .map(|y| { [INFO] [stdout] 17 + let mut nums = y.split(" "); [INFO] [stdout] 18 + nums.next(); [INFO] [stdout] 19 + let amount = nums.next().unwrap().parse::().unwrap(); [INFO] [stdout] 20 + let color = nums.next().unwrap(); [INFO] [stdout] 21 + match color { [INFO] [stdout] 22 + "green" => amount < 14, [INFO] [stdout] 23 + "blue" => amount < 15, [INFO] [stdout] 24 + "red" => amount < 13, [INFO] [stdout] 25 + _ => { [INFO] [stdout] 26 + println!("{color}"); [INFO] [stdout] 27 + true [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] 30 + }) [INFO] [stdout] 31 + .all(|i| i) [INFO] [stdout] 32 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).all(identity)` [INFO] [stdout] --> src/bin/02.rs:16:26 [INFO] [stdout] | [INFO] [stdout] 16 | .map(|y| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 17 | | let mut nums = y.split(" "); [INFO] [stdout] 18 | | nums.next(); [INFO] [stdout] 19 | | let amount = nums.next().unwrap().parse::().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 30 | | }) [INFO] [stdout] 31 | | .all(|i| i) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] help: use `.all(...)` instead [INFO] [stdout] | [INFO] [stdout] 16 ~ .all(|y| { [INFO] [stdout] 17 + let mut nums = y.split(" "); [INFO] [stdout] 18 + nums.next(); [INFO] [stdout] 19 + let amount = nums.next().unwrap().parse::().unwrap(); [INFO] [stdout] 20 + let color = nums.next().unwrap(); [INFO] [stdout] 21 + match color { [INFO] [stdout] 22 + "green" => amount < 14, [INFO] [stdout] 23 + "blue" => amount < 15, [INFO] [stdout] 24 + "red" => amount < 13, [INFO] [stdout] 25 + _ => { [INFO] [stdout] 26 + println!("{color}"); [INFO] [stdout] 27 + true [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] 30 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/04.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return 0; [INFO] [stdout] 15 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/04.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | return 2_u32.pow(self.matches - 1) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return 2_u32.pow(self.matches - 1) as u32; [INFO] [stdout] 17 + 2_u32.pow(self.matches - 1) as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/bin/04.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | return 2_u32.pow(self.matches - 1) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `2_u32.pow(self.matches - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/bin/04.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | let mut dupes: Vec = vec![1; len as usize]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/04.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | .filter(|n| *n != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `temp.get(0)` [INFO] [stdout] --> src/bin/04.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | temp.get(0) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `temp.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/04.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | .intersection(&temp.get(1).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `temp.get(1).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).all(identity)` [INFO] [stdout] --> src/bin/02.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|x| { [INFO] [stdout] | __________________^ [INFO] [stdout] 15 | | x.split(",") [INFO] [stdout] 16 | | .map(|y| { [INFO] [stdout] 17 | | let mut nums = y.split(" "); [INFO] [stdout] ... | [INFO] [stdout] 32 | | }) [INFO] [stdout] 33 | | .all(|x| x) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.all(...)` instead [INFO] [stdout] | [INFO] [stdout] 14 ~ .all(|x| { [INFO] [stdout] 15 + x.split(",") [INFO] [stdout] 16 + .map(|y| { [INFO] [stdout] 17 + let mut nums = y.split(" "); [INFO] [stdout] 18 + nums.next(); [INFO] [stdout] 19 + let amount = nums.next().unwrap().parse::().unwrap(); [INFO] [stdout] 20 + let color = nums.next().unwrap(); [INFO] [stdout] 21 + match color { [INFO] [stdout] 22 + "green" => amount < 14, [INFO] [stdout] 23 + "blue" => amount < 15, [INFO] [stdout] 24 + "red" => amount < 13, [INFO] [stdout] 25 + _ => { [INFO] [stdout] 26 + println!("{color}"); [INFO] [stdout] 27 + true [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] 30 + }) [INFO] [stdout] 31 + .all(|i| i) [INFO] [stdout] 32 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).all(identity)` [INFO] [stdout] --> src/bin/02.rs:16:26 [INFO] [stdout] | [INFO] [stdout] 16 | .map(|y| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 17 | | let mut nums = y.split(" "); [INFO] [stdout] 18 | | nums.next(); [INFO] [stdout] 19 | | let amount = nums.next().unwrap().parse::().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 30 | | }) [INFO] [stdout] 31 | | .all(|i| i) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] help: use `.all(...)` instead [INFO] [stdout] | [INFO] [stdout] 16 ~ .all(|y| { [INFO] [stdout] 17 + let mut nums = y.split(" "); [INFO] [stdout] 18 + nums.next(); [INFO] [stdout] 19 + let amount = nums.next().unwrap().parse::().unwrap(); [INFO] [stdout] 20 + let color = nums.next().unwrap(); [INFO] [stdout] 21 + match color { [INFO] [stdout] 22 + "green" => amount < 14, [INFO] [stdout] 23 + "blue" => amount < 15, [INFO] [stdout] 24 + "red" => amount < 13, [INFO] [stdout] 25 + _ => { [INFO] [stdout] 26 + println!("{color}"); [INFO] [stdout] 27 + true [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] 30 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).any(identity)` [INFO] [stdout] --> src/bin/03.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 45 | ... .map(|(x, y)| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 46 | | ... lines.get(y).map_or(false, |column| { [INFO] [stdout] 47 | | ... column.get(x).map_or(false, |item| { [INFO] [stdout] 48 | | ... *item != "." && !item.parse::().is_ok() [INFO] [stdout] ... | [INFO] [stdout] 51 | | ... }) [INFO] [stdout] 52 | | ... .any(|f| f); [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.any(...)` instead [INFO] [stdout] | [INFO] [stdout] 45 ~ .any(|(x, y)| { [INFO] [stdout] 46 + lines.get(y).map_or(false, |column| { [INFO] [stdout] 47 + column.get(x).map_or(false, |item| { [INFO] [stdout] 48 + *item != "." && !item.parse::().is_ok() [INFO] [stdout] 49 + }) [INFO] [stdout] 50 + }) [INFO] [stdout] 51 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/bin/03.rs:46:37 [INFO] [stdout] | [INFO] [stdout] 46 | / ... lines.get(y).map_or(false, |column| { [INFO] [stdout] 47 | | ... column.get(x).map_or(false, |item| { [INFO] [stdout] 48 | | ... *item != "." && !item.parse::().is_ok() [INFO] [stdout] 49 | | ... }) [INFO] [stdout] 50 | | ... }) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 46 - lines.get(y).map_or(false, |column| { [INFO] [stdout] 46 + lines.get(y).is_some_and(|column| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/bin/03.rs:47:41 [INFO] [stdout] | [INFO] [stdout] 47 | / ... column.get(x).map_or(false, |item| { [INFO] [stdout] 48 | | ... *item != "." && !item.parse::().is_ok() [INFO] [stdout] 49 | | ... }) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 47 - column.get(x).map_or(false, |item| { [INFO] [stdout] 47 + column.get(x).is_some_and(|item| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/03.rs:48:61 [INFO] [stdout] | [INFO] [stdout] 48 | ... *item != "." && !item.parse::().is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/bin/03.rs:82:14 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|(y, c)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 83 | | c.chars() [INFO] [stdout] 84 | | .map(|f| f.to_string()) [INFO] [stdout] 85 | | .collect_vec() [INFO] [stdout] ... | [INFO] [stdout] 91 | | }) [INFO] [stdout] 92 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 82 ~ .flat_map(|(y, c)| { [INFO] [stdout] 83 + c.chars() [INFO] [stdout] 84 + .map(|f| f.to_string()) [INFO] [stdout] 85 + .collect_vec() [INFO] [stdout] 86 + .iter() [INFO] [stdout] 87 + .enumerate() [INFO] [stdout] 88 + .filter(|(_x, c)| *c == "*") [INFO] [stdout] 89 + .map(|(x, _)| (x, y)) [INFO] [stdout] 90 + .collect::>() [INFO] [stdout] 91 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/bin/03.rs:98:25 [INFO] [stdout] | [INFO] [stdout] 98 | / lines.get(y).map_or(None, |f| { [INFO] [stdout] 99 | | //println!("{:?}",f); [INFO] [stdout] 100 | | Some( [INFO] [stdout] 101 | | f.iter() [INFO] [stdout] ... | [INFO] [stdout] 127 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] = note: `#[warn(clippy::option_map_or_none)]` on by default [INFO] [stdout] help: consider using `map` [INFO] [stdout] | [INFO] [stdout] 98 ~ lines.get(y).map(|f| f.iter() [INFO] [stdout] 99 + .group_by(|f| { [INFO] [stdout] 100 + f.chars() [INFO] [stdout] 101 + .next() [INFO] [stdout] 102 + .expect("string should have one char") [INFO] [stdout] 103 + .is_ascii_digit() [INFO] [stdout] 104 + }) [INFO] [stdout] 105 + .into_iter() [INFO] [stdout] 106 + .map(|(g0, group)| { [INFO] [stdout] 107 + let g = group.collect_vec(); [INFO] [stdout] 108 + let len = g.len(); [INFO] [stdout] 109 + [INFO] [stdout] 110 + let num = [INFO] [stdout] 111 + g.iter().map(|c| c.to_string()).join("").parse().ok(); [INFO] [stdout] 112 + curr_x += len; [INFO] [stdout] 113 + RunP2 { [INFO] [stdout] 114 + pos: (curr_x - len, y), [INFO] [stdout] 115 + num, [INFO] [stdout] 116 + len: len - 1, [INFO] [stdout] 117 + is_num: g0, [INFO] [stdout] 118 + } [INFO] [stdout] 119 + }) [INFO] [stdout] 120 + .filter(|r| r.is_num) [INFO] [stdout] 121 + .filter(|r| x - 1 <= r.pos.0 + r.len && r.pos.0 <= x + 1) [INFO] [stdout] 122 + .collect_vec()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).any(identity)` [INFO] [stdout] --> src/bin/03.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 45 | ... .map(|(x, y)| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 46 | | ... lines.get(y).map_or(false, |column| { [INFO] [stdout] 47 | | ... column.get(x).map_or(false, |item| { [INFO] [stdout] 48 | | ... *item != "." && !item.parse::().is_ok() [INFO] [stdout] ... | [INFO] [stdout] 51 | | ... }) [INFO] [stdout] 52 | | ... .any(|f| f); [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.any(...)` instead [INFO] [stdout] | [INFO] [stdout] 45 ~ .any(|(x, y)| { [INFO] [stdout] 46 + lines.get(y).map_or(false, |column| { [INFO] [stdout] 47 + column.get(x).map_or(false, |item| { [INFO] [stdout] 48 + *item != "." && !item.parse::().is_ok() [INFO] [stdout] 49 + }) [INFO] [stdout] 50 + }) [INFO] [stdout] 51 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/bin/03.rs:46:37 [INFO] [stdout] | [INFO] [stdout] 46 | / ... lines.get(y).map_or(false, |column| { [INFO] [stdout] 47 | | ... column.get(x).map_or(false, |item| { [INFO] [stdout] 48 | | ... *item != "." && !item.parse::().is_ok() [INFO] [stdout] 49 | | ... }) [INFO] [stdout] 50 | | ... }) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 46 - lines.get(y).map_or(false, |column| { [INFO] [stdout] 46 + lines.get(y).is_some_and(|column| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/bin/03.rs:47:41 [INFO] [stdout] | [INFO] [stdout] 47 | / ... column.get(x).map_or(false, |item| { [INFO] [stdout] 48 | | ... *item != "." && !item.parse::().is_ok() [INFO] [stdout] 49 | | ... }) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 47 - column.get(x).map_or(false, |item| { [INFO] [stdout] 47 + column.get(x).is_some_and(|item| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/03.rs:48:61 [INFO] [stdout] | [INFO] [stdout] 48 | ... *item != "." && !item.parse::().is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/bin/03.rs:82:14 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|(y, c)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 83 | | c.chars() [INFO] [stdout] 84 | | .map(|f| f.to_string()) [INFO] [stdout] 85 | | .collect_vec() [INFO] [stdout] ... | [INFO] [stdout] 91 | | }) [INFO] [stdout] 92 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 82 ~ .flat_map(|(y, c)| { [INFO] [stdout] 83 + c.chars() [INFO] [stdout] 84 + .map(|f| f.to_string()) [INFO] [stdout] 85 + .collect_vec() [INFO] [stdout] 86 + .iter() [INFO] [stdout] 87 + .enumerate() [INFO] [stdout] 88 + .filter(|(_x, c)| *c == "*") [INFO] [stdout] 89 + .map(|(x, _)| (x, y)) [INFO] [stdout] 90 + .collect::>() [INFO] [stdout] 91 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/bin/03.rs:98:25 [INFO] [stdout] | [INFO] [stdout] 98 | / lines.get(y).map_or(None, |f| { [INFO] [stdout] 99 | | //println!("{:?}",f); [INFO] [stdout] 100 | | Some( [INFO] [stdout] 101 | | f.iter() [INFO] [stdout] ... | [INFO] [stdout] 127 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] = note: `#[warn(clippy::option_map_or_none)]` on by default [INFO] [stdout] help: consider using `map` [INFO] [stdout] | [INFO] [stdout] 98 ~ lines.get(y).map(|f| f.iter() [INFO] [stdout] 99 + .group_by(|f| { [INFO] [stdout] 100 + f.chars() [INFO] [stdout] 101 + .next() [INFO] [stdout] 102 + .expect("string should have one char") [INFO] [stdout] 103 + .is_ascii_digit() [INFO] [stdout] 104 + }) [INFO] [stdout] 105 + .into_iter() [INFO] [stdout] 106 + .map(|(g0, group)| { [INFO] [stdout] 107 + let g = group.collect_vec(); [INFO] [stdout] 108 + let len = g.len(); [INFO] [stdout] 109 + [INFO] [stdout] 110 + let num = [INFO] [stdout] 111 + g.iter().map(|c| c.to_string()).join("").parse().ok(); [INFO] [stdout] 112 + curr_x += len; [INFO] [stdout] 113 + RunP2 { [INFO] [stdout] 114 + pos: (curr_x - len, y), [INFO] [stdout] 115 + num, [INFO] [stdout] 116 + len: len - 1, [INFO] [stdout] 117 + is_num: g0, [INFO] [stdout] 118 + } [INFO] [stdout] 119 + }) [INFO] [stdout] 120 + .filter(|r| r.is_num) [INFO] [stdout] 121 + .filter(|r| x - 1 <= r.pos.0 + r.len && r.pos.0 <= x + 1) [INFO] [stdout] 122 + .collect_vec()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/04.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return 0; [INFO] [stdout] 15 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/04.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | return 2_u32.pow(self.matches - 1) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return 2_u32.pow(self.matches - 1) as u32; [INFO] [stdout] 17 + 2_u32.pow(self.matches - 1) as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/bin/04.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | return 2_u32.pow(self.matches - 1) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `2_u32.pow(self.matches - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/bin/04.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | let mut dupes: Vec = vec![1; len as usize]; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/04.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | .filter(|n| *n != "") [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `temp.get(0)` [INFO] [stdout] --> src/bin/04.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | temp.get(0) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `temp.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/04.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | .intersection(&temp.get(1).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `temp.get(1).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.37s [INFO] running `Command { std: "docker" "inspect" "bd210a3cb0d5eaf60458189d9b2a4878681c6e9ff99450ebcd1ba66f692c41b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd210a3cb0d5eaf60458189d9b2a4878681c6e9ff99450ebcd1ba66f692c41b8", kill_on_drop: false }` [INFO] [stdout] bd210a3cb0d5eaf60458189d9b2a4878681c6e9ff99450ebcd1ba66f692c41b8