[INFO] cloning repository https://github.com/waciejm/arlang [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/waciejm/arlang" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwaciejm%2Farlang", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwaciejm%2Farlang'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e5450d9fc1107db96f525729c276f11c90fb252c [INFO] linting waciejm/arlang against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwaciejm%2Farlang" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/waciejm/arlang [INFO] finished tweaking git repo https://github.com/waciejm/arlang [INFO] tweaked toml for git repo https://github.com/waciejm/arlang written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/waciejm/arlang on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/waciejm/arlang already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded utf8-decode v1.0.1 [INFO] [stderr] Downloaded structopt v0.3.25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 96008f9b23e52829dc207152b6429ddcd8676dee6b9bba00493ec92572bb5f0f [INFO] running `Command { std: "docker" "start" "-a" "96008f9b23e52829dc207152b6429ddcd8676dee6b9bba00493ec92572bb5f0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "96008f9b23e52829dc207152b6429ddcd8676dee6b9bba00493ec92572bb5f0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96008f9b23e52829dc207152b6429ddcd8676dee6b9bba00493ec92572bb5f0f", kill_on_drop: false }` [INFO] [stdout] 96008f9b23e52829dc207152b6429ddcd8676dee6b9bba00493ec92572bb5f0f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7efcf8f2214bc41851b156ba85c8489bad77e6f1058f468d58492551e2e163ea [INFO] running `Command { std: "docker" "start" "-a" "7efcf8f2214bc41851b156ba85c8489bad77e6f1058f468d58492551e2e163ea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling crossbeam-utils v0.8.6 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.6 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking utf8-decode v1.0.1 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking arlang v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/source/mod.rs:43:42 [INFO] [stdout] | [INFO] [stdout] 43 | let decoder = UnsafeDecoder::new(source.bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/tokenizer/mod.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | c if c == '"' => ControlFlow::Break(Some( [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - c if c == '"' => ControlFlow::Break(Some( [INFO] [stdout] 74 + '"' => ControlFlow::Break(Some( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/tokenizer/mod.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 65 | c if c.is_digit(10) => ControlFlow::Break(Some( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/tokenizer/mod.rs:171:49 [INFO] [stdout] | [INFO] [stdout] 171 | while self.src_iter.peek().is_some() && self.src_iter.peek().unwrap().char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.src_iter.peek().unwrap().char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/tokenizer/mod.rs:205:49 [INFO] [stdout] | [INFO] [stdout] 205 | while self.src_iter.peek().is_some() && self.src_iter.peek().unwrap().char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.src_iter.peek().unwrap().char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter/test.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 355 | (true && true).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter/test.rs:359:9 [INFO] [stdout] | [INFO] [stdout] 359 | (true && false).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter/test.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | (false && true).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter/test.rs:367:9 [INFO] [stdout] | [INFO] [stdout] 367 | (false && false).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter/test.rs:375:9 [INFO] [stdout] | [INFO] [stdout] 375 | (true || true).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter/test.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | (true || false).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter/test.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | (false || true).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter/test.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 387 | (false || false).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/interpreter/test.rs:463:9 [INFO] [stdout] | [INFO] [stdout] 463 | (1 as f64).to_string(), [INFO] [stdout] | ^^^^^^^^^^ help: try: `1_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/source/mod.rs:43:42 [INFO] [stdout] | [INFO] [stdout] 43 | let decoder = UnsafeDecoder::new(source.bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/tokenizer/mod.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | c if c == '"' => ControlFlow::Break(Some( [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - c if c == '"' => ControlFlow::Break(Some( [INFO] [stdout] 74 + '"' => ControlFlow::Break(Some( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/tokenizer/mod.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 65 | c if c.is_digit(10) => ControlFlow::Break(Some( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/tokenizer/mod.rs:171:49 [INFO] [stdout] | [INFO] [stdout] 171 | while self.src_iter.peek().is_some() && self.src_iter.peek().unwrap().char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.src_iter.peek().unwrap().char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/tokenizer/mod.rs:205:49 [INFO] [stdout] | [INFO] [stdout] 205 | while self.src_iter.peek().is_some() && self.src_iter.peek().unwrap().char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.src_iter.peek().unwrap().char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/source/test.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | let expected = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 9 | | SourceIterItem { [INFO] [stdout] 10 | | char: 'a', [INFO] [stdout] 11 | | index: SourceIndex::new(0, 0), [INFO] [stdout] ... | [INFO] [stdout] 28 | | }, [INFO] [stdout] 29 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 8 ~ let expected = [SourceIterItem { [INFO] [stdout] 9 + char: 'a', [INFO] [stdout] 10 + index: SourceIndex::new(0, 0), [INFO] [stdout] 11 + }, [INFO] [stdout] 12 + SourceIterItem { [INFO] [stdout] 13 + char: 'b', [INFO] [stdout] 14 + index: SourceIndex::new(0, 1), [INFO] [stdout] 15 + }, [INFO] [stdout] 16 + SourceIterItem { [INFO] [stdout] 17 + char: '\n', [INFO] [stdout] 18 + index: SourceIndex::new(0, 2), [INFO] [stdout] 19 + }, [INFO] [stdout] 20 + SourceIterItem { [INFO] [stdout] 21 + char: 'c', [INFO] [stdout] 22 + index: SourceIndex::new(1, 0), [INFO] [stdout] 23 + }, [INFO] [stdout] 24 + SourceIterItem { [INFO] [stdout] 25 + char: 'd', [INFO] [stdout] 26 + index: SourceIndex::new(1, 1), [INFO] [stdout] 27 ~ }]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.14s [INFO] running `Command { std: "docker" "inspect" "7efcf8f2214bc41851b156ba85c8489bad77e6f1058f468d58492551e2e163ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7efcf8f2214bc41851b156ba85c8489bad77e6f1058f468d58492551e2e163ea", kill_on_drop: false }` [INFO] [stdout] 7efcf8f2214bc41851b156ba85c8489bad77e6f1058f468d58492551e2e163ea