[INFO] cloning repository https://github.com/vpatrinica/adcp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/vpatrinica/adcp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvpatrinica%2Fadcp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvpatrinica%2Fadcp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 711d88b6d853d384cfcbc94ce668184edd66a2e9 [INFO] linting vpatrinica/adcp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvpatrinica%2Fadcp" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/vpatrinica/adcp [INFO] finished tweaking git repo https://github.com/vpatrinica/adcp [INFO] tweaked toml for git repo https://github.com/vpatrinica/adcp written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/vpatrinica/adcp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/vpatrinica/adcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded windows-service v0.8.0 [INFO] [stderr] Downloaded mio-serial v5.0.6 [INFO] [stderr] Downloaded tokio-task-pool v0.1.8 [INFO] [stderr] Downloaded busrt v0.4.22 [INFO] [stderr] Downloaded submap v0.3.5 [INFO] [stderr] Downloaded oneshot v0.1.11 [INFO] [stderr] Downloaded tokio-serial v5.4.5 [INFO] [stderr] Downloaded triggered v0.1.3 [INFO] [stderr] Downloaded unix-named-pipe v0.2.0 [INFO] [stderr] Downloaded serialport v4.8.1 [INFO] [stderr] Downloaded syn v2.0.113 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be6e6eba6016d32a64a818b93a0d8c7a9b3d748b26338716a05d57c46b252942 [INFO] running `Command { std: "docker" "start" "-a" "be6e6eba6016d32a64a818b93a0d8c7a9b3d748b26338716a05d57c46b252942", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be6e6eba6016d32a64a818b93a0d8c7a9b3d748b26338716a05d57c46b252942", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be6e6eba6016d32a64a818b93a0d8c7a9b3d748b26338716a05d57c46b252942", kill_on_drop: false }` [INFO] [stdout] be6e6eba6016d32a64a818b93a0d8c7a9b3d748b26338716a05d57c46b252942 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4eb201766e28464f2f15906d623489611ac9ced33d8497c536e38e5f70c05ab [INFO] running `Command { std: "docker" "start" "-a" "f4eb201766e28464f2f15906d623489611ac9ced33d8497c536e38e5f70c05ab", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.37.28 [INFO] [stderr] Compiling syn v2.0.113 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rmp v0.8.15 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking oneshot v0.1.11 [INFO] [stderr] Checking triggered v0.1.3 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking anyhow v1.0.100 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling assert_cmd v2.1.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking unix-named-pipe v0.2.0 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling stability v0.2.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking submap v0.3.5 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking unescaper v0.1.8 [INFO] [stderr] Checking serialport v4.8.1 [INFO] [stderr] Checking mio-serial v5.0.6 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.26.3 [INFO] [stderr] Checking tracing-appender v0.2.4 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking rmp-serde v1.3.1 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking tokio-task-pool v0.1.8 [INFO] [stderr] Checking tokio-serial v5.4.5 [INFO] [stderr] Checking busrt v0.4.22 [INFO] [stderr] Checking adcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/logging.rs:18:46 [INFO] [stdout] | [INFO] [stdout] 18 | std::fs::create_dir_all(log_dir).map_err(|e| Error::msg(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Error::msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/logging.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | .map_err(|err| Error::msg(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Error::msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Metrics` [INFO] [stdout] --> src/metrics.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | frames: AtomicU64::new(0), [INFO] [stdout] 22 | | parse_errors: AtomicU64::new(0), [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for Metrics { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/parser.rs:106:41 [INFO] [stdout] | [INFO] [stdout] 106 | let raw = line.trim_end_matches(|c| c == '\r' || c == '\n').trim(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\r', '\n']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `fields.get(0)` [INFO] [stdout] --> src/parser.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | let ident = fields [INFO] [stdout] | _____________________^ [INFO] [stdout] 110 | | .get(0) [INFO] [stdout] | |___________________^ help: try: `fields.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser.rs:164:16 [INFO] [stdout] | [INFO] [stdout] 164 | } else if !c.is_whitespace() { [INFO] [stdout] | ________________^ [INFO] [stdout] 165 | | if !hex_chars.is_empty() { [INFO] [stdout] 166 | | break; [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 164 ~ } else if !c.is_whitespace() [INFO] [stdout] 165 ~ && !hex_chars.is_empty() { [INFO] [stdout] 166 | break; [INFO] [stdout] 167 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/parser.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if found_pos.map_or(true, |p| pos < p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 188 - if found_pos.map_or(true, |p| pos < p) { [INFO] [stdout] 188 + if found_pos.is_none_or(|p| pos < p) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/serial.rs:63:31 [INFO] [stdout] | [INFO] [stdout] 63 | .trim_end_matches(|c| c == '\r' || c == '\n') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\r', '\n']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/service.rs:523:14 [INFO] [stdout] | [INFO] [stdout] 523 | .create(true) // Ensure file is created if not already there (especially for Windows "FIFO" simulation) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/processing.rs:159:31 [INFO] [stdout] | [INFO] [stdout] 159 | async fn write_failures(path: &PathBuf, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 159 - async fn write_failures(path: &PathBuf, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] 159 + async fn write_failures(path: &Path, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/processing.rs:159:56 [INFO] [stdout] | [INFO] [stdout] 159 | async fn write_failures(path: &PathBuf, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 159 - async fn write_failures(path: &PathBuf, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] 159 + async fn write_failures(path: &PathBuf, processed_dir: &Path, failures: &[String]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/processing.rs:169:59 [INFO] [stdout] | [INFO] [stdout] 169 | async fn move_to_processed(path: &PathBuf, processed_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 169 - async fn move_to_processed(path: &PathBuf, processed_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 169 + async fn move_to_processed(path: &PathBuf, processed_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/processing.rs:203:53 [INFO] [stdout] | [INFO] [stdout] 203 | async fn move_failed(path: &PathBuf, processed_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 203 - async fn move_failed(path: &PathBuf, processed_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 203 + async fn move_failed(path: &PathBuf, processed_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `adcp::AppConfig` [INFO] [stdout] --> src/bin/adcp-cli.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use adcp::AppConfig; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/adcp-core-starter.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | .args(&["run", "--bin", name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["run", "--bin", name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/backup.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub struct Backup { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | impl Backup { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Backend` [INFO] [stdout] --> src/bin/adcp-cli.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | backend::{Backend, CrosstermBackend}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/adcp-core-starter.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | .args(&["run", "--bin", name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["run", "--bin", name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/logging.rs:18:46 [INFO] [stdout] | [INFO] [stdout] 18 | std::fs::create_dir_all(log_dir).map_err(|e| Error::msg(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Error::msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/logging.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | .map_err(|err| Error::msg(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Error::msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Metrics` [INFO] [stdout] --> src/metrics.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | frames: AtomicU64::new(0), [INFO] [stdout] 22 | | parse_errors: AtomicU64::new(0), [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for Metrics { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/pipeline.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | let lines = vec![ [INFO] [stdout] | _____________________^ [INFO] [stdout] 15 | | "$PNORS,010526,220800,00000000,3ED40002,23.7,1532.0,275.4,-49.1,83.0,0.000,24.02,0,0*77", [INFO] [stdout] 16 | | "$PNORC,010526,220800,1,-32.77,-32.77,-32.77,-32.77,46.34,225.0,C,65,64,61,59,40,37,14,22*35", [INFO] [stdout] 17 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 14 ~ let lines = ["$PNORS,010526,220800,00000000,3ED40002,23.7,1532.0,275.4,-49.1,83.0,0.000,24.02,0,0*77", [INFO] [stdout] 15 ~ "$PNORC,010526,220800,1,-32.77,-32.77,-32.77,-32.77,46.34,225.0,C,65,64,61,59,40,37,14,22*35"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `busrt::client::AsyncClient` [INFO] [stdout] --> src/bin/adcp-proc-manager.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use busrt::client::AsyncClient; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mutex` [INFO] [stdout] --> src/bin/adcp-proc-manager.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `busrt::client::AsyncClient` [INFO] [stdout] --> src/bin/adcp-conf-manager.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use busrt::client::AsyncClient; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rpc` [INFO] [stdout] --> src/bin/adcp-conf-manager.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | use busrt::rpc::{Rpc, RpcClient, RpcEvent, RpcError, RpcHandlers, RpcResult, RPC_ERROR_CODE_INTERNAL}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `adcp::AppConfig` [INFO] [stdout] --> src/bin/adcp-cli.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use adcp::AppConfig; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/parser.rs:106:41 [INFO] [stdout] | [INFO] [stdout] 106 | let raw = line.trim_end_matches(|c| c == '\r' || c == '\n').trim(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\r', '\n']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `fields.get(0)` [INFO] [stdout] --> src/parser.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | let ident = fields [INFO] [stdout] | _____________________^ [INFO] [stdout] 110 | | .get(0) [INFO] [stdout] | |___________________^ help: try: `fields.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/parser.rs:164:16 [INFO] [stdout] | [INFO] [stdout] 164 | } else if !c.is_whitespace() { [INFO] [stdout] | ________________^ [INFO] [stdout] 165 | | if !hex_chars.is_empty() { [INFO] [stdout] 166 | | break; [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 164 ~ } else if !c.is_whitespace() [INFO] [stdout] 165 ~ && !hex_chars.is_empty() { [INFO] [stdout] 166 | break; [INFO] [stdout] 167 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/parser.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if found_pos.map_or(true, |p| pos < p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 188 - if found_pos.map_or(true, |p| pos < p) { [INFO] [stdout] 188 + if found_pos.is_none_or(|p| pos < p) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Backend` [INFO] [stdout] --> src/bin/adcp-cli.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | backend::{Backend, CrosstermBackend}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/bin/adcp-proc-manager.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | while let Some(entry) = entries.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for entry in entries` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SerialStream` [INFO] [stdout] --> src/bin/adcp-port-recorder.rs:10:42 [INFO] [stdout] | [INFO] [stdout] 10 | use tokio_serial::{SerialPortBuilderExt, SerialStream}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/serial.rs:63:31 [INFO] [stdout] | [INFO] [stdout] 63 | .trim_end_matches(|c| c == '\r' || c == '\n') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\r', '\n']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `busrt::client::AsyncClient` [INFO] [stdout] --> src/bin/adcp-proc-manager.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use busrt::client::AsyncClient; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mutex` [INFO] [stdout] --> src/bin/adcp-proc-manager.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/bin/adcp-proc-manager.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | while let Some(entry) = entries.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for entry in entries` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SerialStream` [INFO] [stdout] --> src/bin/adcp-port-recorder.rs:10:42 [INFO] [stdout] | [INFO] [stdout] 10 | use tokio_serial::{SerialPortBuilderExt, SerialStream}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `busrt::client::AsyncClient` [INFO] [stdout] --> src/bin/adcp-conf-manager.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use busrt::client::AsyncClient; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rpc` [INFO] [stdout] --> src/bin/adcp-conf-manager.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | use busrt::rpc::{Rpc, RpcClient, RpcEvent, RpcError, RpcHandlers, RpcResult, RPC_ERROR_CODE_INTERNAL}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/service.rs:523:14 [INFO] [stdout] | [INFO] [stdout] 523 | .create(true) // Ensure file is created if not already there (especially for Windows "FIFO" simulation) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/processing.rs:159:31 [INFO] [stdout] | [INFO] [stdout] 159 | async fn write_failures(path: &PathBuf, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 159 - async fn write_failures(path: &PathBuf, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] 159 + async fn write_failures(path: &Path, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/processing.rs:159:56 [INFO] [stdout] | [INFO] [stdout] 159 | async fn write_failures(path: &PathBuf, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 159 - async fn write_failures(path: &PathBuf, processed_dir: &PathBuf, failures: &[String]) -> Result<()> { [INFO] [stdout] 159 + async fn write_failures(path: &PathBuf, processed_dir: &Path, failures: &[String]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/processing.rs:169:59 [INFO] [stdout] | [INFO] [stdout] 169 | async fn move_to_processed(path: &PathBuf, processed_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 169 - async fn move_to_processed(path: &PathBuf, processed_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 169 + async fn move_to_processed(path: &PathBuf, processed_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/processing.rs:203:53 [INFO] [stdout] | [INFO] [stdout] 203 | async fn move_failed(path: &PathBuf, processed_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 203 - async fn move_failed(path: &PathBuf, processed_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 203 + async fn move_failed(path: &PathBuf, processed_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/processing.rs:320:17 [INFO] [stdout] | [INFO] [stdout] 320 | assert!(!fs::metadata(&sample).await.is_ok(), "sample should be moved after writer marker is cleared"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&sample).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `Command { std: "docker" "inspect" "f4eb201766e28464f2f15906d623489611ac9ced33d8497c536e38e5f70c05ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4eb201766e28464f2f15906d623489611ac9ced33d8497c536e38e5f70c05ab", kill_on_drop: false }` [INFO] [stdout] f4eb201766e28464f2f15906d623489611ac9ced33d8497c536e38e5f70c05ab