[INFO] cloning repository https://github.com/voronaam/pdfbase64tofile [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/voronaam/pdfbase64tofile" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvoronaam%2Fpdfbase64tofile", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvoronaam%2Fpdfbase64tofile'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 37e0aed75e3a5da56c41bf0b402f382dde3780f9 [INFO] linting voronaam/pdfbase64tofile against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvoronaam%2Fpdfbase64tofile" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/voronaam/pdfbase64tofile [INFO] finished tweaking git repo https://github.com/voronaam/pdfbase64tofile [INFO] tweaked toml for git repo https://github.com/voronaam/pdfbase64tofile written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/voronaam/pdfbase64tofile on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/voronaam/pdfbase64tofile already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wayland-scanner v0.31.8 [INFO] [stderr] Downloaded wayland-sys v0.31.8 [INFO] [stderr] Downloaded piston-float v1.0.1 [INFO] [stderr] Downloaded wayland-cursor v0.31.12 [INFO] [stderr] Downloaded wayland-protocols-misc v0.3.10 [INFO] [stderr] Downloaded maybe-owned v0.3.4 [INFO] [stderr] Downloaded zbus_xml v5.1.0 [INFO] [stderr] Downloaded zvariant_utils v3.3.0 [INFO] [stderr] Downloaded zbus_names v4.3.1 [INFO] [stderr] Downloaded zbus_macros v5.13.2 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.10 [INFO] [stderr] Downloaded zvariant_derive v5.9.2 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.10 [INFO] [stderr] Downloaded zvariant v5.9.2 [INFO] [stderr] Downloaded zerocopy-derive v0.8.38 [INFO] [stderr] Downloaded wayland-protocols v0.32.10 [INFO] [stderr] Downloaded wayland-client v0.31.12 [INFO] [stderr] Downloaded rfd v0.17.2 [INFO] [stderr] Downloaded zbus v5.13.2 [INFO] [stderr] Downloaded quick-xml v0.38.4 [INFO] [stderr] Downloaded utf16string v0.2.0 [INFO] [stderr] Downloaded wayland-backend v0.3.12 [INFO] [stderr] Downloaded zerocopy v0.8.38 [INFO] [stderr] Downloaded pdfium-render v0.8.37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8db81ee45085fefd5456ba88ce5631658d00c1751c319e4c44b07a927cb2a5a2 [INFO] running `Command { std: "docker" "start" "-a" "8db81ee45085fefd5456ba88ce5631658d00c1751c319e4c44b07a927cb2a5a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8db81ee45085fefd5456ba88ce5631658d00c1751c319e4c44b07a927cb2a5a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8db81ee45085fefd5456ba88ce5631658d00c1751c319e4c44b07a927cb2a5a2", kill_on_drop: false }` [INFO] [stdout] 8db81ee45085fefd5456ba88ce5631658d00c1751c319e4c44b07a927cb2a5a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a46a0d4017940f1b27aa6843319f540e8559c5e39b8f8cedb58e1345aa8ba11 [INFO] running `Command { std: "docker" "start" "-a" "5a46a0d4017940f1b27aa6843319f540e8559c5e39b8f8cedb58e1345aa8ba11", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zerocopy v0.8.38 [INFO] [stderr] Compiling endi v1.1.1 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking syn v2.0.114 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling built v0.8.0 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking accesskit v0.21.1 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking avif-serialize v0.8.6 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking accesskit_consumer v0.31.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking epaint_default_fonts v0.33.3 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Checking piston-float v1.0.1 [INFO] [stderr] Compiling rfd v0.17.2 [INFO] [stderr] Compiling pdfium-render v0.8.37 [INFO] [stderr] Checking vecmath v1.0.0 [INFO] [stderr] Checking utf16string v0.2.0 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerocopy-derive v0.8.38 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.33.3 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking ecolor v0.33.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking zvariant_utils v3.3.0 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Compiling zvariant_derive v5.9.2 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling zvariant v5.9.2 [INFO] [stderr] Checking webbrowser v1.0.6 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking epaint v0.33.3 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking zbus_names v4.3.1 [INFO] [stderr] Checking egui v0.33.3 [INFO] [stderr] Checking zbus_xml v5.1.0 [INFO] [stderr] Checking zbus-lockstep v0.5.2 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Compiling zbus_macros v5.13.2 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.2 [INFO] [stderr] Checking egui_glow v0.33.3 [INFO] [stderr] Checking zbus v5.13.2 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking wayland-protocols-misc v0.3.10 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking glutin-winit v0.5.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.14.2 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.17.2 [INFO] [stderr] Checking accesskit_winit v0.29.2 [INFO] [stderr] Checking egui-winit v0.33.3 [INFO] [stderr] Checking eframe v0.33.3 [INFO] [stderr] Checking pdfbase64tofile v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | / if let Some(file_name) = entry.file_name().to_str() { [INFO] [stdout] 103 | | if let Some(captures) = file_name.strip_prefix("page").and_then(|s| s.strip_suffix(".txt")) { [INFO] [stdout] 104 | | if let Ok(index) = captures.parse::() { [INFO] [stdout] 105 | | if index > max_index { [INFO] [stdout] ... | [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 102 ~ if let Some(file_name) = entry.file_name().to_str() [INFO] [stdout] 103 ~ && let Some(captures) = file_name.strip_prefix("page").and_then(|s| s.strip_suffix(".txt")) { [INFO] [stdout] 104 | if let Ok(index) = captures.parse::() { [INFO] [stdout] ... [INFO] [stdout] 108 | } [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | / if let Some(captures) = file_name.strip_prefix("page").and_then(|s| s.strip_suffix(".txt")) { [INFO] [stdout] 104 | | if let Ok(index) = captures.parse::() { [INFO] [stdout] 105 | | if index > max_index { [INFO] [stdout] 106 | | max_index = index - 1; [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 103 ~ if let Some(captures) = file_name.strip_prefix("page").and_then(|s| s.strip_suffix(".txt")) [INFO] [stdout] 104 ~ && let Ok(index) = captures.parse::() { [INFO] [stdout] 105 | if index > max_index { [INFO] [stdout] 106 | max_index = index - 1; [INFO] [stdout] 107 | } [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Ok(index) = captures.parse::() { [INFO] [stdout] 105 | | if index > max_index { [INFO] [stdout] 106 | | max_index = index - 1; [INFO] [stdout] 107 | | } [INFO] [stdout] 108 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if let Ok(index) = captures.parse::() [INFO] [stdout] 105 ~ && index > max_index { [INFO] [stdout] 106 | max_index = index - 1; [INFO] [stdout] 107 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(doc) = &self.document { [INFO] [stdout] 119 | | if let Ok(page) = doc.pages().get(index) { [INFO] [stdout] 120 | | // 1. Render Page to Bitmap [INFO] [stdout] 121 | | let bitmap = page.render(2000, 2000, None).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 154 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(doc) = &self.document [INFO] [stdout] 119 ~ && let Ok(page) = doc.pages().get(index) { [INFO] [stdout] 120 | // 1. Render Page to Bitmap [INFO] [stdout] ... [INFO] [stdout] 152 | self.current_page_index = index; [INFO] [stdout] 153 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | / if let Some(doc) = &self.document { [INFO] [stdout] 161 | | if let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 162 | | let boundaries = page.boundaries(); [INFO] [stdout] 163 | | let crop = boundaries [INFO] [stdout] ... | [INFO] [stdout] 214 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 160 ~ if let Some(doc) = &self.document [INFO] [stdout] 161 ~ && let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 162 | let boundaries = page.boundaries(); [INFO] [stdout] ... [INFO] [stdout] 212 | } [INFO] [stdout] 213 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/main.rs:449:33 [INFO] [stdout] | [INFO] [stdout] 449 | self.load_page(ctx, idx as u16); [INFO] [stdout] | ^^^^^^^^^^ help: try: `idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:498:73 [INFO] [stdout] | [INFO] [stdout] 498 | self.text_content.replace_range(idx..idx+replacement.0, &replacement.1); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `replacement.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:506:9 [INFO] [stdout] | [INFO] [stdout] 506 | / if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 507 | | if let Some(range) = state.cursor.char_range() { [INFO] [stdout] 508 | | // Get the index of the cursor (primary selection point) [INFO] [stdout] 509 | | let char_idx = range.primary.index; [INFO] [stdout] ... | [INFO] [stdout] 520 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 506 ~ if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) [INFO] [stdout] 507 ~ && let Some(range) = state.cursor.char_range() { [INFO] [stdout] 508 | // Get the index of the cursor (primary selection point) [INFO] [stdout] ... [INFO] [stdout] 518 | return format!("{}", line_count + 1); [INFO] [stdout] 519 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/main.rs:539:9 [INFO] [stdout] | [INFO] [stdout] 539 | child.expect("Failed to launch display script"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- help: try: `.wait()` [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 547 | / if let Some(mut state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 548 | | if let Some(range) = state.cursor.char_range() { [INFO] [stdout] 549 | | let cursor_idx = range.primary.index; [INFO] [stdout] 550 | | let chars: Vec = self.text_content.chars().collect(); [INFO] [stdout] ... | [INFO] [stdout] 678 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 547 ~ if let Some(mut state) = egui::text_edit::TextEditState::load(ctx, text_id) [INFO] [stdout] 548 ~ && let Some(range) = state.cursor.char_range() { [INFO] [stdout] 549 | let cursor_idx = range.primary.index; [INFO] [stdout] ... [INFO] [stdout] 676 | } [INFO] [stdout] 677 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `chars` [INFO] [stdout] --> src/main.rs:561:26 [INFO] [stdout] | [INFO] [stdout] 561 | for i in cursor_idx..chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 561 - for i in cursor_idx..chars.len() { [INFO] [stdout] 561 + for (i, ) in chars.iter().enumerate().skip(cursor_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:585:21 [INFO] [stdout] | [INFO] [stdout] 585 | / if let Some(doc) = &self.document { [INFO] [stdout] 586 | | if let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 587 | | if let Ok(text_page) = page.text() { [INFO] [stdout] ... | [INFO] [stdout] 675 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 585 ~ if let Some(doc) = &self.document [INFO] [stdout] 586 ~ && let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 587 | if let Ok(text_page) = page.text() { [INFO] [stdout] ... [INFO] [stdout] 673 | } [INFO] [stdout] 674 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:586:25 [INFO] [stdout] | [INFO] [stdout] 586 | / if let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 587 | | if let Ok(text_page) = page.text() { [INFO] [stdout] ... | [INFO] [stdout] 674 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 586 ~ if let Ok(page) = doc.pages().get(self.current_page_index) [INFO] [stdout] 587 ~ && let Ok(text_page) = page.text() { [INFO] [stdout] 588 | [INFO] [stdout] ... [INFO] [stdout] 672 | } [INFO] [stdout] 673 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:594:33 [INFO] [stdout] | [INFO] [stdout] 594 | / ... if let Some(obj_a) = obj_a_opt { [INFO] [stdout] 595 | | ... if let Ok(rect_a) = obj_a.loose_bounds() { [INFO] [stdout] ... | [INFO] [stdout] 672 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 594 ~ if let Some(obj_a) = obj_a_opt [INFO] [stdout] 595 ~ && let Ok(rect_a) = obj_a.loose_bounds() { [INFO] [stdout] 596 | [INFO] [stdout] ... [INFO] [stdout] 670 | } [INFO] [stdout] 671 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:761:25 [INFO] [stdout] | [INFO] [stdout] 761 | / if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 762 | | if let Some(range) = state.cursor.char_range() { [INFO] [stdout] 763 | | let highlights = self.get_highlights(range); [INFO] [stdout] ... | [INFO] [stdout] 822 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 761 ~ if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) [INFO] [stdout] 762 ~ && let Some(range) = state.cursor.char_range() { [INFO] [stdout] 763 | let highlights = self.get_highlights(range); [INFO] [stdout] ... [INFO] [stdout] 820 | } [INFO] [stdout] 821 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:883:25 [INFO] [stdout] | [INFO] [stdout] 883 | / if ctx.input(|i| i.key_pressed(egui::Key::Space) && i.modifiers.ctrl) { [INFO] [stdout] 884 | | if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 885 | | self.cycle_common_problem(state); [INFO] [stdout] 886 | | } [INFO] [stdout] 887 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 883 ~ if ctx.input(|i| i.key_pressed(egui::Key::Space) && i.modifiers.ctrl) [INFO] [stdout] 884 ~ && let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 885 | self.cycle_common_problem(state); [INFO] [stdout] 886 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:900:25 [INFO] [stdout] | [INFO] [stdout] 900 | / if text_edit_response.response.has_focus() { [INFO] [stdout] 901 | | if let Some(cursor_range) = text_edit_response.cursor_range { [INFO] [stdout] 902 | | let cursor_relative_rect = text_edit_response.galley.pos_from_cursor(cursor_range.primary); [INFO] [stdout] ... | [INFO] [stdout] 908 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 900 ~ if text_edit_response.response.has_focus() [INFO] [stdout] 901 ~ && let Some(cursor_range) = text_edit_response.cursor_range { [INFO] [stdout] 902 | let cursor_relative_rect = text_edit_response.galley.pos_from_cursor(cursor_range.primary); [INFO] [stdout] ... [INFO] [stdout] 906 | ui.scroll_to_rect(cursor_screen_rect, None); [INFO] [stdout] 907 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:914:50 [INFO] [stdout] | [INFO] [stdout] 914 | self.get_current_line_number(&ctx), [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | / if let Some(file_name) = entry.file_name().to_str() { [INFO] [stdout] 103 | | if let Some(captures) = file_name.strip_prefix("page").and_then(|s| s.strip_suffix(".txt")) { [INFO] [stdout] 104 | | if let Ok(index) = captures.parse::() { [INFO] [stdout] 105 | | if index > max_index { [INFO] [stdout] ... | [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 102 ~ if let Some(file_name) = entry.file_name().to_str() [INFO] [stdout] 103 ~ && let Some(captures) = file_name.strip_prefix("page").and_then(|s| s.strip_suffix(".txt")) { [INFO] [stdout] 104 | if let Ok(index) = captures.parse::() { [INFO] [stdout] ... [INFO] [stdout] 108 | } [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | / if let Some(captures) = file_name.strip_prefix("page").and_then(|s| s.strip_suffix(".txt")) { [INFO] [stdout] 104 | | if let Ok(index) = captures.parse::() { [INFO] [stdout] 105 | | if index > max_index { [INFO] [stdout] 106 | | max_index = index - 1; [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 103 ~ if let Some(captures) = file_name.strip_prefix("page").and_then(|s| s.strip_suffix(".txt")) [INFO] [stdout] 104 ~ && let Ok(index) = captures.parse::() { [INFO] [stdout] 105 | if index > max_index { [INFO] [stdout] 106 | max_index = index - 1; [INFO] [stdout] 107 | } [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Ok(index) = captures.parse::() { [INFO] [stdout] 105 | | if index > max_index { [INFO] [stdout] 106 | | max_index = index - 1; [INFO] [stdout] 107 | | } [INFO] [stdout] 108 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if let Ok(index) = captures.parse::() [INFO] [stdout] 105 ~ && index > max_index { [INFO] [stdout] 106 | max_index = index - 1; [INFO] [stdout] 107 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(doc) = &self.document { [INFO] [stdout] 119 | | if let Ok(page) = doc.pages().get(index) { [INFO] [stdout] 120 | | // 1. Render Page to Bitmap [INFO] [stdout] 121 | | let bitmap = page.render(2000, 2000, None).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 154 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(doc) = &self.document [INFO] [stdout] 119 ~ && let Ok(page) = doc.pages().get(index) { [INFO] [stdout] 120 | // 1. Render Page to Bitmap [INFO] [stdout] ... [INFO] [stdout] 152 | self.current_page_index = index; [INFO] [stdout] 153 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | / if let Some(doc) = &self.document { [INFO] [stdout] 161 | | if let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 162 | | let boundaries = page.boundaries(); [INFO] [stdout] 163 | | let crop = boundaries [INFO] [stdout] ... | [INFO] [stdout] 214 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 160 ~ if let Some(doc) = &self.document [INFO] [stdout] 161 ~ && let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 162 | let boundaries = page.boundaries(); [INFO] [stdout] ... [INFO] [stdout] 212 | } [INFO] [stdout] 213 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/main.rs:449:33 [INFO] [stdout] | [INFO] [stdout] 449 | self.load_page(ctx, idx as u16); [INFO] [stdout] | ^^^^^^^^^^ help: try: `idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:498:73 [INFO] [stdout] | [INFO] [stdout] 498 | self.text_content.replace_range(idx..idx+replacement.0, &replacement.1); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `replacement.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:506:9 [INFO] [stdout] | [INFO] [stdout] 506 | / if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 507 | | if let Some(range) = state.cursor.char_range() { [INFO] [stdout] 508 | | // Get the index of the cursor (primary selection point) [INFO] [stdout] 509 | | let char_idx = range.primary.index; [INFO] [stdout] ... | [INFO] [stdout] 520 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 506 ~ if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) [INFO] [stdout] 507 ~ && let Some(range) = state.cursor.char_range() { [INFO] [stdout] 508 | // Get the index of the cursor (primary selection point) [INFO] [stdout] ... [INFO] [stdout] 518 | return format!("{}", line_count + 1); [INFO] [stdout] 519 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/main.rs:539:9 [INFO] [stdout] | [INFO] [stdout] 539 | child.expect("Failed to launch display script"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- help: try: `.wait()` [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 547 | / if let Some(mut state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 548 | | if let Some(range) = state.cursor.char_range() { [INFO] [stdout] 549 | | let cursor_idx = range.primary.index; [INFO] [stdout] 550 | | let chars: Vec = self.text_content.chars().collect(); [INFO] [stdout] ... | [INFO] [stdout] 678 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 547 ~ if let Some(mut state) = egui::text_edit::TextEditState::load(ctx, text_id) [INFO] [stdout] 548 ~ && let Some(range) = state.cursor.char_range() { [INFO] [stdout] 549 | let cursor_idx = range.primary.index; [INFO] [stdout] ... [INFO] [stdout] 676 | } [INFO] [stdout] 677 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `chars` [INFO] [stdout] --> src/main.rs:561:26 [INFO] [stdout] | [INFO] [stdout] 561 | for i in cursor_idx..chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 561 - for i in cursor_idx..chars.len() { [INFO] [stdout] 561 + for (i, ) in chars.iter().enumerate().skip(cursor_idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:585:21 [INFO] [stdout] | [INFO] [stdout] 585 | / if let Some(doc) = &self.document { [INFO] [stdout] 586 | | if let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 587 | | if let Ok(text_page) = page.text() { [INFO] [stdout] ... | [INFO] [stdout] 675 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 585 ~ if let Some(doc) = &self.document [INFO] [stdout] 586 ~ && let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 587 | if let Ok(text_page) = page.text() { [INFO] [stdout] ... [INFO] [stdout] 673 | } [INFO] [stdout] 674 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:586:25 [INFO] [stdout] | [INFO] [stdout] 586 | / if let Ok(page) = doc.pages().get(self.current_page_index) { [INFO] [stdout] 587 | | if let Ok(text_page) = page.text() { [INFO] [stdout] ... | [INFO] [stdout] 674 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 586 ~ if let Ok(page) = doc.pages().get(self.current_page_index) [INFO] [stdout] 587 ~ && let Ok(text_page) = page.text() { [INFO] [stdout] 588 | [INFO] [stdout] ... [INFO] [stdout] 672 | } [INFO] [stdout] 673 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:594:33 [INFO] [stdout] | [INFO] [stdout] 594 | / ... if let Some(obj_a) = obj_a_opt { [INFO] [stdout] 595 | | ... if let Ok(rect_a) = obj_a.loose_bounds() { [INFO] [stdout] ... | [INFO] [stdout] 672 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 594 ~ if let Some(obj_a) = obj_a_opt [INFO] [stdout] 595 ~ && let Ok(rect_a) = obj_a.loose_bounds() { [INFO] [stdout] 596 | [INFO] [stdout] ... [INFO] [stdout] 670 | } [INFO] [stdout] 671 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:761:25 [INFO] [stdout] | [INFO] [stdout] 761 | / if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 762 | | if let Some(range) = state.cursor.char_range() { [INFO] [stdout] 763 | | let highlights = self.get_highlights(range); [INFO] [stdout] ... | [INFO] [stdout] 822 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 761 ~ if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) [INFO] [stdout] 762 ~ && let Some(range) = state.cursor.char_range() { [INFO] [stdout] 763 | let highlights = self.get_highlights(range); [INFO] [stdout] ... [INFO] [stdout] 820 | } [INFO] [stdout] 821 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:883:25 [INFO] [stdout] | [INFO] [stdout] 883 | / if ctx.input(|i| i.key_pressed(egui::Key::Space) && i.modifiers.ctrl) { [INFO] [stdout] 884 | | if let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 885 | | self.cycle_common_problem(state); [INFO] [stdout] 886 | | } [INFO] [stdout] 887 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 883 ~ if ctx.input(|i| i.key_pressed(egui::Key::Space) && i.modifiers.ctrl) [INFO] [stdout] 884 ~ && let Some(state) = egui::text_edit::TextEditState::load(ctx, text_id) { [INFO] [stdout] 885 | self.cycle_common_problem(state); [INFO] [stdout] 886 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:900:25 [INFO] [stdout] | [INFO] [stdout] 900 | / if text_edit_response.response.has_focus() { [INFO] [stdout] 901 | | if let Some(cursor_range) = text_edit_response.cursor_range { [INFO] [stdout] 902 | | let cursor_relative_rect = text_edit_response.galley.pos_from_cursor(cursor_range.primary); [INFO] [stdout] ... | [INFO] [stdout] 908 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 900 ~ if text_edit_response.response.has_focus() [INFO] [stdout] 901 ~ && let Some(cursor_range) = text_edit_response.cursor_range { [INFO] [stdout] 902 | let cursor_relative_rect = text_edit_response.galley.pos_from_cursor(cursor_range.primary); [INFO] [stdout] ... [INFO] [stdout] 906 | ui.scroll_to_rect(cursor_screen_rect, None); [INFO] [stdout] 907 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:914:50 [INFO] [stdout] | [INFO] [stdout] 914 | self.get_current_line_number(&ctx), [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 44s [INFO] running `Command { std: "docker" "inspect" "5a46a0d4017940f1b27aa6843319f540e8559c5e39b8f8cedb58e1345aa8ba11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a46a0d4017940f1b27aa6843319f540e8559c5e39b8f8cedb58e1345aa8ba11", kill_on_drop: false }` [INFO] [stdout] 5a46a0d4017940f1b27aa6843319f540e8559c5e39b8f8cedb58e1345aa8ba11