[INFO] cloning repository https://github.com/vixalie/interactive-model-downloader [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/vixalie/interactive-model-downloader" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvixalie%2Finteractive-model-downloader", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvixalie%2Finteractive-model-downloader'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8e58aa27c9055923724b1cc000d086a8b46e13f3 [INFO] linting vixalie/interactive-model-downloader against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvixalie%2Finteractive-model-downloader" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/vixalie/interactive-model-downloader [INFO] finished tweaking git repo https://github.com/vixalie/interactive-model-downloader [INFO] tweaked toml for git repo https://github.com/vixalie/interactive-model-downloader written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/vixalie/interactive-model-downloader on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/vixalie/interactive-model-downloader already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded markup5ever_rcdom v0.3.0 [INFO] [stderr] Downloaded xml5ever v0.18.1 [INFO] [stderr] Downloaded avif-serialize v0.8.4 [INFO] [stderr] Downloaded hyper-rustls v0.27.6 [INFO] [stderr] Downloaded html2md v0.2.15 [INFO] [stderr] Downloaded hyper-util v0.1.12 [INFO] [stderr] Downloaded zune-jpeg v0.4.18 [INFO] [stderr] Downloaded sled v0.34.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e0cccac458d5be85adabe6cc24235d2f88330fb882f61adbb89ae0eb5894c69 [INFO] running `Command { std: "docker" "start" "-a" "8e0cccac458d5be85adabe6cc24235d2f88330fb882f61adbb89ae0eb5894c69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e0cccac458d5be85adabe6cc24235d2f88330fb882f61adbb89ae0eb5894c69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e0cccac458d5be85adabe6cc24235d2f88330fb882f61adbb89ae0eb5894c69", kill_on_drop: false }` [INFO] [stdout] 8e0cccac458d5be85adabe6cc24235d2f88330fb882f61adbb89ae0eb5894c69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 561e453c83ee8610ebcb4d963034c3a64e703717c23270b2d673c8d5b4c9e969 [INFO] running `Command { std: "docker" "start" "-a" "561e453c83ee8610ebcb4d963034c3a64e703717c23270b2d673c8d5b4c9e969", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Checking phf_shared v0.11.3 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Compiling cc v1.2.24 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Compiling built v0.7.7 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Compiling rustls v0.23.27 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Compiling zstd-safe v4.1.3+zstd.1.5.1 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking imgref v1.11.0 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Compiling portable-atomic v1.11.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking bitstream-io v2.6.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking rustls-native-certs v0.8.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking avif-serialize v0.8.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking bytemuck v1.23.1 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Checking winnow v0.7.10 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking image-webp v0.2.3 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking exr v1.73.0 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling openssl-sys v0.9.108 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v1.6.2+zstd.1.5.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling blake3 v1.8.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking zune-jpeg v0.4.18 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking rustls-webpki v0.103.3 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking av1-grain v0.2.4 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking async-compression v0.4.23 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking h2 v0.4.10 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking xml5ever v0.18.1 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking ravif v0.11.20 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Checking markup5ever_rcdom v0.3.0 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking html2md v0.2.15 [INFO] [stderr] Checking hyper-util v0.1.12 [INFO] [stderr] Checking hyper-rustls v0.27.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.20 [INFO] [stderr] Checking zstd v0.9.2+zstd.1.5.1 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking imd v0.1.13 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `denoising_strength`, `use_model`, and `use_model_version` are never used [INFO] [stdout] --> src/civitai/model.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait ImageMeta { [INFO] [stdout] | --------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 20 | fn denoising_strength(&self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 21 | fn use_model(&self) -> Option; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 22 | fn use_model_version(&self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `description` is never used [INFO] [stdout] --> src/civitai/model.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl Model { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn description(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `index` and `description` are never used [INFO] [stdout] --> src/civitai/model.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 103 | impl ModelVersionBrief { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 108 | pub fn index(&self) -> u64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 116 | pub fn description(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `model_name`, `description`, `air`, and `is_early_access` are never used [INFO] [stdout] --> src/civitai/model.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 125 | impl ModelVersion { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 138 | pub fn model_name(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | pub fn description(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | pub fn air(&self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | pub fn is_early_access(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `size`, `sha256_hash`, `crc32`, and `to_bytes` are never used [INFO] [stdout] --> src/civitai/model.rs:229:12 [INFO] [stdout] | [INFO] [stdout] 224 | impl ModelVersionFile { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 229 | pub fn size(&self) -> f64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 249 | pub fn sha256_hash(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 256 | pub fn crc32(&self) -> Option { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 267 | pub fn to_bytes(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `hash`, `has_meta`, and `has_positive_prompt` are never used [INFO] [stdout] --> src/civitai/model.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 278 | impl ModelImage { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 283 | pub fn hash(&self) -> Option { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 287 | pub fn has_meta(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 291 | pub fn has_positive_prompt(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_parse_community_images` is never used [INFO] [stdout] --> src/civitai/model.rs:342:8 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn try_parse_community_images( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `id` and `to_bytes` are never used [INFO] [stdout] --> src/civitai/model.rs:362:12 [INFO] [stdout] | [INFO] [stdout] 361 | impl ModelCommunityImage { [INFO] [stdout] | ------------------------ methods in this implementation [INFO] [stdout] 362 | pub fn id(&self) -> u64 { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 366 | pub fn to_bytes(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cache_db.rs:167:22 [INFO] [stdout] | [INFO] [stdout] 167 | .map(|l| PathBuf::from(l)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/civitai/meta.rs:132:30 [INFO] [stdout] | [INFO] [stdout] 132 | let model_meta_url = format!("https://civitai.com/api/v1/images"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"https://civitai.com/api/v1/images".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/civitai/meta.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | if !posi_prompt.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `posi_prompt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/civitai/meta.rs:221:54 [INFO] [stdout] | [INFO] [stdout] 221 | let encoed_url = utf8_percent_encode(&image_url, &FILENAME_SET).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `FILENAME_SET` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/civitai/meta.rs:287:61 [INFO] [stdout] | [INFO] [stdout] 287 | let encoded_file_path = utf8_percent_encode(&image, &FILENAME_SET).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `FILENAME_SET` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/civitai/meta.rs:299:8 [INFO] [stdout] | [INFO] [stdout] 299 | if trained_words.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!trained_words.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/civitai/model.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | return UtcDateTime::now() <= ends_at; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return UtcDateTime::now() <= ends_at; [INFO] [stdout] 163 + UtcDateTime::now() <= ends_at [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/civitai/model.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 165 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return false; [INFO] [stdout] 165 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/civitai/selections.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / impl ToString for DownloadChoice { [INFO] [stdout] 10 | | fn to_string(&self) -> String { [INFO] [stdout] 11 | | self.1.clone() [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/civitai/mod.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | .map(ModelVersionFile::blake3_hash) [INFO] [stdout] | ______________^ [INFO] [stdout] 78 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(ModelVersionFile::blake3_hash)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/civitai/mod.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | destination_path.as_deref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destination_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/civitai/mod.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | destination_path.as_deref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destination_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/civitai/mod.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | destination_path.as_deref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destination_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/config.rs:149:50 [INFO] [stdout] | [INFO] [stdout] 149 | let parsed_url = reqwest::Url::parse(&url).expect("Given proxy URL is invalid."); [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/commands/config.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | println!("") [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/download.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Some(path) = options.output_path.as_ref() { [INFO] [stdout] 35 | | if !path.exists() && options.fix_missing_dirs { [INFO] [stdout] 36 | | std::fs::create_dir_all(path).expect("Failed to create output directory"); [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 34 ~ if let Some(path) = options.output_path.as_ref() [INFO] [stdout] 35 ~ && !path.exists() && options.fix_missing_dirs { [INFO] [stdout] 36 | std::fs::create_dir_all(path).expect("Failed to create output directory"); [INFO] [stdout] 37 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `denoising_strength`, `use_model`, and `use_model_version` are never used [INFO] [stdout] --> src/civitai/model.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait ImageMeta { [INFO] [stdout] | --------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 20 | fn denoising_strength(&self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 21 | fn use_model(&self) -> Option; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 22 | fn use_model_version(&self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `description` is never used [INFO] [stdout] --> src/civitai/model.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl Model { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn description(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `index` and `description` are never used [INFO] [stdout] --> src/civitai/model.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 103 | impl ModelVersionBrief { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 108 | pub fn index(&self) -> u64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 116 | pub fn description(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `model_name`, `description`, `air`, and `is_early_access` are never used [INFO] [stdout] --> src/civitai/model.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 125 | impl ModelVersion { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 138 | pub fn model_name(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | pub fn description(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | pub fn air(&self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | pub fn is_early_access(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `size`, `sha256_hash`, `crc32`, and `to_bytes` are never used [INFO] [stdout] --> src/civitai/model.rs:229:12 [INFO] [stdout] | [INFO] [stdout] 224 | impl ModelVersionFile { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 229 | pub fn size(&self) -> f64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 249 | pub fn sha256_hash(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 256 | pub fn crc32(&self) -> Option { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 267 | pub fn to_bytes(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `hash`, `has_meta`, and `has_positive_prompt` are never used [INFO] [stdout] --> src/civitai/model.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 278 | impl ModelImage { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 283 | pub fn hash(&self) -> Option { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 287 | pub fn has_meta(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 291 | pub fn has_positive_prompt(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_parse_community_images` is never used [INFO] [stdout] --> src/civitai/model.rs:342:8 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn try_parse_community_images( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `id` and `to_bytes` are never used [INFO] [stdout] --> src/civitai/model.rs:362:12 [INFO] [stdout] | [INFO] [stdout] 361 | impl ModelCommunityImage { [INFO] [stdout] | ------------------------ methods in this implementation [INFO] [stdout] 362 | pub fn id(&self) -> u64 { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 366 | pub fn to_bytes(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cache_db.rs:167:22 [INFO] [stdout] | [INFO] [stdout] 167 | .map(|l| PathBuf::from(l)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/configuration.rs:116:30 [INFO] [stdout] | [INFO] [stdout] 116 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 116 - .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e.to_string()))?; [INFO] [stdout] 116 + .map_err(|e| std::io::Error::other(e.to_string()))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commands/renew.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | let extensions = vec!["ckpt", "safetensors", "pt", "bin"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["ckpt", "safetensors", "pt", "bin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/civitai/meta.rs:132:30 [INFO] [stdout] | [INFO] [stdout] 132 | let model_meta_url = format!("https://civitai.com/api/v1/images"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"https://civitai.com/api/v1/images".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/civitai/meta.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | if !posi_prompt.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `posi_prompt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/civitai/meta.rs:221:54 [INFO] [stdout] | [INFO] [stdout] 221 | let encoed_url = utf8_percent_encode(&image_url, &FILENAME_SET).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `FILENAME_SET` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/civitai/meta.rs:287:61 [INFO] [stdout] | [INFO] [stdout] 287 | let encoded_file_path = utf8_percent_encode(&image, &FILENAME_SET).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `FILENAME_SET` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/civitai/meta.rs:299:8 [INFO] [stdout] | [INFO] [stdout] 299 | if trained_words.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!trained_words.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/civitai/model.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | return UtcDateTime::now() <= ends_at; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return UtcDateTime::now() <= ends_at; [INFO] [stdout] 163 + UtcDateTime::now() <= ends_at [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/civitai/model.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 165 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return false; [INFO] [stdout] 165 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/civitai/selections.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / impl ToString for DownloadChoice { [INFO] [stdout] 10 | | fn to_string(&self) -> String { [INFO] [stdout] 11 | | self.1.clone() [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/civitai/mod.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | .map(ModelVersionFile::blake3_hash) [INFO] [stdout] | ______________^ [INFO] [stdout] 78 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(ModelVersionFile::blake3_hash)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/civitai/mod.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | destination_path.as_deref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destination_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/civitai/mod.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | destination_path.as_deref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destination_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/civitai/mod.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | destination_path.as_deref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destination_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/config.rs:149:50 [INFO] [stdout] | [INFO] [stdout] 149 | let parsed_url = reqwest::Url::parse(&url).expect("Given proxy URL is invalid."); [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/commands/config.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | println!("") [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/download.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Some(path) = options.output_path.as_ref() { [INFO] [stdout] 35 | | if !path.exists() && options.fix_missing_dirs { [INFO] [stdout] 36 | | std::fs::create_dir_all(path).expect("Failed to create output directory"); [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 34 ~ if let Some(path) = options.output_path.as_ref() [INFO] [stdout] 35 ~ && !path.exists() && options.fix_missing_dirs { [INFO] [stdout] 36 | std::fs::create_dir_all(path).expect("Failed to create output directory"); [INFO] [stdout] 37 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/configuration.rs:116:30 [INFO] [stdout] | [INFO] [stdout] 116 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 116 - .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e.to_string()))?; [INFO] [stdout] 116 + .map_err(|e| std::io::Error::other(e.to_string()))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commands/renew.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | let extensions = vec!["ckpt", "safetensors", "pt", "bin"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["ckpt", "safetensors", "pt", "bin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `Command { std: "docker" "inspect" "561e453c83ee8610ebcb4d963034c3a64e703717c23270b2d673c8d5b4c9e969", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "561e453c83ee8610ebcb4d963034c3a64e703717c23270b2d673c8d5b4c9e969", kill_on_drop: false }` [INFO] [stdout] 561e453c83ee8610ebcb4d963034c3a64e703717c23270b2d673c8d5b4c9e969