[INFO] cloning repository https://github.com/virtulis/tamepad [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/virtulis/tamepad" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvirtulis%2Ftamepad", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvirtulis%2Ftamepad'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e4bf040ea6f6514c05f2990d76051b9e7aaefa4e [INFO] linting virtulis/tamepad against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvirtulis%2Ftamepad" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/virtulis/tamepad [INFO] finished tweaking git repo https://github.com/virtulis/tamepad [INFO] tweaked toml for git repo https://github.com/virtulis/tamepad written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/virtulis/tamepad on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/virtulis/tamepad already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strum v0.26.2 [INFO] [stderr] Downloaded schemars_derive v0.8.16 [INFO] [stderr] Downloaded dyn-clone v1.0.17 [INFO] [stderr] Downloaded strum_macros v0.26.2 [INFO] [stderr] Downloaded glutin_egl_sys v0.6.0 [INFO] [stderr] Downloaded glutin_glx_sys v0.5.0 [INFO] [stderr] Downloaded glutin-winit v0.4.2 [INFO] [stderr] Downloaded input-linux-sys v0.8.0 [INFO] [stderr] Downloaded pest_generator v2.7.8 [INFO] [stderr] Downloaded rgb v0.8.37 [INFO] [stderr] Downloaded unicode-script v0.5.6 [INFO] [stderr] Downloaded pest_meta v2.7.8 [INFO] [stderr] Downloaded imgref v1.10.1 [INFO] [stderr] Downloaded pest_derive v2.7.8 [INFO] [stderr] Downloaded glutin v0.31.3 [INFO] [stderr] Downloaded sdl2 v0.36.0 [INFO] [stderr] Downloaded schemars v0.8.16 [INFO] [stderr] Downloaded input-linux v0.6.0 [INFO] [stderr] Downloaded sctk-adwaita v0.8.1 [INFO] [stderr] Downloaded rustybuzz v0.13.0 [INFO] [stderr] Downloaded femtovg v0.9.0 [INFO] [stderr] Downloaded winit v0.29.15 [INFO] [stderr] Downloaded sdl2-sys v0.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de9d9af8dccef9b7190ca37cf03f145bd0ce70abdc88e650d27427adec7673bc [INFO] running `Command { std: "docker" "start" "-a" "de9d9af8dccef9b7190ca37cf03f145bd0ce70abdc88e650d27427adec7673bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de9d9af8dccef9b7190ca37cf03f145bd0ce70abdc88e650d27427adec7673bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de9d9af8dccef9b7190ca37cf03f145bd0ce70abdc88e650d27427adec7673bc", kill_on_drop: false }` [INFO] [stdout] de9d9af8dccef9b7190ca37cf03f145bd0ce70abdc88e650d27427adec7673bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d5da52d0dabd1bd7c1792cc2482116e65b5fab8a08ee0f4025f6d5508280d016 [INFO] running `Command { std: "docker" "start" "-a" "d5da52d0dabd1bd7c1792cc2482116e65b5fab8a08ee0f4025f6d5508280d016", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking libloading v0.8.3 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Compiling smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking xkeysym v0.2.0 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling wayland-sys v0.31.1 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling quick-xml v0.31.0 [INFO] [stderr] Compiling glutin v0.31.3 [INFO] [stderr] Compiling winit v0.29.15 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking x11rb-protocol v0.13.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling glutin-winit v0.4.2 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling wayland-backend v0.3.3 [INFO] [stderr] Checking raw-window-handle v0.6.0 [INFO] [stderr] Checking unicode-script v0.5.6 [INFO] [stderr] Checking unicode-ccc v0.2.0 [INFO] [stderr] Compiling glutin_glx_sys v0.5.0 [INFO] [stderr] Compiling glutin_egl_sys v0.6.0 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Compiling wayland-scanner v0.31.1 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking unicode-bidi-mirroring v0.2.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling schemars v0.8.16 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking owned_ttf_parser v0.20.0 [INFO] [stderr] Checking rustybuzz v0.13.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking ab_glyph v0.2.23 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Compiling serde_derive_internals v0.26.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling schemars_derive v0.8.16 [INFO] [stderr] Compiling pest v2.7.8 [INFO] [stderr] Checking femtovg v0.9.0 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking input-linux-sys v0.8.0 [INFO] [stderr] Checking polling v3.5.0 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking wayland-client v0.31.2 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling pest_meta v2.7.8 [INFO] [stderr] Compiling pest_generator v2.7.8 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking wayland-cursor v0.31.1 [INFO] [stderr] Compiling pest_derive v2.7.8 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking input-linux v0.6.0 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking x11rb v0.13.0 [INFO] [stderr] Checking sctk-adwaita v0.8.1 [INFO] [stderr] Checking tamepad v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gui.rs:182:6 [INFO] [stdout] | [INFO] [stdout] 182 | let mut highlights: Vec = Vec::new(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/state.rs:310:26 [INFO] [stdout] | [INFO] [stdout] 310 | let do_handle_button = |mut state: &mut State, btn: Button, down: bool| { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/state.rs:320:29 [INFO] [stdout] | [INFO] [stdout] 320 | let maybe_handle_button = |mut state: &mut State, btn: Button, down: bool| { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/state.rs:369:16 [INFO] [stdout] | [INFO] [stdout] 369 | .rfind(|(i, s)| s.from_degrees <= degrees) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `oidx` [INFO] [stdout] --> src/state.rs:259:31 [INFO] [stdout] | [INFO] [stdout] 259 | state.active_maps.retain(|(oidx, other)| *other != *map); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_oidx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `print_state` [INFO] [stdout] --> src/state.rs:196:6 [INFO] [stdout] | [INFO] [stdout] 196 | let print_state = |state: &State| { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_print_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gui.rs:182:6 [INFO] [stdout] | [INFO] [stdout] 182 | let mut highlights: Vec = Vec::new(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/state.rs:310:26 [INFO] [stdout] | [INFO] [stdout] 310 | let do_handle_button = |mut state: &mut State, btn: Button, down: bool| { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/state.rs:320:29 [INFO] [stdout] | [INFO] [stdout] 320 | let maybe_handle_button = |mut state: &mut State, btn: Button, down: bool| { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/state.rs:369:16 [INFO] [stdout] | [INFO] [stdout] 369 | .rfind(|(i, s)| s.from_degrees <= degrees) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `oidx` [INFO] [stdout] --> src/state.rs:259:31 [INFO] [stdout] | [INFO] [stdout] 259 | state.active_maps.retain(|(oidx, other)| *other != *map); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_oidx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `print_state` [INFO] [stdout] --> src/state.rs:196:6 [INFO] [stdout] | [INFO] [stdout] 196 | let print_state = |state: &State| { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_print_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `state::CachedOverlay` is more private than the item `state::CachedConfig::overlays` [INFO] [stdout] --> src/state.rs:65:2 [INFO] [stdout] | [INFO] [stdout] 65 | pub overlays: IndexMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `state::CachedConfig::overlays` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `state::CachedOverlay` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/state.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | struct CachedOverlay { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `state::ButtonComboList` is more private than the item `state::State::button_combos` [INFO] [stdout] --> src/state.rs:72:2 [INFO] [stdout] | [INFO] [stdout] 72 | pub button_combos: IndexMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `state::State::button_combos` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `state::ButtonComboList` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/state.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | struct ButtonComboList { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `state::AxisState` is more private than the item `state::State::axis_states` [INFO] [stdout] --> src/state.rs:75:2 [INFO] [stdout] | [INFO] [stdout] 75 | pub axis_states: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `state::State::axis_states` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `state::AxisState` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/state.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | struct AxisState { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `overlay` is never read [INFO] [stdout] --> src/state.rs:20:2 [INFO] [stdout] | [INFO] [stdout] 19 | struct CachedOverlay { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 20 | overlay: Overlay, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CachedOverlay` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:101:61 [INFO] [stdout] | [INFO] [stdout] 101 | ... render_gui(&context, &surface, &window, &mut canvas, &state, &config); [INFO] [stdout] | ^^^^^^ help: change this to: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:101:69 [INFO] [stdout] | [INFO] [stdout] 101 | ... render_gui(&context, &surface, &window, &mut canvas, &state, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:248:36 [INFO] [stdout] | [INFO] [stdout] 248 | shapes.push(Draw::path(p, Some(&fill), None)); [INFO] [stdout] | ^^^^^ help: change this to: `fill` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `ch.sectors.get(0)` [INFO] [stdout] --> src/gui.rs:311:49 [INFO] [stdout] | [INFO] [stdout] 311 | let next = ch.sectors.get(sec_idx + 1).or(ch.sectors.get(0)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ch.sectors.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:364:31 [INFO] [stdout] | [INFO] [stdout] 364 | canvas.fill_path(&path, &paint); [INFO] [stdout] | ^^^^^^ help: change this to: `paint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:367:33 [INFO] [stdout] | [INFO] [stdout] 367 | canvas.stroke_path(&path, &paint); [INFO] [stdout] | ^^^^^^ help: change this to: `paint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:372:45 [INFO] [stdout] | [INFO] [stdout] 372 | canvas.fill_text(cmd.x, cmd.y, &text, &paint).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `paint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:375:47 [INFO] [stdout] | [INFO] [stdout] 375 | canvas.stroke_text(cmd.x, cmd.y, &text, &paint).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `paint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/linux.rs:51:3 [INFO] [stdout] | [INFO] [stdout] 51 | / let _ = select! { [INFO] [stdout] 52 | | recv(actions) -> act => match act { [INFO] [stdout] 53 | | Ok(act) => { [INFO] [stdout] ... | [INFO] [stdout] 87 | | }, [INFO] [stdout] 88 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 51 - let _ = select! { [INFO] [stdout] 51 + select! { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/sdl.rs:100:10 [INFO] [stdout] | [INFO] [stdout] 100 | if let Err(_) = res { break } [INFO] [stdout] | -------^^^^^^------ help: try: `if res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:473:23 [INFO] [stdout] | [INFO] [stdout] 473 | if bs.handled || !bs.handle_at.is_some_and(|at| at <= now) { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bs.handle_at.is_none_or(|at| at > now)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:266:27 [INFO] [stdout] | [INFO] [stdout] 266 | trigger_mapping(state, &map, down, oidx); [INFO] [stdout] | ^^^^ help: change this to: `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:282:27 [INFO] [stdout] | [INFO] [stdout] 282 | trigger_handler(state, &handler, false, oidx) [INFO] [stdout] | ^^^^^^^^ help: change this to: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return all_down && !state.combo_states[*idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return all_down && !state.combo_states[*idx]; [INFO] [stdout] 291 + all_down && !state.combo_states[*idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:303:29 [INFO] [stdout] | [INFO] [stdout] 303 | trigger_handler(state, &handler, true, oidx) [INFO] [stdout] | ^^^^^^^^ help: change this to: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:316:27 [INFO] [stdout] | [INFO] [stdout] 316 | trigger_handler(state, &handler, down, oidx) [INFO] [stdout] | ^^^^^^^^ help: change this to: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/state.rs:370:19 [INFO] [stdout] | [INFO] [stdout] 370 | .or_else(|| ch.sectors.iter().enumerate().last()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 370 - .or_else(|| ch.sectors.iter().enumerate().last()) [INFO] [stdout] 370 + .or_else(|| ch.sectors.iter().enumerate().next_back()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `state::CachedOverlay` is more private than the item `state::CachedConfig::overlays` [INFO] [stdout] --> src/state.rs:65:2 [INFO] [stdout] | [INFO] [stdout] 65 | pub overlays: IndexMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `state::CachedConfig::overlays` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `state::CachedOverlay` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/state.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | struct CachedOverlay { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `state::ButtonComboList` is more private than the item `state::State::button_combos` [INFO] [stdout] --> src/state.rs:72:2 [INFO] [stdout] | [INFO] [stdout] 72 | pub button_combos: IndexMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `state::State::button_combos` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `state::ButtonComboList` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/state.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | struct ButtonComboList { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `state::AxisState` is more private than the item `state::State::axis_states` [INFO] [stdout] --> src/state.rs:75:2 [INFO] [stdout] | [INFO] [stdout] 75 | pub axis_states: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `state::State::axis_states` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `state::AxisState` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/state.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | struct AxisState { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `overlay` is never read [INFO] [stdout] --> src/state.rs:20:2 [INFO] [stdout] | [INFO] [stdout] 19 | struct CachedOverlay { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 20 | overlay: Overlay, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CachedOverlay` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:101:61 [INFO] [stdout] | [INFO] [stdout] 101 | ... render_gui(&context, &surface, &window, &mut canvas, &state, &config); [INFO] [stdout] | ^^^^^^ help: change this to: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:101:69 [INFO] [stdout] | [INFO] [stdout] 101 | ... render_gui(&context, &surface, &window, &mut canvas, &state, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:248:36 [INFO] [stdout] | [INFO] [stdout] 248 | shapes.push(Draw::path(p, Some(&fill), None)); [INFO] [stdout] | ^^^^^ help: change this to: `fill` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `ch.sectors.get(0)` [INFO] [stdout] --> src/gui.rs:311:49 [INFO] [stdout] | [INFO] [stdout] 311 | let next = ch.sectors.get(sec_idx + 1).or(ch.sectors.get(0)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `ch.sectors.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:364:31 [INFO] [stdout] | [INFO] [stdout] 364 | canvas.fill_path(&path, &paint); [INFO] [stdout] | ^^^^^^ help: change this to: `paint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:367:33 [INFO] [stdout] | [INFO] [stdout] 367 | canvas.stroke_path(&path, &paint); [INFO] [stdout] | ^^^^^^ help: change this to: `paint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:372:45 [INFO] [stdout] | [INFO] [stdout] 372 | canvas.fill_text(cmd.x, cmd.y, &text, &paint).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `paint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui.rs:375:47 [INFO] [stdout] | [INFO] [stdout] 375 | canvas.stroke_text(cmd.x, cmd.y, &text, &paint).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `paint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/linux.rs:51:3 [INFO] [stdout] | [INFO] [stdout] 51 | / let _ = select! { [INFO] [stdout] 52 | | recv(actions) -> act => match act { [INFO] [stdout] 53 | | Ok(act) => { [INFO] [stdout] ... | [INFO] [stdout] 87 | | }, [INFO] [stdout] 88 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 51 - let _ = select! { [INFO] [stdout] 51 + select! { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/sdl.rs:100:10 [INFO] [stdout] | [INFO] [stdout] 100 | if let Err(_) = res { break } [INFO] [stdout] | -------^^^^^^------ help: try: `if res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:473:23 [INFO] [stdout] | [INFO] [stdout] 473 | if bs.handled || !bs.handle_at.is_some_and(|at| at <= now) { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bs.handle_at.is_none_or(|at| at > now)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:266:27 [INFO] [stdout] | [INFO] [stdout] 266 | trigger_mapping(state, &map, down, oidx); [INFO] [stdout] | ^^^^ help: change this to: `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:282:27 [INFO] [stdout] | [INFO] [stdout] 282 | trigger_handler(state, &handler, false, oidx) [INFO] [stdout] | ^^^^^^^^ help: change this to: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return all_down && !state.combo_states[*idx]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return all_down && !state.combo_states[*idx]; [INFO] [stdout] 291 + all_down && !state.combo_states[*idx] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:303:29 [INFO] [stdout] | [INFO] [stdout] 303 | trigger_handler(state, &handler, true, oidx) [INFO] [stdout] | ^^^^^^^^ help: change this to: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:316:27 [INFO] [stdout] | [INFO] [stdout] 316 | trigger_handler(state, &handler, down, oidx) [INFO] [stdout] | ^^^^^^^^ help: change this to: `handler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/state.rs:370:19 [INFO] [stdout] | [INFO] [stdout] 370 | .or_else(|| ch.sectors.iter().enumerate().last()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 370 - .or_else(|| ch.sectors.iter().enumerate().last()) [INFO] [stdout] 370 + .or_else(|| ch.sectors.iter().enumerate().next_back()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WWW` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:381:2 [INFO] [stdout] | [INFO] [stdout] 381 | WWW, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Www` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MSDOS` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:382:2 [INFO] [stdout] | [INFO] [stdout] 382 | MSDOS, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Msdos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WLAN` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:495:2 [INFO] [stdout] | [INFO] [stdout] 495 | WLAN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wlan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UWB` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:496:2 [INFO] [stdout] | [INFO] [stdout] 496 | UWB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Uwb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WWAN` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:515:2 [INFO] [stdout] | [INFO] [stdout] 515 | WWAN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wwan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EPG` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:627:2 [INFO] [stdout] | [INFO] [stdout] 627 | EPG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Epg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PVR` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:629:2 [INFO] [stdout] | [INFO] [stdout] 629 | PVR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pvr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MHP` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:630:2 [INFO] [stdout] | [INFO] [stdout] 630 | MHP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mhp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VCR` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:646:2 [INFO] [stdout] | [INFO] [stdout] 646 | VCR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Vcr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SOS` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:928:2 [INFO] [stdout] | [INFO] [stdout] 928 | SOS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Sos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WWW` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:381:2 [INFO] [stdout] | [INFO] [stdout] 381 | WWW, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Www` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MSDOS` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:382:2 [INFO] [stdout] | [INFO] [stdout] 382 | MSDOS, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Msdos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WLAN` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:495:2 [INFO] [stdout] | [INFO] [stdout] 495 | WLAN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wlan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UWB` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:496:2 [INFO] [stdout] | [INFO] [stdout] 496 | UWB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Uwb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WWAN` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:515:2 [INFO] [stdout] | [INFO] [stdout] 515 | WWAN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wwan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EPG` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:627:2 [INFO] [stdout] | [INFO] [stdout] 627 | EPG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Epg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PVR` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:629:2 [INFO] [stdout] | [INFO] [stdout] 629 | PVR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pvr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MHP` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:630:2 [INFO] [stdout] | [INFO] [stdout] 630 | MHP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mhp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VCR` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:646:2 [INFO] [stdout] | [INFO] [stdout] 646 | VCR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Vcr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SOS` contains a capitalized acronym [INFO] [stdout] --> src/types.rs:928:2 [INFO] [stdout] | [INFO] [stdout] 928 | SOS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Sos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/types.rs:973:13 [INFO] [stdout] | [INFO] [stdout] 973 | let str = format!("{}", serde_json::to_string_pretty(&schema).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `serde_json::to_string_pretty(&schema).unwrap().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:54:34 [INFO] [stdout] | [INFO] [stdout] 54 | let mut signals = Signals::new(&[ [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 55 | | signal_hook::consts::signal::SIGTERM, [INFO] [stdout] 56 | | signal_hook::consts::signal::SIGINT, [INFO] [stdout] 57 | | ]).unwrap(); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 ~ let mut signals = Signals::new([ [INFO] [stdout] 55 ~ signal_hook::consts::signal::SIGTERM, [INFO] [stdout] 56 ~ signal_hook::consts::signal::SIGINT, [INFO] [stdout] 57 ~ ]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/types.rs:973:13 [INFO] [stdout] | [INFO] [stdout] 973 | let str = format!("{}", serde_json::to_string_pretty(&schema).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `serde_json::to_string_pretty(&schema).unwrap().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:54:34 [INFO] [stdout] | [INFO] [stdout] 54 | let mut signals = Signals::new(&[ [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 55 | | signal_hook::consts::signal::SIGTERM, [INFO] [stdout] 56 | | signal_hook::consts::signal::SIGINT, [INFO] [stdout] 57 | | ]).unwrap(); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 ~ let mut signals = Signals::new([ [INFO] [stdout] 55 ~ signal_hook::consts::signal::SIGTERM, [INFO] [stdout] 56 ~ signal_hook::consts::signal::SIGINT, [INFO] [stdout] 57 ~ ]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `Command { std: "docker" "inspect" "d5da52d0dabd1bd7c1792cc2482116e65b5fab8a08ee0f4025f6d5508280d016", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5da52d0dabd1bd7c1792cc2482116e65b5fab8a08ee0f4025f6d5508280d016", kill_on_drop: false }` [INFO] [stdout] d5da52d0dabd1bd7c1792cc2482116e65b5fab8a08ee0f4025f6d5508280d016