[INFO] cloning repository https://github.com/vipankumar87/mp3-to-video [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/vipankumar87/mp3-to-video" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvipankumar87%2Fmp3-to-video", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvipankumar87%2Fmp3-to-video'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6935ee678ac7a8e856bce81e0d0613484a787220 [INFO] linting vipankumar87/mp3-to-video against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvipankumar87%2Fmp3-to-video" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/vipankumar87/mp3-to-video [INFO] finished tweaking git repo https://github.com/vipankumar87/mp3-to-video [INFO] tweaked toml for git repo https://github.com/vipankumar87/mp3-to-video written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/vipankumar87/mp3-to-video on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/vipankumar87/mp3-to-video already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4010f9612087b1533fcb0b02e9ee436e40d6b20a3f15327dd67ae3c3a8e1bac [INFO] running `Command { std: "docker" "start" "-a" "e4010f9612087b1533fcb0b02e9ee436e40d6b20a3f15327dd67ae3c3a8e1bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4010f9612087b1533fcb0b02e9ee436e40d6b20a3f15327dd67ae3c3a8e1bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4010f9612087b1533fcb0b02e9ee436e40d6b20a3f15327dd67ae3c3a8e1bac", kill_on_drop: false }` [INFO] [stdout] e4010f9612087b1533fcb0b02e9ee436e40d6b20a3f15327dd67ae3c3a8e1bac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84443a081ffc4ecaf18212b117c527101d383f4a4b15362cf68a9547ba62b654 [INFO] running `Command { std: "docker" "start" "-a" "84443a081ffc4ecaf18212b117c527101d383f4a4b15362cf68a9547ba62b654", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking video_generator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `rand::seq::SliceRandom` [INFO] [stdout] --> src/audio_combiner.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rand::seq::SliceRandom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/audio_combiner.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, Write}; // Make sure to import `Write` [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/audio_combiner.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 10 | | "-i", file_path, [INFO] [stdout] 11 | | "-hide_banner", [INFO] [stdout] 12 | | "-f", "null", [INFO] [stdout] 13 | | "-" [INFO] [stdout] 14 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 ~ .args([ [INFO] [stdout] 10 + "-i", file_path, [INFO] [stdout] 11 + "-hide_banner", [INFO] [stdout] 12 + "-f", "null", [INFO] [stdout] 13 + "-" [INFO] [stdout] 14 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/audio_combiner.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 38 | | "-i", background_mp3, [INFO] [stdout] 39 | | "-filter:a", &format!("volume={}", volume_factor), // Adjust volume by a factor [INFO] [stdout] 40 | | "-c:a", "mp3", [INFO] [stdout] 41 | | "-y", output_file, [INFO] [stdout] 42 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 ~ .args([ [INFO] [stdout] 38 + "-i", background_mp3, [INFO] [stdout] 39 + "-filter:a", &format!("volume={}", volume_factor), // Adjust volume by a factor [INFO] [stdout] 40 + "-c:a", "mp3", [INFO] [stdout] 41 + "-y", output_file, [INFO] [stdout] 42 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/audio_combiner.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | / for path in paths { [INFO] [stdout] 63 | | if let Ok(entry) = path { [INFO] [stdout] 64 | | let path_str = entry.path().to_string_lossy().to_string(); [INFO] [stdout] 65 | | if path_str.ends_with(".mp3") { [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/audio_combiner.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Ok(entry) = path { [INFO] [stdout] 64 | | let path_str = entry.path().to_string_lossy().to_string(); [INFO] [stdout] 65 | | if path_str.ends_with(".mp3") { [INFO] [stdout] 66 | | background_files.push(path_str); [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ for entry in paths.flatten() { [INFO] [stdout] 63 + let path_str = entry.path().to_string_lossy().to_string(); [INFO] [stdout] 64 + if path_str.ends_with(".mp3") { [INFO] [stdout] 65 + background_files.push(path_str); [INFO] [stdout] 66 + } [INFO] [stdout] 67 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::seq::SliceRandom` [INFO] [stdout] --> src/audio_combiner.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rand::seq::SliceRandom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/audio_combiner.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, Write}; // Make sure to import `Write` [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/audio_combiner.rs:77:23 [INFO] [stdout] | [INFO] [stdout] 77 | let filter_even = unix_time % 2 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `unix_time.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/audio_combiner.rs:115:10 [INFO] [stdout] | [INFO] [stdout] 115 | .expect(&format!("Failed to write to concat file {}", audio)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to write to concat file {}", audio))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/audio_combiner.rs:120:15 [INFO] [stdout] | [INFO] [stdout] 120 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 121 | | "-f", "concat", [INFO] [stdout] 122 | | "-safe", "0", [INFO] [stdout] 123 | | "-i", concat_file, [INFO] [stdout] 124 | | "-c", "copy", [INFO] [stdout] 125 | | "-y", output_file, [INFO] [stdout] 126 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 120 ~ .args([ [INFO] [stdout] 121 + "-f", "concat", [INFO] [stdout] 122 + "-safe", "0", [INFO] [stdout] 123 + "-i", concat_file, [INFO] [stdout] 124 + "-c", "copy", [INFO] [stdout] 125 + "-y", output_file, [INFO] [stdout] 126 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/audio.rs:38:57 [INFO] [stdout] | [INFO] [stdout] 38 | let _ = audio_combiner::create_background_audio(&tmp_output, &mp3s, output_path); // tmp_output can be used as is [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `tmp_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/audio.rs:38:70 [INFO] [stdout] | [INFO] [stdout] 38 | let _ = audio_combiner::create_background_audio(&tmp_output, &mp3s, output_path); // tmp_output can be used as is [INFO] [stdout] | ^^^^^ help: change this to: `mp3s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/video.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 108 | if !fs::metadata(output_folder).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(output_folder).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:29:68 [INFO] [stdout] | [INFO] [stdout] 29 | video::mp3_to_video(mp3_paths, image_folder, output_video, &effects, apply_all); [INFO] [stdout] | ^^^^^^^^ help: change this to: `effects` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/audio_combiner.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 10 | | "-i", file_path, [INFO] [stdout] 11 | | "-hide_banner", [INFO] [stdout] 12 | | "-f", "null", [INFO] [stdout] 13 | | "-" [INFO] [stdout] 14 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 ~ .args([ [INFO] [stdout] 10 + "-i", file_path, [INFO] [stdout] 11 + "-hide_banner", [INFO] [stdout] 12 + "-f", "null", [INFO] [stdout] 13 + "-" [INFO] [stdout] 14 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/audio_combiner.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 38 | | "-i", background_mp3, [INFO] [stdout] 39 | | "-filter:a", &format!("volume={}", volume_factor), // Adjust volume by a factor [INFO] [stdout] 40 | | "-c:a", "mp3", [INFO] [stdout] 41 | | "-y", output_file, [INFO] [stdout] 42 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 ~ .args([ [INFO] [stdout] 38 + "-i", background_mp3, [INFO] [stdout] 39 + "-filter:a", &format!("volume={}", volume_factor), // Adjust volume by a factor [INFO] [stdout] 40 + "-c:a", "mp3", [INFO] [stdout] 41 + "-y", output_file, [INFO] [stdout] 42 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/audio_combiner.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | / for path in paths { [INFO] [stdout] 63 | | if let Ok(entry) = path { [INFO] [stdout] 64 | | let path_str = entry.path().to_string_lossy().to_string(); [INFO] [stdout] 65 | | if path_str.ends_with(".mp3") { [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/audio_combiner.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Ok(entry) = path { [INFO] [stdout] 64 | | let path_str = entry.path().to_string_lossy().to_string(); [INFO] [stdout] 65 | | if path_str.ends_with(".mp3") { [INFO] [stdout] 66 | | background_files.push(path_str); [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ for entry in paths.flatten() { [INFO] [stdout] 63 + let path_str = entry.path().to_string_lossy().to_string(); [INFO] [stdout] 64 + if path_str.ends_with(".mp3") { [INFO] [stdout] 65 + background_files.push(path_str); [INFO] [stdout] 66 + } [INFO] [stdout] 67 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/audio_combiner.rs:77:23 [INFO] [stdout] | [INFO] [stdout] 77 | let filter_even = unix_time % 2 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `unix_time.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/audio_combiner.rs:115:10 [INFO] [stdout] | [INFO] [stdout] 115 | .expect(&format!("Failed to write to concat file {}", audio)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to write to concat file {}", audio))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/audio_combiner.rs:120:15 [INFO] [stdout] | [INFO] [stdout] 120 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 121 | | "-f", "concat", [INFO] [stdout] 122 | | "-safe", "0", [INFO] [stdout] 123 | | "-i", concat_file, [INFO] [stdout] 124 | | "-c", "copy", [INFO] [stdout] 125 | | "-y", output_file, [INFO] [stdout] 126 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 120 ~ .args([ [INFO] [stdout] 121 + "-f", "concat", [INFO] [stdout] 122 + "-safe", "0", [INFO] [stdout] 123 + "-i", concat_file, [INFO] [stdout] 124 + "-c", "copy", [INFO] [stdout] 125 + "-y", output_file, [INFO] [stdout] 126 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/audio.rs:38:57 [INFO] [stdout] | [INFO] [stdout] 38 | let _ = audio_combiner::create_background_audio(&tmp_output, &mp3s, output_path); // tmp_output can be used as is [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `tmp_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/audio.rs:38:70 [INFO] [stdout] | [INFO] [stdout] 38 | let _ = audio_combiner::create_background_audio(&tmp_output, &mp3s, output_path); // tmp_output can be used as is [INFO] [stdout] | ^^^^^ help: change this to: `mp3s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/video.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 108 | if !fs::metadata(output_folder).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(output_folder).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:29:68 [INFO] [stdout] | [INFO] [stdout] 29 | video::mp3_to_video(mp3_paths, image_folder, output_video, &effects, apply_all); [INFO] [stdout] | ^^^^^^^^ help: change this to: `effects` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.30s [INFO] running `Command { std: "docker" "inspect" "84443a081ffc4ecaf18212b117c527101d383f4a4b15362cf68a9547ba62b654", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84443a081ffc4ecaf18212b117c527101d383f4a4b15362cf68a9547ba62b654", kill_on_drop: false }` [INFO] [stdout] 84443a081ffc4ecaf18212b117c527101d383f4a4b15362cf68a9547ba62b654