[INFO] cloning repository https://github.com/vinzify/Cortex-portable-brain [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/vinzify/Cortex-portable-brain" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvinzify%2FCortex-portable-brain", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvinzify%2FCortex-portable-brain'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 069564b176413b25d521ff20a96f31c42932baa8 [INFO] linting vinzify/Cortex-portable-brain against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvinzify%2FCortex-portable-brain" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-1-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/vinzify/Cortex-portable-brain [INFO] finished tweaking git repo https://github.com/vinzify/Cortex-portable-brain [INFO] tweaked toml for git repo https://github.com/vinzify/Cortex-portable-brain written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/vinzify/Cortex-portable-brain on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/vinzify/Cortex-portable-brain already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/vinzify/Cortex-v3.1-RMVM---Relational-Memory-Virtual-Machine.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tonic-prost-build v0.14.5 [INFO] [stderr] Downloaded protoc-bin-vendored v3.2.0 [INFO] [stderr] Downloaded pulldown-cmark-to-cmark v22.0.0 [INFO] [stderr] Downloaded tonic-build v0.14.5 [INFO] [stderr] Downloaded keyring v3.6.3 [INFO] [stderr] Downloaded protoc-bin-vendored-macos-aarch_64 v3.2.0 [INFO] [stderr] Downloaded protoc-bin-vendored-macos-x86_64 v3.2.0 [INFO] [stderr] Downloaded protoc-bin-vendored-linux-aarch_64 v3.2.0 [INFO] [stderr] Downloaded protoc-bin-vendored-win32 v3.2.0 [INFO] [stderr] Downloaded protoc-bin-vendored-linux-x86_64 v3.2.0 [INFO] [stderr] Downloaded protoc-bin-vendored-linux-x86_32 v3.2.0 [INFO] [stderr] Downloaded protoc-bin-vendored-linux-ppcle_64 v3.2.0 [INFO] [stderr] Downloaded protoc-bin-vendored-linux-s390_64 v3.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0548dbcd3827ba6f06bedf5476ffdb7b488fd40fb44834ba56855f54eebdaabc [INFO] running `Command { std: "docker" "start" "-a" "0548dbcd3827ba6f06bedf5476ffdb7b488fd40fb44834ba56855f54eebdaabc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0548dbcd3827ba6f06bedf5476ffdb7b488fd40fb44834ba56855f54eebdaabc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0548dbcd3827ba6f06bedf5476ffdb7b488fd40fb44834ba56855f54eebdaabc", kill_on_drop: false }` [INFO] [stdout] 0548dbcd3827ba6f06bedf5476ffdb7b488fd40fb44834ba56855f54eebdaabc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 83611bab38281513bbe471f88169569ebc4e193d84a3bbecb0b12ac0c40df24f [INFO] running `Command { std: "docker" "start" "-a" "83611bab38281513bbe471f88169569ebc4e193d84a3bbecb0b12ac0c40df24f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling pulldown-cmark v0.13.1 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Compiling protoc-bin-vendored-macos-x86_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-x86_64 v3.2.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling protoc-bin-vendored-linux-ppcle_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-win32 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-x86_32 v3.2.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling protoc-bin-vendored-linux-s390_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-aarch_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-macos-aarch_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored v3.2.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Compiling petgraph v0.8.3 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking keyring v3.6.3 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Compiling pulldown-cmark-to-cmark v22.0.0 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Compiling tempfile v3.26.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling prost-derive v0.14.3 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling tonic-build v0.14.5 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling prost v0.14.3 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking prost-types v0.14.3 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling prost-build v0.14.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling tonic-prost-build v0.14.5 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Compiling rmvm-proto v0.1.0 (https://github.com/vinzify/Cortex-v3.1-RMVM---Relational-Memory-Virtual-Machine.git?rev=f5d7932dfa35b52354ad31ec741d76147066fea5#f5d7932d) [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Compiling rmvm-grpc v0.1.0 (https://github.com/vinzify/Cortex-v3.1-RMVM---Relational-Memory-Virtual-Machine.git?rev=f5d7932dfa35b52354ad31ec741d76147066fea5#f5d7932d) [INFO] [stderr] Checking brain-store v0.1.0-alpha.1 (/opt/rustwide/workdir/crates/brain-store) [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking rmvm-kernel v0.1.0 (https://github.com/vinzify/Cortex-v3.1-RMVM---Relational-Memory-Virtual-Machine.git?rev=f5d7932dfa35b52354ad31ec741d76147066fea5#f5d7932d) [INFO] [stderr] Checking planner-guard v0.1.0-alpha.1 (/opt/rustwide/workdir/crates/planner-guard) [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking tonic v0.14.5 [INFO] [stderr] Checking tonic-prost v0.14.5 [INFO] [stderr] Checking adapter-rmvm v0.1.0-alpha.1 (/opt/rustwide/workdir/crates/adapter-rmvm) [INFO] [stderr] Checking rmvm-sidecar v0.1.0-alpha.1 (/opt/rustwide/workdir/crates/rmvm-sidecar) [INFO] [stderr] Checking cortex-app v0.1.0-alpha.1 (/opt/rustwide/workdir/crates/cortex-app) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> crates/cortex-app/src/product.rs:531:9 [INFO] [stdout] | [INFO] [stdout] 531 | let mut scheduled = Vec::new(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> crates/cortex-app/src/product.rs:531:9 [INFO] [stdout] | [INFO] [stdout] 531 | let mut scheduled = Vec::new(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:571:9 [INFO] [stdout] | [INFO] [stdout] 571 | / if let Some(dir) = install_dir { [INFO] [stdout] 572 | | if let Ok(true) = remove_dir_if_empty(&dir) { [INFO] [stdout] 573 | | removed.push(dir.display().to_string()); [INFO] [stdout] 574 | | } [INFO] [stdout] 575 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 571 ~ if let Some(dir) = install_dir [INFO] [stdout] 572 ~ && let Ok(true) = remove_dir_if_empty(&dir) { [INFO] [stdout] 573 | removed.push(dir.display().to_string()); [INFO] [stdout] 574 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:571:9 [INFO] [stdout] | [INFO] [stdout] 571 | / if let Some(dir) = install_dir { [INFO] [stdout] 572 | | if let Ok(true) = remove_dir_if_empty(&dir) { [INFO] [stdout] 573 | | removed.push(dir.display().to_string()); [INFO] [stdout] 574 | | } [INFO] [stdout] 575 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 571 ~ if let Some(dir) = install_dir [INFO] [stdout] 572 ~ && let Ok(true) = remove_dir_if_empty(&dir) { [INFO] [stdout] 573 | removed.push(dir.display().to_string()); [INFO] [stdout] 574 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:678:5 [INFO] [stdout] | [INFO] [stdout] 678 | / if let Ok(entry) = secret_entry(key) { [INFO] [stdout] 679 | | if let Ok(value) = entry.get_password() { [INFO] [stdout] 680 | | return Ok(Some(value)); [INFO] [stdout] 681 | | } [INFO] [stdout] 682 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 678 ~ if let Ok(entry) = secret_entry(key) [INFO] [stdout] 679 ~ && let Ok(value) = entry.get_password() { [INFO] [stdout] 680 | return Ok(Some(value)); [INFO] [stdout] 681 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:678:5 [INFO] [stdout] | [INFO] [stdout] 678 | / if let Ok(entry) = secret_entry(key) { [INFO] [stdout] 679 | | if let Ok(value) = entry.get_password() { [INFO] [stdout] 680 | | return Ok(Some(value)); [INFO] [stdout] 681 | | } [INFO] [stdout] 682 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 678 ~ if let Ok(entry) = secret_entry(key) [INFO] [stdout] 679 ~ && let Ok(value) = entry.get_password() { [INFO] [stdout] 680 | return Ok(Some(value)); [INFO] [stdout] 681 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:802:5 [INFO] [stdout] | [INFO] [stdout] 802 | / if let Ok(store) = BrainStore::new(None) { [INFO] [stdout] 803 | | if let Ok(summary) = store.resolve_brain(active) { [INFO] [stdout] 804 | | return summary.name; [INFO] [stdout] 805 | | } [INFO] [stdout] 806 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 802 ~ if let Ok(store) = BrainStore::new(None) [INFO] [stdout] 803 ~ && let Ok(summary) = store.resolve_brain(active) { [INFO] [stdout] 804 | return summary.name; [INFO] [stdout] 805 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:802:5 [INFO] [stdout] | [INFO] [stdout] 802 | / if let Ok(store) = BrainStore::new(None) { [INFO] [stdout] 803 | | if let Ok(summary) = store.resolve_brain(active) { [INFO] [stdout] 804 | | return summary.name; [INFO] [stdout] 805 | | } [INFO] [stdout] 806 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 802 ~ if let Ok(store) = BrainStore::new(None) [INFO] [stdout] 803 ~ && let Ok(summary) = store.resolve_brain(active) { [INFO] [stdout] 804 | return summary.name; [INFO] [stdout] 805 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:1101:12 [INFO] [stdout] | [INFO] [stdout] 1101 | } else if interactive [INFO] [stdout] | ____________^ [INFO] [stdout] 1102 | | && cfg [INFO] [stdout] 1103 | | .providers [INFO] [stdout] 1104 | | .get(&provider_name) [INFO] [stdout] ... | [INFO] [stdout] 1117 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1106 ~ .unwrap_or(false) [INFO] [stdout] 1107 ~ && let Some(value) = prompt_optional("Planner API key (optional)")? { [INFO] [stdout] 1108 | if let Some(secret_ref) = cfg [INFO] [stdout] ... [INFO] [stdout] 1114 | } [INFO] [stdout] 1115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:1108:9 [INFO] [stdout] | [INFO] [stdout] 1108 | / if let Some(value) = prompt_optional("Planner API key (optional)")? { [INFO] [stdout] 1109 | | if let Some(secret_ref) = cfg [INFO] [stdout] 1110 | | .providers [INFO] [stdout] 1111 | | .get(&provider_name) [INFO] [stdout] ... | [INFO] [stdout] 1116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1108 ~ if let Some(value) = prompt_optional("Planner API key (optional)")? [INFO] [stdout] 1109 ~ && let Some(secret_ref) = cfg [INFO] [stdout] 1110 | .providers [INFO] [stdout] ... [INFO] [stdout] 1114 | put_secret(&paths, &secret_ref, &value)?; [INFO] [stdout] 1115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:1101:12 [INFO] [stdout] | [INFO] [stdout] 1101 | } else if interactive [INFO] [stdout] | ____________^ [INFO] [stdout] 1102 | | && cfg [INFO] [stdout] 1103 | | .providers [INFO] [stdout] 1104 | | .get(&provider_name) [INFO] [stdout] ... | [INFO] [stdout] 1117 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1106 ~ .unwrap_or(false) [INFO] [stdout] 1107 ~ && let Some(value) = prompt_optional("Planner API key (optional)")? { [INFO] [stdout] 1108 | if let Some(secret_ref) = cfg [INFO] [stdout] ... [INFO] [stdout] 1114 | } [INFO] [stdout] 1115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:1108:9 [INFO] [stdout] | [INFO] [stdout] 1108 | / if let Some(value) = prompt_optional("Planner API key (optional)")? { [INFO] [stdout] 1109 | | if let Some(secret_ref) = cfg [INFO] [stdout] 1110 | | .providers [INFO] [stdout] 1111 | | .get(&provider_name) [INFO] [stdout] ... | [INFO] [stdout] 1116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1108 ~ if let Some(value) = prompt_optional("Planner API key (optional)")? [INFO] [stdout] 1109 ~ && let Some(secret_ref) = cfg [INFO] [stdout] 1110 | .providers [INFO] [stdout] ... [INFO] [stdout] 1114 | put_secret(&paths, &secret_ref, &value)?; [INFO] [stdout] 1115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/cortex-app/src/product.rs:1297:22 [INFO] [stdout] | [INFO] [stdout] 1297 | let stop_proxy = req.all || (!req.rmvm_only && !req.proxy_only) || req.proxy_only; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1297 - let stop_proxy = req.all || (!req.rmvm_only && !req.proxy_only) || req.proxy_only; [INFO] [stdout] 1297 + let stop_proxy = !(!req.all && req.rmvm_only && !req.proxy_only); [INFO] [stdout] | [INFO] [stdout] 1297 - let stop_proxy = req.all || (!req.rmvm_only && !req.proxy_only) || req.proxy_only; [INFO] [stdout] 1297 + let stop_proxy = req.all || !req.rmvm_only || req.proxy_only; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/cortex-app/src/product.rs:1298:21 [INFO] [stdout] | [INFO] [stdout] 1298 | let stop_rmvm = req.all || (!req.rmvm_only && !req.proxy_only) || req.rmvm_only; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1298 - let stop_rmvm = req.all || (!req.rmvm_only && !req.proxy_only) || req.rmvm_only; [INFO] [stdout] 1298 + let stop_rmvm = !(!req.all && !req.rmvm_only && req.proxy_only); [INFO] [stdout] | [INFO] [stdout] 1298 - let stop_rmvm = req.all || (!req.rmvm_only && !req.proxy_only) || req.rmvm_only; [INFO] [stdout] 1298 + let stop_rmvm = req.all || req.rmvm_only || !req.proxy_only; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/cortex-app/src/product.rs:1297:22 [INFO] [stdout] | [INFO] [stdout] 1297 | let stop_proxy = req.all || (!req.rmvm_only && !req.proxy_only) || req.proxy_only; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1297 - let stop_proxy = req.all || (!req.rmvm_only && !req.proxy_only) || req.proxy_only; [INFO] [stdout] 1297 + let stop_proxy = !(!req.all && req.rmvm_only && !req.proxy_only); [INFO] [stdout] | [INFO] [stdout] 1297 - let stop_proxy = req.all || (!req.rmvm_only && !req.proxy_only) || req.proxy_only; [INFO] [stdout] 1297 + let stop_proxy = req.all || !req.rmvm_only || req.proxy_only; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/cortex-app/src/product.rs:1298:21 [INFO] [stdout] | [INFO] [stdout] 1298 | let stop_rmvm = req.all || (!req.rmvm_only && !req.proxy_only) || req.rmvm_only; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1298 - let stop_rmvm = req.all || (!req.rmvm_only && !req.proxy_only) || req.rmvm_only; [INFO] [stdout] 1298 + let stop_rmvm = !(!req.all && !req.rmvm_only && req.proxy_only); [INFO] [stdout] | [INFO] [stdout] 1298 - let stop_rmvm = req.all || (!req.rmvm_only && !req.proxy_only) || req.rmvm_only; [INFO] [stdout] 1298 + let stop_rmvm = req.all || req.rmvm_only || !req.proxy_only; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:1749:5 [INFO] [stdout] | [INFO] [stdout] 1749 | / if let Some(model) = model { [INFO] [stdout] 1750 | | if let Some(profile) = cfg.providers.get_mut(name) { [INFO] [stdout] 1751 | | profile.planner_model = model; [INFO] [stdout] 1752 | | } [INFO] [stdout] 1753 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1749 ~ if let Some(model) = model [INFO] [stdout] 1750 ~ && let Some(profile) = cfg.providers.get_mut(name) { [INFO] [stdout] 1751 | profile.planner_model = model; [INFO] [stdout] 1752 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/cortex-app/src/product.rs:1749:5 [INFO] [stdout] | [INFO] [stdout] 1749 | / if let Some(model) = model { [INFO] [stdout] 1750 | | if let Some(profile) = cfg.providers.get_mut(name) { [INFO] [stdout] 1751 | | profile.planner_model = model; [INFO] [stdout] 1752 | | } [INFO] [stdout] 1753 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1749 ~ if let Some(model) = model [INFO] [stdout] 1750 ~ && let Some(profile) = cfg.providers.get_mut(name) { [INFO] [stdout] 1751 | profile.planner_model = model; [INFO] [stdout] 1752 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> crates/cortex-app/src/proxy.rs:1090:26 [INFO] [stdout] | [INFO] [stdout] 1090 | fn setup_store(home: &PathBuf) -> (String, String) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1090 ~ fn setup_store(home: &Path) -> (String, String) { [INFO] [stdout] 1091 | unsafe { [INFO] [stdout] 1092 | std::env::set_var("TEST_BRAIN_SECRET_PROXY", "test-secret-proxy"); [INFO] [stdout] 1093 | } [INFO] [stdout] 1094 ~ let store = BrainStore::new(Some(home.to_path_buf())).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.82s [INFO] running `Command { std: "docker" "inspect" "83611bab38281513bbe471f88169569ebc4e193d84a3bbecb0b12ac0c40df24f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83611bab38281513bbe471f88169569ebc4e193d84a3bbecb0b12ac0c40df24f", kill_on_drop: false }` [INFO] [stdout] 83611bab38281513bbe471f88169569ebc4e193d84a3bbecb0b12ac0c40df24f