[INFO] cloning repository https://github.com/vincentpun/advent-of-code-2022
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/vincentpun/advent-of-code-2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvincentpun%2Fadvent-of-code-2022", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvincentpun%2Fadvent-of-code-2022'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 40d41fc58e72f4ee93ebf4c162cd51f216647f65
[INFO] linting vincentpun/advent-of-code-2022 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvincentpun%2Fadvent-of-code-2022" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/vincentpun/advent-of-code-2022
[INFO] finished tweaking git repo https://github.com/vincentpun/advent-of-code-2022
[INFO] tweaked toml for git repo https://github.com/vincentpun/advent-of-code-2022 written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/vincentpun/advent-of-code-2022 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/vincentpun/advent-of-code-2022 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded utf8-chars v2.0.2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 984efb2da55f3ad07fff1d0f32059b5cbfca569a0c33feb035f295e2854f46fd
[INFO] running `Command { std: "docker" "start" "-a" "984efb2da55f3ad07fff1d0f32059b5cbfca569a0c33feb035f295e2854f46fd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "984efb2da55f3ad07fff1d0f32059b5cbfca569a0c33feb035f295e2854f46fd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "984efb2da55f3ad07fff1d0f32059b5cbfca569a0c33feb035f295e2854f46fd", kill_on_drop: false }`
[INFO] [stdout] 984efb2da55f3ad07fff1d0f32059b5cbfca569a0c33feb035f295e2854f46fd
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a407d6f83b72c8c3d2374aec760d53882355ef3d66643b3fc9c50bac0bb35a05
[INFO] running `Command { std: "docker" "start" "-a" "a407d6f83b72c8c3d2374aec760d53882355ef3d66643b3fc9c50bac0bb35a05", kill_on_drop: false }`
[INFO] [stderr]     Checking arrayvec v0.7.2
[INFO] [stderr]     Checking utf8-chars v2.0.2
[INFO] [stderr]     Checking advent-of-code-2022 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: function `debug` is never used
[INFO] [stdout]    --> src/y2022/d9.rs:130:4
[INFO] [stdout]     |
[INFO] [stdout] 130 | fn debug(coordinates: &[(i32, i32); 10]) {
[INFO] [stdout]     |    ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/y2022/d1.rs:51:44
[INFO] [stdout]    |
[INFO] [stdout] 51 |     let inventory_contents = read_contents(&INPUT_PATH).expect("Should be able to read inputs");
[INFO] [stdout]    |                                            ^^^^^^^^^^^ help: change this to: `INPUT_PATH`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/y2022/d3.rs:40:38
[INFO] [stdout]    |
[INFO] [stdout] 40 |                 let rucksack_items = rucksack.all().map(|c| *c).collect::<HashSet<char>>();
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `rucksack.all().copied()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]    = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/y2022/d4.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         !(first.upper < second.lower)
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(first.upper >= second.lower)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/y2022/d5.rs:18:38
[INFO] [stdout]    |
[INFO] [stdout] 18 |         println!("Stack {}: {} ", i, stack.last().map(|c| *c).unwrap_or(' '));
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `stack.last().copied()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/y2022/d5.rs:32:38
[INFO] [stdout]    |
[INFO] [stdout] 32 |         println!("Stack {}: {} ", i, stack.last().map(|c| *c).unwrap_or(' '));
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `stack.last().copied()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `repeat().take()` can be written more concisely
[INFO] [stdout]    --> src/y2022/d5.rs:100:30
[INFO] [stdout]     |
[INFO] [stdout] 100 |     let mut stacks: Stacks = std::iter::repeat(Vec::new()).take(num_stacks).collect();
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(Vec::new(), num_stacks)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n
[INFO] [stdout]     = note: `#[warn(clippy::manual_repeat_n)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `stacks`
[INFO] [stdout]    --> src/y2022/d5.rs:113:18
[INFO] [stdout]     |
[INFO] [stdout] 113 |         for i in 0..num_stacks {
[INFO] [stdout]     |                  ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 113 -         for i in 0..num_stacks {
[INFO] [stdout] 113 +         for (i, <item>) in stacks.iter_mut().enumerate().take(num_stacks) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function call inside of `expect`
[INFO] [stdout]   --> src/y2022/d6.rs:36:10
[INFO] [stdout]    |
[INFO] [stdout] 36 |           .expect(&format!(
[INFO] [stdout]    |  __________^
[INFO] [stdout] 37 | |             "There should be at least {} characters",
[INFO] [stdout] 38 | |             buffer_size
[INFO] [stdout] 39 | |         ));
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stdout]    = note: `#[warn(clippy::expect_fun_call)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 36 ~         .unwrap_or_else(|_| panic!("There should be at least {} characters",
[INFO] [stdout] 37 ~             buffer_size));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `debug` is never used
[INFO] [stdout]    --> src/y2022/d9.rs:130:4
[INFO] [stdout]     |
[INFO] [stdout] 130 | fn debug(coordinates: &[(i32, i32); 10]) {
[INFO] [stdout]     |    ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map(..).flatten()` on `Iterator`
[INFO] [stdout]   --> src/y2022/d8.rs:20:10
[INFO] [stdout]    |
[INFO] [stdout] 20 |           .map(|tree_row| tree_row.iter())
[INFO] [stdout]    |  __________^
[INFO] [stdout] 21 | |         .flatten()
[INFO] [stdout]    | |__________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|tree_row| tree_row.iter())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
[INFO] [stdout]    = note: `#[warn(clippy::map_flatten)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/y2022/d8.rs:22:22
[INFO] [stdout]    |
[INFO] [stdout] 22 |         .map(|tree| (tree.visibility.len() > 0) as i32)
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tree.visibility.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/y2022/d8.rs:34:13
[INFO] [stdout]    |
[INFO] [stdout] 34 |             let iter: Box<dyn Iterator<Item = &mut Tree>>;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `iter` here and remove the assignments from the branches
[INFO] [stdout]    |
[INFO] [stdout] 34 ~             
[INFO] [stdout] 35 ~             let iter: Box<dyn Iterator<Item = &mut Tree>> = if direction == VisibilityDirection::Left {
[INFO] [stdout] 36 ~                 Box::new(tree_row.iter_mut())
[INFO] [stdout] 37 |             } else {
[INFO] [stdout] 38 ~                 Box::new(tree_row.iter_mut().rev())
[INFO] [stdout] 39 ~             };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `tree_col_i` is only used to index `trees`
[INFO] [stdout]   --> src/y2022/d8.rs:53:27
[INFO] [stdout]    |
[INFO] [stdout] 53 |         for tree_col_i in 0..num_tree_cols {
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 53 -         for tree_col_i in 0..num_tree_cols {
[INFO] [stdout] 53 +         for <item> in trees.iter_mut().take(num_tree_cols) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/y2022/d1.rs:51:44
[INFO] [stdout]    |
[INFO] [stdout] 51 |     let inventory_contents = read_contents(&INPUT_PATH).expect("Should be able to read inputs");
[INFO] [stdout]    |                                            ^^^^^^^^^^^ help: change this to: `INPUT_PATH`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range<usize>`
[INFO] [stdout]   --> src/y2022/d8.rs:58:30
[INFO] [stdout]    |
[INFO] [stdout] 58 |                     Box::new((0..num_tree_rows).into_iter())
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..num_tree_rows)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map(..).flatten()` on `Iterator`
[INFO] [stdout]    --> src/y2022/d8.rs:83:10
[INFO] [stdout]     |
[INFO] [stdout]  83 |           .map(|(i, tree_row)| {
[INFO] [stdout]     |  __________^
[INFO] [stdout]  84 | |             tree_row.iter().enumerate().map({
[INFO] [stdout]  85 | |                 let trees = &trees;
[INFO] [stdout]  86 | |                 move |(j, _)| {
[INFO] [stdout] ...   |
[INFO] [stdout] 101 | |         })
[INFO] [stdout] 102 | |         .flatten()
[INFO] [stdout]     | |__________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
[INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()`
[INFO] [stdout]     |
[INFO] [stdout]  83 ~         .flat_map(|(i, tree_row)| {
[INFO] [stdout]  84 +             tree_row.iter().enumerate().map({
[INFO] [stdout]  85 +                 let trees = &trees;
[INFO] [stdout]  86 +                 move |(j, _)| {
[INFO] [stdout]  87 +                     visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Top)
[INFO] [stdout]  88 +                         * visible_trees_from_tree(
[INFO] [stdout]  89 +                             &trees,
[INFO] [stdout]  90 +                             (i.clone(), j),
[INFO] [stdout]  91 +                             VisibilityDirection::Bottom,
[INFO] [stdout]  92 +                         )
[INFO] [stdout]  93 +                         * visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Left)
[INFO] [stdout]  94 +                         * visible_trees_from_tree(
[INFO] [stdout]  95 +                             &trees,
[INFO] [stdout]  96 +                             (i.clone(), j),
[INFO] [stdout]  97 +                             VisibilityDirection::Right,
[INFO] [stdout]  98 +                         )
[INFO] [stdout]  99 +                 }
[INFO] [stdout] 100 +             })
[INFO] [stdout] 101 +         })
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/y2022/d8.rs:87:45
[INFO] [stdout]    |
[INFO] [stdout] 87 |                     visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Top)
[INFO] [stdout]    |                                             ^^^^^^ help: change this to: `trees`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d8.rs:87:54
[INFO] [stdout]    |
[INFO] [stdout] 87 |                     visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Top)
[INFO] [stdout]    |                                                      ^^^^^^^^^ help: try removing the `clone` call: `i`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]    = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/y2022/d3.rs:40:38
[INFO] [stdout]    |
[INFO] [stdout] 40 |                 let rucksack_items = rucksack.all().map(|c| *c).collect::<HashSet<char>>();
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `rucksack.all().copied()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]    = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/y2022/d8.rs:89:29
[INFO] [stdout]    |
[INFO] [stdout] 89 | ...                   &trees,
[INFO] [stdout]    |                       ^^^^^^ help: change this to: `trees`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d8.rs:90:30
[INFO] [stdout]    |
[INFO] [stdout] 90 | ...                   (i.clone(), j),
[INFO] [stdout]    |                        ^^^^^^^^^ help: try removing the `clone` call: `i`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/y2022/d8.rs:93:51
[INFO] [stdout]    |
[INFO] [stdout] 93 |                         * visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Left)
[INFO] [stdout]    |                                                   ^^^^^^ help: change this to: `trees`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d8.rs:93:60
[INFO] [stdout]    |
[INFO] [stdout] 93 |                         * visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Left)
[INFO] [stdout]    |                                                            ^^^^^^^^^ help: try removing the `clone` call: `i`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/y2022/d8.rs:95:29
[INFO] [stdout]    |
[INFO] [stdout] 95 | ...                   &trees,
[INFO] [stdout]    |                       ^^^^^^ help: change this to: `trees`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d8.rs:96:30
[INFO] [stdout]    |
[INFO] [stdout] 96 | ...                   (i.clone(), j),
[INFO] [stdout]    |                        ^^^^^^^^^ help: try removing the `clone` call: `i`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/y2022/d8.rs:110:12
[INFO] [stdout]     |
[INFO] [stdout] 110 |     trees: &Vec<Vec<Tree>>,
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 110 -     trees: &Vec<Vec<Tree>>,
[INFO] [stdout] 110 +     trees: &[Vec<Tree>],
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of both operands
[INFO] [stdout]    --> src/y2022/d8.rs:150:12
[INFO] [stdout]     |
[INFO] [stdout] 150 |         if &trees[i][j].height >= &tree_height_threshold {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]     = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] help: use the values directly
[INFO] [stdout]     |
[INFO] [stdout] 150 -         if &trees[i][j].height >= &tree_height_threshold {
[INFO] [stdout] 150 +         if trees[i][j].height >= tree_height_threshold {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/y2022/d4.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         !(first.upper < second.lower)
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(first.upper >= second.lower)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d9.rs:63:32
[INFO] [stdout]    |
[INFO] [stdout] 63 |             catch_up_if_needed(head_coordinates.clone(), tail_coordinates.clone());
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*head_coordinates`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d9.rs:63:58
[INFO] [stdout]    |
[INFO] [stdout] 63 |             catch_up_if_needed(head_coordinates.clone(), tail_coordinates.clone());
[INFO] [stdout]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tail_coordinates`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d9.rs:86:36
[INFO] [stdout]    |
[INFO] [stdout] 86 |                 catch_up_if_needed(coordinates[i - 1].clone(), coordinates[i].clone());
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `coordinates[i - 1]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/y2022/d5.rs:18:38
[INFO] [stdout]    |
[INFO] [stdout] 18 |         println!("Stack {}: {} ", i, stack.last().map(|c| *c).unwrap_or(' '));
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `stack.last().copied()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d9.rs:86:64
[INFO] [stdout]    |
[INFO] [stdout] 86 |                 catch_up_if_needed(coordinates[i - 1].clone(), coordinates[i].clone());
[INFO] [stdout]    |                                                                ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `coordinates[i]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/y2022/d5.rs:32:38
[INFO] [stdout]    |
[INFO] [stdout] 32 |         println!("Stack {}: {} ", i, stack.last().map(|c| *c).unwrap_or(' '));
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `stack.last().copied()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `coordinates`
[INFO] [stdout]    --> src/y2022/d9.rs:140:22
[INFO] [stdout]     |
[INFO] [stdout] 140 |             for i in 0..8 {
[INFO] [stdout]     |                      ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 140 -             for i in 0..8 {
[INFO] [stdout] 140 +             for (i, <item>) in coordinates.iter().enumerate().take(8) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `repeat().take()` can be written more concisely
[INFO] [stdout]    --> src/y2022/d5.rs:100:30
[INFO] [stdout]     |
[INFO] [stdout] 100 |     let mut stacks: Stacks = std::iter::repeat(Vec::new()).take(num_stacks).collect();
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(Vec::new(), num_stacks)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n
[INFO] [stdout]     = note: `#[warn(clippy::manual_repeat_n)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `stacks`
[INFO] [stdout]    --> src/y2022/d5.rs:113:18
[INFO] [stdout]     |
[INFO] [stdout] 113 |         for i in 0..num_stacks {
[INFO] [stdout]     |                  ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 113 -         for i in 0..num_stacks {
[INFO] [stdout] 113 +         for (i, <item>) in stacks.iter_mut().enumerate().take(num_stacks) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function call inside of `expect`
[INFO] [stdout]   --> src/y2022/d6.rs:36:10
[INFO] [stdout]    |
[INFO] [stdout] 36 |           .expect(&format!(
[INFO] [stdout]    |  __________^
[INFO] [stdout] 37 | |             "There should be at least {} characters",
[INFO] [stdout] 38 | |             buffer_size
[INFO] [stdout] 39 | |         ));
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stdout]    = note: `#[warn(clippy::expect_fun_call)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 36 ~         .unwrap_or_else(|_| panic!("There should be at least {} characters",
[INFO] [stdout] 37 ~             buffer_size));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map(..).flatten()` on `Iterator`
[INFO] [stdout]   --> src/y2022/d8.rs:20:10
[INFO] [stdout]    |
[INFO] [stdout] 20 |           .map(|tree_row| tree_row.iter())
[INFO] [stdout]    |  __________^
[INFO] [stdout] 21 | |         .flatten()
[INFO] [stdout]    | |__________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|tree_row| tree_row.iter())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
[INFO] [stdout]    = note: `#[warn(clippy::map_flatten)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/y2022/d8.rs:22:22
[INFO] [stdout]    |
[INFO] [stdout] 22 |         .map(|tree| (tree.visibility.len() > 0) as i32)
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tree.visibility.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/y2022/d8.rs:34:13
[INFO] [stdout]    |
[INFO] [stdout] 34 |             let iter: Box<dyn Iterator<Item = &mut Tree>>;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `iter` here and remove the assignments from the branches
[INFO] [stdout]    |
[INFO] [stdout] 34 ~             
[INFO] [stdout] 35 ~             let iter: Box<dyn Iterator<Item = &mut Tree>> = if direction == VisibilityDirection::Left {
[INFO] [stdout] 36 ~                 Box::new(tree_row.iter_mut())
[INFO] [stdout] 37 |             } else {
[INFO] [stdout] 38 ~                 Box::new(tree_row.iter_mut().rev())
[INFO] [stdout] 39 ~             };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `tree_col_i` is only used to index `trees`
[INFO] [stdout]   --> src/y2022/d8.rs:53:27
[INFO] [stdout]    |
[INFO] [stdout] 53 |         for tree_col_i in 0..num_tree_cols {
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 53 -         for tree_col_i in 0..num_tree_cols {
[INFO] [stdout] 53 +         for <item> in trees.iter_mut().take(num_tree_cols) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range<usize>`
[INFO] [stdout]   --> src/y2022/d8.rs:58:30
[INFO] [stdout]    |
[INFO] [stdout] 58 |                     Box::new((0..num_tree_rows).into_iter())
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..num_tree_rows)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map(..).flatten()` on `Iterator`
[INFO] [stdout]    --> src/y2022/d8.rs:83:10
[INFO] [stdout]     |
[INFO] [stdout]  83 |           .map(|(i, tree_row)| {
[INFO] [stdout]     |  __________^
[INFO] [stdout]  84 | |             tree_row.iter().enumerate().map({
[INFO] [stdout]  85 | |                 let trees = &trees;
[INFO] [stdout]  86 | |                 move |(j, _)| {
[INFO] [stdout] ...   |
[INFO] [stdout] 101 | |         })
[INFO] [stdout] 102 | |         .flatten()
[INFO] [stdout]     | |__________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
[INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()`
[INFO] [stdout]     |
[INFO] [stdout]  83 ~         .flat_map(|(i, tree_row)| {
[INFO] [stdout]  84 +             tree_row.iter().enumerate().map({
[INFO] [stdout]  85 +                 let trees = &trees;
[INFO] [stdout]  86 +                 move |(j, _)| {
[INFO] [stdout]  87 +                     visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Top)
[INFO] [stdout]  88 +                         * visible_trees_from_tree(
[INFO] [stdout]  89 +                             &trees,
[INFO] [stdout]  90 +                             (i.clone(), j),
[INFO] [stdout]  91 +                             VisibilityDirection::Bottom,
[INFO] [stdout]  92 +                         )
[INFO] [stdout]  93 +                         * visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Left)
[INFO] [stdout]  94 +                         * visible_trees_from_tree(
[INFO] [stdout]  95 +                             &trees,
[INFO] [stdout]  96 +                             (i.clone(), j),
[INFO] [stdout]  97 +                             VisibilityDirection::Right,
[INFO] [stdout]  98 +                         )
[INFO] [stdout]  99 +                 }
[INFO] [stdout] 100 +             })
[INFO] [stdout] 101 +         })
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/y2022/d8.rs:87:45
[INFO] [stdout]    |
[INFO] [stdout] 87 |                     visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Top)
[INFO] [stdout]    |                                             ^^^^^^ help: change this to: `trees`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d8.rs:87:54
[INFO] [stdout]    |
[INFO] [stdout] 87 |                     visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Top)
[INFO] [stdout]    |                                                      ^^^^^^^^^ help: try removing the `clone` call: `i`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]    = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/y2022/d8.rs:89:29
[INFO] [stdout]    |
[INFO] [stdout] 89 | ...                   &trees,
[INFO] [stdout]    |                       ^^^^^^ help: change this to: `trees`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d8.rs:90:30
[INFO] [stdout]    |
[INFO] [stdout] 90 | ...                   (i.clone(), j),
[INFO] [stdout]    |                        ^^^^^^^^^ help: try removing the `clone` call: `i`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/y2022/d8.rs:93:51
[INFO] [stdout]    |
[INFO] [stdout] 93 |                         * visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Left)
[INFO] [stdout]    |                                                   ^^^^^^ help: change this to: `trees`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d8.rs:93:60
[INFO] [stdout]    |
[INFO] [stdout] 93 |                         * visible_trees_from_tree(&trees, (i.clone(), j), VisibilityDirection::Left)
[INFO] [stdout]    |                                                            ^^^^^^^^^ help: try removing the `clone` call: `i`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/y2022/d8.rs:95:29
[INFO] [stdout]    |
[INFO] [stdout] 95 | ...                   &trees,
[INFO] [stdout]    |                       ^^^^^^ help: change this to: `trees`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d8.rs:96:30
[INFO] [stdout]    |
[INFO] [stdout] 96 | ...                   (i.clone(), j),
[INFO] [stdout]    |                        ^^^^^^^^^ help: try removing the `clone` call: `i`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/y2022/d8.rs:110:12
[INFO] [stdout]     |
[INFO] [stdout] 110 |     trees: &Vec<Vec<Tree>>,
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 110 -     trees: &Vec<Vec<Tree>>,
[INFO] [stdout] 110 +     trees: &[Vec<Tree>],
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of both operands
[INFO] [stdout]    --> src/y2022/d8.rs:150:12
[INFO] [stdout]     |
[INFO] [stdout] 150 |         if &trees[i][j].height >= &tree_height_threshold {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]     = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] help: use the values directly
[INFO] [stdout]     |
[INFO] [stdout] 150 -         if &trees[i][j].height >= &tree_height_threshold {
[INFO] [stdout] 150 +         if trees[i][j].height >= tree_height_threshold {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d9.rs:63:32
[INFO] [stdout]    |
[INFO] [stdout] 63 |             catch_up_if_needed(head_coordinates.clone(), tail_coordinates.clone());
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*head_coordinates`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d9.rs:63:58
[INFO] [stdout]    |
[INFO] [stdout] 63 |             catch_up_if_needed(head_coordinates.clone(), tail_coordinates.clone());
[INFO] [stdout]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tail_coordinates`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d9.rs:86:36
[INFO] [stdout]    |
[INFO] [stdout] 86 |                 catch_up_if_needed(coordinates[i - 1].clone(), coordinates[i].clone());
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `coordinates[i - 1]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait
[INFO] [stdout]   --> src/y2022/d9.rs:86:64
[INFO] [stdout]    |
[INFO] [stdout] 86 |                 catch_up_if_needed(coordinates[i - 1].clone(), coordinates[i].clone());
[INFO] [stdout]    |                                                                ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `coordinates[i]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `coordinates`
[INFO] [stdout]    --> src/y2022/d9.rs:140:22
[INFO] [stdout]     |
[INFO] [stdout] 140 |             for i in 0..8 {
[INFO] [stdout]     |                      ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 140 -             for i in 0..8 {
[INFO] [stdout] 140 +             for (i, <item>) in coordinates.iter().enumerate().take(8) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.70s
[INFO] running `Command { std: "docker" "inspect" "a407d6f83b72c8c3d2374aec760d53882355ef3d66643b3fc9c50bac0bb35a05", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a407d6f83b72c8c3d2374aec760d53882355ef3d66643b3fc9c50bac0bb35a05", kill_on_drop: false }`
[INFO] [stdout] a407d6f83b72c8c3d2374aec760d53882355ef3d66643b3fc9c50bac0bb35a05