[INFO] cloning repository https://github.com/vince-nyanga/rust-shell [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/vince-nyanga/rust-shell" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvince-nyanga%2Frust-shell", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvince-nyanga%2Frust-shell'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 33c14edc9175796eaf1d3bd1e909ecb97fab3b79 [INFO] linting vince-nyanga/rust-shell against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvince-nyanga%2Frust-shell" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/vince-nyanga/rust-shell [INFO] finished tweaking git repo https://github.com/vince-nyanga/rust-shell [INFO] tweaked toml for git repo https://github.com/vince-nyanga/rust-shell written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/vince-nyanga/rust-shell on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/vince-nyanga/rust-shell already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c41c0c1060d04a6fe7b5e70c9a8ede6e0eb6497e7863eb2a017d3ec11af9dde0 [INFO] running `Command { std: "docker" "start" "-a" "c41c0c1060d04a6fe7b5e70c9a8ede6e0eb6497e7863eb2a017d3ec11af9dde0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c41c0c1060d04a6fe7b5e70c9a8ede6e0eb6497e7863eb2a017d3ec11af9dde0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c41c0c1060d04a6fe7b5e70c9a8ede6e0eb6497e7863eb2a017d3ec11af9dde0", kill_on_drop: false }` [INFO] [stdout] c41c0c1060d04a6fe7b5e70c9a8ede6e0eb6497e7863eb2a017d3ec11af9dde0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3581cf5e6d8d8c0f6f1af9a817cf86377612250c6bc502fa3cd1019b352ed12 [INFO] running `Command { std: "docker" "start" "-a" "e3581cf5e6d8d8c0f6f1af9a817cf86377612250c6bc502fa3cd1019b352ed12", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking shell-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/command_handler.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 105 | if !env::set_current_dir(path.clone()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::set_current_dir(path.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/command_handler.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | / return env::var("PATH") [INFO] [stdout] 113 | | .unwrap() [INFO] [stdout] 114 | | .split(":") [INFO] [stdout] 115 | | .map(|path| format!("{}/{}", path, command)) [INFO] [stdout] 116 | | .find(|path| std::fs::metadata(path).is_ok()); [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 ~ env::var("PATH") [INFO] [stdout] 113 + .unwrap() [INFO] [stdout] 114 + .split(":") [INFO] [stdout] 115 + .map(|path| format!("{}/{}", path, command)) [INFO] [stdout] 116 ~ .find(|path| std::fs::metadata(path).is_ok()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/main.rs:12:45 [INFO] [stdout] | [INFO] [stdout] 12 | let prompt_parts: Vec<&str> = input.trim().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/command_handler.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 105 | if !env::set_current_dir(path.clone()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::set_current_dir(path.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/command_handler.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | / return env::var("PATH") [INFO] [stdout] 113 | | .unwrap() [INFO] [stdout] 114 | | .split(":") [INFO] [stdout] 115 | | .map(|path| format!("{}/{}", path, command)) [INFO] [stdout] 116 | | .find(|path| std::fs::metadata(path).is_ok()); [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 ~ env::var("PATH") [INFO] [stdout] 113 + .unwrap() [INFO] [stdout] 114 + .split(":") [INFO] [stdout] 115 + .map(|path| format!("{}/{}", path, command)) [INFO] [stdout] 116 ~ .find(|path| std::fs::metadata(path).is_ok()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/main.rs:12:45 [INFO] [stdout] | [INFO] [stdout] 12 | let prompt_parts: Vec<&str> = input.trim().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.54s [INFO] running `Command { std: "docker" "inspect" "e3581cf5e6d8d8c0f6f1af9a817cf86377612250c6bc502fa3cd1019b352ed12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3581cf5e6d8d8c0f6f1af9a817cf86377612250c6bc502fa3cd1019b352ed12", kill_on_drop: false }` [INFO] [stdout] e3581cf5e6d8d8c0f6f1af9a817cf86377612250c6bc502fa3cd1019b352ed12