[INFO] cloning repository https://github.com/veri-tty/vncenum [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/veri-tty/vncenum" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fveri-tty%2Fvncenum", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fveri-tty%2Fvncenum'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 23a55feebcd119e57b21484c544f0ae1347107ea [INFO] linting veri-tty/vncenum against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fveri-tty%2Fvncenum" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/veri-tty/vncenum [INFO] finished tweaking git repo https://github.com/veri-tty/vncenum [INFO] tweaked toml for git repo https://github.com/veri-tty/vncenum written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/veri-tty/vncenum on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/veri-tty/vncenum already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 452f679f036ea4d7d0f7e3d63aabeab29ac6bebef7b8793ac31dfbf7a85eaba3 [INFO] running `Command { std: "docker" "start" "-a" "452f679f036ea4d7d0f7e3d63aabeab29ac6bebef7b8793ac31dfbf7a85eaba3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "452f679f036ea4d7d0f7e3d63aabeab29ac6bebef7b8793ac31dfbf7a85eaba3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "452f679f036ea4d7d0f7e3d63aabeab29ac6bebef7b8793ac31dfbf7a85eaba3", kill_on_drop: false }` [INFO] [stdout] 452f679f036ea4d7d0f7e3d63aabeab29ac6bebef7b8793ac31dfbf7a85eaba3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2d19d8f351fc319c431ea2bca48192f06d43dc0fa276b0ba21251b606a292ded [INFO] running `Command { std: "docker" "start" "-a" "2d19d8f351fc319c431ea2bca48192f06d43dc0fa276b0ba21251b606a292ded", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking xml-rs v0.8.26 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking vncscan v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | / ... if attr.name.local_name == "portid" { [INFO] [stdout] 41 | | ... if let Ok(port) = attr.value.parse::() { [INFO] [stdout] 42 | | ... current_ports.push(port); [INFO] [stdout] 43 | | ... } [INFO] [stdout] 44 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if attr.name.local_name == "portid" [INFO] [stdout] 41 ~ && let Ok(port) = attr.value.parse::() { [INFO] [stdout] 42 | current_ports.push(port); [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | / match name.local_name.as_str() { [INFO] [stdout] 52 | | "host" => { [INFO] [stdout] 53 | | if let Some(ip) = current_ip.take() { [INFO] [stdout] 54 | | hosts.push(Host { [INFO] [stdout] ... | [INFO] [stdout] 61 | | _ => {} [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ if name.local_name.as_str() == "host" { [INFO] [stdout] 52 + if let Some(ip) = current_ip.take() { [INFO] [stdout] 53 + hosts.push(Host { [INFO] [stdout] 54 + ip, [INFO] [stdout] 55 + ports: current_ports.clone(), [INFO] [stdout] 56 + }); [INFO] [stdout] 57 + } [INFO] [stdout] 58 + in_host = false; [INFO] [stdout] 59 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 144 | if !fs::metadata(path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | / ... if attr.name.local_name == "portid" { [INFO] [stdout] 41 | | ... if let Ok(port) = attr.value.parse::() { [INFO] [stdout] 42 | | ... current_ports.push(port); [INFO] [stdout] 43 | | ... } [INFO] [stdout] 44 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if attr.name.local_name == "portid" [INFO] [stdout] 41 ~ && let Ok(port) = attr.value.parse::() { [INFO] [stdout] 42 | current_ports.push(port); [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | / match name.local_name.as_str() { [INFO] [stdout] 52 | | "host" => { [INFO] [stdout] 53 | | if let Some(ip) = current_ip.take() { [INFO] [stdout] 54 | | hosts.push(Host { [INFO] [stdout] ... | [INFO] [stdout] 61 | | _ => {} [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ if name.local_name.as_str() == "host" { [INFO] [stdout] 52 + if let Some(ip) = current_ip.take() { [INFO] [stdout] 53 + hosts.push(Host { [INFO] [stdout] 54 + ip, [INFO] [stdout] 55 + ports: current_ports.clone(), [INFO] [stdout] 56 + }); [INFO] [stdout] 57 + } [INFO] [stdout] 58 + in_host = false; [INFO] [stdout] 59 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 144 | if !fs::metadata(path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.73s [INFO] running `Command { std: "docker" "inspect" "2d19d8f351fc319c431ea2bca48192f06d43dc0fa276b0ba21251b606a292ded", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d19d8f351fc319c431ea2bca48192f06d43dc0fa276b0ba21251b606a292ded", kill_on_drop: false }` [INFO] [stdout] 2d19d8f351fc319c431ea2bca48192f06d43dc0fa276b0ba21251b606a292ded