[INFO] cloning repository https://github.com/vazanoir/rs-cat
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/vazanoir/rs-cat" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvazanoir%2Frs-cat", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvazanoir%2Frs-cat'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] b1537702f6ecc5b4aa6ce2a800c837138b0b9a87
[INFO] linting vazanoir/rs-cat against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvazanoir%2Frs-cat" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/vazanoir/rs-cat
[INFO] finished tweaking git repo https://github.com/vazanoir/rs-cat
[INFO] tweaked toml for git repo https://github.com/vazanoir/rs-cat written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/vazanoir/rs-cat on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/vazanoir/rs-cat already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] d7560b0390d693cfa894ae00c6c4ce7902b4c33c844a118a991ec4fff1ac5157
[INFO] running `Command { std: "docker" "start" "-a" "d7560b0390d693cfa894ae00c6c4ce7902b4c33c844a118a991ec4fff1ac5157", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "d7560b0390d693cfa894ae00c6c4ce7902b4c33c844a118a991ec4fff1ac5157", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d7560b0390d693cfa894ae00c6c4ce7902b4c33c844a118a991ec4fff1ac5157", kill_on_drop: false }`
[INFO] [stdout] d7560b0390d693cfa894ae00c6c4ce7902b4c33c844a118a991ec4fff1ac5157
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] e65762ab0f4fdf683aa50047dff7fe6a5241078d5224528788378139dd77aa41
[INFO] running `Command { std: "docker" "start" "-a" "e65762ab0f4fdf683aa50047dff7fe6a5241078d5224528788378139dd77aa41", kill_on_drop: false }`
[INFO] [stderr]     Checking rs-cat v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cat/format/options.rs:72:5
[INFO] [stdout]    |
[INFO] [stdout] 72 |     return options;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -     return options;
[INFO] [stdout] 72 +     options
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cat/format/options.rs:121:5
[INFO] [stdout]     |
[INFO] [stdout] 121 |     return Ok(options);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 121 -     return Ok(options);
[INFO] [stdout] 121 +     Ok(options)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/cat/format/options.rs:79:23
[INFO] [stdout]    |
[INFO] [stdout] 79 |         let is_file = arg.chars().nth(0).unwrap() != '-';
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `arg.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/cat/format/options.rs:135:9
[INFO] [stdout]     |
[INFO] [stdout] 135 |         help.push_str("\n");
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `help.push('\n')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout]     = note: `#[warn(clippy::single_char_add_str)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cat/format/options.rs:158:5
[INFO] [stdout]     |
[INFO] [stdout] 158 |     return line;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 158 -     return line;
[INFO] [stdout] 158 +     line
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/cat/format/options.rs:149:5
[INFO] [stdout]     |
[INFO] [stdout] 149 |     line.push_str("\t");
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `line.push('\t')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/cat/format/options.rs:152:13
[INFO] [stdout]     |
[INFO] [stdout] 152 |             line.push_str("\t");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `line.push('\t')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cat/format.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     return formated_line_number;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 13 -     return formated_line_number;
[INFO] [stdout] 13 +     formated_line_number
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cat/format.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 |     return char::from_u32(i).unwrap().to_string();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 17 -     return char::from_u32(i).unwrap().to_string();
[INFO] [stdout] 17 +     char::from_u32(i).unwrap().to_string()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cat/format.rs:36:5
[INFO] [stdout]    |
[INFO] [stdout] 36 |     return line;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 -     return line;
[INFO] [stdout] 36 +     line
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cat/format.rs:118:8
[INFO] [stdout]     |
[INFO] [stdout] 118 |     if !squeeze_blank || (squeeze_blank && blank_line_counter <= 1) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 118 -     if !squeeze_blank || (squeeze_blank && blank_line_counter <= 1) {
[INFO] [stdout] 118 +     if !(squeeze_blank && blank_line_counter > 1) {
[INFO] [stdout]     |
[INFO] [stdout] 118 -     if !squeeze_blank || (squeeze_blank && blank_line_counter <= 1) {
[INFO] [stdout] 118 +     if !squeeze_blank || blank_line_counter <= 1 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cat/format.rs:122:5
[INFO] [stdout]     |
[INFO] [stdout] 122 |     return (output, line_number, blank_line_counter);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 122 -     return (output, line_number, blank_line_counter);
[INFO] [stdout] 122 +     (output, line_number, blank_line_counter)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/cat/format.rs:40:14
[INFO] [stdout]    |
[INFO] [stdout] 40 |     options: &Vec<options::Option>,
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 40 -     options: &Vec<options::Option>,
[INFO] [stdout] 40 +     options: &[options::Option],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/cat/format.rs:56:22
[INFO] [stdout]    |
[INFO] [stdout] 56 |     let empty_line = line.trim_end_matches("\n").len() == 0;
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.trim_end_matches("\n").is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/cat/format.rs:115:9
[INFO] [stdout]     |
[INFO] [stdout] 115 |         line = line + "$";
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^ help: replace it with: `line += "$"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/cat.rs:36:22
[INFO] [stdout]    |
[INFO] [stdout] 36 |         let is_arg = arg.chars().nth(0).unwrap() == '-';
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `arg.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/cat.rs:76:26
[INFO] [stdout]    |
[INFO] [stdout] 76 |             let is_arg = arg.chars().nth(0).unwrap() == '-';
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `arg.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cat/format/options.rs:72:5
[INFO] [stdout]    |
[INFO] [stdout] 72 |     return options;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -     return options;
[INFO] [stdout] 72 +     options
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cat/format/options.rs:121:5
[INFO] [stdout]     |
[INFO] [stdout] 121 |     return Ok(options);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 121 -     return Ok(options);
[INFO] [stdout] 121 +     Ok(options)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/cat/format/options.rs:79:23
[INFO] [stdout]    |
[INFO] [stdout] 79 |         let is_file = arg.chars().nth(0).unwrap() != '-';
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `arg.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/cat/format/options.rs:135:9
[INFO] [stdout]     |
[INFO] [stdout] 135 |         help.push_str("\n");
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `help.push('\n')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout]     = note: `#[warn(clippy::single_char_add_str)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cat/format/options.rs:158:5
[INFO] [stdout]     |
[INFO] [stdout] 158 |     return line;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 158 -     return line;
[INFO] [stdout] 158 +     line
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/cat/format/options.rs:149:5
[INFO] [stdout]     |
[INFO] [stdout] 149 |     line.push_str("\t");
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `line.push('\t')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/cat/format/options.rs:152:13
[INFO] [stdout]     |
[INFO] [stdout] 152 |             line.push_str("\t");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `line.push('\t')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cat/format.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     return formated_line_number;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 13 -     return formated_line_number;
[INFO] [stdout] 13 +     formated_line_number
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cat/format.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 |     return char::from_u32(i).unwrap().to_string();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 17 -     return char::from_u32(i).unwrap().to_string();
[INFO] [stdout] 17 +     char::from_u32(i).unwrap().to_string()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cat/format.rs:36:5
[INFO] [stdout]    |
[INFO] [stdout] 36 |     return line;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 -     return line;
[INFO] [stdout] 36 +     line
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cat/format.rs:118:8
[INFO] [stdout]     |
[INFO] [stdout] 118 |     if !squeeze_blank || (squeeze_blank && blank_line_counter <= 1) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 118 -     if !squeeze_blank || (squeeze_blank && blank_line_counter <= 1) {
[INFO] [stdout] 118 +     if !(squeeze_blank && blank_line_counter > 1) {
[INFO] [stdout]     |
[INFO] [stdout] 118 -     if !squeeze_blank || (squeeze_blank && blank_line_counter <= 1) {
[INFO] [stdout] 118 +     if !squeeze_blank || blank_line_counter <= 1 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cat/format.rs:122:5
[INFO] [stdout]     |
[INFO] [stdout] 122 |     return (output, line_number, blank_line_counter);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 122 -     return (output, line_number, blank_line_counter);
[INFO] [stdout] 122 +     (output, line_number, blank_line_counter)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/cat/format.rs:40:14
[INFO] [stdout]    |
[INFO] [stdout] 40 |     options: &Vec<options::Option>,
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 40 -     options: &Vec<options::Option>,
[INFO] [stdout] 40 +     options: &[options::Option],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/cat/format.rs:56:22
[INFO] [stdout]    |
[INFO] [stdout] 56 |     let empty_line = line.trim_end_matches("\n").len() == 0;
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.trim_end_matches("\n").is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/cat/format.rs:115:9
[INFO] [stdout]     |
[INFO] [stdout] 115 |         line = line + "$";
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^ help: replace it with: `line += "$"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/cat.rs:36:22
[INFO] [stdout]    |
[INFO] [stdout] 36 |         let is_arg = arg.chars().nth(0).unwrap() == '-';
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `arg.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/cat.rs:76:26
[INFO] [stdout]    |
[INFO] [stdout] 76 |             let is_arg = arg.chars().nth(0).unwrap() == '-';
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `arg.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s
[INFO] running `Command { std: "docker" "inspect" "e65762ab0f4fdf683aa50047dff7fe6a5241078d5224528788378139dd77aa41", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e65762ab0f4fdf683aa50047dff7fe6a5241078d5224528788378139dd77aa41", kill_on_drop: false }`
[INFO] [stdout] e65762ab0f4fdf683aa50047dff7fe6a5241078d5224528788378139dd77aa41