[INFO] cloning repository https://github.com/v-maxson/chipper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/v-maxson/chipper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fv-maxson%2Fchipper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fv-maxson%2Fchipper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 46fd90fff075fb03a5ea4289af6911348c621128 [INFO] linting v-maxson/chipper against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fv-maxson%2Fchipper" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/v-maxson/chipper [INFO] finished tweaking git repo https://github.com/v-maxson/chipper [INFO] tweaked toml for git repo https://github.com/v-maxson/chipper written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/v-maxson/chipper on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/v-maxson/chipper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bool32 v0.1.1 [INFO] [stderr] Downloaded fixedstep v0.3.0 [INFO] [stderr] Downloaded rand_core v0.9.2 [INFO] [stderr] Downloaded zerocopy-derive v0.8.20 [INFO] [stderr] Downloaded zerocopy v0.8.20 [INFO] [stderr] Downloaded fermium v22605.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 564c58118a8dccdbff05ed2889fd5fa67c1780a0f879da623280de4987e91749 [INFO] running `Command { std: "docker" "start" "-a" "564c58118a8dccdbff05ed2889fd5fa67c1780a0f879da623280de4987e91749", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "564c58118a8dccdbff05ed2889fd5fa67c1780a0f879da623280de4987e91749", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "564c58118a8dccdbff05ed2889fd5fa67c1780a0f879da623280de4987e91749", kill_on_drop: false }` [INFO] [stdout] 564c58118a8dccdbff05ed2889fd5fa67c1780a0f879da623280de4987e91749 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad785e1f918055666a561cd0d44d0ceb0c194f1a44b297639b23b6c634edf299 [INFO] running `Command { std: "docker" "start" "-a" "ad785e1f918055666a561cd0d44d0ceb0c194f1a44b297639b23b6c634edf299", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.17 [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Compiling getrandom v0.3.1 [INFO] [stderr] Compiling zerocopy v0.8.20 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling cc v1.2.15 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Compiling anyhow v1.0.96 [INFO] [stderr] Checking bool32 v0.1.1 [INFO] [stderr] Checking fixedstep v0.3.0 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling fermium v22605.0.0 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking rand_core v0.9.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.0 [INFO] [stderr] Checking chipper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: inconsistent casing in hexadecimal literal [INFO] [stdout] --> src/cpu/mod.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 45 | pub const PIXEL_OFF: u32 = 0xFFa3a34d; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `0xffa3a34d` or `0xFFA3A34D` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_case_hex_literals [INFO] [stdout] = note: `#[warn(clippy::mixed_case_hex_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inconsistent casing in hexadecimal literal [INFO] [stdout] --> src/cpu/mod.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 46 | pub const PIXEL_ON: u32 = 0xFF5e5e35; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `0xff5e5e35` or `0xFF5E5E35` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_case_hex_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inconsistent casing in hexadecimal literal [INFO] [stdout] --> src/cpu/mod.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 45 | pub const PIXEL_OFF: u32 = 0xFFa3a34d; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `0xffa3a34d` or `0xFFA3A34D` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_case_hex_literals [INFO] [stdout] = note: `#[warn(clippy::mixed_case_hex_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inconsistent casing in hexadecimal literal [INFO] [stdout] --> src/cpu/mod.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 46 | pub const PIXEL_ON: u32 = 0xFF5e5e35; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `0xff5e5e35` or `0xFF5E5E35` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_case_hex_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `pop` after checking its variant with `is_err` [INFO] [stdout] --> src/cpu/instruction_set.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 18 | if pop.is_err() { [INFO] [stdout] | --------------- help: try: `if let Ok() = pop` [INFO] [stdout] ... [INFO] [stdout] 22 | cpu.pc = pop.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/instruction_set.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - eprintln!("Stack underflow"); [INFO] [stdout] 20 - return; [INFO] [stdout] 19 + eprintln!("Stack underflow"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/platform.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | / match unsafe { event.type_ } { [INFO] [stdout] 100 | | SDL_QUIT => return false, [INFO] [stdout] 101 | | _ => {} [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________^ help: try: `if unsafe { event.type_ } == SDL_QUIT { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 12s [INFO] [stdout] warning: called `unwrap` on `pop` after checking its variant with `is_err` [INFO] [stdout] --> src/cpu/instruction_set.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 18 | if pop.is_err() { [INFO] [stdout] | --------------- help: try: `if let Ok() = pop` [INFO] [stdout] ... [INFO] [stdout] 22 | cpu.pc = pop.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/instruction_set.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - eprintln!("Stack underflow"); [INFO] [stdout] 20 - return; [INFO] [stdout] 19 + eprintln!("Stack underflow"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/platform.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | / match unsafe { event.type_ } { [INFO] [stdout] 100 | | SDL_QUIT => return false, [INFO] [stdout] 101 | | _ => {} [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________^ help: try: `if unsafe { event.type_ } == SDL_QUIT { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "ad785e1f918055666a561cd0d44d0ceb0c194f1a44b297639b23b6c634edf299", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad785e1f918055666a561cd0d44d0ceb0c194f1a44b297639b23b6c634edf299", kill_on_drop: false }` [INFO] [stdout] ad785e1f918055666a561cd0d44d0ceb0c194f1a44b297639b23b6c634edf299