[INFO] cloning repository https://github.com/utkn/dull [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/utkn/dull" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Futkn%2Fdull", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Futkn%2Fdull'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1e90942e91988fccd18600d43b04aaa1cb231b6a [INFO] linting utkn/dull against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Futkn%2Fdull" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/utkn/dull [INFO] finished tweaking git repo https://github.com/utkn/dull [INFO] tweaked toml for git repo https://github.com/utkn/dull written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/utkn/dull on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/utkn/dull already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pwd v1.4.0 [INFO] [stderr] Downloaded expanduser v1.2.2 [INFO] [stderr] Downloaded serde_derive v1.0.192 [INFO] [stderr] Downloaded clap v4.4.8 [INFO] [stderr] Downloaded clap_builder v4.4.8 [INFO] [stderr] Downloaded serde v1.0.192 [INFO] [stderr] Downloaded winnow v0.5.19 [INFO] [stderr] Downloaded hashbrown v0.14.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49622832b33a96717b5e28c24fc0f001d1c929430e04b3ea4b766e39eed4d1a7 [INFO] running `Command { std: "docker" "start" "-a" "49622832b33a96717b5e28c24fc0f001d1c929430e04b3ea4b766e39eed4d1a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49622832b33a96717b5e28c24fc0f001d1c929430e04b3ea4b766e39eed4d1a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49622832b33a96717b5e28c24fc0f001d1c929430e04b3ea4b766e39eed4d1a7", kill_on_drop: false }` [INFO] [stdout] 49622832b33a96717b5e28c24fc0f001d1c929430e04b3ea4b766e39eed4d1a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ec28d4804dad2646533a413dd75bcc264769a5d6c3e64b8e4f8eff09c4d6fc7 [INFO] running `Command { std: "docker" "start" "-a" "1ec28d4804dad2646533a413dd75bcc264769a5d6c3e64b8e4f8eff09c4d6fc7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling serde v1.0.192 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking hashbrown v0.14.2 [INFO] [stderr] Checking winnow v0.5.19 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking anyhow v1.0.75 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking gethostname v0.4.3 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.192 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking thiserror v1.0.50 [INFO] [stderr] Checking pwd v1.4.0 [INFO] [stderr] Checking expanduser v1.2.2 [INFO] [stderr] Checking clap v4.4.8 [INFO] [stderr] Checking serde_spanned v0.6.4 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_json v1.0.108 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking dull-dotfile-manager v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:1:29 [INFO] [stdout] | [INFO] [stdout] 1 | pub const BUILD_FILE_NAME: &'static str = ".dull-build"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:2:29 [INFO] [stdout] | [INFO] [stdout] 2 | pub const STATE_FILE_NAME: &'static str = ".dull-state"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | pub const LINKTHIS_FILENAME: &'static str = ".dull-linkthis"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:4:32 [INFO] [stdout] | [INFO] [stdout] 4 | pub const LINKTHESE_FILENAME: &'static str = ".dull-linkthese"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub const DEFAULT_IGNOREFILES: &'static [&'static str] = &[LINKTHIS_FILENAME, LINKTHESE_FILENAME]; [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | pub const DEFAULT_IGNOREFILES: &'static [&'static str] = &[LINKTHIS_FILENAME, LINKTHESE_FILENAME]; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tx_apply::*` [INFO] [stdout] --> src/transaction.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use tx_apply::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:1:29 [INFO] [stdout] | [INFO] [stdout] 1 | pub const BUILD_FILE_NAME: &'static str = ".dull-build"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:2:29 [INFO] [stdout] | [INFO] [stdout] 2 | pub const STATE_FILE_NAME: &'static str = ".dull-state"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | pub const LINKTHIS_FILENAME: &'static str = ".dull-linkthis"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:4:32 [INFO] [stdout] | [INFO] [stdout] 4 | pub const LINKTHESE_FILENAME: &'static str = ".dull-linkthese"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub const DEFAULT_IGNOREFILES: &'static [&'static str] = &[LINKTHIS_FILENAME, LINKTHESE_FILENAME]; [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/globals.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | pub const DEFAULT_IGNOREFILES: &'static [&'static str] = &[LINKTHIS_FILENAME, LINKTHESE_FILENAME]; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tx_apply::*` [INFO] [stdout] --> src/transaction.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use tx_apply::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `extend` instead of `append` for adding the full range of a second vector [INFO] [stdout] --> src/config_parser.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | self.modules.extend(parent_config.modules.drain(..)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.modules.append(&mut parent_config.modules)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extend_with_drain [INFO] [stdout] = note: `#[warn(clippy::extend_with_drain)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/config_parser.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match &result { [INFO] [stdout] 61 | | Err(err) => { [INFO] [stdout] 62 | | println!( [INFO] [stdout] 63 | | "Skipping including {:?} from {:?} due to error: {:?}", [INFO] [stdout] ... | [INFO] [stdout] 67 | | Ok(_) => {} [INFO] [stdout] 68 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ if let Err(err) = &result { [INFO] [stdout] 61 + println!( [INFO] [stdout] 62 + "Skipping including {:?} from {:?} due to error: {:?}", [INFO] [stdout] 63 + target_path, config_file_path, err [INFO] [stdout] 64 + ); [INFO] [stdout] 65 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/module_parser.rs:19:41 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn emplace(self, target_prefix: &PathBuf) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - pub fn emplace(self, target_prefix: &PathBuf) -> Vec { [INFO] [stdout] 19 + pub fn emplace(self, target_prefix: &Path) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/module_parser.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|source| { [INFO] [stdout] | ______________^ [INFO] [stdout] 23 | | source [INFO] [stdout] 24 | | .strip_prefix(&self.module_path) [INFO] [stdout] 25 | | .map(|stripped| stripped.to_owned()) [INFO] [stdout] 26 | | .map(|stripped| (source, stripped)) [INFO] [stdout] 27 | | }) [INFO] [stdout] 28 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 22 ~ .flat_map(|source| { [INFO] [stdout] 23 + source [INFO] [stdout] 24 + .strip_prefix(&self.module_path) [INFO] [stdout] 25 + .map(|stripped| stripped.to_owned()) [INFO] [stdout] 26 + .map(|stripped| (source, stripped)) [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/module_parser.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return Ok(TraversalStrategy::Recurse(dir_contents)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Ok(TraversalStrategy::Recurse(dir_contents)); [INFO] [stdout] 95 + Ok(TraversalStrategy::Recurse(dir_contents)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/module_parser.rs:146:22 [INFO] [stdout] | [INFO] [stdout] 146 | .map(|p| TraversalDirective::LinkThis(p)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TraversalDirective::LinkThis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/module_parser.rs:152:22 [INFO] [stdout] | [INFO] [stdout] 152 | .map(|p| TraversalDirective::LinkThese(p)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TraversalDirective::LinkThese` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/module_parser.rs:158:15 [INFO] [stdout] | [INFO] [stdout] 158 | while frontier.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!frontier.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/transaction/primitives.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | if let Ok(_) = std::fs::symlink_metadata(&target) { [INFO] [stdout] | -------^^^^^------------------------------------- help: try: `if std::fs::symlink_metadata(&target).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/transaction/tx_gen.rs:99:30 [INFO] [stdout] | [INFO] [stdout] 99 | .filter(|subdir| !subdir.symlink_metadata().is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `subdir.symlink_metadata().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference [INFO] [stdout] --> src/transaction/tx_result.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn as_tx_result(self) -> anyhow::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/transaction.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 35 | .context(format!("could not create the backup directory"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"could not create the backup directory".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/virtual_system.rs:55:42 [INFO] [stdout] | [INFO] [stdout] 55 | std::fs::write(&build_info_path, format!("{}", effective_build_name)).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `effective_build_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:97:30 [INFO] [stdout] | [INFO] [stdout] 97 | .context(format!( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 98 | | "no state was found, explicitly supply the target using --build" [INFO] [stdout] 99 | | ))? [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `"no state was found, explicitly supply the target using --build".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 138 | .flat_map(|path| VirtualSystem::read(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VirtualSystem::read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `extend` instead of `append` for adding the full range of a second vector [INFO] [stdout] --> src/config_parser.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | self.modules.extend(parent_config.modules.drain(..)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.modules.append(&mut parent_config.modules)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extend_with_drain [INFO] [stdout] = note: `#[warn(clippy::extend_with_drain)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/config_parser.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match &result { [INFO] [stdout] 61 | | Err(err) => { [INFO] [stdout] 62 | | println!( [INFO] [stdout] 63 | | "Skipping including {:?} from {:?} due to error: {:?}", [INFO] [stdout] ... | [INFO] [stdout] 67 | | Ok(_) => {} [INFO] [stdout] 68 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ if let Err(err) = &result { [INFO] [stdout] 61 + println!( [INFO] [stdout] 62 + "Skipping including {:?} from {:?} due to error: {:?}", [INFO] [stdout] 63 + target_path, config_file_path, err [INFO] [stdout] 64 + ); [INFO] [stdout] 65 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/module_parser.rs:19:41 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn emplace(self, target_prefix: &PathBuf) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - pub fn emplace(self, target_prefix: &PathBuf) -> Vec { [INFO] [stdout] 19 + pub fn emplace(self, target_prefix: &Path) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/module_parser.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|source| { [INFO] [stdout] | ______________^ [INFO] [stdout] 23 | | source [INFO] [stdout] 24 | | .strip_prefix(&self.module_path) [INFO] [stdout] 25 | | .map(|stripped| stripped.to_owned()) [INFO] [stdout] 26 | | .map(|stripped| (source, stripped)) [INFO] [stdout] 27 | | }) [INFO] [stdout] 28 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 22 ~ .flat_map(|source| { [INFO] [stdout] 23 + source [INFO] [stdout] 24 + .strip_prefix(&self.module_path) [INFO] [stdout] 25 + .map(|stripped| stripped.to_owned()) [INFO] [stdout] 26 + .map(|stripped| (source, stripped)) [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/module_parser.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return Ok(TraversalStrategy::Recurse(dir_contents)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Ok(TraversalStrategy::Recurse(dir_contents)); [INFO] [stdout] 95 + Ok(TraversalStrategy::Recurse(dir_contents)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/module_parser.rs:146:22 [INFO] [stdout] | [INFO] [stdout] 146 | .map(|p| TraversalDirective::LinkThis(p)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TraversalDirective::LinkThis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/module_parser.rs:152:22 [INFO] [stdout] | [INFO] [stdout] 152 | .map(|p| TraversalDirective::LinkThese(p)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TraversalDirective::LinkThese` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/module_parser.rs:158:15 [INFO] [stdout] | [INFO] [stdout] 158 | while frontier.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!frontier.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/transaction/primitives.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | if let Ok(_) = std::fs::symlink_metadata(&target) { [INFO] [stdout] | -------^^^^^------------------------------------- help: try: `if std::fs::symlink_metadata(&target).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/transaction/tx_gen.rs:99:30 [INFO] [stdout] | [INFO] [stdout] 99 | .filter(|subdir| !subdir.symlink_metadata().is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `subdir.symlink_metadata().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference [INFO] [stdout] --> src/transaction/tx_result.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn as_tx_result(self) -> anyhow::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/transaction.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 35 | .context(format!("could not create the backup directory"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"could not create the backup directory".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/virtual_system.rs:55:42 [INFO] [stdout] | [INFO] [stdout] 55 | std::fs::write(&build_info_path, format!("{}", effective_build_name)).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `effective_build_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:97:30 [INFO] [stdout] | [INFO] [stdout] 97 | .context(format!( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 98 | | "no state was found, explicitly supply the target using --build" [INFO] [stdout] 99 | | ))? [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `"no state was found, explicitly supply the target using --build".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 138 | .flat_map(|path| VirtualSystem::read(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VirtualSystem::read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.49s [INFO] running `Command { std: "docker" "inspect" "1ec28d4804dad2646533a413dd75bcc264769a5d6c3e64b8e4f8eff09c4d6fc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ec28d4804dad2646533a413dd75bcc264769a5d6c3e64b8e4f8eff09c4d6fc7", kill_on_drop: false }` [INFO] [stdout] 1ec28d4804dad2646533a413dd75bcc264769a5d6c3e64b8e4f8eff09c4d6fc7