[INFO] cloning repository https://github.com/usernamenotused/fast_encode_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/usernamenotused/fast_encode_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fusernamenotused%2Ffast_encode_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fusernamenotused%2Ffast_encode_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] be13d55a51335d3ac4fef6e3dede99899832e8d9 [INFO] linting usernamenotused/fast_encode_rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fusernamenotused%2Ffast_encode_rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/usernamenotused/fast_encode_rs [INFO] finished tweaking git repo https://github.com/usernamenotused/fast_encode_rs [INFO] tweaked toml for git repo https://github.com/usernamenotused/fast_encode_rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/usernamenotused/fast_encode_rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/usernamenotused/fast_encode_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded is-terminal v0.4.16 [INFO] [stderr] Downloaded winapi-util v0.1.10 [INFO] [stderr] Downloaded md5 v0.7.0 [INFO] [stderr] Downloaded gzip-header v1.0.0 [INFO] [stderr] Downloaded toml_write v0.1.2 [INFO] [stderr] Downloaded anstyle-query v1.1.4 [INFO] [stderr] Downloaded cargo-platform v0.1.9 [INFO] [stderr] Downloaded cargo_metadata v0.18.1 [INFO] [stderr] Downloaded nu-ansi-term v0.50.1 [INFO] [stderr] Downloaded tempfile v3.21.0 [INFO] [stderr] Downloaded camino v1.1.12 [INFO] [stderr] Downloaded procfs-core v0.16.0 [INFO] [stderr] Downloaded cc v1.2.35 [INFO] [stderr] Downloaded indexmap v2.11.0 [INFO] [stderr] Downloaded serde_json v1.0.143 [INFO] [stderr] Downloaded anyhow v1.0.99 [INFO] [stderr] Downloaded h2 v0.3.27 [INFO] [stderr] Downloaded quick-xml v0.31.0 [INFO] [stderr] Downloaded git2 v0.18.3 [INFO] [stderr] Downloaded cargo-tarpaulin v0.27.3 [INFO] [stderr] Downloaded clap_builder v4.5.47 [INFO] [stderr] Downloaded object v0.26.2 [INFO] [stderr] Downloaded object v0.32.2 [INFO] [stderr] Downloaded nix v0.27.1 [INFO] [stderr] Downloaded chrono v0.4.41 [INFO] [stderr] Downloaded wasi v0.14.3+wasi-0.2.4 [INFO] [stderr] Downloaded regex-syntax v0.8.6 [INFO] [stderr] Downloaded regex v1.11.2 [INFO] [stderr] Downloaded ruzstd v0.5.0 [INFO] [stderr] Downloaded rustix v1.0.8 [INFO] [stderr] Downloaded procfs v0.16.0 [INFO] [stderr] Downloaded find-msvc-tools v0.1.0 [INFO] [stderr] Downloaded wit-bindgen v0.45.0 [INFO] [stderr] Downloaded clap v4.5.47 [INFO] [stderr] Downloaded criterion v0.5.1 [INFO] [stderr] Downloaded humantime v2.2.0 [INFO] [stderr] Downloaded llvm_profparser v0.3.3 [INFO] [stderr] Downloaded regex-automata v0.4.10 [INFO] [stderr] Downloaded iana-time-zone v0.1.63 [INFO] [stderr] Downloaded clap_derive v4.5.47 [INFO] [stderr] Downloaded convert_case v0.6.0 [INFO] [stderr] Downloaded twox-hash v1.6.3 [INFO] [stderr] Downloaded anstream v0.6.20 [INFO] [stderr] Downloaded libz-sys v1.1.22 [INFO] [stderr] Downloaded coveralls-api v0.6.0 [INFO] [stderr] Downloaded enum-display-macro v0.1.4 [INFO] [stderr] Downloaded enum-display v0.1.4 [INFO] [stderr] Downloaded humantime-serde v1.1.1 [INFO] [stderr] Downloaded anstyle-wincon v3.0.10 [INFO] [stderr] Downloaded libgit2-sys v0.16.2+1.7.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1cfabb034e78cf65d90b3c9beaf8f2070f1a80f94207c0d9d49625562a38ca7 [INFO] running `Command { std: "docker" "start" "-a" "e1cfabb034e78cf65d90b3c9beaf8f2070f1a80f94207c0d9d49625562a38ca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1cfabb034e78cf65d90b3c9beaf8f2070f1a80f94207c0d9d49625562a38ca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1cfabb034e78cf65d90b3c9beaf8f2070f1a80f94207c0d9d49625562a38ca7", kill_on_drop: false }` [INFO] [stdout] e1cfabb034e78cf65d90b3c9beaf8f2070f1a80f94207c0d9d49625562a38ca7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a30f0faa8404454f374ad3f58babc84f0ffe5e4d68a774597985a5078ca504b [INFO] running `Command { std: "docker" "start" "-a" "7a30f0faa8404454f374ad3f58babc84f0ffe5e4d68a774597985a5078ca504b", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling find-msvc-tools v0.1.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Compiling anyhow v1.0.99 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking clap_builder v4.5.47 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Compiling cc v1.2.35 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking indexmap v2.11.0 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling camino v1.1.12 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking gzip-header v1.0.0 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling procfs v0.16.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling llvm_profparser v0.3.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Compiling cargo-tarpaulin v0.27.3 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Checking procfs-core v0.16.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking object v0.26.2 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling enum-display-macro v0.1.4 [INFO] [stderr] Checking enum-display v0.1.4 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking clap v4.5.47 [INFO] [stderr] Checking ruzstd v0.5.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking cargo-platform v0.1.9 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking fast-encode v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/detection.rs:190:30 [INFO] [stdout] | [INFO] [stdout] 190 | if data.len() < 2 || data.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `!data.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/detection.rs:206:34 [INFO] [stdout] | [INFO] [stdout] 206 | if le_char < 0x80 || (le_char >= 0x20 && le_char < 0x7F) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x20..0x7F).contains(&le_char)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/detection.rs:210:34 [INFO] [stdout] | [INFO] [stdout] 210 | if be_char < 0x80 || (be_char >= 0x20 && be_char < 0x7F) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x20..0x7F).contains(&be_char)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/detection.rs:355:17 [INFO] [stdout] | [INFO] [stdout] 355 | / if result.encoding.is_ascii_compatible() { [INFO] [stdout] 356 | | result.confidence = (result.confidence * 1.2).min(1.0); [INFO] [stdout] 357 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 353 ~ "english" | "en" [INFO] [stdout] 354 | // Boost confidence for ASCII-compatible encodings [INFO] [stdout] 355 ~ if result.encoding.is_ascii_compatible() => { [INFO] [stdout] 356 | result.confidence = (result.confidence * 1.2).min(1.0); [INFO] [stdout] 357 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> src/multibyte.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_utf8(&self, input: &[u8]) -> Result> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/multibyte.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 95 | if input.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `!input.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tables.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / return match encoding { [INFO] [stdout] 11 | | // Unicode and ASCII [INFO] [stdout] 12 | | Encoding::UTF8 | Encoding::ASCII => &ASCII_CHARS, [INFO] [stdout] ... | [INFO] [stdout] 39 | | _ => &ASCII_CHARS, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 ~ match encoding { [INFO] [stdout] 11 + // Unicode and ASCII [INFO] [stdout] 12 + Encoding::UTF8 | Encoding::ASCII => &ASCII_CHARS, [INFO] [stdout] 13 + [INFO] [stdout] 14 + // ISO-8859 series [INFO] [stdout] 15 + Encoding::ISO_8859_1 => &ISO_8859_1_CHARS, [INFO] [stdout] 16 + Encoding::ISO_8859_15 => &ISO_8859_15_CHARS, // Latin-9 with Euro [INFO] [stdout] 17 + [INFO] [stdout] 18 + // Windows code pages [INFO] [stdout] 19 + Encoding::WINDOWS_1252 => &WINDOWS_1252_CHARS, [INFO] [stdout] 20 + Encoding::WINDOWS_1250 => &WINDOWS_1250_CHARS, [INFO] [stdout] 21 + [INFO] [stdout] 22 + // DOS code pages [INFO] [stdout] 23 + Encoding::CP_437 => &CP_437_CHARS, [INFO] [stdout] 24 + Encoding::CP_850 => &CP_850_CHARS, [INFO] [stdout] 25 + [INFO] [stdout] 26 + // EBCDIC variants [INFO] [stdout] 27 + Encoding::EBCDIC_037 => &EBCDIC_037_CHARS, [INFO] [stdout] 28 + Encoding::EBCDIC_500 => &EBCDIC_500_CHARS, [INFO] [stdout] 29 + Encoding::EBCDIC_1047 => &EBCDIC_1047_CHARS, [INFO] [stdout] 30 + [INFO] [stdout] 31 + // Asian encodings (scaffolded, TODO: fill in real tables) [INFO] [stdout] 32 + Encoding::SHIFT_JIS => &SHIFT_JIS_CHARS, [INFO] [stdout] 33 + Encoding::EUC_JP => &EUC_JP_CHARS, [INFO] [stdout] 34 + Encoding::GB2312 => &GB2312_CHARS, [INFO] [stdout] 35 + Encoding::BIG5 => &BIG5_CHARS, [INFO] [stdout] 36 + Encoding::EUC_KR => &EUC_KR_CHARS, [INFO] [stdout] 37 + [INFO] [stdout] 38 + // For unsupported encodings, fall back to ASCII for now [INFO] [stdout] 39 + _ => &ASCII_CHARS, [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:398:13 [INFO] [stdout] | [INFO] [stdout] 398 | / if let Some(ch) = ch_opt { [INFO] [stdout] 399 | | if (ch as u32) < 65536 { [INFO] [stdout] 400 | | to_lookup[ch as usize] = byte as u8; [INFO] [stdout] 401 | | } [INFO] [stdout] 402 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 398 ~ if let Some(ch) = ch_opt [INFO] [stdout] 399 ~ && (ch as u32) < 65536 { [INFO] [stdout] 400 | to_lookup[ch as usize] = byte as u8; [INFO] [stdout] 401 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking coveralls-api v0.6.0 [INFO] [stdout] warning: struct `DetectionResult` is never constructed [INFO] [stdout] --> src/main.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 288 | struct DetectionResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:354:5 [INFO] [stdout] | [INFO] [stdout] 354 | / if args.strip_bom { [INFO] [stdout] 355 | | if let Some(bom) = from_encoding.bom() { [INFO] [stdout] 356 | | if processed_data.starts_with(bom) { [INFO] [stdout] 357 | | processed_data = processed_data[bom.len()..].to_vec(); [INFO] [stdout] ... | [INFO] [stdout] 363 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 354 ~ if args.strip_bom [INFO] [stdout] 355 ~ && let Some(bom) = from_encoding.bom() { [INFO] [stdout] 356 | if processed_data.starts_with(bom) { [INFO] [stdout] ... [INFO] [stdout] 361 | } [INFO] [stdout] 362 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 355 | / if let Some(bom) = from_encoding.bom() { [INFO] [stdout] 356 | | if processed_data.starts_with(bom) { [INFO] [stdout] 357 | | processed_data = processed_data[bom.len()..].to_vec(); [INFO] [stdout] 358 | | if cli.verbose { [INFO] [stdout] ... | [INFO] [stdout] 362 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 355 ~ if let Some(bom) = from_encoding.bom() [INFO] [stdout] 356 ~ && processed_data.starts_with(bom) { [INFO] [stdout] 357 | processed_data = processed_data[bom.len()..].to_vec(); [INFO] [stdout] ... [INFO] [stdout] 360 | } [INFO] [stdout] 361 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:551:13 [INFO] [stdout] | [INFO] [stdout] 551 | / if let Some(ref filter_cat) = args.category { [INFO] [stdout] 552 | | if *category != filter_cat.as_str() { [INFO] [stdout] 553 | | return false; [INFO] [stdout] 554 | | } [INFO] [stdout] 555 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 551 ~ if let Some(ref filter_cat) = args.category [INFO] [stdout] 552 ~ && *category != filter_cat.as_str() { [INFO] [stdout] 553 | return false; [INFO] [stdout] 554 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/detection.rs:190:30 [INFO] [stdout] | [INFO] [stdout] 190 | if data.len() < 2 || data.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `!data.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/detection.rs:206:34 [INFO] [stdout] | [INFO] [stdout] 206 | if le_char < 0x80 || (le_char >= 0x20 && le_char < 0x7F) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x20..0x7F).contains(&le_char)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/detection.rs:210:34 [INFO] [stdout] | [INFO] [stdout] 210 | if be_char < 0x80 || (be_char >= 0x20 && be_char < 0x7F) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x20..0x7F).contains(&be_char)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/detection.rs:355:17 [INFO] [stdout] | [INFO] [stdout] 355 | / if result.encoding.is_ascii_compatible() { [INFO] [stdout] 356 | | result.confidence = (result.confidence * 1.2).min(1.0); [INFO] [stdout] 357 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 353 ~ "english" | "en" [INFO] [stdout] 354 | // Boost confidence for ASCII-compatible encodings [INFO] [stdout] 355 ~ if result.encoding.is_ascii_compatible() => { [INFO] [stdout] 356 | result.confidence = (result.confidence * 1.2).min(1.0); [INFO] [stdout] 357 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> src/multibyte.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_utf8(&self, input: &[u8]) -> Result> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/multibyte.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 95 | if input.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `!input.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tables.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / return match encoding { [INFO] [stdout] 11 | | // Unicode and ASCII [INFO] [stdout] 12 | | Encoding::UTF8 | Encoding::ASCII => &ASCII_CHARS, [INFO] [stdout] ... | [INFO] [stdout] 39 | | _ => &ASCII_CHARS, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 ~ match encoding { [INFO] [stdout] 11 + // Unicode and ASCII [INFO] [stdout] 12 + Encoding::UTF8 | Encoding::ASCII => &ASCII_CHARS, [INFO] [stdout] 13 + [INFO] [stdout] 14 + // ISO-8859 series [INFO] [stdout] 15 + Encoding::ISO_8859_1 => &ISO_8859_1_CHARS, [INFO] [stdout] 16 + Encoding::ISO_8859_15 => &ISO_8859_15_CHARS, // Latin-9 with Euro [INFO] [stdout] 17 + [INFO] [stdout] 18 + // Windows code pages [INFO] [stdout] 19 + Encoding::WINDOWS_1252 => &WINDOWS_1252_CHARS, [INFO] [stdout] 20 + Encoding::WINDOWS_1250 => &WINDOWS_1250_CHARS, [INFO] [stdout] 21 + [INFO] [stdout] 22 + // DOS code pages [INFO] [stdout] 23 + Encoding::CP_437 => &CP_437_CHARS, [INFO] [stdout] 24 + Encoding::CP_850 => &CP_850_CHARS, [INFO] [stdout] 25 + [INFO] [stdout] 26 + // EBCDIC variants [INFO] [stdout] 27 + Encoding::EBCDIC_037 => &EBCDIC_037_CHARS, [INFO] [stdout] 28 + Encoding::EBCDIC_500 => &EBCDIC_500_CHARS, [INFO] [stdout] 29 + Encoding::EBCDIC_1047 => &EBCDIC_1047_CHARS, [INFO] [stdout] 30 + [INFO] [stdout] 31 + // Asian encodings (scaffolded, TODO: fill in real tables) [INFO] [stdout] 32 + Encoding::SHIFT_JIS => &SHIFT_JIS_CHARS, [INFO] [stdout] 33 + Encoding::EUC_JP => &EUC_JP_CHARS, [INFO] [stdout] 34 + Encoding::GB2312 => &GB2312_CHARS, [INFO] [stdout] 35 + Encoding::BIG5 => &BIG5_CHARS, [INFO] [stdout] 36 + Encoding::EUC_KR => &EUC_KR_CHARS, [INFO] [stdout] 37 + [INFO] [stdout] 38 + // For unsupported encodings, fall back to ASCII for now [INFO] [stdout] 39 + _ => &ASCII_CHARS, [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DetectionResult` is never constructed [INFO] [stdout] --> src/main.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 288 | struct DetectionResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:398:13 [INFO] [stdout] | [INFO] [stdout] 398 | / if let Some(ch) = ch_opt { [INFO] [stdout] 399 | | if (ch as u32) < 65536 { [INFO] [stdout] 400 | | to_lookup[ch as usize] = byte as u8; [INFO] [stdout] 401 | | } [INFO] [stdout] 402 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 398 ~ if let Some(ch) = ch_opt [INFO] [stdout] 399 ~ && (ch as u32) < 65536 { [INFO] [stdout] 400 | to_lookup[ch as usize] = byte as u8; [INFO] [stdout] 401 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:354:5 [INFO] [stdout] | [INFO] [stdout] 354 | / if args.strip_bom { [INFO] [stdout] 355 | | if let Some(bom) = from_encoding.bom() { [INFO] [stdout] 356 | | if processed_data.starts_with(bom) { [INFO] [stdout] 357 | | processed_data = processed_data[bom.len()..].to_vec(); [INFO] [stdout] ... | [INFO] [stdout] 363 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 354 ~ if args.strip_bom [INFO] [stdout] 355 ~ && let Some(bom) = from_encoding.bom() { [INFO] [stdout] 356 | if processed_data.starts_with(bom) { [INFO] [stdout] ... [INFO] [stdout] 361 | } [INFO] [stdout] 362 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 355 | / if let Some(bom) = from_encoding.bom() { [INFO] [stdout] 356 | | if processed_data.starts_with(bom) { [INFO] [stdout] 357 | | processed_data = processed_data[bom.len()..].to_vec(); [INFO] [stdout] 358 | | if cli.verbose { [INFO] [stdout] ... | [INFO] [stdout] 362 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 355 ~ if let Some(bom) = from_encoding.bom() [INFO] [stdout] 356 ~ && processed_data.starts_with(bom) { [INFO] [stdout] 357 | processed_data = processed_data[bom.len()..].to_vec(); [INFO] [stdout] ... [INFO] [stdout] 360 | } [INFO] [stdout] 361 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:551:13 [INFO] [stdout] | [INFO] [stdout] 551 | / if let Some(ref filter_cat) = args.category { [INFO] [stdout] 552 | | if *category != filter_cat.as_str() { [INFO] [stdout] 553 | | return false; [INFO] [stdout] 554 | | } [INFO] [stdout] 555 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 551 ~ if let Some(ref filter_cat) = args.category [INFO] [stdout] 552 ~ && *category != filter_cat.as_str() { [INFO] [stdout] 553 | return false; [INFO] [stdout] 554 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `Command { std: "docker" "inspect" "7a30f0faa8404454f374ad3f58babc84f0ffe5e4d68a774597985a5078ca504b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a30f0faa8404454f374ad3f58babc84f0ffe5e4d68a774597985a5078ca504b", kill_on_drop: false }` [INFO] [stdout] 7a30f0faa8404454f374ad3f58babc84f0ffe5e4d68a774597985a5078ca504b