[INFO] cloning repository https://github.com/ur-fault/tatra [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ur-fault/tatra" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fur-fault%2Ftatra", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fur-fault%2Ftatra'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 72bacf1a5ee7b34367606af63dcdeb61e046c729 [INFO] linting ur-fault/tatra against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fur-fault%2Ftatra" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ur-fault/tatra [INFO] finished tweaking git repo https://github.com/ur-fault/tatra [INFO] tweaked toml for git repo https://github.com/ur-fault/tatra written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ur-fault/tatra on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ur-fault/tatra already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c82786c7d569671467590f83ed8d770b3fcde52a6587ea587fdbab914f8f37c0 [INFO] running `Command { std: "docker" "start" "-a" "c82786c7d569671467590f83ed8d770b3fcde52a6587ea587fdbab914f8f37c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c82786c7d569671467590f83ed8d770b3fcde52a6587ea587fdbab914f8f37c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c82786c7d569671467590f83ed8d770b3fcde52a6587ea587fdbab914f8f37c0", kill_on_drop: false }` [INFO] [stdout] c82786c7d569671467590f83ed8d770b3fcde52a6587ea587fdbab914f8f37c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 46c22ca53a9950b2ea05eca440517494b2f87aaf8a352c97467fc817916cb542 [INFO] running `Command { std: "docker" "start" "-a" "46c22ca53a9950b2ea05eca440517494b2f87aaf8a352c97467fc817916cb542", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking tatra v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/main.rs:147:44 [INFO] [stdout] | [INFO] [stdout] 147 | let start = if parsing.attr && parsing.start + 1 <= index { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `parsing.start < index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/main.rs:147:44 [INFO] [stdout] | [INFO] [stdout] 147 | let start = if parsing.attr && parsing.start + 1 <= index { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `parsing.start < index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:63:58 [INFO] [stdout] | [INFO] [stdout] 63 | if let Some(color) = parse_color(&attr[2..]) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | } else if attr.starts_with("on") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 62 ~ } else if let Some() = attr.strip_prefix("on") { [INFO] [stdout] 63 ~ if let Some(color) = parse_color() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | in_escape = true && parsing.attr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `parsing.attr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/main.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | while let Some((index, ch)) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (index, ch) in chars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:63:58 [INFO] [stdout] | [INFO] [stdout] 63 | if let Some(color) = parse_color(&attr[2..]) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | } else if attr.starts_with("on") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 62 ~ } else if let Some() = attr.strip_prefix("on") { [INFO] [stdout] 63 ~ if let Some(color) = parse_color() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | in_escape = true && parsing.attr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `parsing.attr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/main.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | while let Some((index, ch)) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (index, ch) in chars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.80s [INFO] running `Command { std: "docker" "inspect" "46c22ca53a9950b2ea05eca440517494b2f87aaf8a352c97467fc817916cb542", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46c22ca53a9950b2ea05eca440517494b2f87aaf8a352c97467fc817916cb542", kill_on_drop: false }` [INFO] [stdout] 46c22ca53a9950b2ea05eca440517494b2f87aaf8a352c97467fc817916cb542