[INFO] cloning repository https://github.com/unixpickle/brute-tree [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/unixpickle/brute-tree" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Funixpickle%2Fbrute-tree", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Funixpickle%2Fbrute-tree'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 98e6bb344decde3ccf141ef6b907a0c32ba485f9 [INFO] linting unixpickle/brute-tree against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Funixpickle%2Fbrute-tree" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/unixpickle/brute-tree [INFO] finished tweaking git repo https://github.com/unixpickle/brute-tree [INFO] tweaked toml for git repo https://github.com/unixpickle/brute-tree written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/unixpickle/brute-tree on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/unixpickle/brute-tree already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded slab v0.4.0 [INFO] [stderr] Downloaded iovec v0.1.2 [INFO] [stderr] Downloaded cfg-if v0.1.2 [INFO] [stderr] Downloaded log v0.4.1 [INFO] [stderr] Downloaded tokio-io v0.1.5 [INFO] [stderr] Downloaded byteorder v1.2.1 [INFO] [stderr] Downloaded redox_termios v0.1.1 [INFO] [stderr] Downloaded atty v0.2.6 [INFO] [stderr] Downloaded textwrap v0.9.0 [INFO] [stderr] Downloaded relay v0.1.1 [INFO] [stderr] Downloaded httparse v1.2.4 [INFO] [stderr] Downloaded strsim v0.7.0 [INFO] [stderr] Downloaded lazycell v0.6.0 [INFO] [stderr] Downloaded serde_derive v1.0.27 [INFO] [stderr] Downloaded mime v0.3.5 [INFO] [stderr] Downloaded termion v1.5.1 [INFO] [stderr] Downloaded tokio-proto v0.1.1 [INFO] [stderr] Downloaded unicase v2.1.0 [INFO] [stderr] Downloaded serde v1.0.27 [INFO] [stderr] Downloaded serde_json v1.0.10 [INFO] [stderr] Downloaded mio v0.6.13 [INFO] [stderr] Downloaded hyper v0.11.21 [INFO] [stderr] Downloaded clap v2.31.1 [INFO] [stderr] Downloaded futures v0.1.18 [INFO] [stderr] Downloaded base64 v0.9.0 [INFO] [stderr] Downloaded num-traits v0.2.1 [INFO] [stderr] Downloaded bytes v0.4.6 [INFO] [stderr] Downloaded time v0.1.39 [INFO] [stderr] Downloaded serde_derive_internals v0.19.0 [INFO] [stderr] Downloaded net2 v0.2.32 [INFO] [stderr] Downloaded tokio-core v0.1.12 [INFO] [stderr] Downloaded slab v0.3.0 [INFO] [stderr] Downloaded unicode-width v0.1.4 [INFO] [stderr] Downloaded num_cpus v1.8.0 [INFO] [stderr] Downloaded rand v0.3.22 [INFO] [stderr] Downloaded dtoa v0.4.2 [INFO] [stderr] Downloaded smallvec v0.2.1 [INFO] [stderr] Downloaded redox_syscall v0.1.37 [INFO] [stderr] Downloaded take v0.1.0 [INFO] [stderr] Downloaded tokio-service v0.1.0 [INFO] [stderr] Downloaded scoped-tls v0.1.1 [INFO] [stderr] Downloaded vec_map v0.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc0a1ccae0f3f7ec727c62b66426f3c22fc6e46aaa0985b96afc710688ece214 [INFO] running `Command { std: "docker" "start" "-a" "dc0a1ccae0f3f7ec727c62b66426f3c22fc6e46aaa0985b96afc710688ece214", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc0a1ccae0f3f7ec727c62b66426f3c22fc6e46aaa0985b96afc710688ece214", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc0a1ccae0f3f7ec727c62b66426f3c22fc6e46aaa0985b96afc710688ece214", kill_on_drop: false }` [INFO] [stdout] dc0a1ccae0f3f7ec727c62b66426f3c22fc6e46aaa0985b96afc710688ece214 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eae9195afb7c647266b47252b19ae16e499da3eec8efcd8e1b28f481b72c253c [INFO] running `Command { std: "docker" "start" "-a" "eae9195afb7c647266b47252b19ae16e499da3eec8efcd8e1b28f481b72c253c", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking futures v0.1.18 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Compiling version_check v0.1.3 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Checking lazycell v0.6.0 [INFO] [stderr] Checking scoped-tls v0.1.1 [INFO] [stderr] Checking slab v0.4.0 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking safemem v0.2.0 [INFO] [stderr] Checking take v0.1.0 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking smallvec v0.2.1 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking serde v1.0.27 [INFO] [stderr] Checking num-traits v0.2.1 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking httparse v1.2.4 [INFO] [stderr] Compiling unicase v2.1.0 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking base64 v0.9.0 [INFO] [stderr] Checking mio v0.6.13 [INFO] [stderr] Checking clap v2.31.1 [INFO] [stderr] Checking mime v0.3.5 [INFO] [stderr] Checking tokio-io v0.1.5 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Compiling serde_derive_internals v0.19.0 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Compiling serde_derive v1.0.27 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.21 [INFO] [stderr] Checking serde_json v1.0.10 [INFO] [stderr] Checking brute-tree v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tree.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | Tree{feature: feature, threshold: threshold, branch: None} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `feature` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tree.rs:30:36 [INFO] [stdout] | [INFO] [stdout] 30 | Tree{feature: feature, threshold: threshold, branch: None} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tree.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | feature: feature, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `feature` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tree.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 34 | threshold: threshold, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/evaluate.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | let mut counts = &mut class_counts[path]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tree.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | Tree{feature: feature, threshold: threshold, branch: None} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `feature` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tree.rs:30:36 [INFO] [stdout] | [INFO] [stdout] 30 | Tree{feature: feature, threshold: threshold, branch: None} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tree.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | feature: feature, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `feature` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tree.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 34 | threshold: threshold, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/tree.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | if let &Some(ref branch) = &self.branch { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 48 - if let &Some(ref branch) = &self.branch { [INFO] [stdout] 48 + if let Some(branch) = &self.branch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/tree.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | if let &Some(ref branch) = &self.branch { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 71 - if let &Some(ref branch) = &self.branch { [INFO] [stdout] 71 + if let Some(branch) = &self.branch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/evaluate.rs:21:29 [INFO] [stdout] | [INFO] [stdout] 21 | let max_label = *labels.into_iter().max().unwrap_or(&0usize); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/evaluate.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | counts.push(0usize); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0usize;SIZE]` [INFO] [stdout] = help: or `counts.extend(std::iter::repeat_n(0usize, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dataset/mod.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | ^^ ^^ ^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 12 - fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] 12 + fn train_data(&self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dataset/mod.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | ^^ ^^ ^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 13 - fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] 13 + fn test_data(&self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/dataset/mnist.rs:56:21 [INFO] [stdout] | [INFO] [stdout] 56 | Err(io::Error::new(io::ErrorKind::Other, "invalid path")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 56 - Err(io::Error::new(io::ErrorKind::Other, "invalid path")) [INFO] [stdout] 56 + Err(io::Error::other("invalid path")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dataset/mnist.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 67 | fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | ^^ ^^ ^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 67 - fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] 67 + fn train_data(&self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dataset/mnist.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | ^^ ^^ ^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 71 - fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] 71 + fn test_data(&self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used a field initializer for a tuple struct [INFO] [stdout] --> src/dataset/mnist.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 117 | let mut image = Image{0: [0u8; IMAGE_SIZE]}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use tuple initialization: `Image([0u8; IMAGE_SIZE])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields [INFO] [stdout] = note: `#[warn(clippy::init_numbered_fields)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/dataset/mnist.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | / for j in 0..(IMAGE_SIZE) { [INFO] [stdout] 119 | | image.0[j] = raw_result[offset + j]; [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `image.0[..(IMAGE_SIZE)].copy_from_slice(&raw_result[offset..((IMAGE_SIZE) + offset)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/search.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 26 | self.recursive_search(&t, &Vec::from_iter(samples.iter().map(|x| x)), labels, [INFO] [stdout] | ^^ help: change this to: `t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/search.rs:26:65 [INFO] [stdout] | [INFO] [stdout] 26 | self.recursive_search(&t, &Vec::from_iter(samples.iter().map(|x| x)), labels, [INFO] [stdout] | ^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/search.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if !t.branch.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `t.branch.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/search.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | branch: match &t.branch { [INFO] [stdout] | _____________________^ [INFO] [stdout] 106 | | &Some(ref branch) => { [INFO] [stdout] 107 | | Some(Box::new(Branch{ [INFO] [stdout] 108 | | left: self.mutate(&branch.left, false), [INFO] [stdout] ... | [INFO] [stdout] 112 | | &None => None [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 ~ branch: t.branch.as_ref().map(|branch| Box::new(Branch{ [INFO] [stdout] 106 + left: self.mutate(&branch.left, false), [INFO] [stdout] 107 + right: self.mutate(&branch.right, false) [INFO] [stdout] 108 + })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/search.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | branch: match &t.branch { [INFO] [stdout] | _____________________^ [INFO] [stdout] 106 | | &Some(ref branch) => { [INFO] [stdout] 107 | | Some(Box::new(Branch{ [INFO] [stdout] 108 | | left: self.mutate(&branch.left, false), [INFO] [stdout] ... | [INFO] [stdout] 112 | | &None => None [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 ~ branch: match t.branch { [INFO] [stdout] 106 ~ Some(ref branch) => { [INFO] [stdout] 107 | Some(Box::new(Branch{ [INFO] [stdout] ... [INFO] [stdout] 111 | }, [INFO] [stdout] 112 ~ None => None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/search.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | &Some(ref branch) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 106 - &Some(ref branch) => { [INFO] [stdout] 106 + Some(branch) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tree.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Tree` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Tree` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tree.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Tree` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Tree` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tree.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Branch` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Branch` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tree.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Branch` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Branch` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/evaluate.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Clone, Debug)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `TreeEvaluation` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_TreeEvaluation` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/evaluate.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Clone, Debug)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `TreeEvaluation` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_TreeEvaluation` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/dataset/mod.rs:12:37 [INFO] [stdout] | [INFO] [stdout] 12 | fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ ^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 12 | fn train_data<'a>(&'a self) -> (&'a [Self::Sample], &'a [usize]); [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/dataset/mod.rs:13:36 [INFO] [stdout] | [INFO] [stdout] 13 | fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ ^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 13 | fn test_data<'a>(&'a self) -> (&'a [Self::Sample], &'a [usize]); [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/dataset/mnist.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 67 | fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ ^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 67 | fn train_data<'a>(&'a self) -> (&'a [Self::Sample], &'a [usize]) { [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/dataset/mnist.rs:71:36 [INFO] [stdout] | [INFO] [stdout] 71 | fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ ^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 71 | fn test_data<'a>(&'a self) -> (&'a [Self::Sample], &'a [usize]) { [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/evaluate.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | let mut counts = &mut class_counts[path]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/tree.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | if let &Some(ref branch) = &self.branch { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 48 - if let &Some(ref branch) = &self.branch { [INFO] [stdout] 48 + if let Some(branch) = &self.branch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/tree.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | if let &Some(ref branch) = &self.branch { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 71 - if let &Some(ref branch) = &self.branch { [INFO] [stdout] 71 + if let Some(branch) = &self.branch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/evaluate.rs:21:29 [INFO] [stdout] | [INFO] [stdout] 21 | let max_label = *labels.into_iter().max().unwrap_or(&0usize); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/evaluate.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | counts.push(0usize); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0usize;SIZE]` [INFO] [stdout] = help: or `counts.extend(std::iter::repeat_n(0usize, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dataset/mod.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | ^^ ^^ ^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 12 - fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] 12 + fn train_data(&self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dataset/mod.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | ^^ ^^ ^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 13 - fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] 13 + fn test_data(&self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/dataset/mnist.rs:56:21 [INFO] [stdout] | [INFO] [stdout] 56 | Err(io::Error::new(io::ErrorKind::Other, "invalid path")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 56 - Err(io::Error::new(io::ErrorKind::Other, "invalid path")) [INFO] [stdout] 56 + Err(io::Error::other("invalid path")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dataset/mnist.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 67 | fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | ^^ ^^ ^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 67 - fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] 67 + fn train_data(&self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/dataset/mnist.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | ^^ ^^ ^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 71 - fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] 71 + fn test_data(&self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used a field initializer for a tuple struct [INFO] [stdout] --> src/dataset/mnist.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 117 | let mut image = Image{0: [0u8; IMAGE_SIZE]}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use tuple initialization: `Image([0u8; IMAGE_SIZE])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields [INFO] [stdout] = note: `#[warn(clippy::init_numbered_fields)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/dataset/mnist.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | / for j in 0..(IMAGE_SIZE) { [INFO] [stdout] 119 | | image.0[j] = raw_result[offset + j]; [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____________^ help: try replacing the loop by: `image.0[..(IMAGE_SIZE)].copy_from_slice(&raw_result[offset..((IMAGE_SIZE) + offset)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/search.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 26 | self.recursive_search(&t, &Vec::from_iter(samples.iter().map(|x| x)), labels, [INFO] [stdout] | ^^ help: change this to: `t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/search.rs:26:65 [INFO] [stdout] | [INFO] [stdout] 26 | self.recursive_search(&t, &Vec::from_iter(samples.iter().map(|x| x)), labels, [INFO] [stdout] | ^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/search.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if !t.branch.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `t.branch.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/search.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | branch: match &t.branch { [INFO] [stdout] | _____________________^ [INFO] [stdout] 106 | | &Some(ref branch) => { [INFO] [stdout] 107 | | Some(Box::new(Branch{ [INFO] [stdout] 108 | | left: self.mutate(&branch.left, false), [INFO] [stdout] ... | [INFO] [stdout] 112 | | &None => None [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 ~ branch: t.branch.as_ref().map(|branch| Box::new(Branch{ [INFO] [stdout] 106 + left: self.mutate(&branch.left, false), [INFO] [stdout] 107 + right: self.mutate(&branch.right, false) [INFO] [stdout] 108 + })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/search.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | branch: match &t.branch { [INFO] [stdout] | _____________________^ [INFO] [stdout] 106 | | &Some(ref branch) => { [INFO] [stdout] 107 | | Some(Box::new(Branch{ [INFO] [stdout] 108 | | left: self.mutate(&branch.left, false), [INFO] [stdout] ... | [INFO] [stdout] 112 | | &None => None [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 ~ branch: match t.branch { [INFO] [stdout] 106 ~ Some(ref branch) => { [INFO] [stdout] 107 | Some(Box::new(Branch{ [INFO] [stdout] ... [INFO] [stdout] 111 | }, [INFO] [stdout] 112 ~ None => None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/search.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | &Some(ref branch) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 106 - &Some(ref branch) => { [INFO] [stdout] 106 + Some(branch) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tree.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Tree` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Tree` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tree.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Tree` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Tree` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tree.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Branch` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Branch` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tree.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Debug)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Branch` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Branch` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/evaluate.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Clone, Debug)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `TreeEvaluation` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_TreeEvaluation` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/evaluate.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Clone, Debug)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `TreeEvaluation` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_TreeEvaluation` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/dataset/mod.rs:12:37 [INFO] [stdout] | [INFO] [stdout] 12 | fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ ^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 12 | fn train_data<'a>(&'a self) -> (&'a [Self::Sample], &'a [usize]); [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/dataset/mod.rs:13:36 [INFO] [stdout] | [INFO] [stdout] 13 | fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]); [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ ^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 13 | fn test_data<'a>(&'a self) -> (&'a [Self::Sample], &'a [usize]); [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/dataset/mnist.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 67 | fn train_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ ^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 67 | fn train_data<'a>(&'a self) -> (&'a [Self::Sample], &'a [usize]) { [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/dataset/mnist.rs:71:36 [INFO] [stdout] | [INFO] [stdout] 71 | fn test_data<'a>(&'a self) -> (&[Self::Sample], &[usize]) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^ ^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 71 | fn test_data<'a>(&'a self) -> (&'a [Self::Sample], &'a [usize]) { [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server/main.rs:31:23 [INFO] [stdout] | [INFO] [stdout] 31 | type Future = Box>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | type Future = Box>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/server/main.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 106 | if let Ok(_) = file.read_to_string(&mut body) { [INFO] [stdout] | -------^^^^^--------------------------------- help: try: `if file.read_to_string(&mut body).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/server/main.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | / if let Ok(eval) = parsed { [INFO] [stdout] 109 | | Some(eval) [INFO] [stdout] 110 | | } else { [INFO] [stdout] 111 | | None [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____________^ help: replace with: `parsed.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/server/main.rs:104:42 [INFO] [stdout] | [INFO] [stdout] 104 | if let Ok(mut file) = File::open(path.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `subsec_millis()` is more concise than this calculation [INFO] [stdout] --> src/worker/main.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | total_time.subsec_nanos() / 1000000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `total_time.subsec_millis()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stdout] = note: `#[warn(clippy::duration_subsec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server/main.rs:31:23 [INFO] [stdout] | [INFO] [stdout] 31 | type Future = Box>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | type Future = Box>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `subsec_millis()` is more concise than this calculation [INFO] [stdout] --> src/worker/main.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | total_time.subsec_nanos() / 1000000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `total_time.subsec_millis()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stdout] = note: `#[warn(clippy::duration_subsec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/server/main.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 106 | if let Ok(_) = file.read_to_string(&mut body) { [INFO] [stdout] | -------^^^^^--------------------------------- help: try: `if file.read_to_string(&mut body).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/server/main.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | / if let Ok(eval) = parsed { [INFO] [stdout] 109 | | Some(eval) [INFO] [stdout] 110 | | } else { [INFO] [stdout] 111 | | None [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____________^ help: replace with: `parsed.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/server/main.rs:104:42 [INFO] [stdout] | [INFO] [stdout] 104 | if let Ok(mut file) = File::open(path.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.34s [INFO] running `Command { std: "docker" "inspect" "eae9195afb7c647266b47252b19ae16e499da3eec8efcd8e1b28f481b72c253c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eae9195afb7c647266b47252b19ae16e499da3eec8efcd8e1b28f481b72c253c", kill_on_drop: false }` [INFO] [stdout] eae9195afb7c647266b47252b19ae16e499da3eec8efcd8e1b28f481b72c253c