[INFO] cloning repository https://github.com/tyuvraj/learn-wgpu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tyuvraj/learn-wgpu" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftyuvraj%2Flearn-wgpu", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftyuvraj%2Flearn-wgpu'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e2a9482362f89811ce189e4206d81b4344c902db [INFO] linting tyuvraj/learn-wgpu against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftyuvraj%2Flearn-wgpu" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tyuvraj/learn-wgpu [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/tyuvraj/learn-wgpu [INFO] tweaked toml for git repo https://github.com/tyuvraj/learn-wgpu written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tyuvraj/learn-wgpu on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tyuvraj/learn-wgpu already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bytemuck_derive v1.9.2 [INFO] [stderr] Downloaded external-memory v0.0.1 [INFO] [stderr] Downloaded gfx-hal v0.9.0 [INFO] [stderr] Downloaded naga v0.5.0 [INFO] [stderr] Downloaded quick-xml v0.37.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28d4ad05e1198238279c72bdb7a63d10edd46f6d091076fd5dd9a58c2af42fb5 [INFO] running `Command { std: "docker" "start" "-a" "28d4ad05e1198238279c72bdb7a63d10edd46f6d091076fd5dd9a58c2af42fb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28d4ad05e1198238279c72bdb7a63d10edd46f6d091076fd5dd9a58c2af42fb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28d4ad05e1198238279c72bdb7a63d10edd46f6d091076fd5dd9a58c2af42fb5", kill_on_drop: false }` [INFO] [stdout] 28d4ad05e1198238279c72bdb7a63d10edd46f6d091076fd5dd9a58c2af42fb5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a44d8a58162b1350e5dd0c04ef55176c8218491270e8c9f2a6af7af9552d9be [INFO] running `Command { std: "docker" "start" "-a" "6a44d8a58162b1350e5dd0c04ef55176c8218491270e8c9f2a6af7af9552d9be", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Checking once_cell v1.21.1 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Compiling wayland-sys v0.31.6 [INFO] [stderr] Compiling cc v1.2.17 [INFO] [stderr] Compiling quick-xml v0.37.3 [INFO] [stderr] Compiling wayland-client v0.31.8 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling naga v24.0.0 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Compiling ash v0.38.0+1.3.281 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling wgpu-hal v24.0.2 [INFO] [stderr] Compiling drm-fourcc v2.2.0 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Compiling smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling wgpu-core v24.0.2 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Checking indexmap v2.8.0 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling winit v0.29.15 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling wgpu v24.0.3 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Compiling wayland-scanner v0.31.6 [INFO] [stderr] Compiling wayland-backend v0.3.8 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking pollster v0.2.5 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling bytemuck_derive v1.9.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking bytemuck v1.22.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking naga v0.5.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking wgpu-types v24.0.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking external-memory v0.0.1 [INFO] [stderr] Checking gpu-descriptor v0.3.1 [INFO] [stderr] Checking gfx-hal v0.9.0 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking wayland-cursor v0.31.8 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking sctk-adwaita v0.8.3 [INFO] [stderr] Checking wgpu_gp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/helpers.rs:17:36 [INFO] [stdout] | [INFO] [stdout] 17 | let limits_device = limits.unwrap_or(wgpu::Limits::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:75:31 [INFO] [stdout] | [INFO] [stdout] 75 | let init = IWgpuInit::new(&window, 1, None).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/helpers.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | / pub fn new(&mut self, init: &IWgpuInit) -> wgpu::RenderPipeline { [INFO] [stdout] 115 | | if self.shader.is_some() { [INFO] [stdout] 116 | | self.vs_shader = self.shader; [INFO] [stdout] 117 | | self.fs_shader = self.shader; [INFO] [stdout] ... | [INFO] [stdout] 174 | | }) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:133:26 [INFO] [stdout] | [INFO] [stdout] 133 | layout: Some(&self.pipeline_layout.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.pipeline_layout.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 135 | module: &self.vs_shader.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.vs_shader.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:137:26 [INFO] [stdout] | [INFO] [stdout] 137 | buffers: &self.vertex_buffer_layout, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.vertex_buffer_layout` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/helpers.rs:17:36 [INFO] [stdout] | [INFO] [stdout] 17 | let limits_device = limits.unwrap_or(wgpu::Limits::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:75:31 [INFO] [stdout] | [INFO] [stdout] 75 | let init = IWgpuInit::new(&window, 1, None).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/helpers.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | / pub fn new(&mut self, init: &IWgpuInit) -> wgpu::RenderPipeline { [INFO] [stdout] 115 | | if self.shader.is_some() { [INFO] [stdout] 116 | | self.vs_shader = self.shader; [INFO] [stdout] 117 | | self.fs_shader = self.shader; [INFO] [stdout] ... | [INFO] [stdout] 174 | | }) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:141:25 [INFO] [stdout] | [INFO] [stdout] 141 | module: &self.fs_shader.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.fs_shader.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:133:26 [INFO] [stdout] | [INFO] [stdout] 133 | layout: Some(&self.pipeline_layout.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.pipeline_layout.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 135 | module: &self.vs_shader.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.vs_shader.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:137:26 [INFO] [stdout] | [INFO] [stdout] 137 | buffers: &self.vertex_buffer_layout, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.vertex_buffer_layout` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helpers.rs:141:25 [INFO] [stdout] | [INFO] [stdout] 141 | module: &self.fs_shader.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.fs_shader.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> examples/ch01/wgpu_info.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / match event { [INFO] [stdout] 22 | | Event::WindowEvent { event: WindowEvent::CloseRequested, .. } => { [INFO] [stdout] 23 | | log::info!("Window closed"); [INFO] [stdout] 24 | | elwt.exit(); [INFO] [stdout] ... | [INFO] [stdout] 30 | | _ => (), [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Event::WindowEvent { event: WindowEvent::CloseRequested, .. } = event { [INFO] [stdout] 22 + log::info!("Window closed"); [INFO] [stdout] 23 + elwt.exit(); [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> examples/ch02/common.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub async fn new(&mut self, event_loop: EventLoop<()>, window: Window, [INFO] [stdout] 19 | | num_vertices: u32) { [INFO] [stdout] 20 | | let init = ws::IWgpuInit::new(&window, 1, None).await; [INFO] [stdout] 21 | | let shader = init.device.create_shader_module(wgpu::ShaderModuleDescriptor { [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> examples/imshow/imshow.rs:17:39 [INFO] [stdout] | [INFO] [stdout] 17 | let init = ws::IWgpuInit::new(&window, 1, None) [INFO] [stdout] | ^^^^^^^ help: change this to: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> examples/imshow/imshow.rs:133:33 [INFO] [stdout] | [INFO] [stdout] 133 | render_pass.draw(0..6 as u32, 0..1); [INFO] [stdout] | ^^^^^^^^ help: try: `6_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> examples/imshow/imshow.rs:157:21 [INFO] [stdout] | [INFO] [stdout] 157 | / if !state.input(event) { [INFO] [stdout] 158 | | match event { [INFO] [stdout] 159 | | WindowEvent::Resized(new_size) => { [INFO] [stdout] 160 | | state.resize(*new_size); [INFO] [stdout] ... | [INFO] [stdout] 187 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 156 ~ Event::WindowEvent { ref event, window_id } if window_id == state.window.id() [INFO] [stdout] 157 ~ && !state.input(event) => { [INFO] [stdout] 158 | match event { [INFO] [stdout] ... [INFO] [stdout] 186 | } [INFO] [stdout] 187 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> examples/ch02/common.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub async fn new(&mut self, event_loop: EventLoop<()>, window: Window, [INFO] [stdout] 19 | | num_vertices: u32) { [INFO] [stdout] 20 | | let init = ws::IWgpuInit::new(&window, 1, None).await; [INFO] [stdout] 21 | | let shader = init.device.create_shader_module(wgpu::ShaderModuleDescriptor { [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> examples/ch02/common.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub async fn new(&mut self, event_loop: EventLoop<()>, window: Window, [INFO] [stdout] 19 | | num_vertices: u32) { [INFO] [stdout] 20 | | let init = ws::IWgpuInit::new(&window, 1, None).await; [INFO] [stdout] 21 | | let shader = init.device.create_shader_module(wgpu::ShaderModuleDescriptor { [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> examples/ch02/triangle_primitive.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 17 | match &primitive_type[..] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use the original value instead: `primitive_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> examples/ch02/triangle_primitive.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | window.set_title(&*format!("{}{}", "Chapter 02: primitive type: ", primitive_type)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("{}{}", "Chapter 02: primitive type: ", primitive_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> examples/ch02/triangle_gpu_buffer.rs:43:39 [INFO] [stdout] | [INFO] [stdout] 43 | let init = ws::IWgpuInit::new(&window, 1, None) [INFO] [stdout] | ^^^^^^^ help: change this to: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> examples/ch02/triangle_gpu_buffer.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | / if !state.input(event) { [INFO] [stdout] 143 | | match event { [INFO] [stdout] 144 | | WindowEvent::Resized(new_size) => { [INFO] [stdout] 145 | | state.resize(*new_size); [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 141 ~ Event::WindowEvent { ref event, window_id } if window_id == state.window.id() [INFO] [stdout] 142 ~ && !state.input(event) => { [INFO] [stdout] 143 | match event { [INFO] [stdout] ... [INFO] [stdout] 171 | } [INFO] [stdout] 172 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.20s [INFO] running `Command { std: "docker" "inspect" "6a44d8a58162b1350e5dd0c04ef55176c8218491270e8c9f2a6af7af9552d9be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a44d8a58162b1350e5dd0c04ef55176c8218491270e8c9f2a6af7af9552d9be", kill_on_drop: false }` [INFO] [stdout] 6a44d8a58162b1350e5dd0c04ef55176c8218491270e8c9f2a6af7af9552d9be