[INFO] cloning repository https://github.com/tympaniplayer/catr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tympaniplayer/catr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftympaniplayer%2Fcatr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftympaniplayer%2Fcatr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6c9d3c3bd3d3b729899d92df7f0db5f8f5cc373a [INFO] linting tympaniplayer/catr against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftympaniplayer%2Fcatr" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tympaniplayer/catr [INFO] finished tweaking git repo https://github.com/tympaniplayer/catr [INFO] tweaked toml for git repo https://github.com/tympaniplayer/catr written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tympaniplayer/catr on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tympaniplayer/catr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded predicates-tree v1.0.6 [INFO] [stderr] Downloaded bstr v1.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a95ed7f747587fbf2ea9113e1f82a5c3823f2401835d07562caf3ca1a3294de3 [INFO] running `Command { std: "docker" "start" "-a" "a95ed7f747587fbf2ea9113e1f82a5c3823f2401835d07562caf3ca1a3294de3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a95ed7f747587fbf2ea9113e1f82a5c3823f2401835d07562caf3ca1a3294de3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a95ed7f747587fbf2ea9113e1f82a5c3823f2401835d07562caf3ca1a3294de3", kill_on_drop: false }` [INFO] [stdout] a95ed7f747587fbf2ea9113e1f82a5c3823f2401835d07562caf3ca1a3294de3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f976f04c1ecffa61c6c9eec7f69e267d29329d0a8def347ae6c8259117838a00 [INFO] running `Command { std: "docker" "start" "-a" "f976f04c1ecffa61c6c9eec7f69e267d29329d0a8def347ae6c8259117838a00", kill_on_drop: false }` [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking once_cell v1.16.0 [INFO] [stderr] Checking termtree v0.4.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking predicates-tree v1.0.6 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking bstr v1.0.1 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking predicates v3.0.4 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking catr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 70 | if !config.number_nonblank_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - if !config.number_nonblank_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] 70 + if !(config.number_nonblank_lines && line.len() <= 0) { [INFO] [stdout] | [INFO] [stdout] 70 - if !config.number_nonblank_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] 70 + if !config.number_nonblank_lines || line.len() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:65:80 [INFO] [stdout] | [INFO] [stdout] 65 | if config.number_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:70:90 [INFO] [stdout] | [INFO] [stdout] 70 | if !config.number_nonblank_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 70 | if !config.number_nonblank_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - if !config.number_nonblank_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] 70 + if !(config.number_nonblank_lines && line.len() <= 0) { [INFO] [stdout] | [INFO] [stdout] 70 - if !config.number_nonblank_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] 70 + if !config.number_nonblank_lines || line.len() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:65:80 [INFO] [stdout] | [INFO] [stdout] 65 | if config.number_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:70:90 [INFO] [stdout] | [INFO] [stdout] 70 | if !config.number_nonblank_lines || (config.number_nonblank_lines && line.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.40s [INFO] running `Command { std: "docker" "inspect" "f976f04c1ecffa61c6c9eec7f69e267d29329d0a8def347ae6c8259117838a00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f976f04c1ecffa61c6c9eec7f69e267d29329d0a8def347ae6c8259117838a00", kill_on_drop: false }` [INFO] [stdout] f976f04c1ecffa61c6c9eec7f69e267d29329d0a8def347ae6c8259117838a00