[INFO] cloning repository https://github.com/turytsia/university-pv281-PeerToPeerFilesystem [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/turytsia/university-pv281-PeerToPeerFilesystem" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fturytsia%2Funiversity-pv281-PeerToPeerFilesystem", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fturytsia%2Funiversity-pv281-PeerToPeerFilesystem'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dffbce1cd585e0ebdfe4b308b90537a87b485950 [INFO] linting turytsia/university-pv281-PeerToPeerFilesystem against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fturytsia%2Funiversity-pv281-PeerToPeerFilesystem" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/turytsia/university-pv281-PeerToPeerFilesystem [INFO] finished tweaking git repo https://github.com/turytsia/university-pv281-PeerToPeerFilesystem [INFO] tweaked toml for git repo https://github.com/turytsia/university-pv281-PeerToPeerFilesystem written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/turytsia/university-pv281-PeerToPeerFilesystem on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/turytsia/university-pv281-PeerToPeerFilesystem already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-macros v2.4.0 [INFO] [stderr] Downloaded ghash v0.5.1 [INFO] [stderr] Downloaded c_linked_list v1.1.1 [INFO] [stderr] Downloaded get_if_addrs v0.5.3 [INFO] [stderr] Downloaded env_filter v0.1.2 [INFO] [stderr] Downloaded get_if_addrs-sys v0.1.1 [INFO] [stderr] Downloaded block-buffer v0.11.0-rc.3 [INFO] [stderr] Downloaded tempfile v3.15.0 [INFO] [stderr] Downloaded cpufeatures v0.2.14 [INFO] [stderr] Downloaded tracing-futures v0.2.5 [INFO] [stderr] Downloaded clap_derive v4.5.24 [INFO] [stderr] Downloaded env_logger v0.11.5 [INFO] [stderr] Downloaded clap v4.5.26 [INFO] [stderr] Downloaded const-oid v0.10.0-rc.3 [INFO] [stderr] Downloaded mio v1.0.2 [INFO] [stderr] Downloaded trust-dns-client v0.20.4 [INFO] [stderr] Downloaded rand v0.9.0-alpha.2 [INFO] [stderr] Downloaded gcc v0.3.55 [INFO] [stderr] Downloaded aes-gcm v0.10.3 [INFO] [stderr] Downloaded socket2 v0.4.10 [INFO] [stderr] Downloaded clap_builder v4.5.26 [INFO] [stderr] Downloaded pin-project-internal v1.1.8 [INFO] [stderr] Downloaded pin-project v1.1.8 [INFO] [stderr] Downloaded radix_trie v0.2.1 [INFO] [stderr] Downloaded trust-dns-proto v0.20.4 [INFO] [stderr] Downloaded rand_core v0.9.0-alpha.2 [INFO] [stderr] Downloaded hybrid-array v0.2.1 [INFO] [stderr] Downloaded object v0.36.5 [INFO] [stderr] Downloaded derive_builder v0.9.0 [INFO] [stderr] Downloaded rustix v0.38.43 [INFO] [stderr] Downloaded data-encoding v2.7.0 [INFO] [stderr] Downloaded rand_chacha v0.9.0-alpha.2 [INFO] [stderr] Downloaded unicode-ident v1.0.13 [INFO] [stderr] Downloaded derive_builder_core v0.9.0 [INFO] [stderr] Downloaded digest v0.11.0-pre.9 [INFO] [stderr] Downloaded miniz_oxide v0.8.0 [INFO] [stderr] Downloaded endian-type v0.1.2 [INFO] [stderr] Downloaded public-ip v0.2.2 [INFO] [stderr] Downloaded sha1 v0.11.0-pre.4 [INFO] [stderr] Downloaded crypto-common v0.2.0-rc.1 [INFO] [stderr] Downloaded nibble_vec v0.1.0 [INFO] [stderr] Downloaded enum-as-inner v0.3.4 [INFO] [stderr] Downloaded hyper-system-resolver v0.5.0 [INFO] [stderr] Downloaded dns-lookup v1.0.8 [INFO] [stderr] Downloaded libc v0.2.161 [INFO] [stderr] Downloaded tokio v1.41.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7653a618d747d37b92e79d017b0305430238e5df9635cbbc2bda005a6dcc0ca6 [INFO] running `Command { std: "docker" "start" "-a" "7653a618d747d37b92e79d017b0305430238e5df9635cbbc2bda005a6dcc0ca6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7653a618d747d37b92e79d017b0305430238e5df9635cbbc2bda005a6dcc0ca6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7653a618d747d37b92e79d017b0305430238e5df9635cbbc2bda005a6dcc0ca6", kill_on_drop: false }` [INFO] [stdout] 7653a618d747d37b92e79d017b0305430238e5df9635cbbc2bda005a6dcc0ca6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 07ad7398424faa0dd89c1f2b841e5ba5362602e757a79d3a7382a3622e0e8d90 [INFO] running `Command { std: "docker" "start" "-a" "07ad7398424faa0dd89c1f2b841e5ba5362602e757a79d3a7382a3622e0e8d90", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Checking tinyvec v1.8.1 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling derive_builder v0.9.0 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Compiling rustix v0.38.43 [INFO] [stderr] Checking data-encoding v2.7.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling anyhow v1.0.95 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking const-oid v0.10.0-rc.3 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking c_linked_list v1.1.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking clap_builder v4.5.26 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking get_if_addrs v0.5.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dns-lookup v1.0.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking hybrid-array v0.2.1 [INFO] [stderr] Checking tempfile v3.15.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking crypto-common v0.2.0-rc.1 [INFO] [stderr] Checking block-buffer v0.11.0-rc.3 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking digest v0.11.0-pre.9 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking sha1 v0.11.0-pre.4 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling enum-as-inner v0.3.4 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling derive_builder_core v0.9.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.85 [INFO] [stderr] Compiling pin-project-internal v1.1.8 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling clap_derive v4.5.24 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_core v0.9.0-alpha.2 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking pin-project v1.1.8 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.5.26 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking rand v0.9.0-alpha.2 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking uuid v1.12.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking hyper-system-resolver v0.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking trust-dns-proto v0.20.4 [INFO] [stderr] Checking trust-dns-client v0.20.4 [INFO] [stderr] Checking public-ip v0.2.2 [INFO] [stderr] Checking p2p v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: enum `LookupRoundStatus` is never used [INFO] [stdout] --> src/core/lookup.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum LookupRoundStatus { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | /// with the closest nodes it knows of. This implies that the queried node does not store the value. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | /// during a value lookup, so it responds with the closest nodes it knows of. This is determined by [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | /// the `success_type` field. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | /// 'did the results improve'. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | /// If this method is in a find_value lookup, it will return true if the value was found. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | /// If this method is in a find_node lookup or the value was not found in the find_value lookup, [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | /// it will return true if the list of closest nodes has been improved. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/node.rs:790:21 [INFO] [stdout] | [INFO] [stdout] 790 | / return match for_value { [INFO] [stdout] 791 | | true => LookupResponse::new_value_successful(resolver_node_info), [INFO] [stdout] 792 | | false => LookupResponse::new_failed(resolver_node_info), [INFO] [stdout] 793 | | }; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 790 ~ match for_value { [INFO] [stdout] 791 + true => LookupResponse::new_value_successful(resolver_node_info), [INFO] [stdout] 792 + false => LookupResponse::new_failed(resolver_node_info), [INFO] [stdout] 793 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `LookupRoundStatus` is never used [INFO] [stdout] --> src/core/lookup.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum LookupRoundStatus { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | /// with the closest nodes it knows of. This implies that the queried node does not store the value. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | /// during a value lookup, so it responds with the closest nodes it knows of. This is determined by [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | /// the `success_type` field. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | /// 'did the results improve'. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | /// If this method is in a find_value lookup, it will return true if the value was found. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | /// If this method is in a find_node lookup or the value was not found in the find_value lookup, [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/core/lookup.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | /// it will return true if the list of closest nodes has been improved. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/node.rs:790:21 [INFO] [stdout] | [INFO] [stdout] 790 | / return match for_value { [INFO] [stdout] 791 | | true => LookupResponse::new_value_successful(resolver_node_info), [INFO] [stdout] 792 | | false => LookupResponse::new_failed(resolver_node_info), [INFO] [stdout] 793 | | }; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 790 ~ match for_value { [INFO] [stdout] 791 + true => LookupResponse::new_value_successful(resolver_node_info), [INFO] [stdout] 792 + false => LookupResponse::new_failed(resolver_node_info), [INFO] [stdout] 793 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/routing/kbucket.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | assert!(!kbucket.add_nodeinfo_limited(new_node).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `kbucket.add_nodeinfo_limited(new_node).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Key` which implements the `Copy` trait [INFO] [stdout] --> src/storage/shard_storage_manager.rs:237:57 [INFO] [stdout] | [INFO] [stdout] 237 | manager.add_active_tcp_connection(port, sender, chunk.hash.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chunk.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Key` which implements the `Copy` trait [INFO] [stdout] --> src/storage/shard_storage_manager.rs:258:57 [INFO] [stdout] | [INFO] [stdout] 258 | manager.add_active_tcp_connection(port, sender, chunk.hash.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chunk.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Key` which implements the `Copy` trait [INFO] [stdout] --> src/storage/shard_storage_manager.rs:286:57 [INFO] [stdout] | [INFO] [stdout] 286 | manager.add_active_tcp_connection(port, sender, chunk.hash.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chunk.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Key` which implements the `Copy` trait [INFO] [stdout] --> src/storage/shard_storage_manager.rs:315:57 [INFO] [stdout] | [INFO] [stdout] 315 | manager.add_active_tcp_connection(port, sender, chunk.hash.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chunk.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Key` which implements the `Copy` trait [INFO] [stdout] --> src/storage/shard_storage_manager.rs:334:57 [INFO] [stdout] | [INFO] [stdout] 334 | manager.add_active_tcp_connection(port, sender, chunk.hash.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chunk.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 47.62s [INFO] running `Command { std: "docker" "inspect" "07ad7398424faa0dd89c1f2b841e5ba5362602e757a79d3a7382a3622e0e8d90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07ad7398424faa0dd89c1f2b841e5ba5362602e757a79d3a7382a3622e0e8d90", kill_on_drop: false }` [INFO] [stdout] 07ad7398424faa0dd89c1f2b841e5ba5362602e757a79d3a7382a3622e0e8d90