[INFO] cloning repository https://github.com/tuggan/coreutils-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tuggan/coreutils-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftuggan%2Fcoreutils-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftuggan%2Fcoreutils-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1899dafc880d48ff8a76a875a654b3f6d2bc744e [INFO] linting tuggan/coreutils-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftuggan%2Fcoreutils-rust" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tuggan/coreutils-rust [INFO] finished tweaking git repo https://github.com/tuggan/coreutils-rust [INFO] tweaked toml for git repo https://github.com/tuggan/coreutils-rust written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tuggan/coreutils-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tuggan/coreutils-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded signal-hook v0.1.16 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] [stderr] Downloaded libc v0.2.72 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 392095a13f9858d1601da3b6ba5b66f13b1b83874a082bc9093c0e5095ae4cf4 [INFO] running `Command { std: "docker" "start" "-a" "392095a13f9858d1601da3b6ba5b66f13b1b83874a082bc9093c0e5095ae4cf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "392095a13f9858d1601da3b6ba5b66f13b1b83874a082bc9093c0e5095ae4cf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "392095a13f9858d1601da3b6ba5b66f13b1b83874a082bc9093c0e5095ae4cf4", kill_on_drop: false }` [INFO] [stdout] 392095a13f9858d1601da3b6ba5b66f13b1b83874a082bc9093c0e5095ae4cf4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43e0ce42823e2081fd51db7ed5067f8334057cb340f840d756e6144823d455f3 [INFO] running `Command { std: "docker" "start" "-a" "43e0ce42823e2081fd51db7ed5067f8334057cb340f840d756e6144823d455f3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.72 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking coreutils-rust v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/basename.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/basename.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if multiple && suffix.len() < 1 && names.len() > 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `suffix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/basename.rs:60:27 [INFO] [stdout] | [INFO] [stdout] 60 | let mut basestr = match basename.to_str() { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 61 | | None => "", [INFO] [stdout] 62 | | Some(s) => s, [INFO] [stdout] 63 | | }; [INFO] [stdout] | |_________^ help: ascribe the type &str and replace your expression with: `basename.to_str().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/basename.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | if suffix.len() > 0 && basestr.ends_with(suffix) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!suffix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/basename.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 75 - print!("\n"); [INFO] [stdout] 75 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/yes.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/true.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/true.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 37 - print!("\n"); [INFO] [stdout] 37 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/whoami.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/env/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/env/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/time/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/user/error.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/whoami.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/yes.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/sleep.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/env/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/env/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/time/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/user/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/user/error.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/sleep.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/basename.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/cat.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/cat.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/cat.rs:34:19 [INFO] [stdout] | [INFO] [stdout] 34 | const ABOUT: &'static str = env!("CARGO_PKG_DESCRIPTION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/true.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string_from_os` is never used [INFO] [stdout] --> src/lib/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn string_from_os(string: OsString) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_cwd` is never used [INFO] [stdout] --> src/lib/env/unix.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/env/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EnvError` is never constructed [INFO] [stdout] --> src/lib/env/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct EnvError { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/env/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl EnvError { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> EnvError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_username` is never used [INFO] [stdout] --> src/lib/user/unix.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn get_username() -> UserResult { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `UserResult` is never used [INFO] [stdout] --> src/lib/user/error.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 19 | pub type UserResult = std::result::Result; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserError` is never constructed [INFO] [stdout] --> src/lib/user/error.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct UserError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/user/error.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl UserError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 38 | pub fn new(code: usize, message: &str) -> UserError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib/env/unix.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/env/unix.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(path.into()); [INFO] [stdout] 39 + Ok(path.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/pwd.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/env/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/env/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/sleep.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/env/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/env/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/time/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/basename.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if multiple && suffix.len() < 1 && names.len() > 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `suffix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/user/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/time/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/user/error.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/lib/env/unix.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 36 | String::from_utf8(mem::transmute(buf)).unwrap() [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::, std::vec::Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/user/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/user/error.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/sleep.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib/env/unix.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/pwd.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/basename.rs:60:27 [INFO] [stdout] | [INFO] [stdout] 60 | let mut basestr = match basename.to_str() { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 61 | | None => "", [INFO] [stdout] 62 | | Some(s) => s, [INFO] [stdout] 63 | | }; [INFO] [stdout] | |_________^ help: ascribe the type &str and replace your expression with: `basename.to_str().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/basename.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | if suffix.len() > 0 && basestr.ends_with(suffix) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!suffix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/basename.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 75 - print!("\n"); [INFO] [stdout] 75 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/cat.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/cat.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/cat.rs:34:19 [INFO] [stdout] | [INFO] [stdout] 34 | const ABOUT: &'static str = env!("CARGO_PKG_DESCRIPTION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/file/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | pub mod file; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | return Result::Ok(metadata.st_blksize()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Result::Ok(metadata.st_blksize()); [INFO] [stdout] 30 + Result::Ok(metadata.st_blksize()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - Err(error) => return Result::Err(error), [INFO] [stdout] 32 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Result::Ok(blk as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Result::Ok(blk as usize); [INFO] [stdout] 40 + Result::Ok(blk as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - Err(error) => return Result::Err(error), [INFO] [stdout] 42 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/true.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 37 - print!("\n"); [INFO] [stdout] 37 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return v * multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return v * multiplier; [INFO] [stdout] 40 + v * multiplier [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(ret); [INFO] [stdout] 75 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/time/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | let ret: f64; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 | [INFO] [stdout] ... [INFO] [stdout] 63 | [INFO] [stdout] 64 ~ let ret: f64 = if re_suffix.is_match(s) { [INFO] [stdout] 65 | // Split suffix [INFO] [stdout] ... [INFO] [stdout] 68 | [INFO] [stdout] 69 ~ apply_suffix(time, suffix) [INFO] [stdout] 70 | } else { [INFO] [stdout] 71 | // No suffix [INFO] [stdout] 72 ~ s.parse().unwrap() [INFO] [stdout] 73 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | return Ok(username); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Ok(username); [INFO] [stdout] 46 + Ok(username) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] 48 + _ => Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/lib/user/unix.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - n if n == -1 => 16384 as usize, [INFO] [stdout] 28 + -1 => 16384 as usize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib/user/unix.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `16384_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sleep.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | if !(now.elapsed() >= duration) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(now.elapsed() < duration)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/sleep.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 46 | sleep += match libtime::parse_to_seconds(number) { [INFO] [stdout] | __________________^ [INFO] [stdout] 47 | | Ok(n) => n, [INFO] [stdout] 48 | | Err(e) => return Err(e.into()), [INFO] [stdout] 49 | | } [INFO] [stdout] | |_________^ help: try instead: `libtime::parse_to_seconds(number)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sleep.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | let signals = Signals::new(&[SIGINT, SIGTERM, SIGUSR1, SIGUSR2]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[SIGINT, SIGTERM, SIGUSR1, SIGUSR2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cat.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok(reader); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Ok(reader); [INFO] [stdout] 87 + Ok(reader) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/cat.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 81 | let fd = match File::open(&path) { [INFO] [stdout] | __________________^ [INFO] [stdout] 82 | | Err(why) => return Err(why), [INFO] [stdout] 83 | | Ok(fd) => fd, [INFO] [stdout] 84 | | }; [INFO] [stdout] | |_________^ help: try instead: `File::open(&path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cat.rs:81:35 [INFO] [stdout] | [INFO] [stdout] 81 | let fd = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/cat.rs:116:16 [INFO] [stdout] | [INFO] [stdout] 116 | } else if n == 1 { [INFO] [stdout] | ________________^ [INFO] [stdout] 117 | | last_line_blank = true; [INFO] [stdout] 118 | | } else { [INFO] [stdout] 119 | | last_line_blank = false; [INFO] [stdout] 120 | | }; [INFO] [stdout] | |_________^ help: you can reduce it to: `{ last_line_blank = n == 1; }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/whoami.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/env/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/env/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/time/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/user/error.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/whoami.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string_from_os` is never used [INFO] [stdout] --> src/lib/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn string_from_os(string: OsString) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_cwd` is never used [INFO] [stdout] --> src/lib/env/unix.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/env/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EnvError` is never constructed [INFO] [stdout] --> src/lib/env/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct EnvError { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/env/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl EnvError { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> EnvError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `apply_suffix` is never used [INFO] [stdout] --> src/lib/time/mod.rs:31:4 [INFO] [stdout] | [INFO] [stdout] 31 | fn apply_suffix(v: f64, c: char) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_to_seconds` is never used [INFO] [stdout] --> src/lib/time/mod.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn parse_to_seconds(s: &str) -> error::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/time/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TimeError` is never constructed [INFO] [stdout] --> src/lib/time/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct TimeError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/time/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl TimeError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> TimeError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib/env/unix.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/env/unix.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(path.into()); [INFO] [stdout] 39 + Ok(path.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/pwd.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/lib/env/unix.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 36 | String::from_utf8(mem::transmute(buf)).unwrap() [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::, std::vec::Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib/env/unix.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/file/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | pub mod file; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | return Result::Ok(metadata.st_blksize()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Result::Ok(metadata.st_blksize()); [INFO] [stdout] 30 + Result::Ok(metadata.st_blksize()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - Err(error) => return Result::Err(error), [INFO] [stdout] 32 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Result::Ok(blk as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Result::Ok(blk as usize); [INFO] [stdout] 40 + Result::Ok(blk as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - Err(error) => return Result::Err(error), [INFO] [stdout] 42 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/env/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/env/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/time/error.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unix as native` [INFO] [stdout] --> src/lib/user/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use unix as native; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/user/error.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | code: code, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/pwd.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return v * multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return v * multiplier; [INFO] [stdout] 40 + v * multiplier [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(ret); [INFO] [stdout] 75 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/time/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | let ret: f64; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 | [INFO] [stdout] ... [INFO] [stdout] 63 | [INFO] [stdout] 64 ~ let ret: f64 = if re_suffix.is_match(s) { [INFO] [stdout] 65 | // Split suffix [INFO] [stdout] ... [INFO] [stdout] 68 | [INFO] [stdout] 69 ~ apply_suffix(time, suffix) [INFO] [stdout] 70 | } else { [INFO] [stdout] 71 | // No suffix [INFO] [stdout] 72 ~ s.parse().unwrap() [INFO] [stdout] 73 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | return Ok(username); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Ok(username); [INFO] [stdout] 46 + Ok(username) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] 48 + _ => Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/lib/user/unix.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - n if n == -1 => 16384 as usize, [INFO] [stdout] 28 + -1 => 16384 as usize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib/user/unix.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `16384_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_cwd` is never used [INFO] [stdout] --> src/lib/env/unix.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/env/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EnvError` is never constructed [INFO] [stdout] --> src/lib/env/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct EnvError { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/env/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl EnvError { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> EnvError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `apply_suffix` is never used [INFO] [stdout] --> src/lib/time/mod.rs:31:4 [INFO] [stdout] | [INFO] [stdout] 31 | fn apply_suffix(v: f64, c: char) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_to_seconds` is never used [INFO] [stdout] --> src/lib/time/mod.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn parse_to_seconds(s: &str) -> error::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/time/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TimeError` is never constructed [INFO] [stdout] --> src/lib/time/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct TimeError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/time/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl TimeError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> TimeError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_username` is never used [INFO] [stdout] --> src/lib/user/unix.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn get_username() -> UserResult { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `UserResult` is never used [INFO] [stdout] --> src/lib/user/error.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 19 | pub type UserResult = std::result::Result; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserError` is never constructed [INFO] [stdout] --> src/lib/user/error.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct UserError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/user/error.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl UserError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 38 | pub fn new(code: usize, message: &str) -> UserError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib/env/unix.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/env/unix.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(path.into()); [INFO] [stdout] 39 + Ok(path.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string_from_os` is never used [INFO] [stdout] --> src/lib/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn string_from_os(string: OsString) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_cwd` is never used [INFO] [stdout] --> src/lib/env/unix.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/env/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EnvError` is never constructed [INFO] [stdout] --> src/lib/env/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct EnvError { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/env/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl EnvError { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> EnvError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_username` is never used [INFO] [stdout] --> src/lib/user/unix.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn get_username() -> UserResult { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `UserResult` is never used [INFO] [stdout] --> src/lib/user/error.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 19 | pub type UserResult = std::result::Result; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserError` is never constructed [INFO] [stdout] --> src/lib/user/error.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct UserError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/user/error.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl UserError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 38 | pub fn new(code: usize, message: &str) -> UserError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib/env/unix.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/env/unix.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(path.into()); [INFO] [stdout] 39 + Ok(path.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/lib/env/unix.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 36 | String::from_utf8(mem::transmute(buf)).unwrap() [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::, std::vec::Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib/env/unix.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/file/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | pub mod file; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | return Result::Ok(metadata.st_blksize()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Result::Ok(metadata.st_blksize()); [INFO] [stdout] 30 + Result::Ok(metadata.st_blksize()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - Err(error) => return Result::Err(error), [INFO] [stdout] 32 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Result::Ok(blk as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Result::Ok(blk as usize); [INFO] [stdout] 40 + Result::Ok(blk as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - Err(error) => return Result::Err(error), [INFO] [stdout] 42 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return v * multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return v * multiplier; [INFO] [stdout] 40 + v * multiplier [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/lib/env/unix.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 36 | String::from_utf8(mem::transmute(buf)).unwrap() [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::, std::vec::Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib/env/unix.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(ret); [INFO] [stdout] 75 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/time/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | let ret: f64; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 | [INFO] [stdout] ... [INFO] [stdout] 63 | [INFO] [stdout] 64 ~ let ret: f64 = if re_suffix.is_match(s) { [INFO] [stdout] 65 | // Split suffix [INFO] [stdout] ... [INFO] [stdout] 68 | [INFO] [stdout] 69 ~ apply_suffix(time, suffix) [INFO] [stdout] 70 | } else { [INFO] [stdout] 71 | // No suffix [INFO] [stdout] 72 ~ s.parse().unwrap() [INFO] [stdout] 73 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | return Ok(username); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Ok(username); [INFO] [stdout] 46 + Ok(username) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] 48 + _ => Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/file/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | pub mod file; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/lib/user/unix.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - n if n == -1 => 16384 as usize, [INFO] [stdout] 28 + -1 => 16384 as usize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib/user/unix.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `16384_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | return Result::Ok(metadata.st_blksize()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Result::Ok(metadata.st_blksize()); [INFO] [stdout] 30 + Result::Ok(metadata.st_blksize()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - Err(error) => return Result::Err(error), [INFO] [stdout] 32 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Result::Ok(blk as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Result::Ok(blk as usize); [INFO] [stdout] 40 + Result::Ok(blk as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - Err(error) => return Result::Err(error), [INFO] [stdout] 42 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return v * multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return v * multiplier; [INFO] [stdout] 40 + v * multiplier [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(ret); [INFO] [stdout] 75 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/time/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | let ret: f64; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 | [INFO] [stdout] ... [INFO] [stdout] 63 | [INFO] [stdout] 64 ~ let ret: f64 = if re_suffix.is_match(s) { [INFO] [stdout] 65 | // Split suffix [INFO] [stdout] ... [INFO] [stdout] 68 | [INFO] [stdout] 69 ~ apply_suffix(time, suffix) [INFO] [stdout] 70 | } else { [INFO] [stdout] 71 | // No suffix [INFO] [stdout] 72 ~ s.parse().unwrap() [INFO] [stdout] 73 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string_from_os` is never used [INFO] [stdout] --> src/lib/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn string_from_os(string: OsString) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_cwd` is never used [INFO] [stdout] --> src/lib/env/unix.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/env/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EnvError` is never constructed [INFO] [stdout] --> src/lib/env/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct EnvError { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/env/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl EnvError { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> EnvError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `apply_suffix` is never used [INFO] [stdout] --> src/lib/time/mod.rs:31:4 [INFO] [stdout] | [INFO] [stdout] 31 | fn apply_suffix(v: f64, c: char) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_to_seconds` is never used [INFO] [stdout] --> src/lib/time/mod.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn parse_to_seconds(s: &str) -> error::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/time/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TimeError` is never constructed [INFO] [stdout] --> src/lib/time/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct TimeError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/time/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl TimeError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> TimeError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib/env/unix.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/env/unix.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(path.into()); [INFO] [stdout] 39 + Ok(path.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/lib/env/unix.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 36 | String::from_utf8(mem::transmute(buf)).unwrap() [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::, std::vec::Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib/env/unix.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/file/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | pub mod file; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | return Result::Ok(metadata.st_blksize()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Result::Ok(metadata.st_blksize()); [INFO] [stdout] 30 + Result::Ok(metadata.st_blksize()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - Err(error) => return Result::Err(error), [INFO] [stdout] 32 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Result::Ok(blk as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Result::Ok(blk as usize); [INFO] [stdout] 40 + Result::Ok(blk as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - Err(error) => return Result::Err(error), [INFO] [stdout] 42 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return v * multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return v * multiplier; [INFO] [stdout] 40 + v * multiplier [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(ret); [INFO] [stdout] 75 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/time/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | let ret: f64; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 | [INFO] [stdout] ... [INFO] [stdout] 63 | [INFO] [stdout] 64 ~ let ret: f64 = if re_suffix.is_match(s) { [INFO] [stdout] 65 | // Split suffix [INFO] [stdout] ... [INFO] [stdout] 68 | [INFO] [stdout] 69 ~ apply_suffix(time, suffix) [INFO] [stdout] 70 | } else { [INFO] [stdout] 71 | // No suffix [INFO] [stdout] 72 ~ s.parse().unwrap() [INFO] [stdout] 73 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | return Ok(username); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Ok(username); [INFO] [stdout] 46 + Ok(username) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] 48 + _ => Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/lib/user/unix.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - n if n == -1 => 16384 as usize, [INFO] [stdout] 28 + -1 => 16384 as usize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib/user/unix.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `16384_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | return Ok(username); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Ok(username); [INFO] [stdout] 46 + Ok(username) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] 48 + _ => Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/lib/user/unix.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - n if n == -1 => 16384 as usize, [INFO] [stdout] 28 + -1 => 16384 as usize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib/user/unix.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `16384_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sleep.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | if !(now.elapsed() >= duration) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(now.elapsed() < duration)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/sleep.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 46 | sleep += match libtime::parse_to_seconds(number) { [INFO] [stdout] | __________________^ [INFO] [stdout] 47 | | Ok(n) => n, [INFO] [stdout] 48 | | Err(e) => return Err(e.into()), [INFO] [stdout] 49 | | } [INFO] [stdout] | |_________^ help: try instead: `libtime::parse_to_seconds(number)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sleep.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | let signals = Signals::new(&[SIGINT, SIGTERM, SIGUSR1, SIGUSR2]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[SIGINT, SIGTERM, SIGUSR1, SIGUSR2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_cwd` is never used [INFO] [stdout] --> src/lib/env/unix.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/env/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EnvError` is never constructed [INFO] [stdout] --> src/lib/env/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct EnvError { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/env/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl EnvError { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> EnvError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `apply_suffix` is never used [INFO] [stdout] --> src/lib/time/mod.rs:31:4 [INFO] [stdout] | [INFO] [stdout] 31 | fn apply_suffix(v: f64, c: char) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_to_seconds` is never used [INFO] [stdout] --> src/lib/time/mod.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn parse_to_seconds(s: &str) -> error::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Result` is never used [INFO] [stdout] --> src/lib/time/error.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Result = std::result::Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TimeError` is never constructed [INFO] [stdout] --> src/lib/time/error.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct TimeError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/time/error.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl TimeError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn new(code: usize, message: &str) -> TimeError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_username` is never used [INFO] [stdout] --> src/lib/user/unix.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn get_username() -> UserResult { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `UserResult` is never used [INFO] [stdout] --> src/lib/user/error.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 19 | pub type UserResult = std::result::Result; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserError` is never constructed [INFO] [stdout] --> src/lib/user/error.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct UserError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/lib/user/error.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl UserError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 38 | pub fn new(code: usize, message: &str) -> UserError { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib/env/unix.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn get_cwd<'a>() -> Result { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/env/unix.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(path.into()); [INFO] [stdout] 39 + Ok(path.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cat.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok(reader); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Ok(reader); [INFO] [stdout] 87 + Ok(reader) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/cat.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 81 | let fd = match File::open(&path) { [INFO] [stdout] | __________________^ [INFO] [stdout] 82 | | Err(why) => return Err(why), [INFO] [stdout] 83 | | Ok(fd) => fd, [INFO] [stdout] 84 | | }; [INFO] [stdout] | |_________^ help: try instead: `File::open(&path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cat.rs:81:35 [INFO] [stdout] | [INFO] [stdout] 81 | let fd = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/cat.rs:116:16 [INFO] [stdout] | [INFO] [stdout] 116 | } else if n == 1 { [INFO] [stdout] | ________________^ [INFO] [stdout] 117 | | last_line_blank = true; [INFO] [stdout] 118 | | } else { [INFO] [stdout] 119 | | last_line_blank = false; [INFO] [stdout] 120 | | }; [INFO] [stdout] | |_________^ help: you can reduce it to: `{ last_line_blank = n == 1; }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/lib/env/unix.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 36 | String::from_utf8(mem::transmute(buf)).unwrap() [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::, std::vec::Vec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib/env/unix.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(path.into()); [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/file/mod.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | pub mod file; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | return Result::Ok(metadata.st_blksize()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Result::Ok(metadata.st_blksize()); [INFO] [stdout] 30 + Result::Ok(metadata.st_blksize()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - Err(error) => return Result::Err(error), [INFO] [stdout] 32 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Result::Ok(blk as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Result::Ok(blk as usize); [INFO] [stdout] 40 + Result::Ok(blk as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file/file.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | Err(error) => return Result::Err(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - Err(error) => return Result::Err(error), [INFO] [stdout] 42 + Err(error) => Result::Err(error), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return v * multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return v * multiplier; [INFO] [stdout] 40 + v * multiplier [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/time/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(ret); [INFO] [stdout] 75 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/time/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | let ret: f64; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 | [INFO] [stdout] ... [INFO] [stdout] 63 | [INFO] [stdout] 64 ~ let ret: f64 = if re_suffix.is_match(s) { [INFO] [stdout] 65 | // Split suffix [INFO] [stdout] ... [INFO] [stdout] 68 | [INFO] [stdout] 69 ~ apply_suffix(time, suffix) [INFO] [stdout] 70 | } else { [INFO] [stdout] 71 | // No suffix [INFO] [stdout] 72 ~ s.parse().unwrap() [INFO] [stdout] 73 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.90s [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | return Ok(username); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Ok(username); [INFO] [stdout] 46 + Ok(username) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/user/unix.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - _ => return Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] 48 + _ => Err(UserError::new(1, "unable to get user passwd struct")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/lib/user/unix.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - n if n == -1 => 16384 as usize, [INFO] [stdout] 28 + -1 => 16384 as usize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib/user/unix.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | n if n == -1 => 16384 as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `16384_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "43e0ce42823e2081fd51db7ed5067f8334057cb340f840d756e6144823d455f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43e0ce42823e2081fd51db7ed5067f8334057cb340f840d756e6144823d455f3", kill_on_drop: false }` [INFO] [stdout] 43e0ce42823e2081fd51db7ed5067f8334057cb340f840d756e6144823d455f3