[INFO] cloning repository https://github.com/tstelzer/azul-board [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tstelzer/azul-board" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftstelzer%2Fazul-board", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftstelzer%2Fazul-board'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3a1a1d62963d16a0e0c28a4db5e544bda86dd0ab [INFO] linting tstelzer/azul-board against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftstelzer%2Fazul-board" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tstelzer/azul-board [INFO] finished tweaking git repo https://github.com/tstelzer/azul-board [INFO] tweaked toml for git repo https://github.com/tstelzer/azul-board written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tstelzer/azul-board on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tstelzer/azul-board already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded miniz_oxide v0.5.3 [INFO] [stderr] Downloaded either v1.7.0 [INFO] [stderr] Downloaded uuid v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4dfeb2eb0e14974e052dcd0f927a6a805fb59bfc337b1aee562b3e80e10d99bd [INFO] running `Command { std: "docker" "start" "-a" "4dfeb2eb0e14974e052dcd0f927a6a805fb59bfc337b1aee562b3e80e10d99bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4dfeb2eb0e14974e052dcd0f927a6a805fb59bfc337b1aee562b3e80e10d99bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4dfeb2eb0e14974e052dcd0f927a6a805fb59bfc337b1aee562b3e80e10d99bd", kill_on_drop: false }` [INFO] [stdout] 4dfeb2eb0e14974e052dcd0f927a6a805fb59bfc337b1aee562b3e80e10d99bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6b823e833ce8435de6b37d3ae8fb2846b4fc3250455171791c729ce02a66518 [INFO] running `Command { std: "docker" "start" "-a" "b6b823e833ce8435de6b37d3ae8fb2846b4fc3250455171791c729ce02a66518", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling proc-macro2 v1.0.42 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking bit_field v0.10.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking lebe v0.5.1 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking bytemuck v1.11.0 [INFO] [stderr] Checking spin v0.9.4 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking png v0.17.5 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.2.6 [INFO] [stderr] Checking tiff v0.7.3 [INFO] [stderr] Compiling pin-project-internal v1.0.11 [INFO] [stderr] Checking pin-project v1.0.11 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking exr v1.4.2 [INFO] [stderr] Checking image v0.24.3 [INFO] [stderr] Checking create-azul-board v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 31 | result.push(&tile_to_color[&field]); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:51:42 [INFO] [stdout] | [INFO] [stdout] 51 | fn randomize_board_mut(board: &mut Board) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:109:42 [INFO] [stdout] | [INFO] [stdout] 109 | *pixel = tile_to_rgb[&tile]; [INFO] [stdout] | ^^^^^ help: change this to: `tile` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:124:54 [INFO] [stdout] | [INFO] [stdout] 124 | fn print_matrix(xs: &Matrix2d) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if !(x < len / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(x >= len / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:143:16 [INFO] [stdout] | [INFO] [stdout] 143 | if !(y < len - x - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(y >= len - x - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 31 | result.push(&tile_to_color[&field]); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:51:42 [INFO] [stdout] | [INFO] [stdout] 51 | fn randomize_board_mut(board: &mut Board) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:109:42 [INFO] [stdout] | [INFO] [stdout] 109 | *pixel = tile_to_rgb[&tile]; [INFO] [stdout] | ^^^^^ help: change this to: `tile` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:124:54 [INFO] [stdout] | [INFO] [stdout] 124 | fn print_matrix(xs: &Matrix2d) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if !(x < len / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(x >= len / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:143:16 [INFO] [stdout] | [INFO] [stdout] 143 | if !(y < len - x - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(y >= len - x - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.47s [INFO] running `Command { std: "docker" "inspect" "b6b823e833ce8435de6b37d3ae8fb2846b4fc3250455171791c729ce02a66518", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6b823e833ce8435de6b37d3ae8fb2846b4fc3250455171791c729ce02a66518", kill_on_drop: false }` [INFO] [stdout] b6b823e833ce8435de6b37d3ae8fb2846b4fc3250455171791c729ce02a66518