[INFO] cloning repository https://github.com/tsemo4917/shyper-cli-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tsemo4917/shyper-cli-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftsemo4917%2Fshyper-cli-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftsemo4917%2Fshyper-cli-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bc460b7faf45e68515c6d35b0aa9041398bd9b9c [INFO] linting tsemo4917/shyper-cli-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftsemo4917%2Fshyper-cli-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tsemo4917/shyper-cli-rs [INFO] finished tweaking git repo https://github.com/tsemo4917/shyper-cli-rs [INFO] tweaked toml for git repo https://github.com/tsemo4917/shyper-cli-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tsemo4917/shyper-cli-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tsemo4917/shyper-cli-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/tsemo4917/libshyper` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded env_filter v0.1.0 [INFO] [stderr] Downloaded env_logger v0.11.3 [INFO] [stderr] Downloaded syn v2.0.61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0836b7c15acc18a85ac29487a26b11d02319c91f9d4b1b320d5d3406059139cf [INFO] running `Command { std: "docker" "start" "-a" "0836b7c15acc18a85ac29487a26b11d02319c91f9d4b1b320d5d3406059139cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0836b7c15acc18a85ac29487a26b11d02319c91f9d4b1b320d5d3406059139cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0836b7c15acc18a85ac29487a26b11d02319c91f9d4b1b320d5d3406059139cf", kill_on_drop: false }` [INFO] [stdout] 0836b7c15acc18a85ac29487a26b11d02319c91f9d4b1b320d5d3406059139cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8854a5762567feb56a72fa9d862c28fc65e22ab7616ac79213ab226bf2d15468 [INFO] running `Command { std: "docker" "start" "-a" "8854a5762567feb56a72fa9d862c28fc65e22ab7616ac79213ab226bf2d15468", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Compiling bindgen v0.63.0 [INFO] [stderr] Compiling clang-sys v1.7.0 [INFO] [stderr] Compiling libloading v0.8.3 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Compiling shyper v0.1.0 (https://github.com/tsemo4917/libshyper#16d57f50) [INFO] [stderr] Checking shyper-cli-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/shyper.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | libc::ioctl(crate::shyper::ShyperBackend::fd(), $request) [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/shyper.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | libc::ioctl(crate::shyper::ShyperBackend::fd(), $request) [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `0 as *mut _` detected [INFO] [stdout] --> src/blk.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | 0 as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `std::ptr::null_mut::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stdout] = note: `#[warn(clippy::zero_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/config.rs:175:33 [INFO] [stdout] | [INFO] [stdout] 175 | let color = u64::from_str_radix(color_slice, 10).map_err(de::Error::custom)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `color_slice.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/config.rs:183:21 [INFO] [stdout] | [INFO] [stdout] 183 | u64::from_str_radix(&color_slice[0..pos], 10).map_err(de::Error::custom)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `color_slice[0..pos].parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/config.rs:184:27 [INFO] [stdout] | [INFO] [stdout] 184 | let end = u64::from_str_radix(&color_slice[pos + 1..len], 10) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `color_slice[pos + 1..len].parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `0 as *mut _` detected [INFO] [stdout] --> src/blk.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | 0 as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `std::ptr::null_mut::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stdout] = note: `#[warn(clippy::zero_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/config.rs:175:33 [INFO] [stdout] | [INFO] [stdout] 175 | let color = u64::from_str_radix(color_slice, 10).map_err(de::Error::custom)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `color_slice.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/config.rs:183:21 [INFO] [stdout] | [INFO] [stdout] 183 | u64::from_str_radix(&color_slice[0..pos], 10).map_err(de::Error::custom)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `color_slice[0..pos].parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/config.rs:184:27 [INFO] [stdout] | [INFO] [stdout] 184 | let end = u64::from_str_radix(&color_slice[pos + 1..len], 10) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `color_slice[pos + 1..len].parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:535:8 [INFO] [stdout] | [INFO] [stdout] 535 | if !copy_img_file_to_memory(vm_id, vm_cfg.image.kernel_filename.clone(), fd).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `copy_img_file_to_memory(vm_id, vm_cfg.image.kernel_filename.clone(), fd).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device.smmu_id` after checking its variant with `is_some` [INFO] [stdout] --> src/config.rs:471:41 [INFO] [stdout] | [INFO] [stdout] 470 | if device.smmu_id.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = device.smmu_id` [INFO] [stdout] 471 | passthrough_stream_ids.push(device.smmu_id.unwrap() as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u64` -> `*const u64`) [INFO] [stdout] --> src/config.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | vm_cfg.memory.colors.as_ref().unwrap().as_ptr() as *const u64 as u64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vm_cfg.memory.colors.as_ref().unwrap().as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u64` -> `*const u64`) [INFO] [stdout] --> src/config.rs:434:28 [INFO] [stdout] | [INFO] [stdout] 434 | cfg_list_addr: device.cfg_list.as_ptr() as *const u64 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `device.cfg_list.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u64` -> `*const u64`) [INFO] [stdout] --> src/config.rs:480:24 [INFO] [stdout] | [INFO] [stdout] 480 | irqs_addr: passthrough_irqs.as_ptr() as *const u64 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `passthrough_irqs.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u64` -> `*const u64`) [INFO] [stdout] --> src/config.rs:496:31 [INFO] [stdout] | [INFO] [stdout] 496 | streams_ids_addr: passthrough_stream_ids.as_ptr() as *const u64 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `passthrough_stream_ids.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `0 as *mut _` detected [INFO] [stdout] --> src/config.rs:614:13 [INFO] [stdout] | [INFO] [stdout] 614 | 0 as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `std::ptr::null_mut::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/config.rs:626:56 [INFO] [stdout] | [INFO] [stdout] 626 | let cache_ipa = virt_to_phys_user(cache_va as u64).map_err(|err| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 626 ~ let cache_ipa = virt_to_phys_user(cache_va as u64).inspect_err(|err| { [INFO] [stdout] 627 | warn!("Failed to get cache pa\n"); [INFO] [stdout] 628 | unsafe { [INFO] [stdout] 629 | munmap(cache_va, CACHE_MAX); [INFO] [stdout] 630 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/config.rs:671:17 [INFO] [stdout] | [INFO] [stdout] 671 | shyper_fd as i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `shyper_fd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/daemon.rs:167:17 [INFO] [stdout] | [INFO] [stdout] 167 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 - } [INFO] [stdout] 167 - return; [INFO] [stdout] 166 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/daemon.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 169 | _ => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 169 - _ => return, [INFO] [stdout] 169 + _ => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/daemon.rs:221:18 [INFO] [stdout] | [INFO] [stdout] 221 | _ => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 221 - _ => return, [INFO] [stdout] 221 + _ => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/daemon.rs:223:14 [INFO] [stdout] | [INFO] [stdout] 223 | _ => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 223 - _ => return, [INFO] [stdout] 223 + _ => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/daemon.rs:256:36 [INFO] [stdout] | [INFO] [stdout] 256 | let mut signals = Signals::new(&[SIGUSR1]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `[SIGUSR1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/daemon.rs:275:24 [INFO] [stdout] | [INFO] [stdout] 273 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 274 | disk_cnt += 1; [INFO] [stdout] 275 | disks.push(result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/util.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | if let Ok(file) = File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/util.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / for i in 0..s.len() { [INFO] [stdout] 41 | | buf[i] = s[i]; [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `buf[..s.len()].copy_from_slice(&s[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/util.rs:50:20 [INFO] [stdout] | [INFO] [stdout] 50 | File::open(&pagemap_path).map_err(|err| format!("Open {} err: {}", &pagemap_path, err))?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `pagemap_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/util.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | return Err(format!("Read page table entry err")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Read page table entry err".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/util.rs:91:10 [INFO] [stdout] | [INFO] [stdout] 91 | (&s[2..], 16) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/util.rs:90:24 [INFO] [stdout] | [INFO] [stdout] 90 | let (src, radix) = if s.starts_with("0x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 90 ~ let (src, radix) = if let Some() = s.strip_prefix("0x") { [INFO] [stdout] 91 ~ (, 16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/util.rs:93:10 [INFO] [stdout] | [INFO] [stdout] 93 | (&s[2..], 2) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/util.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | } else if s.starts_with("0b") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 92 ~ } else if let Some() = s.strip_prefix("0b") { [INFO] [stdout] 93 ~ (, 2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | struct CLI { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:535:8 [INFO] [stdout] | [INFO] [stdout] 535 | if !copy_img_file_to_memory(vm_id, vm_cfg.image.kernel_filename.clone(), fd).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `copy_img_file_to_memory(vm_id, vm_cfg.image.kernel_filename.clone(), fd).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device.smmu_id` after checking its variant with `is_some` [INFO] [stdout] --> src/config.rs:471:41 [INFO] [stdout] | [INFO] [stdout] 470 | if device.smmu_id.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = device.smmu_id` [INFO] [stdout] 471 | passthrough_stream_ids.push(device.smmu_id.unwrap() as u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u64` -> `*const u64`) [INFO] [stdout] --> src/config.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | vm_cfg.memory.colors.as_ref().unwrap().as_ptr() as *const u64 as u64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vm_cfg.memory.colors.as_ref().unwrap().as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u64` -> `*const u64`) [INFO] [stdout] --> src/config.rs:434:28 [INFO] [stdout] | [INFO] [stdout] 434 | cfg_list_addr: device.cfg_list.as_ptr() as *const u64 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `device.cfg_list.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u64` -> `*const u64`) [INFO] [stdout] --> src/config.rs:480:24 [INFO] [stdout] | [INFO] [stdout] 480 | irqs_addr: passthrough_irqs.as_ptr() as *const u64 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `passthrough_irqs.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u64` -> `*const u64`) [INFO] [stdout] --> src/config.rs:496:31 [INFO] [stdout] | [INFO] [stdout] 496 | streams_ids_addr: passthrough_stream_ids.as_ptr() as *const u64 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `passthrough_stream_ids.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `0 as *mut _` detected [INFO] [stdout] --> src/config.rs:614:13 [INFO] [stdout] | [INFO] [stdout] 614 | 0 as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `std::ptr::null_mut::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/config.rs:626:56 [INFO] [stdout] | [INFO] [stdout] 626 | let cache_ipa = virt_to_phys_user(cache_va as u64).map_err(|err| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 626 ~ let cache_ipa = virt_to_phys_user(cache_va as u64).inspect_err(|err| { [INFO] [stdout] 627 | warn!("Failed to get cache pa\n"); [INFO] [stdout] 628 | unsafe { [INFO] [stdout] 629 | munmap(cache_va, CACHE_MAX); [INFO] [stdout] 630 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/config.rs:671:17 [INFO] [stdout] | [INFO] [stdout] 671 | shyper_fd as i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `shyper_fd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/daemon.rs:167:17 [INFO] [stdout] | [INFO] [stdout] 167 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 - } [INFO] [stdout] 167 - return; [INFO] [stdout] 166 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/daemon.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 169 | _ => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 169 - _ => return, [INFO] [stdout] 169 + _ => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/daemon.rs:221:18 [INFO] [stdout] | [INFO] [stdout] 221 | _ => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 221 - _ => return, [INFO] [stdout] 221 + _ => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/daemon.rs:223:14 [INFO] [stdout] | [INFO] [stdout] 223 | _ => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 223 - _ => return, [INFO] [stdout] 223 + _ => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/daemon.rs:256:36 [INFO] [stdout] | [INFO] [stdout] 256 | let mut signals = Signals::new(&[SIGUSR1]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `[SIGUSR1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/daemon.rs:275:24 [INFO] [stdout] | [INFO] [stdout] 273 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 274 | disk_cnt += 1; [INFO] [stdout] 275 | disks.push(result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/util.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | if let Ok(file) = File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:131:20 [INFO] [stdout] | [INFO] [stdout] 131 | return Err(String::from(format!("File {} not exists!", file))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("File {} not exists!", file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SDL` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | SDL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sdl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/util.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / for i in 0..s.len() { [INFO] [stdout] 41 | | buf[i] = s[i]; [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `buf[..s.len()].copy_from_slice(&s[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/util.rs:50:20 [INFO] [stdout] | [INFO] [stdout] 50 | File::open(&pagemap_path).map_err(|err| format!("Open {} err: {}", &pagemap_path, err))?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `pagemap_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/util.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | return Err(format!("Read page table entry err")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Read page table entry err".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/util.rs:91:10 [INFO] [stdout] | [INFO] [stdout] 91 | (&s[2..], 16) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/util.rs:90:24 [INFO] [stdout] | [INFO] [stdout] 90 | let (src, radix) = if s.starts_with("0x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 90 ~ let (src, radix) = if let Some() = s.strip_prefix("0x") { [INFO] [stdout] 91 ~ (, 16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/util.rs:93:10 [INFO] [stdout] | [INFO] [stdout] 93 | (&s[2..], 2) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/util.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | } else if s.starts_with("0b") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 92 ~ } else if let Some() = s.strip_prefix("0b") { [INFO] [stdout] 93 ~ (, 2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | struct CLI { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:131:20 [INFO] [stdout] | [INFO] [stdout] 131 | return Err(String::from(format!("File {} not exists!", file))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("File {} not exists!", file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SDL` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | SDL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sdl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.36s [INFO] running `Command { std: "docker" "inspect" "8854a5762567feb56a72fa9d862c28fc65e22ab7616ac79213ab226bf2d15468", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8854a5762567feb56a72fa9d862c28fc65e22ab7616ac79213ab226bf2d15468", kill_on_drop: false }` [INFO] [stdout] 8854a5762567feb56a72fa9d862c28fc65e22ab7616ac79213ab226bf2d15468