[INFO] cloning repository https://github.com/trimscash/skiphead [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/trimscash/skiphead" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftrimscash%2Fskiphead", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftrimscash%2Fskiphead'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8c4db5ed1f6d1f4e0d66a8ce6a8258c9558ae3a6 [INFO] linting trimscash/skiphead against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftrimscash%2Fskiphead" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/trimscash/skiphead [INFO] finished tweaking git repo https://github.com/trimscash/skiphead [INFO] tweaked toml for git repo https://github.com/trimscash/skiphead written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/trimscash/skiphead on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/trimscash/skiphead already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded termion v3.0.0 [INFO] [stderr] Downloaded file-format v0.24.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 94540342d67a263d231827a95561fdfb651539102b6b5aa1c069d7e993ad5cfb [INFO] running `Command { std: "docker" "start" "-a" "94540342d67a263d231827a95561fdfb651539102b6b5aa1c069d7e993ad5cfb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "94540342d67a263d231827a95561fdfb651539102b6b5aa1c069d7e993ad5cfb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94540342d67a263d231827a95561fdfb651539102b6b5aa1c069d7e993ad5cfb", kill_on_drop: false }` [INFO] [stdout] 94540342d67a263d231827a95561fdfb651539102b6b5aa1c069d7e993ad5cfb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1bd51fd45a7396b67f343f4fd5b27d0d12640a35ff9665fea57567bad9e507c [INFO] running `Command { std: "docker" "start" "-a" "f1bd51fd45a7396b67f343f4fd5b27d0d12640a35ff9665fea57567bad9e507c", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking file-format v0.24.0 [INFO] [stderr] Checking termion v3.0.0 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking skiphead v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use termion; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use termion; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | let mut cmd = Args::command(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cmd` [INFO] [stdout] --> src/main.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | let mut cmd = Args::command(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cmd` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `is_non_bin` is never read [INFO] [stdout] --> src/main.rs:258:32 [INFO] [stdout] | [INFO] [stdout] 258 | let mut is_non_bin: bool = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:257:12 [INFO] [stdout] | [INFO] [stdout] 257 | #[warn(unused_assignments)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/main.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | let bar: String = iter::repeat("-").take(col as usize).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"-".repeat(col as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] = note: `#[warn(clippy::manual_str_repeat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/main.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | let bar: String = iter::repeat("-").take(col as usize).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("-", col as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:65:18 [INFO] [stdout] | [INFO] [stdout] 65 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 ~ Ok(_) => Ok(()), [INFO] [stdout] 66 | Err(e) => { [INFO] [stdout] ... [INFO] [stdout] 69 | } [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | return Err(e); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 ~ Err(e) [INFO] [stdout] 69 | } [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:78:10 [INFO] [stdout] | [INFO] [stdout] 78 | buf: &Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - buf: &Vec, [INFO] [stdout] 78 + buf: &[u8], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 173 | if !fs::metadata(&args.output_directory).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&args.output_directory).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | / if args.export_file { [INFO] [stdout] 173 | | if !fs::metadata(&args.output_directory).is_ok() { [INFO] [stdout] 174 | | let _ = match fs::create_dir(&args.output_directory) { [INFO] [stdout] 175 | | Ok(f) => f, [INFO] [stdout] ... | [INFO] [stdout] 182 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ if args.export_file [INFO] [stdout] 173 ~ && !fs::metadata(&args.output_directory).is_ok() { [INFO] [stdout] 174 | let _ = match fs::create_dir(&args.output_directory) { [INFO] [stdout] ... [INFO] [stdout] 180 | }; [INFO] [stdout] 181 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | / let _ = match fs::create_dir(&args.output_directory) { [INFO] [stdout] 175 | | Ok(f) => f, [INFO] [stdout] 176 | | Err(_) => { [INFO] [stdout] 177 | | println!("Can't create {} directory..", &args.output_directory); [INFO] [stdout] ... | [INFO] [stdout] 180 | | }; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 174 - let _ = match fs::create_dir(&args.output_directory) { [INFO] [stdout] 174 + match fs::create_dir(&args.output_directory) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:239:8 [INFO] [stdout] | [INFO] [stdout] 239 | if exists_non_bin == false && args.only { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!exists_non_bin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return Ok(is_non_bin); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return Ok(is_non_bin); [INFO] [stdout] 291 + Ok(is_non_bin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:254:85 [INFO] [stdout] | [INFO] [stdout] 254 | skiped_and_picked_file_buf(skip_num, pick_offset, pick_length, file_offset, &file_buf); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `file_buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | let mut cmd = Args::command(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cmd` [INFO] [stdout] --> src/main.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | let mut cmd = Args::command(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cmd` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `is_non_bin` is never read [INFO] [stdout] --> src/main.rs:258:32 [INFO] [stdout] | [INFO] [stdout] 258 | let mut is_non_bin: bool = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:257:12 [INFO] [stdout] | [INFO] [stdout] 257 | #[warn(unused_assignments)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/main.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | let bar: String = iter::repeat("-").take(col as usize).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"-".repeat(col as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] = note: `#[warn(clippy::manual_str_repeat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/main.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | let bar: String = iter::repeat("-").take(col as usize).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("-", col as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:65:18 [INFO] [stdout] | [INFO] [stdout] 65 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 ~ Ok(_) => Ok(()), [INFO] [stdout] 66 | Err(e) => { [INFO] [stdout] ... [INFO] [stdout] 69 | } [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | return Err(e); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 ~ Err(e) [INFO] [stdout] 69 | } [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:78:10 [INFO] [stdout] | [INFO] [stdout] 78 | buf: &Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - buf: &Vec, [INFO] [stdout] 78 + buf: &[u8], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 173 | if !fs::metadata(&args.output_directory).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&args.output_directory).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | / if args.export_file { [INFO] [stdout] 173 | | if !fs::metadata(&args.output_directory).is_ok() { [INFO] [stdout] 174 | | let _ = match fs::create_dir(&args.output_directory) { [INFO] [stdout] 175 | | Ok(f) => f, [INFO] [stdout] ... | [INFO] [stdout] 182 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ if args.export_file [INFO] [stdout] 173 ~ && !fs::metadata(&args.output_directory).is_ok() { [INFO] [stdout] 174 | let _ = match fs::create_dir(&args.output_directory) { [INFO] [stdout] ... [INFO] [stdout] 180 | }; [INFO] [stdout] 181 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | / let _ = match fs::create_dir(&args.output_directory) { [INFO] [stdout] 175 | | Ok(f) => f, [INFO] [stdout] 176 | | Err(_) => { [INFO] [stdout] 177 | | println!("Can't create {} directory..", &args.output_directory); [INFO] [stdout] ... | [INFO] [stdout] 180 | | }; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 174 - let _ = match fs::create_dir(&args.output_directory) { [INFO] [stdout] 174 + match fs::create_dir(&args.output_directory) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:239:8 [INFO] [stdout] | [INFO] [stdout] 239 | if exists_non_bin == false && args.only { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!exists_non_bin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return Ok(is_non_bin); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return Ok(is_non_bin); [INFO] [stdout] 291 + Ok(is_non_bin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:254:85 [INFO] [stdout] | [INFO] [stdout] 254 | skiped_and_picked_file_buf(skip_num, pick_offset, pick_length, file_offset, &file_buf); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `file_buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.75s [INFO] running `Command { std: "docker" "inspect" "f1bd51fd45a7396b67f343f4fd5b27d0d12640a35ff9665fea57567bad9e507c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1bd51fd45a7396b67f343f4fd5b27d0d12640a35ff9665fea57567bad9e507c", kill_on_drop: false }` [INFO] [stdout] f1bd51fd45a7396b67f343f4fd5b27d0d12640a35ff9665fea57567bad9e507c