[INFO] cloning repository https://github.com/trifledmatter/forgescript [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/trifledmatter/forgescript" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftrifledmatter%2Fforgescript", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftrifledmatter%2Fforgescript'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 056bae6b38c82bb3d55ad83db049b05bd797cd9e [INFO] linting trifledmatter/forgescript against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftrifledmatter%2Fforgescript" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/trifledmatter/forgescript [INFO] finished tweaking git repo https://github.com/trifledmatter/forgescript [INFO] tweaked toml for git repo https://github.com/trifledmatter/forgescript written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/trifledmatter/forgescript on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/trifledmatter/forgescript already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1cf5229f413a0da411699503b5a91569771ed585373ff42b00ef22dc9aae4793 [INFO] running `Command { std: "docker" "start" "-a" "1cf5229f413a0da411699503b5a91569771ed585373ff42b00ef22dc9aae4793", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1cf5229f413a0da411699503b5a91569771ed585373ff42b00ef22dc9aae4793", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cf5229f413a0da411699503b5a91569771ed585373ff42b00ef22dc9aae4793", kill_on_drop: false }` [INFO] [stdout] 1cf5229f413a0da411699503b5a91569771ed585373ff42b00ef22dc9aae4793 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ded055c9239e73e65ad3c1824a0cf08e5de33e44f63eef29f75d9d0d90bdb059 [INFO] running `Command { std: "docker" "start" "-a" "ded055c9239e73e65ad3c1824a0cf08e5de33e44f63eef29f75d9d0d90bdb059", kill_on_drop: false }` [INFO] [stderr] Checking ForgeLang v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lexer.rs:138:15 [INFO] [stdout] | [INFO] [stdout] 138 | while self [INFO] [stdout] | _______________^ [INFO] [stdout] 139 | | .peek() [INFO] [stdout] 140 | | .map_or(false, |c| c.is_alphanumeric() || c == '_') [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 140 - .map_or(false, |c| c.is_alphanumeric() || c == '_') [INFO] [stdout] 140 + .is_some_and(|c| c.is_alphanumeric() || c == '_') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lexer.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 162 | while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 162 - while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] 162 + while self.peek().is_some_and(|c| c.is_digit(10)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:162:45 [INFO] [stdout] | [INFO] [stdout] 162 | while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lexer.rs:166:40 [INFO] [stdout] | [INFO] [stdout] 166 | if self.peek() == Some('.') && self.peek_next().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 166 - if self.peek() == Some('.') && self.peek_next().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] 166 + if self.peek() == Some('.') && self.peek_next().is_some_and(|c| c.is_digit(10)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:166:75 [INFO] [stdout] | [INFO] [stdout] 166 | if self.peek() == Some('.') && self.peek_next().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lexer.rs:168:19 [INFO] [stdout] | [INFO] [stdout] 168 | while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 168 - while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] 168 + while self.peek().is_some_and(|c| c.is_digit(10)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:168:49 [INFO] [stdout] | [INFO] [stdout] 168 | while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:160:42 [INFO] [stdout] | [INFO] [stdout] 160 | fn visit_identifier(&mut self, name: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:162:45 [INFO] [stdout] | [INFO] [stdout] 162 | fn visit_function_call(&mut self, name: &String, args: &[Expr]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:164:64 [INFO] [stdout] | [INFO] [stdout] 164 | fn visit_property_access(&mut self, expr: &Expr, property: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:170:48 [INFO] [stdout] | [INFO] [stdout] 170 | fn visit_cast(&mut self, expr: &Expr, typ: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:171:36 [INFO] [stdout] | [INFO] [stdout] 171 | fn visit_error(&mut self, msg: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:177:52 [INFO] [stdout] | [INFO] [stdout] 177 | fn visit_variable_declaration(&mut self, name: &String, init: &Option, is_mut: bool) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:178:52 [INFO] [stdout] | [INFO] [stdout] 178 | fn visit_function_declaration(&mut self, name: &String, params: &[(String, String)], return_type: &String, body: &[Box]) ... [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:178:103 [INFO] [stdout] | [INFO] [stdout] 178 | ...ng, params: &[(String, String)], return_type: &String, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:181:34 [INFO] [stdout] | [INFO] [stdout] 181 | fn visit_for(&mut self, var: &String, start: &Expr, end: &Expr, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:182:39 [INFO] [stdout] | [INFO] [stdout] 182 | fn visit_for_each(&mut self, var: &String, collection: &Expr, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:187:40 [INFO] [stdout] | [INFO] [stdout] 187 | fn visit_import(&mut self, module: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:188:48 [INFO] [stdout] | [INFO] [stdout] 188 | fn visit_type_declaration(&mut self, name: &String, fields: &[(String, String)]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:189:49 [INFO] [stdout] | [INFO] [stdout] 189 | fn visit_class_declaration(&mut self, name: &String, fields: &[(String, String)], methods: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:190:50 [INFO] [stdout] | [INFO] [stdout] 190 | fn visit_method_declaration(&mut self, name: &String, params: &[(String, String)], return_type: &String, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:190:101 [INFO] [stdout] | [INFO] [stdout] 190 | fn visit_method_declaration(&mut self, name: &String, params: &[(String, String)], return_type: &String, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:191:38 [INFO] [stdout] | [INFO] [stdout] 191 | fn visit_module(&mut self, name: &String, stmts: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:193:57 [INFO] [stdout] | [INFO] [stdout] 193 | fn visit_schedule(&mut self, stmt: &Stmt, interval: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:194:48 [INFO] [stdout] | [INFO] [stdout] 194 | fn visit_macro_definition(&mut self, name: &String, params: &[String], body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:195:48 [INFO] [stdout] | [INFO] [stdout] 195 | fn visit_foreign_function(&mut self, lang: &String, name: &String, params: &[(String, String)], return_type: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:195:63 [INFO] [stdout] | [INFO] [stdout] 195 | fn visit_foreign_function(&mut self, lang: &String, name: &String, params: &[(String, String)], return_type: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:195:114 [INFO] [stdout] | [INFO] [stdout] 195 | fn visit_foreign_function(&mut self, lang: &String, name: &String, params: &[(String, String)], return_type: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | write!(f, ") -> {} do\n", return_type)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 400 - write!(f, ") -> {} do\n", return_type)?; [INFO] [stdout] 400 + writeln!(f, ") -> {} do", return_type)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:402:21 [INFO] [stdout] | [INFO] [stdout] 402 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 402 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 402 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:407:17 [INFO] [stdout] | [INFO] [stdout] 407 | write!(f, "if {} do\n", cond)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 407 - write!(f, "if {} do\n", cond)?; [INFO] [stdout] 407 + writeln!(f, "if {} do", cond)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:409:21 [INFO] [stdout] | [INFO] [stdout] 409 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 409 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 409 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:411:17 [INFO] [stdout] | [INFO] [stdout] 411 | write!(f, "end else do\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 411 - write!(f, "end else do\n")?; [INFO] [stdout] 411 + writeln!(f, "end else do")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:413:21 [INFO] [stdout] | [INFO] [stdout] 413 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 413 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 413 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:418:17 [INFO] [stdout] | [INFO] [stdout] 418 | write!(f, "if {} do\n", cond)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 418 - write!(f, "if {} do\n", cond)?; [INFO] [stdout] 418 + writeln!(f, "if {} do", cond)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:420:21 [INFO] [stdout] | [INFO] [stdout] 420 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 420 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 420 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:425:17 [INFO] [stdout] | [INFO] [stdout] 425 | write!(f, "while {} do\n", cond)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 425 - write!(f, "while {} do\n", cond)?; [INFO] [stdout] 425 + writeln!(f, "while {} do", cond)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:427:21 [INFO] [stdout] | [INFO] [stdout] 427 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 427 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 427 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:432:17 [INFO] [stdout] | [INFO] [stdout] 432 | write!(f, "for {} in {}..{} do\n", var, start, end)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 432 - write!(f, "for {} in {}..{} do\n", var, start, end)?; [INFO] [stdout] 432 + writeln!(f, "for {} in {}..{} do", var, start, end)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:434:21 [INFO] [stdout] | [INFO] [stdout] 434 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 434 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 434 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:439:17 [INFO] [stdout] | [INFO] [stdout] 439 | write!(f, "foreach {} in {} do\n", var, collection)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 439 - write!(f, "foreach {} in {} do\n", var, collection)?; [INFO] [stdout] 439 + writeln!(f, "foreach {} in {} do", var, collection)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:441:21 [INFO] [stdout] | [INFO] [stdout] 441 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 441 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 441 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:446:17 [INFO] [stdout] | [INFO] [stdout] 446 | write!(f, "do\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 446 - write!(f, "do\n")?; [INFO] [stdout] 446 + writeln!(f, "do")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:448:21 [INFO] [stdout] | [INFO] [stdout] 448 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 448 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 448 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:458:17 [INFO] [stdout] | [INFO] [stdout] 458 | write!(f, "type {} do\n", name)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 458 - write!(f, "type {} do\n", name)?; [INFO] [stdout] 458 + writeln!(f, "type {} do", name)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:460:21 [INFO] [stdout] | [INFO] [stdout] 460 | write!(f, "{}: {},\n", field_name, field_type)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 460 - write!(f, "{}: {},\n", field_name, field_type)?; [INFO] [stdout] 460 + writeln!(f, "{}: {},", field_name, field_type)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:465:17 [INFO] [stdout] | [INFO] [stdout] 465 | write!(f, "class {} do\n", name)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 465 - write!(f, "class {} do\n", name)?; [INFO] [stdout] 465 + writeln!(f, "class {} do", name)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:467:21 [INFO] [stdout] | [INFO] [stdout] 467 | write!(f, "{}: {},\n", field_name, field_type)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 467 - write!(f, "{}: {},\n", field_name, field_type)?; [INFO] [stdout] 467 + writeln!(f, "{}: {},", field_name, field_type)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:470:21 [INFO] [stdout] | [INFO] [stdout] 470 | write!(f, "{}\n", method)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 470 - write!(f, "{}\n", method)?; [INFO] [stdout] 470 + writeln!(f, "{}", method)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:482:17 [INFO] [stdout] | [INFO] [stdout] 482 | write!(f, ") -> {} do\n", return_type)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 482 - write!(f, ") -> {} do\n", return_type)?; [INFO] [stdout] 482 + writeln!(f, ") -> {} do", return_type)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:484:21 [INFO] [stdout] | [INFO] [stdout] 484 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 484 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 484 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:489:17 [INFO] [stdout] | [INFO] [stdout] 489 | write!(f, "module {} do\n", name)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 489 - write!(f, "module {} do\n", name)?; [INFO] [stdout] 489 + writeln!(f, "module {} do", name)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:491:21 [INFO] [stdout] | [INFO] [stdout] 491 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 491 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 491 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:509:17 [INFO] [stdout] | [INFO] [stdout] 509 | write!(f, ") do\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 509 - write!(f, ") do\n")?; [INFO] [stdout] 509 + writeln!(f, ") do")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:511:21 [INFO] [stdout] | [INFO] [stdout] 511 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 511 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 511 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:516:17 [INFO] [stdout] | [INFO] [stdout] 516 | write!(f, "ffi \"{}\" do\n", lang)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 516 - write!(f, "ffi \"{}\" do\n", lang)?; [INFO] [stdout] 516 + writeln!(f, "ffi \"{}\" do", lang)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 142 | while !(self.peek().unwrap().lexeme == "end") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.peek().unwrap().lexeme != "end")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/parser.rs:861:35 [INFO] [stdout] | [INFO] [stdout] 861 | fn block(&mut self) -> Result>, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/parser.rs:1063:17 [INFO] [stdout] | [INFO] [stdout] 1063 | assert_eq!(*value, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1063 - assert_eq!(*value, true); [INFO] [stdout] 1063 + assert!(*value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/parser.rs:1085:17 [INFO] [stdout] | [INFO] [stdout] 1085 | assert_eq!(*value, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1085 - assert_eq!(*value, true); [INFO] [stdout] 1085 + assert!(*value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - fn main() { [INFO] [stdout] 8 - return; [INFO] [stdout] 7 + fn main() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lexer.rs:347:24 [INFO] [stdout] | [INFO] [stdout] 347 | let expected = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 348 | | TokenType::Identifier, [INFO] [stdout] 349 | | TokenType::Identifier, [INFO] [stdout] 350 | | TokenType::Identifier, [INFO] [stdout] 351 | | TokenType::Eof, [INFO] [stdout] 352 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 347 ~ let expected = [TokenType::Identifier, [INFO] [stdout] 348 + TokenType::Identifier, [INFO] [stdout] 349 + TokenType::Identifier, [INFO] [stdout] 350 ~ TokenType::Eof]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lexer.rs:367:24 [INFO] [stdout] | [INFO] [stdout] 367 | let expected = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 368 | | TokenType::Number, [INFO] [stdout] 369 | | TokenType::Number, [INFO] [stdout] 370 | | TokenType::Number, [INFO] [stdout] 371 | | TokenType::Number, [INFO] [stdout] 372 | | TokenType::Eof, [INFO] [stdout] 373 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 367 ~ let expected = [TokenType::Number, [INFO] [stdout] 368 + TokenType::Number, [INFO] [stdout] 369 + TokenType::Number, [INFO] [stdout] 370 + TokenType::Number, [INFO] [stdout] 371 ~ TokenType::Eof]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lexer.rs:425:24 [INFO] [stdout] | [INFO] [stdout] 425 | let expected = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 426 | | TokenType::StringLiteral, [INFO] [stdout] 427 | | TokenType::StringLiteral, [INFO] [stdout] 428 | | TokenType::StringLiteral, [INFO] [stdout] 429 | | TokenType::Eof, [INFO] [stdout] 430 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 425 ~ let expected = [TokenType::StringLiteral, [INFO] [stdout] 426 + TokenType::StringLiteral, [INFO] [stdout] 427 + TokenType::StringLiteral, [INFO] [stdout] 428 ~ TokenType::Eof]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lexer.rs:138:15 [INFO] [stdout] | [INFO] [stdout] 138 | while self [INFO] [stdout] | _______________^ [INFO] [stdout] 139 | | .peek() [INFO] [stdout] 140 | | .map_or(false, |c| c.is_alphanumeric() || c == '_') [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 140 - .map_or(false, |c| c.is_alphanumeric() || c == '_') [INFO] [stdout] 140 + .is_some_and(|c| c.is_alphanumeric() || c == '_') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lexer.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 162 | while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 162 - while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] 162 + while self.peek().is_some_and(|c| c.is_digit(10)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:162:45 [INFO] [stdout] | [INFO] [stdout] 162 | while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lexer.rs:166:40 [INFO] [stdout] | [INFO] [stdout] 166 | if self.peek() == Some('.') && self.peek_next().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 166 - if self.peek() == Some('.') && self.peek_next().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] 166 + if self.peek() == Some('.') && self.peek_next().is_some_and(|c| c.is_digit(10)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:166:75 [INFO] [stdout] | [INFO] [stdout] 166 | if self.peek() == Some('.') && self.peek_next().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lexer.rs:168:19 [INFO] [stdout] | [INFO] [stdout] 168 | while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 168 - while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] 168 + while self.peek().is_some_and(|c| c.is_digit(10)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:168:49 [INFO] [stdout] | [INFO] [stdout] 168 | while self.peek().map_or(false, |c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:160:42 [INFO] [stdout] | [INFO] [stdout] 160 | fn visit_identifier(&mut self, name: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:162:45 [INFO] [stdout] | [INFO] [stdout] 162 | fn visit_function_call(&mut self, name: &String, args: &[Expr]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:164:64 [INFO] [stdout] | [INFO] [stdout] 164 | fn visit_property_access(&mut self, expr: &Expr, property: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:170:48 [INFO] [stdout] | [INFO] [stdout] 170 | fn visit_cast(&mut self, expr: &Expr, typ: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:171:36 [INFO] [stdout] | [INFO] [stdout] 171 | fn visit_error(&mut self, msg: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:177:52 [INFO] [stdout] | [INFO] [stdout] 177 | fn visit_variable_declaration(&mut self, name: &String, init: &Option, is_mut: bool) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:178:52 [INFO] [stdout] | [INFO] [stdout] 178 | fn visit_function_declaration(&mut self, name: &String, params: &[(String, String)], return_type: &String, body: &[Box]) ... [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:178:103 [INFO] [stdout] | [INFO] [stdout] 178 | ...ng, params: &[(String, String)], return_type: &String, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:181:34 [INFO] [stdout] | [INFO] [stdout] 181 | fn visit_for(&mut self, var: &String, start: &Expr, end: &Expr, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:182:39 [INFO] [stdout] | [INFO] [stdout] 182 | fn visit_for_each(&mut self, var: &String, collection: &Expr, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:187:40 [INFO] [stdout] | [INFO] [stdout] 187 | fn visit_import(&mut self, module: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:188:48 [INFO] [stdout] | [INFO] [stdout] 188 | fn visit_type_declaration(&mut self, name: &String, fields: &[(String, String)]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:189:49 [INFO] [stdout] | [INFO] [stdout] 189 | fn visit_class_declaration(&mut self, name: &String, fields: &[(String, String)], methods: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:190:50 [INFO] [stdout] | [INFO] [stdout] 190 | fn visit_method_declaration(&mut self, name: &String, params: &[(String, String)], return_type: &String, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:190:101 [INFO] [stdout] | [INFO] [stdout] 190 | fn visit_method_declaration(&mut self, name: &String, params: &[(String, String)], return_type: &String, body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:191:38 [INFO] [stdout] | [INFO] [stdout] 191 | fn visit_module(&mut self, name: &String, stmts: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:193:57 [INFO] [stdout] | [INFO] [stdout] 193 | fn visit_schedule(&mut self, stmt: &Stmt, interval: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:194:48 [INFO] [stdout] | [INFO] [stdout] 194 | fn visit_macro_definition(&mut self, name: &String, params: &[String], body: &[Box]) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:195:48 [INFO] [stdout] | [INFO] [stdout] 195 | fn visit_foreign_function(&mut self, lang: &String, name: &String, params: &[(String, String)], return_type: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:195:63 [INFO] [stdout] | [INFO] [stdout] 195 | fn visit_foreign_function(&mut self, lang: &String, name: &String, params: &[(String, String)], return_type: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/ast.rs:195:114 [INFO] [stdout] | [INFO] [stdout] 195 | fn visit_foreign_function(&mut self, lang: &String, name: &String, params: &[(String, String)], return_type: &String) -> T; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | write!(f, ") -> {} do\n", return_type)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 400 - write!(f, ") -> {} do\n", return_type)?; [INFO] [stdout] 400 + writeln!(f, ") -> {} do", return_type)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:402:21 [INFO] [stdout] | [INFO] [stdout] 402 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 402 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 402 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:407:17 [INFO] [stdout] | [INFO] [stdout] 407 | write!(f, "if {} do\n", cond)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 407 - write!(f, "if {} do\n", cond)?; [INFO] [stdout] 407 + writeln!(f, "if {} do", cond)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:409:21 [INFO] [stdout] | [INFO] [stdout] 409 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 409 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 409 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:411:17 [INFO] [stdout] | [INFO] [stdout] 411 | write!(f, "end else do\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 411 - write!(f, "end else do\n")?; [INFO] [stdout] 411 + writeln!(f, "end else do")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:413:21 [INFO] [stdout] | [INFO] [stdout] 413 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 413 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 413 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:418:17 [INFO] [stdout] | [INFO] [stdout] 418 | write!(f, "if {} do\n", cond)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 418 - write!(f, "if {} do\n", cond)?; [INFO] [stdout] 418 + writeln!(f, "if {} do", cond)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:420:21 [INFO] [stdout] | [INFO] [stdout] 420 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 420 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 420 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:425:17 [INFO] [stdout] | [INFO] [stdout] 425 | write!(f, "while {} do\n", cond)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 425 - write!(f, "while {} do\n", cond)?; [INFO] [stdout] 425 + writeln!(f, "while {} do", cond)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:427:21 [INFO] [stdout] | [INFO] [stdout] 427 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 427 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 427 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:432:17 [INFO] [stdout] | [INFO] [stdout] 432 | write!(f, "for {} in {}..{} do\n", var, start, end)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 432 - write!(f, "for {} in {}..{} do\n", var, start, end)?; [INFO] [stdout] 432 + writeln!(f, "for {} in {}..{} do", var, start, end)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:434:21 [INFO] [stdout] | [INFO] [stdout] 434 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 434 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 434 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:439:17 [INFO] [stdout] | [INFO] [stdout] 439 | write!(f, "foreach {} in {} do\n", var, collection)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 439 - write!(f, "foreach {} in {} do\n", var, collection)?; [INFO] [stdout] 439 + writeln!(f, "foreach {} in {} do", var, collection)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:441:21 [INFO] [stdout] | [INFO] [stdout] 441 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 441 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 441 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:446:17 [INFO] [stdout] | [INFO] [stdout] 446 | write!(f, "do\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 446 - write!(f, "do\n")?; [INFO] [stdout] 446 + writeln!(f, "do")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:448:21 [INFO] [stdout] | [INFO] [stdout] 448 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 448 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 448 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:458:17 [INFO] [stdout] | [INFO] [stdout] 458 | write!(f, "type {} do\n", name)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 458 - write!(f, "type {} do\n", name)?; [INFO] [stdout] 458 + writeln!(f, "type {} do", name)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:460:21 [INFO] [stdout] | [INFO] [stdout] 460 | write!(f, "{}: {},\n", field_name, field_type)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 460 - write!(f, "{}: {},\n", field_name, field_type)?; [INFO] [stdout] 460 + writeln!(f, "{}: {},", field_name, field_type)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:465:17 [INFO] [stdout] | [INFO] [stdout] 465 | write!(f, "class {} do\n", name)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 465 - write!(f, "class {} do\n", name)?; [INFO] [stdout] 465 + writeln!(f, "class {} do", name)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:467:21 [INFO] [stdout] | [INFO] [stdout] 467 | write!(f, "{}: {},\n", field_name, field_type)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 467 - write!(f, "{}: {},\n", field_name, field_type)?; [INFO] [stdout] 467 + writeln!(f, "{}: {},", field_name, field_type)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:470:21 [INFO] [stdout] | [INFO] [stdout] 470 | write!(f, "{}\n", method)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 470 - write!(f, "{}\n", method)?; [INFO] [stdout] 470 + writeln!(f, "{}", method)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:482:17 [INFO] [stdout] | [INFO] [stdout] 482 | write!(f, ") -> {} do\n", return_type)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 482 - write!(f, ") -> {} do\n", return_type)?; [INFO] [stdout] 482 + writeln!(f, ") -> {} do", return_type)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:484:21 [INFO] [stdout] | [INFO] [stdout] 484 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 484 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 484 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:489:17 [INFO] [stdout] | [INFO] [stdout] 489 | write!(f, "module {} do\n", name)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 489 - write!(f, "module {} do\n", name)?; [INFO] [stdout] 489 + writeln!(f, "module {} do", name)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:491:21 [INFO] [stdout] | [INFO] [stdout] 491 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 491 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 491 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:509:17 [INFO] [stdout] | [INFO] [stdout] 509 | write!(f, ") do\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 509 - write!(f, ") do\n")?; [INFO] [stdout] 509 + writeln!(f, ") do")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:511:21 [INFO] [stdout] | [INFO] [stdout] 511 | write!(f, "{}\n", stmt)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 511 - write!(f, "{}\n", stmt)?; [INFO] [stdout] 511 + writeln!(f, "{}", stmt)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/ast.rs:516:17 [INFO] [stdout] | [INFO] [stdout] 516 | write!(f, "ffi \"{}\" do\n", lang)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 516 - write!(f, "ffi \"{}\" do\n", lang)?; [INFO] [stdout] 516 + writeln!(f, "ffi \"{}\" do", lang)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 142 | while !(self.peek().unwrap().lexeme == "end") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.peek().unwrap().lexeme != "end")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/parser.rs:861:35 [INFO] [stdout] | [INFO] [stdout] 861 | fn block(&mut self) -> Result>, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - fn main() { [INFO] [stdout] 8 - return; [INFO] [stdout] 7 + fn main() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.96s [INFO] running `Command { std: "docker" "inspect" "ded055c9239e73e65ad3c1824a0cf08e5de33e44f63eef29f75d9d0d90bdb059", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ded055c9239e73e65ad3c1824a0cf08e5de33e44f63eef29f75d9d0d90bdb059", kill_on_drop: false }` [INFO] [stdout] ded055c9239e73e65ad3c1824a0cf08e5de33e44f63eef29f75d9d0d90bdb059