[INFO] cloning repository https://github.com/tribhuwan-kumar/rskill [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tribhuwan-kumar/rskill" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftribhuwan-kumar%2Frskill", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftribhuwan-kumar%2Frskill'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 12af54c83ed5d9ebfbabfa2cf114517febcfdb31 [INFO] linting tribhuwan-kumar/rskill against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftribhuwan-kumar%2Frskill" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tribhuwan-kumar/rskill [INFO] finished tweaking git repo https://github.com/tribhuwan-kumar/rskill [INFO] tweaked toml for git repo https://github.com/tribhuwan-kumar/rskill written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tribhuwan-kumar/rskill on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tribhuwan-kumar/rskill already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded indoc v2.0.6 [INFO] [stderr] Downloaded unicode-truncate v1.1.0 [INFO] [stderr] Downloaded derive_setters v0.1.8 [INFO] [stderr] Downloaded libredox v0.1.4 [INFO] [stderr] Downloaded if_chain v1.0.2 [INFO] [stderr] Downloaded derive_builder_macro v0.20.2 [INFO] [stderr] Downloaded instability v0.3.7 [INFO] [stderr] Downloaded tui-big-text v0.7.1 [INFO] [stderr] Downloaded font8x8 v0.3.1 [INFO] [stderr] Downloaded spinoff v0.7.0 [INFO] [stderr] Downloaded cassowary v0.3.0 [INFO] [stderr] Downloaded derive_builder_core v0.20.2 [INFO] [stderr] Downloaded derive_builder v0.20.2 [INFO] [stderr] Downloaded crossterm v0.28.1 [INFO] [stderr] Downloaded tui-popup v0.6.0 [INFO] [stderr] Downloaded crossterm v0.26.1 [INFO] [stderr] Downloaded ratatui v0.20.1 [INFO] [stderr] Downloaded ratatui v0.29.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0034bc22426493f4b19fde15e56b1b14ae020d55c4ed3f3094a8778a3a696360 [INFO] running `Command { std: "docker" "start" "-a" "0034bc22426493f4b19fde15e56b1b14ae020d55c4ed3f3094a8778a3a696360", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0034bc22426493f4b19fde15e56b1b14ae020d55c4ed3f3094a8778a3a696360", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0034bc22426493f4b19fde15e56b1b14ae020d55c4ed3f3094a8778a3a696360", kill_on_drop: false }` [INFO] [stdout] 0034bc22426493f4b19fde15e56b1b14ae020d55c4ed3f3094a8778a3a696360 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf40be7cba3a2759d27012fb1660e0c8c8ea4698d859e3090156674e5f23a23e [INFO] running `Command { std: "docker" "start" "-a" "cf40be7cba3a2759d27012fb1660e0c8c8ea4698d859e3090156674e5f23a23e", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking font8x8 v0.3.1 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking spinoff v0.7.0 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking if_chain v1.0.2 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking ratatui v0.20.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling derive-getters v0.5.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking tokio v1.46.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling instability v0.3.7 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Compiling derive_setters v0.1.8 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking tui-popup v0.6.0 [INFO] [stderr] Checking tui-big-text v0.7.1 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking rskill v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/scanner.rs:282:32 [INFO] [stdout] | [INFO] [stdout] 282 | fn sort_projects(projects: &mut Vec, sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 282 - fn sort_projects(projects: &mut Vec, sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] 282 + fn sort_projects(projects: &mut [RustProject], sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/scanner.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 285 | projects.sort_by(|a, b| b.total_cleanable_size().cmp(&a.total_cleanable_size())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - projects.sort_by(|a, b| b.total_cleanable_size().cmp(&a.total_cleanable_size())); [INFO] [stdout] 285 + projects.sort_by_key(|b| std::cmp::Reverse(b.total_cleanable_size())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scanner.rs:341:23 [INFO] [stdout] | [INFO] [stdout] 341 | } else if !project.target_dir.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project.target_dir.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ui.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 160 | let text = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 161 | | format!("{} projects | {} cleanable", total_projects, total_size_str), [INFO] [stdout] 162 | | format!("{} deleted ({})", self.deleted_count, deleted_size_str), [INFO] [stdout] 163 | | "↑↓/jk: navigate | space/del/D: delete | o: open | r: refresh | q: quit".to_string(), [INFO] [stdout] 164 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 160 ~ let text = [format!("{} projects | {} cleanable", total_projects, total_size_str), [INFO] [stdout] 161 + format!("{} deleted ({})", self.deleted_count, deleted_size_str), [INFO] [stdout] 162 ~ "↑↓/jk: navigate | space/del/D: delete | o: open | r: refresh | q: quit".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/scanner.rs:282:32 [INFO] [stdout] | [INFO] [stdout] 282 | fn sort_projects(projects: &mut Vec, sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 282 - fn sort_projects(projects: &mut Vec, sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] 282 + fn sort_projects(projects: &mut [RustProject], sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/scanner.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 285 | projects.sort_by(|a, b| b.total_cleanable_size().cmp(&a.total_cleanable_size())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - projects.sort_by(|a, b| b.total_cleanable_size().cmp(&a.total_cleanable_size())); [INFO] [stdout] 285 + projects.sort_by_key(|b| std::cmp::Reverse(b.total_cleanable_size())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scanner.rs:341:23 [INFO] [stdout] | [INFO] [stdout] 341 | } else if !project.target_dir.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project.target_dir.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ui.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 160 | let text = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 161 | | format!("{} projects | {} cleanable", total_projects, total_size_str), [INFO] [stdout] 162 | | format!("{} deleted ({})", self.deleted_count, deleted_size_str), [INFO] [stdout] 163 | | "↑↓/jk: navigate | space/del/D: delete | o: open | r: refresh | q: quit".to_string(), [INFO] [stdout] 164 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 160 ~ let text = [format!("{} projects | {} cleanable", total_projects, total_size_str), [INFO] [stdout] 161 + format!("{} deleted ({})", self.deleted_count, deleted_size_str), [INFO] [stdout] 162 ~ "↑↓/jk: navigate | space/del/D: delete | o: open | r: refresh | q: quit".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.77s [INFO] running `Command { std: "docker" "inspect" "cf40be7cba3a2759d27012fb1660e0c8c8ea4698d859e3090156674e5f23a23e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf40be7cba3a2759d27012fb1660e0c8c8ea4698d859e3090156674e5f23a23e", kill_on_drop: false }` [INFO] [stdout] cf40be7cba3a2759d27012fb1660e0c8c8ea4698d859e3090156674e5f23a23e