[INFO] cloning repository https://github.com/tplaysted/fast-dedup [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tplaysted/fast-dedup" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftplaysted%2Ffast-dedup", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftplaysted%2Ffast-dedup'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5b77bd2a9ab30514610e32efa077380c6c60ec6b [INFO] linting tplaysted/fast-dedup against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftplaysted%2Ffast-dedup" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tplaysted/fast-dedup [INFO] finished tweaking git repo https://github.com/tplaysted/fast-dedup [INFO] tweaked toml for git repo https://github.com/tplaysted/fast-dedup written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tplaysted/fast-dedup on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tplaysted/fast-dedup already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fast-dhash v0.1.0 [INFO] [stderr] Downloaded clap v4.5.0 [INFO] [stderr] Downloaded clap_builder v4.5.0 [INFO] [stderr] Downloaded png v0.17.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 310f08bfa9690aa05cf6fd57e19089c362d8b244e56b1b31d91a572cd286b596 [INFO] running `Command { std: "docker" "start" "-a" "310f08bfa9690aa05cf6fd57e19089c362d8b244e56b1b31d91a572cd286b596", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "310f08bfa9690aa05cf6fd57e19089c362d8b244e56b1b31d91a572cd286b596", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "310f08bfa9690aa05cf6fd57e19089c362d8b244e56b1b31d91a572cd286b596", kill_on_drop: false }` [INFO] [stdout] 310f08bfa9690aa05cf6fd57e19089c362d8b244e56b1b31d91a572cd286b596 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 44ae0b28670f1729a1420297a5cc23ba5e796e6a6f3518f959d6776025005f1f [INFO] running `Command { std: "docker" "start" "-a" "44ae0b28670f1729a1420297a5cc23ba5e796e6a6f3518f959d6776025005f1f", kill_on_drop: false }` [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking png v0.17.11 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking imagesize v0.12.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking image v0.24.8 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking serde v1.0.196 [INFO] [stderr] Checking fast-dhash v0.1.0 [INFO] [stderr] Checking dedup v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use image; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | use imagesize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return Some(self_size > other_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Some(self_size > other_size); [INFO] [stdout] 51 + Some(self_size > other_size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | if !is_image(&self) {return None}; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | if !is_image(&other) {return None}; [INFO] [stdout] | ^^^^^^ help: change this to: `other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let self_size: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `self_size` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 | let other_size: usize; [INFO] [stdout] 36 | [INFO] [stdout] 37 ~ let self_size: usize = match imagesize::size(self) { [INFO] [stdout] 38 | Ok(dim) => { [INFO] [stdout] 39 ~ dim.width * dim.height [INFO] [stdout] 40 | } [INFO] [stdout] 41 | Err(why) => {println!("Error getting size: {:?}", why); return None;} [INFO] [stdout] 42 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let other_size: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `other_size` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 | [INFO] [stdout] ... [INFO] [stdout] 43 | [INFO] [stdout] 44 ~ let other_size: usize = match imagesize::size(other) { [INFO] [stdout] 45 | Ok(dim) => { [INFO] [stdout] 46 ~ dim.width * dim.height [INFO] [stdout] 47 | } [INFO] [stdout] 48 | Err(why) => {println!("Error getting size: {:?}", why); return None;} [INFO] [stdout] 49 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return IsBetterQual::partial_cmp(Path::new(self), Path::new(other)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return IsBetterQual::partial_cmp(Path::new(self), Path::new(other)); [INFO] [stdout] 57 + IsBetterQual::partial_cmp(Path::new(self), Path::new(other)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if !ext.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `ext.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ext` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 64 | if !ext.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 65 | match ext.unwrap().to_str() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return false [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return false [INFO] [stdout] 75 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match ext.unwrap().to_str() { [INFO] [stdout] 66 | | Some("jpg") => true, [INFO] [stdout] 67 | | Some("jpeg") => true, [INFO] [stdout] 68 | | Some("png") => true, [INFO] [stdout] ... | [INFO] [stdout] 72 | | _ => false [INFO] [stdout] 73 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 65 - match ext.unwrap().to_str() { [INFO] [stdout] 66 - Some("jpg") => true, [INFO] [stdout] 67 - Some("jpeg") => true, [INFO] [stdout] 68 - Some("png") => true, [INFO] [stdout] 69 - Some("JPG") => true, [INFO] [stdout] 70 - Some("JPEG") => true, [INFO] [stdout] 71 - Some("PNG") => true, [INFO] [stdout] 72 - _ => false [INFO] [stdout] 73 - } [INFO] [stdout] 65 + matches!(ext.unwrap().to_str(), Some("jpg") | Some("jpeg") | Some("png") | Some("JPG") | Some("JPEG") | Some("PNG")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | return Ok(image_paths); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return Ok(image_paths); [INFO] [stdout] 101 + Ok(image_paths) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | return splits; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return splits; [INFO] [stdout] 125 + splits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `big_vec` [INFO] [stdout] --> src/main.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 111 | for j in i * (d + 1) .. (i + 1) * (d + 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 111 - for j in i * (d + 1) .. (i + 1) * (d + 1) { [INFO] [stdout] 111 + for in big_vec.iter().take((i + 1) * (d + 1)).skip(i * (d + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `big_vec` [INFO] [stdout] --> src/main.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 119 | for j in r + i * d .. r + (i + 1) * d { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 119 - for j in r + i * d .. r + (i + 1) * d { [INFO] [stdout] 119 + for in big_vec.iter().take(r + (i + 1) * d).skip(r + i * d) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | return Ok(hashes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return Ok(hashes); [INFO] [stdout] 142 + Ok(hashes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 175 | return Ok(hashes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - return Ok(hashes); [INFO] [stdout] 175 + Ok(hashes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/main.rs:148:36 [INFO] [stdout] | [INFO] [stdout] 148 | let splits = get_splits(paths, thread_count.try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/main.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 155 | for split in splits { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, split) in (1..).zip(splits.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | return Ok(total); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return Ok(total); [INFO] [stdout] 185 + Ok(total) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | return (originals, duplicates); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return (originals, duplicates); [INFO] [stdout] 220 + (originals, duplicates) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:232:5 [INFO] [stdout] | [INFO] [stdout] 232 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 - return Ok(()); [INFO] [stdout] 232 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:226:38 [INFO] [stdout] | [INFO] [stdout] 226 | if path.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "Can't delete folder"));} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 226 - if path.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "Can't delete folder"));} [INFO] [stdout] 226 + if path.is_dir() {return Err(std::io::Error::other("Can't delete folder"));} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/main.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | / if let Err(why) = fs::remove_file(path) { [INFO] [stdout] 228 | | return Err(why); [INFO] [stdout] 229 | | } [INFO] [stdout] | |_________^ help: replace it with: `fs::remove_file(path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 248 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return Ok(()); [INFO] [stdout] 248 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:236:34 [INFO] [stdout] | [INFO] [stdout] 236 | if !dir.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "'dir' must be a directory"));} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 236 - if !dir.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "'dir' must be a directory"));} [INFO] [stdout] 236 + if !dir.is_dir() {return Err(std::io::Error::other("'dir' must be a directory"));} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:240:38 [INFO] [stdout] | [INFO] [stdout] 240 | if path.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "Can't copy folder"));} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 240 - if path.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "Can't copy folder"));} [INFO] [stdout] 240 + if path.is_dir() {return Err(std::io::Error::other("Can't copy folder"));} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/main.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | / if let Err(why) = fs::copy(path, new_path) { [INFO] [stdout] 244 | | return Err(why); [INFO] [stdout] 245 | | } [INFO] [stdout] | |_________^ help: replace it with: `fs::copy(path, new_path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use image; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | use imagesize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return Some(self_size > other_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Some(self_size > other_size); [INFO] [stdout] 51 + Some(self_size > other_size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | if !is_image(&self) {return None}; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | if !is_image(&other) {return None}; [INFO] [stdout] | ^^^^^^ help: change this to: `other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let self_size: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `self_size` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 | let other_size: usize; [INFO] [stdout] 36 | [INFO] [stdout] 37 ~ let self_size: usize = match imagesize::size(self) { [INFO] [stdout] 38 | Ok(dim) => { [INFO] [stdout] 39 ~ dim.width * dim.height [INFO] [stdout] 40 | } [INFO] [stdout] 41 | Err(why) => {println!("Error getting size: {:?}", why); return None;} [INFO] [stdout] 42 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let other_size: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `other_size` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 | [INFO] [stdout] ... [INFO] [stdout] 43 | [INFO] [stdout] 44 ~ let other_size: usize = match imagesize::size(other) { [INFO] [stdout] 45 | Ok(dim) => { [INFO] [stdout] 46 ~ dim.width * dim.height [INFO] [stdout] 47 | } [INFO] [stdout] 48 | Err(why) => {println!("Error getting size: {:?}", why); return None;} [INFO] [stdout] 49 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return IsBetterQual::partial_cmp(Path::new(self), Path::new(other)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return IsBetterQual::partial_cmp(Path::new(self), Path::new(other)); [INFO] [stdout] 57 + IsBetterQual::partial_cmp(Path::new(self), Path::new(other)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if !ext.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `ext.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ext` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 64 | if !ext.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 65 | match ext.unwrap().to_str() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return false [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return false [INFO] [stdout] 75 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match ext.unwrap().to_str() { [INFO] [stdout] 66 | | Some("jpg") => true, [INFO] [stdout] 67 | | Some("jpeg") => true, [INFO] [stdout] 68 | | Some("png") => true, [INFO] [stdout] ... | [INFO] [stdout] 72 | | _ => false [INFO] [stdout] 73 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 65 - match ext.unwrap().to_str() { [INFO] [stdout] 66 - Some("jpg") => true, [INFO] [stdout] 67 - Some("jpeg") => true, [INFO] [stdout] 68 - Some("png") => true, [INFO] [stdout] 69 - Some("JPG") => true, [INFO] [stdout] 70 - Some("JPEG") => true, [INFO] [stdout] 71 - Some("PNG") => true, [INFO] [stdout] 72 - _ => false [INFO] [stdout] 73 - } [INFO] [stdout] 65 + matches!(ext.unwrap().to_str(), Some("jpg") | Some("jpeg") | Some("png") | Some("JPG") | Some("JPEG") | Some("PNG")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | return Ok(image_paths); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return Ok(image_paths); [INFO] [stdout] 101 + Ok(image_paths) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | return splits; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return splits; [INFO] [stdout] 125 + splits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `big_vec` [INFO] [stdout] --> src/main.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 111 | for j in i * (d + 1) .. (i + 1) * (d + 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 111 - for j in i * (d + 1) .. (i + 1) * (d + 1) { [INFO] [stdout] 111 + for in big_vec.iter().take((i + 1) * (d + 1)).skip(i * (d + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `big_vec` [INFO] [stdout] --> src/main.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 119 | for j in r + i * d .. r + (i + 1) * d { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 119 - for j in r + i * d .. r + (i + 1) * d { [INFO] [stdout] 119 + for in big_vec.iter().take(r + (i + 1) * d).skip(r + i * d) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | return Ok(hashes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return Ok(hashes); [INFO] [stdout] 142 + Ok(hashes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 175 | return Ok(hashes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - return Ok(hashes); [INFO] [stdout] 175 + Ok(hashes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/main.rs:148:36 [INFO] [stdout] | [INFO] [stdout] 148 | let splits = get_splits(paths, thread_count.try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/main.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 155 | for split in splits { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, split) in (1..).zip(splits.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | return Ok(total); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return Ok(total); [INFO] [stdout] 185 + Ok(total) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | return (originals, duplicates); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return (originals, duplicates); [INFO] [stdout] 220 + (originals, duplicates) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:232:5 [INFO] [stdout] | [INFO] [stdout] 232 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 - return Ok(()); [INFO] [stdout] 232 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:226:38 [INFO] [stdout] | [INFO] [stdout] 226 | if path.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "Can't delete folder"));} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 226 - if path.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "Can't delete folder"));} [INFO] [stdout] 226 + if path.is_dir() {return Err(std::io::Error::other("Can't delete folder"));} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/main.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | / if let Err(why) = fs::remove_file(path) { [INFO] [stdout] 228 | | return Err(why); [INFO] [stdout] 229 | | } [INFO] [stdout] | |_________^ help: replace it with: `fs::remove_file(path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 248 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return Ok(()); [INFO] [stdout] 248 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:236:34 [INFO] [stdout] | [INFO] [stdout] 236 | if !dir.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "'dir' must be a directory"));} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 236 - if !dir.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "'dir' must be a directory"));} [INFO] [stdout] 236 + if !dir.is_dir() {return Err(std::io::Error::other("'dir' must be a directory"));} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:240:38 [INFO] [stdout] | [INFO] [stdout] 240 | if path.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "Can't copy folder"));} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 240 - if path.is_dir() {return Err(std::io::Error::new(std::io::ErrorKind::Other, "Can't copy folder"));} [INFO] [stdout] 240 + if path.is_dir() {return Err(std::io::Error::other("Can't copy folder"));} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/main.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | / if let Err(why) = fs::copy(path, new_path) { [INFO] [stdout] 244 | | return Err(why); [INFO] [stdout] 245 | | } [INFO] [stdout] | |_________^ help: replace it with: `fs::copy(path, new_path)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.97s [INFO] running `Command { std: "docker" "inspect" "44ae0b28670f1729a1420297a5cc23ba5e796e6a6f3518f959d6776025005f1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44ae0b28670f1729a1420297a5cc23ba5e796e6a6f3518f959d6776025005f1f", kill_on_drop: false }` [INFO] [stdout] 44ae0b28670f1729a1420297a5cc23ba5e796e6a6f3518f959d6776025005f1f