[INFO] cloning repository https://github.com/totally-real-penguin/cipher-cli
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/totally-real-penguin/cipher-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftotally-real-penguin%2Fcipher-cli", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftotally-real-penguin%2Fcipher-cli'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 45ceb0fdf199c46e568b16f9f5d973721bb40db2
[INFO] linting totally-real-penguin/cipher-cli against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftotally-real-penguin%2Fcipher-cli" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/totally-real-penguin/cipher-cli
[INFO] finished tweaking git repo https://github.com/totally-real-penguin/cipher-cli
[INFO] tweaked toml for git repo https://github.com/totally-real-penguin/cipher-cli written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/totally-real-penguin/cipher-cli on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/totally-real-penguin/cipher-cli already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 96c49021b1239d3451c558b8b6f3e54665d35e8b97cff9e931f3e065ff15f321
[INFO] running `Command { std: "docker" "start" "-a" "96c49021b1239d3451c558b8b6f3e54665d35e8b97cff9e931f3e065ff15f321", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "96c49021b1239d3451c558b8b6f3e54665d35e8b97cff9e931f3e065ff15f321", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "96c49021b1239d3451c558b8b6f3e54665d35e8b97cff9e931f3e065ff15f321", kill_on_drop: false }`
[INFO] [stdout] 96c49021b1239d3451c558b8b6f3e54665d35e8b97cff9e931f3e065ff15f321
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 8a47917d812ca1ac18cc8e359b5c688b745dac4c1f8d78ad1a36d0df0d15473c
[INFO] running `Command { std: "docker" "start" "-a" "8a47917d812ca1ac18cc8e359b5c688b745dac4c1f8d78ad1a36d0df0d15473c", kill_on_drop: false }`
[INFO] [stderr]     Checking cipher-cli v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/encrypt.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     return input
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 13 -     return input
[INFO] [stdout] 13 +     input
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/encrypt.rs:18:11
[INFO] [stdout]    |
[INFO] [stdout] 18 |     while !string.parse::<i16>().is_ok() | string.is_empty() {
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `string.parse::<i16>().is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/encrypt.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 |     return string.parse::<i16>().unwrap()
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     return string.parse::<i16>().unwrap()
[INFO] [stdout] 22 +     string.parse::<i16>().unwrap()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/encrypt.rs:33:12
[INFO] [stdout]    |
[INFO] [stdout] 33 |         if num >= 65 && num <= 90 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(65..=90).contains(&num)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout]    = note: `#[warn(clippy::manual_range_contains)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/encrypt.rs:39:25
[INFO] [stdout]    |
[INFO] [stdout] 39 |             if num < 0 {num = 26 + num};
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^ help: replace it with: `num += 26`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/encrypt.rs:40:13
[INFO] [stdout]    |
[INFO] [stdout] 40 |             num = num % 26;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: replace it with: `num %= 26`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/encrypt.rs:67:12
[INFO] [stdout]    |
[INFO] [stdout] 67 |         if num >= 65 && num <= 90 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(65..=90).contains(&num)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]   --> src/encrypt.rs:72:40
[INFO] [stdout]    |
[INFO] [stdout] 72 |                 buffer.push(*ALPHA.get(shift_index as usize).expect("Not in bounds"));
[INFO] [stdout]    |                                        ^^^^^^^^^^^^^^^^^^^^ help: try: `shift_index`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/encrypt.rs:75:25
[INFO] [stdout]    |
[INFO] [stdout] 75 |             if num < 0 {num = 26 + num}
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^ help: replace it with: `num += 26`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/encrypt.rs:76:13
[INFO] [stdout]    |
[INFO] [stdout] 76 |             num = num % 26;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: replace it with: `num %= 26`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/encrypt.rs:95:12
[INFO] [stdout]    |
[INFO] [stdout] 95 |         if num >= 65 && num <=(90) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(65..=(90)).contains(&num)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/encrypt.rs:97:16
[INFO] [stdout]    |
[INFO] [stdout] 97 |             if key < 65 || key > 90 {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^ help: use: `!(65..=90).contains(&key)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/encrypt.rs:106:29
[INFO] [stdout]     |
[INFO] [stdout] 106 |                 if num < 0 {num = 26 + num}
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^ help: replace it with: `num += 26`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/encrypt.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     return input
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 13 -     return input
[INFO] [stdout] 13 +     input
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/encrypt.rs:18:11
[INFO] [stdout]    |
[INFO] [stdout] 18 |     while !string.parse::<i16>().is_ok() | string.is_empty() {
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `string.parse::<i16>().is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/encrypt.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 |     return string.parse::<i16>().unwrap()
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     return string.parse::<i16>().unwrap()
[INFO] [stdout] 22 +     string.parse::<i16>().unwrap()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/encrypt.rs:33:12
[INFO] [stdout]    |
[INFO] [stdout] 33 |         if num >= 65 && num <= 90 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(65..=90).contains(&num)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout]    = note: `#[warn(clippy::manual_range_contains)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/encrypt.rs:39:25
[INFO] [stdout]    |
[INFO] [stdout] 39 |             if num < 0 {num = 26 + num};
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^ help: replace it with: `num += 26`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/encrypt.rs:40:13
[INFO] [stdout]    |
[INFO] [stdout] 40 |             num = num % 26;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: replace it with: `num %= 26`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/encrypt.rs:67:12
[INFO] [stdout]    |
[INFO] [stdout] 67 |         if num >= 65 && num <= 90 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(65..=90).contains(&num)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]   --> src/encrypt.rs:72:40
[INFO] [stdout]    |
[INFO] [stdout] 72 |                 buffer.push(*ALPHA.get(shift_index as usize).expect("Not in bounds"));
[INFO] [stdout]    |                                        ^^^^^^^^^^^^^^^^^^^^ help: try: `shift_index`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/encrypt.rs:75:25
[INFO] [stdout]    |
[INFO] [stdout] 75 |             if num < 0 {num = 26 + num}
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^ help: replace it with: `num += 26`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/encrypt.rs:76:13
[INFO] [stdout]    |
[INFO] [stdout] 76 |             num = num % 26;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: replace it with: `num %= 26`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/encrypt.rs:95:12
[INFO] [stdout]    |
[INFO] [stdout] 95 |         if num >= 65 && num <=(90) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(65..=(90)).contains(&num)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/encrypt.rs:97:16
[INFO] [stdout]    |
[INFO] [stdout] 97 |             if key < 65 || key > 90 {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^ help: use: `!(65..=90).contains(&key)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/encrypt.rs:106:29
[INFO] [stdout]     |
[INFO] [stdout] 106 |                 if num < 0 {num = 26 + num}
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^ help: replace it with: `num += 26`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s
[INFO] running `Command { std: "docker" "inspect" "8a47917d812ca1ac18cc8e359b5c688b745dac4c1f8d78ad1a36d0df0d15473c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8a47917d812ca1ac18cc8e359b5c688b745dac4c1f8d78ad1a36d0df0d15473c", kill_on_drop: false }`
[INFO] [stdout] 8a47917d812ca1ac18cc8e359b5c688b745dac4c1f8d78ad1a36d0df0d15473c