[INFO] cloning repository https://github.com/topten1222/rust_learnning [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/topten1222/rust_learnning" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftopten1222%2Frust_learnning", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftopten1222%2Frust_learnning'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4dc28212df4fb5f2163716a879f9b2bec20bd117 [INFO] linting topten1222/rust_learnning against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftopten1222%2Frust_learnning" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/topten1222/rust_learnning [INFO] finished tweaking git repo https://github.com/topten1222/rust_learnning [INFO] tweaked toml for git repo https://github.com/topten1222/rust_learnning written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/topten1222/rust_learnning on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/topten1222/rust_learnning already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded validator_derive v0.20.0 [INFO] [stderr] Downloaded hyper-util v0.1.11 [INFO] [stderr] Downloaded dsl_auto_type v0.1.3 [INFO] [stderr] Downloaded pq-sys v0.7.1 [INFO] [stderr] Downloaded validator v0.20.0 [INFO] [stderr] Downloaded file-format v0.26.0 [INFO] [stderr] Downloaded diesel_derives v2.2.5 [INFO] [stderr] Downloaded diesel v2.2.10 [INFO] [stderr] Downloaded axum v0.8.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f0f0d6a20fcba0c37e36d68baba6c20f1f688ebb0ccabd5c8e89ae92b32fa81 [INFO] running `Command { std: "docker" "start" "-a" "6f0f0d6a20fcba0c37e36d68baba6c20f1f688ebb0ccabd5c8e89ae92b32fa81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f0f0d6a20fcba0c37e36d68baba6c20f1f688ebb0ccabd5c8e89ae92b32fa81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f0f0d6a20fcba0c37e36d68baba6c20f1f688ebb0ccabd5c8e89ae92b32fa81", kill_on_drop: false }` [INFO] [stdout] 6f0f0d6a20fcba0c37e36d68baba6c20f1f688ebb0ccabd5c8e89ae92b32fa81 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e0455cce309c82d7ed8270bc920edb41e168fa28978f7e8510e6b2609bceb343 [INFO] running `Command { std: "docker" "start" "-a" "e0455cce309c82d7ed8270bc920edb41e168fa28978f7e8510e6b2609bceb343", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Compiling rustversion v1.0.20 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Compiling pq-sys v0.7.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking file-format v0.26.0 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking axum-core v0.5.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking multer v3.1.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.2.0 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking tokio v1.44.2 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling dsl_auto_type v0.1.3 [INFO] [stderr] Compiling validator_derive v0.20.0 [INFO] [stderr] Compiling diesel_derives v2.2.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking hyper-util v0.1.11 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking axum v0.8.3 [INFO] [stderr] Checking diesel v2.2.10 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking validator v0.20.0 [INFO] [stderr] Checking hello_world v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/controllers/contact_controller.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | return (StatusCode::CREATED, Json(response)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return (StatusCode::CREATED, Json(response)); [INFO] [stdout] 50 + (StatusCode::CREATED, Json(response)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/controllers/contact_controller.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | return (StatusCode::INTERNAL_SERVER_ERROR, Json(response)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return (StatusCode::INTERNAL_SERVER_ERROR, Json(response)); [INFO] [stdout] 59 + (StatusCode::INTERNAL_SERVER_ERROR, Json(response)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/controllers/contact_controller.rs:79:16 [INFO] [stdout] | [INFO] [stdout] 79 | if !ext.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ext.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/controllers/contact_controller.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | return (StatusCode::CREATED, Json(response)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return (StatusCode::CREATED, Json(response)); [INFO] [stdout] 50 + (StatusCode::CREATED, Json(response)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/controllers/contact_controller.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | return (StatusCode::INTERNAL_SERVER_ERROR, Json(response)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return (StatusCode::INTERNAL_SERVER_ERROR, Json(response)); [INFO] [stdout] 59 + (StatusCode::INTERNAL_SERVER_ERROR, Json(response)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/controllers/contact_controller.rs:79:16 [INFO] [stdout] | [INFO] [stdout] 79 | if !ext.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ext.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `Command { std: "docker" "inspect" "e0455cce309c82d7ed8270bc920edb41e168fa28978f7e8510e6b2609bceb343", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0455cce309c82d7ed8270bc920edb41e168fa28978f7e8510e6b2609bceb343", kill_on_drop: false }` [INFO] [stdout] e0455cce309c82d7ed8270bc920edb41e168fa28978f7e8510e6b2609bceb343