[INFO] cloning repository https://github.com/tony-o/rust-udsn
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tony-o/rust-udsn" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftony-o%2Frust-udsn", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftony-o%2Frust-udsn'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 3f70a8dd3addee95a9aae65d01960f9415fd710c
[INFO] linting tony-o/rust-udsn against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftony-o%2Frust-udsn" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/tony-o/rust-udsn
[INFO] finished tweaking git repo https://github.com/tony-o/rust-udsn
[INFO] tweaked toml for git repo https://github.com/tony-o/rust-udsn written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/tony-o/rust-udsn on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/tony-o/rust-udsn already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 05f17fcc13124492ff21af4d6f0150c78738971cd83e0e99148674257500f582
[INFO] running `Command { std: "docker" "start" "-a" "05f17fcc13124492ff21af4d6f0150c78738971cd83e0e99148674257500f582", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "05f17fcc13124492ff21af4d6f0150c78738971cd83e0e99148674257500f582", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "05f17fcc13124492ff21af4d6f0150c78738971cd83e0e99148674257500f582", kill_on_drop: false }`
[INFO] [stdout] 05f17fcc13124492ff21af4d6f0150c78738971cd83e0e99148674257500f582
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6a54640316d574af4352338fd869dcb18b9e6761843d674451d8b7babe435802
[INFO] running `Command { std: "docker" "start" "-a" "6a54640316d574af4352338fd869dcb18b9e6761843d674451d8b7babe435802", kill_on_drop: false }`
[INFO] [stderr]     Checking udsn v0.2.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `DSN`
[INFO] [stdout]   --> src/lib.rs:38:5
[INFO] [stdout]    |
[INFO] [stdout] 38 | /     pub fn new() -> Self {
[INFO] [stdout] 39 | |         Self {
[INFO] [stdout] 40 | |             protocol: "".to_string(),
[INFO] [stdout] 41 | |             username: None,
[INFO] [stdout] ...  |
[INFO] [stdout] 48 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 17 + impl Default for DSN {
[INFO] [stdout] 18 +     fn default() -> Self {
[INFO] [stdout] 19 +         Self::new()
[INFO] [stdout] 20 +     }
[INFO] [stdout] 21 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:91:23
[INFO] [stdout]     |
[INFO] [stdout]  91 |           self.params = if let Some(ps) = params {
[INFO] [stdout]     |  _______________________^
[INFO] [stdout]  92 | |             Some(
[INFO] [stdout]  93 | |                 ps.iter()
[INFO] [stdout]  94 | |                     .map(|(k, v)| {
[INFO] [stdout] ...   |
[INFO] [stdout] 107 | |             None
[INFO] [stdout] 108 | |         };
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  91 ~         self.params = params.map(|ps| ps.iter()
[INFO] [stdout]  92 +                     .map(|(k, v)| {
[INFO] [stdout]  93 +                         (
[INFO] [stdout]  94 +                             k.to_string(),
[INFO] [stdout]  95 +                             if let Some(vv) = v {
[INFO] [stdout]  96 +                                 Some(vv.to_string())
[INFO] [stdout]  97 +                             } else {
[INFO] [stdout]  98 +                                 None
[INFO] [stdout]  99 +                             },
[INFO] [stdout] 100 +                         )
[INFO] [stdout] 101 +                     })
[INFO] [stdout] 102 ~                     .collect());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:97:29
[INFO] [stdout]     |
[INFO] [stdout]  97 | / ...                   if let Some(vv) = v {
[INFO] [stdout]  98 | | ...                       Some(vv.to_string())
[INFO] [stdout]  99 | | ...                   } else {
[INFO] [stdout] 100 | | ...                       None
[INFO] [stdout] 101 | | ...                   },
[INFO] [stdout]     | |_______________________^ help: try: `v.as_ref().map(|vv| vv.to_string())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:120:21
[INFO] [stdout]     |
[INFO] [stdout] 120 | /                     if let Some(a) = v {
[INFO] [stdout] 121 | |                         Some(a.to_string())
[INFO] [stdout] 122 | |                     } else {
[INFO] [stdout] 123 | |                         None
[INFO] [stdout] 124 | |                     },
[INFO] [stdout]     | |_____________________^ help: try: `v.as_ref().map(|a| a.to_string())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:166:25
[INFO] [stdout]     |
[INFO] [stdout] 166 |         match scnd.find(&[':', '/']) {
[INFO] [stdout]     |                         ^^^^^^^^^^^ help: change this to: `[':', '/']`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:186:52
[INFO] [stdout]     |
[INFO] [stdout] 186 |                         match scnd[(v + 1)..].find(&['/', '?']) {
[INFO] [stdout]     |                                                    ^^^^^^^^^^^ help: change this to: `['/', '?']`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout]    --> src/lib.rs:188:40
[INFO] [stdout]     |
[INFO] [stdout] 188 |   ...                   port = match scnd[(v + 1)..(v + 1 + p)].parse::<u16>() {
[INFO] [stdout]     |  ______________________________^
[INFO] [stdout] 189 | | ...                       Ok(i) => Some(i),
[INFO] [stdout] 190 | | ...                       Err(_e) => None,
[INFO] [stdout] 191 | | ...                   };
[INFO] [stdout]     | |_______________________^ help: replace with: `scnd[(v + 1)..(v + 1 + p)].parse::<u16>().ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]     = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `DSN`
[INFO] [stdout]    --> src/lib.rs:263:5
[INFO] [stdout]     |
[INFO] [stdout] 263 | /     pub fn to_string(&self) -> String {
[INFO] [stdout] 264 | |         let mut out = String::with_capacity(1024);
[INFO] [stdout] 265 | |         let mut need_at = false;
[INFO] [stdout] 266 | |         let mut root_path = false;
[INFO] [stdout] ...   |
[INFO] [stdout] 314 | |         out
[INFO] [stdout] 315 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: implement trait `Display` for type `DSN` instead
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]     = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:308:20
[INFO] [stdout]     |
[INFO] [stdout] 308 |                 if !param_iter.peek().is_none() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `param_iter.peek().is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:270:41
[INFO] [stdout]     |
[INFO] [stdout] 270 |             out.push_str(percent_encode(&user).as_str());
[INFO] [stdout]     |                                         ^^^^^ help: change this to: `user`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:274:13
[INFO] [stdout]     |
[INFO] [stdout] 274 |             out.push_str(":");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push(':')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout]     = note: `#[warn(clippy::single_char_add_str)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:275:41
[INFO] [stdout]     |
[INFO] [stdout] 275 |             out.push_str(percent_encode(&pass).as_str());
[INFO] [stdout]     |                                         ^^^^^ help: change this to: `pass`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:279:13
[INFO] [stdout]     |
[INFO] [stdout] 279 |             out.push_str("@");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('@')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:282:67
[INFO] [stdout]     |
[INFO] [stdout] 282 |             Some(Resource::URI(v)) => out.push_str(percent_encode(&v).as_str()),
[INFO] [stdout]     |                                                                   ^^ help: change this to: `v`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:290:13
[INFO] [stdout]     |
[INFO] [stdout] 290 |             out.push_str(":");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push(':')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:295:17
[INFO] [stdout]     |
[INFO] [stdout] 295 |                 out.push_str("/");
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('/')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:297:41
[INFO] [stdout]     |
[INFO] [stdout] 297 |             out.push_str(percent_encode(&db).as_str());
[INFO] [stdout]     |                                         ^^^ help: change this to: `db`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:300:13
[INFO] [stdout]     |
[INFO] [stdout] 300 |             out.push_str("?");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('?')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]    --> src/lib.rs:301:41
[INFO] [stdout]     |
[INFO] [stdout] 301 |             let mut param_iter = params.into_iter().peekable();
[INFO] [stdout]     |                                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]     = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:303:45
[INFO] [stdout]     |
[INFO] [stdout] 303 |                 out.push_str(percent_encode(&k).as_str());
[INFO] [stdout]     |                                             ^^ help: change this to: `k`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:305:21
[INFO] [stdout]     |
[INFO] [stdout] 305 |                     out.push_str("=");
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('=')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:306:49
[INFO] [stdout]     |
[INFO] [stdout] 306 |                     out.push_str(percent_encode(&iv).as_str());
[INFO] [stdout]     |                                                 ^^^ help: change this to: `iv`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:309:21
[INFO] [stdout]     |
[INFO] [stdout] 309 |                     out.push_str("&");
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('&')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `DSN`
[INFO] [stdout]   --> src/lib.rs:38:5
[INFO] [stdout]    |
[INFO] [stdout] 38 | /     pub fn new() -> Self {
[INFO] [stdout] 39 | |         Self {
[INFO] [stdout] 40 | |             protocol: "".to_string(),
[INFO] [stdout] 41 | |             username: None,
[INFO] [stdout] ...  |
[INFO] [stdout] 48 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 17 + impl Default for DSN {
[INFO] [stdout] 18 +     fn default() -> Self {
[INFO] [stdout] 19 +         Self::new()
[INFO] [stdout] 20 +     }
[INFO] [stdout] 21 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:91:23
[INFO] [stdout]     |
[INFO] [stdout]  91 |           self.params = if let Some(ps) = params {
[INFO] [stdout]     |  _______________________^
[INFO] [stdout]  92 | |             Some(
[INFO] [stdout]  93 | |                 ps.iter()
[INFO] [stdout]  94 | |                     .map(|(k, v)| {
[INFO] [stdout] ...   |
[INFO] [stdout] 107 | |             None
[INFO] [stdout] 108 | |         };
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  91 ~         self.params = params.map(|ps| ps.iter()
[INFO] [stdout]  92 +                     .map(|(k, v)| {
[INFO] [stdout]  93 +                         (
[INFO] [stdout]  94 +                             k.to_string(),
[INFO] [stdout]  95 +                             if let Some(vv) = v {
[INFO] [stdout]  96 +                                 Some(vv.to_string())
[INFO] [stdout]  97 +                             } else {
[INFO] [stdout]  98 +                                 None
[INFO] [stdout]  99 +                             },
[INFO] [stdout] 100 +                         )
[INFO] [stdout] 101 +                     })
[INFO] [stdout] 102 ~                     .collect());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:97:29
[INFO] [stdout]     |
[INFO] [stdout]  97 | / ...                   if let Some(vv) = v {
[INFO] [stdout]  98 | | ...                       Some(vv.to_string())
[INFO] [stdout]  99 | | ...                   } else {
[INFO] [stdout] 100 | | ...                       None
[INFO] [stdout] 101 | | ...                   },
[INFO] [stdout]     | |_______________________^ help: try: `v.as_ref().map(|vv| vv.to_string())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:120:21
[INFO] [stdout]     |
[INFO] [stdout] 120 | /                     if let Some(a) = v {
[INFO] [stdout] 121 | |                         Some(a.to_string())
[INFO] [stdout] 122 | |                     } else {
[INFO] [stdout] 123 | |                         None
[INFO] [stdout] 124 | |                     },
[INFO] [stdout]     | |_____________________^ help: try: `v.as_ref().map(|a| a.to_string())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:166:25
[INFO] [stdout]     |
[INFO] [stdout] 166 |         match scnd.find(&[':', '/']) {
[INFO] [stdout]     |                         ^^^^^^^^^^^ help: change this to: `[':', '/']`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:186:52
[INFO] [stdout]     |
[INFO] [stdout] 186 |                         match scnd[(v + 1)..].find(&['/', '?']) {
[INFO] [stdout]     |                                                    ^^^^^^^^^^^ help: change this to: `['/', '?']`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout]    --> src/lib.rs:188:40
[INFO] [stdout]     |
[INFO] [stdout] 188 |   ...                   port = match scnd[(v + 1)..(v + 1 + p)].parse::<u16>() {
[INFO] [stdout]     |  ______________________________^
[INFO] [stdout] 189 | | ...                       Ok(i) => Some(i),
[INFO] [stdout] 190 | | ...                       Err(_e) => None,
[INFO] [stdout] 191 | | ...                   };
[INFO] [stdout]     | |_______________________^ help: replace with: `scnd[(v + 1)..(v + 1 + p)].parse::<u16>().ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]     = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `DSN`
[INFO] [stdout]    --> src/lib.rs:263:5
[INFO] [stdout]     |
[INFO] [stdout] 263 | /     pub fn to_string(&self) -> String {
[INFO] [stdout] 264 | |         let mut out = String::with_capacity(1024);
[INFO] [stdout] 265 | |         let mut need_at = false;
[INFO] [stdout] 266 | |         let mut root_path = false;
[INFO] [stdout] ...   |
[INFO] [stdout] 314 | |         out
[INFO] [stdout] 315 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: implement trait `Display` for type `DSN` instead
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]     = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:308:20
[INFO] [stdout]     |
[INFO] [stdout] 308 |                 if !param_iter.peek().is_none() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `param_iter.peek().is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:270:41
[INFO] [stdout]     |
[INFO] [stdout] 270 |             out.push_str(percent_encode(&user).as_str());
[INFO] [stdout]     |                                         ^^^^^ help: change this to: `user`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:274:13
[INFO] [stdout]     |
[INFO] [stdout] 274 |             out.push_str(":");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push(':')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout]     = note: `#[warn(clippy::single_char_add_str)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:275:41
[INFO] [stdout]     |
[INFO] [stdout] 275 |             out.push_str(percent_encode(&pass).as_str());
[INFO] [stdout]     |                                         ^^^^^ help: change this to: `pass`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:279:13
[INFO] [stdout]     |
[INFO] [stdout] 279 |             out.push_str("@");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('@')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:282:67
[INFO] [stdout]     |
[INFO] [stdout] 282 |             Some(Resource::URI(v)) => out.push_str(percent_encode(&v).as_str()),
[INFO] [stdout]     |                                                                   ^^ help: change this to: `v`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:290:13
[INFO] [stdout]     |
[INFO] [stdout] 290 |             out.push_str(":");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push(':')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:295:17
[INFO] [stdout]     |
[INFO] [stdout] 295 |                 out.push_str("/");
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('/')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:297:41
[INFO] [stdout]     |
[INFO] [stdout] 297 |             out.push_str(percent_encode(&db).as_str());
[INFO] [stdout]     |                                         ^^^ help: change this to: `db`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:300:13
[INFO] [stdout]     |
[INFO] [stdout] 300 |             out.push_str("?");
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('?')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]    --> src/lib.rs:301:41
[INFO] [stdout]     |
[INFO] [stdout] 301 |             let mut param_iter = params.into_iter().peekable();
[INFO] [stdout]     |                                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]     = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:303:45
[INFO] [stdout]     |
[INFO] [stdout] 303 |                 out.push_str(percent_encode(&k).as_str());
[INFO] [stdout]     |                                             ^^ help: change this to: `k`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:305:21
[INFO] [stdout]     |
[INFO] [stdout] 305 |                     out.push_str("=");
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('=')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:306:49
[INFO] [stdout]     |
[INFO] [stdout] 306 |                     out.push_str(percent_encode(&iv).as_str());
[INFO] [stdout]     |                                                 ^^^ help: change this to: `iv`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]    --> src/lib.rs:309:21
[INFO] [stdout]     |
[INFO] [stdout] 309 |                     out.push_str("&");
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('&')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.74s
[INFO] running `Command { std: "docker" "inspect" "6a54640316d574af4352338fd869dcb18b9e6761843d674451d8b7babe435802", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6a54640316d574af4352338fd869dcb18b9e6761843d674451d8b7babe435802", kill_on_drop: false }`
[INFO] [stdout] 6a54640316d574af4352338fd869dcb18b9e6761843d674451d8b7babe435802