[INFO] cloning repository https://github.com/tomc1998/rust-lmc
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tomc1998/rust-lmc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftomc1998%2Frust-lmc", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftomc1998%2Frust-lmc'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 1827800f48ac1edaac36c7b39df35029b129508a
[INFO] linting tomc1998/rust-lmc against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftomc1998%2Frust-lmc" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/tomc1998/rust-lmc
[INFO] finished tweaking git repo https://github.com/tomc1998/rust-lmc
[INFO] tweaked toml for git repo https://github.com/tomc1998/rust-lmc written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/tomc1998/rust-lmc on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/tomc1998/rust-lmc already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a003cd6b6daa4211b66d7624026fd0b59126eb951e24ed2be16f822aa8a2d1d7
[INFO] running `Command { std: "docker" "start" "-a" "a003cd6b6daa4211b66d7624026fd0b59126eb951e24ed2be16f822aa8a2d1d7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a003cd6b6daa4211b66d7624026fd0b59126eb951e24ed2be16f822aa8a2d1d7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a003cd6b6daa4211b66d7624026fd0b59126eb951e24ed2be16f822aa8a2d1d7", kill_on_drop: false }`
[INFO] [stdout] a003cd6b6daa4211b66d7624026fd0b59126eb951e24ed2be16f822aa8a2d1d7
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] e31e5ed52601dd9eb2e8d8ded9468b29a8a1ae44dc1051c58c21056f32312219
[INFO] running `Command { std: "docker" "start" "-a" "e31e5ed52601dd9eb2e8d8ded9468b29a8a1ae44dc1051c58c21056f32312219", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking lmc v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead
[INFO] [stdout]  --> src/io.rs:7:3
[INFO] [stdout]   |
[INFO] [stdout] 7 |   try!(f.read_to_string(&mut buffer));
[INFO] [stdout]   |   ^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead
[INFO] [stdout]  --> src/io.rs:5:15
[INFO] [stdout]   |
[INFO] [stdout] 5 |   let mut f = try!(File::open(filename));
[INFO] [stdout]   |               ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/assembler/lexer.rs:14:19
[INFO] [stdout]    |
[INFO] [stdout] 14 | const OP_CODES: [&'static str; 10] = ["ADD", "SUB", "LDA", "STO", "BR", "BRZ", "BRP", "IN", "OUT", "HLT"];
[INFO] [stdout]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/assembler/lexer.rs:40:58
[INFO] [stdout]    |
[INFO] [stdout] 40 |   src_line = SrcLine{op: "", operand: None, label: None, lnum: lnum};
[INFO] [stdout]    |                                                          ^^^^^^^^^^ help: replace it with: `lnum`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/assembler/parser.rs:20:9
[INFO] [stdout]    |
[INFO] [stdout] 20 |         loc: loc,
[INFO] [stdout]    |         ^^^^^^^^ help: replace it with: `loc`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `curr_op` is never read
[INFO] [stdout]   --> src/assembler/parser.rs:64:15
[INFO] [stdout]    |
[INFO] [stdout] 64 |               curr_op.operand = 999;
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: maybe it is overwritten before being read?
[INFO] [stdout]    = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `LMC` contains a capitalized acronym
[INFO] [stdout]  --> src/lmc.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct LMC {
[INFO] [stdout]   |            ^^^ help: consider making the acronym lowercase, except the initial letter: `Lmc`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]   = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lmc.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     return true;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 123 -     return true;
[INFO] [stdout] 123 +     true
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/lmc.rs:99:9
[INFO] [stdout]     |
[INFO] [stdout]  99 | /         if self.acc == 0 {
[INFO] [stdout] 100 | |           self.pc = self.operand;
[INFO] [stdout] 101 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  98 ~       7
[INFO] [stdout]  99 ~         if self.acc == 0 => {
[INFO] [stdout] 100 |           self.pc = self.operand;
[INFO] [stdout] 101 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/lmc.rs:106:9
[INFO] [stdout]     |
[INFO] [stdout] 106 | /         if !self.neg {
[INFO] [stdout] 107 | |           self.pc = self.operand;
[INFO] [stdout] 108 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 105 ~       8
[INFO] [stdout] 106 ~         if !self.neg => {
[INFO] [stdout] 107 |           self.pc = self.operand;
[INFO] [stdout] 108 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/lmc.rs:61:11
[INFO] [stdout]    |
[INFO] [stdout] 61 |           self.acc = self.acc % 1000;
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.acc %= 1000`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lmc.rs:134:5
[INFO] [stdout]     |
[INFO] [stdout] 134 |     return self.execute();
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 134 -     return self.execute();
[INFO] [stdout] 134 +     self.execute()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]  --> src/io.rs:8:3
[INFO] [stdout]   |
[INFO] [stdout] 8 |   return Ok(buffer);
[INFO] [stdout]   |   ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]   |
[INFO] [stdout] 8 -   return Ok(buffer);
[INFO] [stdout] 8 +   Ok(buffer)
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/io.rs:23:8
[INFO] [stdout]    |
[INFO] [stdout] 23 |     if !res.is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `input` after checking its variant with `is_some`
[INFO] [stdout]   --> src/io.rs:33:14
[INFO] [stdout]    |
[INFO] [stdout] 32 |     if input != None && input.is_some() {
[INFO] [stdout]    |                         --------------- the check is happening here
[INFO] [stdout] 33 |       return input.unwrap();
[INFO] [stdout]    |              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/io.rs:28:8
[INFO] [stdout]    |
[INFO] [stdout] 28 |     if input == None {
[INFO] [stdout]    |        ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `input.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]    = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/io.rs:32:8
[INFO] [stdout]    |
[INFO] [stdout] 32 |     if input != None && input.is_some() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `input.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/lexer.rs:23:3
[INFO] [stdout]    |
[INFO] [stdout] 23 |   return false;
[INFO] [stdout]    |   ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 -   return false;
[INFO] [stdout] 23 +   false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/lexer.rs:63:3
[INFO] [stdout]    |
[INFO] [stdout] 63 |   return Ok(Some(src_line));
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 63 -   return Ok(Some(src_line));
[INFO] [stdout] 63 +   Ok(Some(src_line))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/assembler/lexer.rs:33:6
[INFO] [stdout]    |
[INFO] [stdout] 33 |   if lexemes.len() == 0 {
[INFO] [stdout]    |      ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lexemes.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/assembler/lexer.rs:77:8
[INFO] [stdout]    |
[INFO] [stdout] 77 |     if !line_lex_res.is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^ help: try: `line_lex_res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_some`
[INFO] [stdout]   --> src/assembler/lexer.rs:86:30
[INFO] [stdout]    |
[INFO] [stdout] 85 |     if token.is_some() {
[INFO] [stdout]    |     ------------------ help: try: `if let Some(<item>) = token`
[INFO] [stdout] 86 |       token_list.tokens.push(token.unwrap());
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/lexer.rs:89:3
[INFO] [stdout]    |
[INFO] [stdout] 89 |   return Ok(token_list);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 89 -   return Ok(token_list);
[INFO] [stdout] 89 +   Ok(token_list)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `t.label` after checking its variant with `is_some`
[INFO] [stdout]   --> src/assembler/parser.rs:21:15
[INFO] [stdout]    |
[INFO] [stdout] 18 |     if t.label.is_some() {
[INFO] [stdout]    |     -------------------- help: try: `if let Some(<item>) = t.label`
[INFO] [stdout] ...
[INFO] [stdout] 21 |         name: t.label.unwrap(),
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/parser.rs:26:3
[INFO] [stdout]    |
[INFO] [stdout] 26 |   return labels;
[INFO] [stdout]    |   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 26 -   return labels;
[INFO] [stdout] 26 +   labels
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `loc` is used as a loop counter
[INFO] [stdout]   --> src/assembler/parser.rs:17:3
[INFO] [stdout]    |
[INFO] [stdout] 17 |   for t in &(token_list.tokens) {
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (loc, t) in (token_list.tokens).iter().enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `t.operand` after checking its variant with `is_some`
[INFO] [stdout]   --> src/assembler/parser.rs:59:29
[INFO] [stdout]    |
[INFO] [stdout] 58 |         if t.operand.is_some() {
[INFO] [stdout]    |         ---------------------- help: try: `if let Some(<item>) = t.operand`
[INFO] [stdout] 59 |           let operand_str = t.operand.unwrap().trim();
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/parser.rs:98:3
[INFO] [stdout]    |
[INFO] [stdout] 98 |   return Ok(operations);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 98 -   return Ok(operations);
[INFO] [stdout] 98 +   Ok(operations)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]   --> src/assembler/parser.rs:62:31
[INFO] [stdout]    |
[INFO] [stdout] 62 |             curr_op.operand = operand_res.ok().unwrap() as u16;
[INFO] [stdout]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operand_res.ok().unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/assembler/parser.rs:107:3
[INFO] [stdout]     |
[INFO] [stdout] 107 |   return ops;
[INFO] [stdout]     |   ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 107 -   return ops;
[INFO] [stdout] 107 +   ops
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/assembler/parser.rs:102:3
[INFO] [stdout]     |
[INFO] [stdout] 102 |   let ops : Result<Vec<Operation>, String>;
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 106 |   ops = op_pass(token_list, &labels);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `ops` here
[INFO] [stdout]     |
[INFO] [stdout] 102 ~   
[INFO] [stdout] 103 |   let labels: Vec<Label>;
[INFO] [stdout] 104 |
[INFO] [stdout] 105 |   labels = label_pass(token_list);
[INFO] [stdout] 106 ~   let ops : Result<Vec<Operation>, String> = op_pass(token_list, &labels);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/assembler/parser.rs:103:3
[INFO] [stdout]     |
[INFO] [stdout] 103 |   let labels: Vec<Label>;
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] 104 |
[INFO] [stdout] 105 |   labels = label_pass(token_list);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `labels` here
[INFO] [stdout]     |
[INFO] [stdout] 103 ~   
[INFO] [stdout] 104 |
[INFO] [stdout] 105 ~   let labels: Vec<Label> = label_pass(token_list);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/assembler/code_gen.rs:4:24
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub fn gen(operations: &Vec<parser::Operation>, lmc: &mut lmc::LMC) {
[INFO] [stdout]   |                        ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 4 - pub fn gen(operations: &Vec<parser::Operation>, lmc: &mut lmc::LMC) {
[INFO] [stdout] 4 + pub fn gen(operations: &[parser::Operation], lmc: &mut lmc::LMC) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]   --> src/assembler/code_gen.rs:13:36
[INFO] [stdout]    |
[INFO] [stdout] 13 |     val = (o.op_code as u16)*100 + o.operand as u16;
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^ help: try: `o.operand`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/assembler/mod.rs:14:6
[INFO] [stdout]    |
[INFO] [stdout] 14 |   if !token_list_res.is_ok() {
[INFO] [stdout]    |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `token_list_res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/assembler/mod.rs:21:6
[INFO] [stdout]    |
[INFO] [stdout] 21 |   if !operations_res.is_ok() {
[INFO] [stdout]    |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operations_res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/mod.rs:28:3
[INFO] [stdout]    |
[INFO] [stdout] 28 |   return true;
[INFO] [stdout]    |   ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -   return true;
[INFO] [stdout] 28 +   true
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/assembler/mod.rs:8:3
[INFO] [stdout]    |
[INFO] [stdout]  8 |   let token_list_res: Result<lexer::TokenList, String>;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 13 |   token_list_res = lexer::lex(src);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `token_list_res` here
[INFO] [stdout]    |
[INFO] [stdout]  8 ~   
[INFO] [stdout]  9 |   let token_list: lexer::TokenList;
[INFO] [stdout] ...
[INFO] [stdout] 12 |
[INFO] [stdout] 13 ~   let token_list_res: Result<lexer::TokenList, String> = lexer::lex(src);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/assembler/mod.rs:9:3
[INFO] [stdout]    |
[INFO] [stdout]  9 |   let token_list: lexer::TokenList;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 18 |   token_list = token_list_res.ok().unwrap();
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `token_list` here
[INFO] [stdout]    |
[INFO] [stdout]  9 ~   
[INFO] [stdout] 10 |   let operations_res: Result<Vec<parser::Operation>, String>;
[INFO] [stdout] ...
[INFO] [stdout] 17 |   }
[INFO] [stdout] 18 ~   let token_list: lexer::TokenList = token_list_res.ok().unwrap();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/assembler/mod.rs:10:3
[INFO] [stdout]    |
[INFO] [stdout] 10 |   let operations_res: Result<Vec<parser::Operation>, String>;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 20 |   operations_res = parser::parse(&token_list);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `operations_res` here
[INFO] [stdout]    |
[INFO] [stdout] 10 ~   
[INFO] [stdout] 11 |   let operations: Vec<parser::Operation>;
[INFO] [stdout] ...
[INFO] [stdout] 19 |
[INFO] [stdout] 20 ~   let operations_res: Result<Vec<parser::Operation>, String> = parser::parse(&token_list);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/assembler/mod.rs:11:3
[INFO] [stdout]    |
[INFO] [stdout] 11 |   let operations: Vec<parser::Operation>;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 25 |   operations = operations_res.ok().unwrap();
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `operations` here
[INFO] [stdout]    |
[INFO] [stdout] 11 ~   
[INFO] [stdout] 12 |
[INFO] [stdout] ...
[INFO] [stdout] 24 |   }
[INFO] [stdout] 25 ~   let operations: Vec<parser::Operation> = operations_res.ok().unwrap();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]  --> src/main.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 |     println!("");
[INFO] [stdout]   |     ^^^^^^^^^--^
[INFO] [stdout]   |              |
[INFO] [stdout]   |              help: remove the empty string
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]   = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     println!("");
[INFO] [stdout]    |     ^^^^^^^^^--^
[INFO] [stdout]    |              |
[INFO] [stdout]    |              help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/assembler/lexer.rs:28:19
[INFO] [stdout]    |
[INFO] [stdout] 28 | fn lex_line(line: &str, lnum: u32) -> Result<Option<SrcLine>, &str> {
[INFO] [stdout]    |                   ^^^^                              ^^^^^^^   ^^^^ the same lifetime is elided here
[INFO] [stdout]    |                   |                                 |
[INFO] [stdout]    |                   the lifetime is elided here       the same lifetime is hidden here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 28 | fn lex_line(line: &str, lnum: u32) -> Result<Option<SrcLine<'_>>, &str> {
[INFO] [stdout]    |                                                            ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/assembler/lexer.rs:67:20
[INFO] [stdout]    |
[INFO] [stdout] 67 | pub fn lex(source: &str) -> Result<TokenList, String> {
[INFO] [stdout]    |                    ^^^^            ^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                    |
[INFO] [stdout]    |                    the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 67 | pub fn lex(source: &str) -> Result<TokenList<'_>, String> {
[INFO] [stdout]    |                                             ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead
[INFO] [stdout]  --> src/io.rs:7:3
[INFO] [stdout]   |
[INFO] [stdout] 7 |   try!(f.read_to_string(&mut buffer));
[INFO] [stdout]   |   ^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead
[INFO] [stdout]  --> src/io.rs:5:15
[INFO] [stdout]   |
[INFO] [stdout] 5 |   let mut f = try!(File::open(filename));
[INFO] [stdout]   |               ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/assembler/lexer.rs:14:19
[INFO] [stdout]    |
[INFO] [stdout] 14 | const OP_CODES: [&'static str; 10] = ["ADD", "SUB", "LDA", "STO", "BR", "BRZ", "BRP", "IN", "OUT", "HLT"];
[INFO] [stdout]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/assembler/lexer.rs:40:58
[INFO] [stdout]    |
[INFO] [stdout] 40 |   src_line = SrcLine{op: "", operand: None, label: None, lnum: lnum};
[INFO] [stdout]    |                                                          ^^^^^^^^^^ help: replace it with: `lnum`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/assembler/parser.rs:20:9
[INFO] [stdout]    |
[INFO] [stdout] 20 |         loc: loc,
[INFO] [stdout]    |         ^^^^^^^^ help: replace it with: `loc`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `curr_op` is never read
[INFO] [stdout]   --> src/assembler/parser.rs:64:15
[INFO] [stdout]    |
[INFO] [stdout] 64 |               curr_op.operand = 999;
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: maybe it is overwritten before being read?
[INFO] [stdout]    = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `LMC` contains a capitalized acronym
[INFO] [stdout]  --> src/lmc.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct LMC {
[INFO] [stdout]   |            ^^^ help: consider making the acronym lowercase, except the initial letter: `Lmc`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]   = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lmc.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     return true;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 123 -     return true;
[INFO] [stdout] 123 +     true
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/lmc.rs:99:9
[INFO] [stdout]     |
[INFO] [stdout]  99 | /         if self.acc == 0 {
[INFO] [stdout] 100 | |           self.pc = self.operand;
[INFO] [stdout] 101 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  98 ~       7
[INFO] [stdout]  99 ~         if self.acc == 0 => {
[INFO] [stdout] 100 |           self.pc = self.operand;
[INFO] [stdout] 101 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/lmc.rs:106:9
[INFO] [stdout]     |
[INFO] [stdout] 106 | /         if !self.neg {
[INFO] [stdout] 107 | |           self.pc = self.operand;
[INFO] [stdout] 108 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 105 ~       8
[INFO] [stdout] 106 ~         if !self.neg => {
[INFO] [stdout] 107 |           self.pc = self.operand;
[INFO] [stdout] 108 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/lmc.rs:61:11
[INFO] [stdout]    |
[INFO] [stdout] 61 |           self.acc = self.acc % 1000;
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.acc %= 1000`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lmc.rs:134:5
[INFO] [stdout]     |
[INFO] [stdout] 134 |     return self.execute();
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 134 -     return self.execute();
[INFO] [stdout] 134 +     self.execute()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]  --> src/io.rs:8:3
[INFO] [stdout]   |
[INFO] [stdout] 8 |   return Ok(buffer);
[INFO] [stdout]   |   ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]   |
[INFO] [stdout] 8 -   return Ok(buffer);
[INFO] [stdout] 8 +   Ok(buffer)
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/io.rs:23:8
[INFO] [stdout]    |
[INFO] [stdout] 23 |     if !res.is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `input` after checking its variant with `is_some`
[INFO] [stdout]   --> src/io.rs:33:14
[INFO] [stdout]    |
[INFO] [stdout] 32 |     if input != None && input.is_some() {
[INFO] [stdout]    |                         --------------- the check is happening here
[INFO] [stdout] 33 |       return input.unwrap();
[INFO] [stdout]    |              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/io.rs:28:8
[INFO] [stdout]    |
[INFO] [stdout] 28 |     if input == None {
[INFO] [stdout]    |        ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `input.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]    = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/io.rs:32:8
[INFO] [stdout]    |
[INFO] [stdout] 32 |     if input != None && input.is_some() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `input.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/lexer.rs:23:3
[INFO] [stdout]    |
[INFO] [stdout] 23 |   return false;
[INFO] [stdout]    |   ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 -   return false;
[INFO] [stdout] 23 +   false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/lexer.rs:63:3
[INFO] [stdout]    |
[INFO] [stdout] 63 |   return Ok(Some(src_line));
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 63 -   return Ok(Some(src_line));
[INFO] [stdout] 63 +   Ok(Some(src_line))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/assembler/lexer.rs:33:6
[INFO] [stdout]    |
[INFO] [stdout] 33 |   if lexemes.len() == 0 {
[INFO] [stdout]    |      ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lexemes.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/assembler/lexer.rs:77:8
[INFO] [stdout]    |
[INFO] [stdout] 77 |     if !line_lex_res.is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^ help: try: `line_lex_res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_some`
[INFO] [stdout]   --> src/assembler/lexer.rs:86:30
[INFO] [stdout]    |
[INFO] [stdout] 85 |     if token.is_some() {
[INFO] [stdout]    |     ------------------ help: try: `if let Some(<item>) = token`
[INFO] [stdout] 86 |       token_list.tokens.push(token.unwrap());
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/lexer.rs:89:3
[INFO] [stdout]    |
[INFO] [stdout] 89 |   return Ok(token_list);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 89 -   return Ok(token_list);
[INFO] [stdout] 89 +   Ok(token_list)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `t.label` after checking its variant with `is_some`
[INFO] [stdout]   --> src/assembler/parser.rs:21:15
[INFO] [stdout]    |
[INFO] [stdout] 18 |     if t.label.is_some() {
[INFO] [stdout]    |     -------------------- help: try: `if let Some(<item>) = t.label`
[INFO] [stdout] ...
[INFO] [stdout] 21 |         name: t.label.unwrap(),
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/parser.rs:26:3
[INFO] [stdout]    |
[INFO] [stdout] 26 |   return labels;
[INFO] [stdout]    |   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 26 -   return labels;
[INFO] [stdout] 26 +   labels
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `loc` is used as a loop counter
[INFO] [stdout]   --> src/assembler/parser.rs:17:3
[INFO] [stdout]    |
[INFO] [stdout] 17 |   for t in &(token_list.tokens) {
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (loc, t) in (token_list.tokens).iter().enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `t.operand` after checking its variant with `is_some`
[INFO] [stdout]   --> src/assembler/parser.rs:59:29
[INFO] [stdout]    |
[INFO] [stdout] 58 |         if t.operand.is_some() {
[INFO] [stdout]    |         ---------------------- help: try: `if let Some(<item>) = t.operand`
[INFO] [stdout] 59 |           let operand_str = t.operand.unwrap().trim();
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/parser.rs:98:3
[INFO] [stdout]    |
[INFO] [stdout] 98 |   return Ok(operations);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 98 -   return Ok(operations);
[INFO] [stdout] 98 +   Ok(operations)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]   --> src/assembler/parser.rs:62:31
[INFO] [stdout]    |
[INFO] [stdout] 62 |             curr_op.operand = operand_res.ok().unwrap() as u16;
[INFO] [stdout]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operand_res.ok().unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/assembler/parser.rs:107:3
[INFO] [stdout]     |
[INFO] [stdout] 107 |   return ops;
[INFO] [stdout]     |   ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 107 -   return ops;
[INFO] [stdout] 107 +   ops
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/assembler/parser.rs:102:3
[INFO] [stdout]     |
[INFO] [stdout] 102 |   let ops : Result<Vec<Operation>, String>;
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 106 |   ops = op_pass(token_list, &labels);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `ops` here
[INFO] [stdout]     |
[INFO] [stdout] 102 ~   
[INFO] [stdout] 103 |   let labels: Vec<Label>;
[INFO] [stdout] 104 |
[INFO] [stdout] 105 |   labels = label_pass(token_list);
[INFO] [stdout] 106 ~   let ops : Result<Vec<Operation>, String> = op_pass(token_list, &labels);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/assembler/parser.rs:103:3
[INFO] [stdout]     |
[INFO] [stdout] 103 |   let labels: Vec<Label>;
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] 104 |
[INFO] [stdout] 105 |   labels = label_pass(token_list);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `labels` here
[INFO] [stdout]     |
[INFO] [stdout] 103 ~   
[INFO] [stdout] 104 |
[INFO] [stdout] 105 ~   let labels: Vec<Label> = label_pass(token_list);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/assembler/code_gen.rs:4:24
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub fn gen(operations: &Vec<parser::Operation>, lmc: &mut lmc::LMC) {
[INFO] [stdout]   |                        ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 4 - pub fn gen(operations: &Vec<parser::Operation>, lmc: &mut lmc::LMC) {
[INFO] [stdout] 4 + pub fn gen(operations: &[parser::Operation], lmc: &mut lmc::LMC) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]   --> src/assembler/code_gen.rs:13:36
[INFO] [stdout]    |
[INFO] [stdout] 13 |     val = (o.op_code as u16)*100 + o.operand as u16;
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^ help: try: `o.operand`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/assembler/mod.rs:14:6
[INFO] [stdout]    |
[INFO] [stdout] 14 |   if !token_list_res.is_ok() {
[INFO] [stdout]    |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `token_list_res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/assembler/mod.rs:21:6
[INFO] [stdout]    |
[INFO] [stdout] 21 |   if !operations_res.is_ok() {
[INFO] [stdout]    |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operations_res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/assembler/mod.rs:28:3
[INFO] [stdout]    |
[INFO] [stdout] 28 |   return true;
[INFO] [stdout]    |   ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -   return true;
[INFO] [stdout] 28 +   true
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/assembler/mod.rs:8:3
[INFO] [stdout]    |
[INFO] [stdout]  8 |   let token_list_res: Result<lexer::TokenList, String>;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 13 |   token_list_res = lexer::lex(src);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `token_list_res` here
[INFO] [stdout]    |
[INFO] [stdout]  8 ~   
[INFO] [stdout]  9 |   let token_list: lexer::TokenList;
[INFO] [stdout] ...
[INFO] [stdout] 12 |
[INFO] [stdout] 13 ~   let token_list_res: Result<lexer::TokenList, String> = lexer::lex(src);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/assembler/mod.rs:9:3
[INFO] [stdout]    |
[INFO] [stdout]  9 |   let token_list: lexer::TokenList;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 18 |   token_list = token_list_res.ok().unwrap();
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `token_list` here
[INFO] [stdout]    |
[INFO] [stdout]  9 ~   
[INFO] [stdout] 10 |   let operations_res: Result<Vec<parser::Operation>, String>;
[INFO] [stdout] ...
[INFO] [stdout] 17 |   }
[INFO] [stdout] 18 ~   let token_list: lexer::TokenList = token_list_res.ok().unwrap();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/assembler/mod.rs:10:3
[INFO] [stdout]    |
[INFO] [stdout] 10 |   let operations_res: Result<Vec<parser::Operation>, String>;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 20 |   operations_res = parser::parse(&token_list);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `operations_res` here
[INFO] [stdout]    |
[INFO] [stdout] 10 ~   
[INFO] [stdout] 11 |   let operations: Vec<parser::Operation>;
[INFO] [stdout] ...
[INFO] [stdout] 19 |
[INFO] [stdout] 20 ~   let operations_res: Result<Vec<parser::Operation>, String> = parser::parse(&token_list);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/assembler/mod.rs:11:3
[INFO] [stdout]    |
[INFO] [stdout] 11 |   let operations: Vec<parser::Operation>;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here
[INFO] [stdout] ...
[INFO] [stdout] 25 |   operations = operations_res.ok().unwrap();
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `operations` here
[INFO] [stdout]    |
[INFO] [stdout] 11 ~   
[INFO] [stdout] 12 |
[INFO] [stdout] ...
[INFO] [stdout] 24 |   }
[INFO] [stdout] 25 ~   let operations: Vec<parser::Operation> = operations_res.ok().unwrap();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]  --> src/main.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 |     println!("");
[INFO] [stdout]   |     ^^^^^^^^^--^
[INFO] [stdout]   |              |
[INFO] [stdout]   |              help: remove the empty string
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]   = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     println!("");
[INFO] [stdout]    |     ^^^^^^^^^--^
[INFO] [stdout]    |              |
[INFO] [stdout]    |              help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/assembler/lexer.rs:28:19
[INFO] [stdout]    |
[INFO] [stdout] 28 | fn lex_line(line: &str, lnum: u32) -> Result<Option<SrcLine>, &str> {
[INFO] [stdout]    |                   ^^^^                              ^^^^^^^   ^^^^ the same lifetime is elided here
[INFO] [stdout]    |                   |                                 |
[INFO] [stdout]    |                   the lifetime is elided here       the same lifetime is hidden here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 28 | fn lex_line(line: &str, lnum: u32) -> Result<Option<SrcLine<'_>>, &str> {
[INFO] [stdout]    |                                                            ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/assembler/lexer.rs:67:20
[INFO] [stdout]    |
[INFO] [stdout] 67 | pub fn lex(source: &str) -> Result<TokenList, String> {
[INFO] [stdout]    |                    ^^^^            ^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                    |
[INFO] [stdout]    |                    the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 67 | pub fn lex(source: &str) -> Result<TokenList<'_>, String> {
[INFO] [stdout]    |                                             ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s
[INFO] running `Command { std: "docker" "inspect" "e31e5ed52601dd9eb2e8d8ded9468b29a8a1ae44dc1051c58c21056f32312219", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e31e5ed52601dd9eb2e8d8ded9468b29a8a1ae44dc1051c58c21056f32312219", kill_on_drop: false }`
[INFO] [stdout] e31e5ed52601dd9eb2e8d8ded9468b29a8a1ae44dc1051c58c21056f32312219