[INFO] cloning repository https://github.com/tom-james-watson/converter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tom-james-watson/converter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftom-james-watson%2Fconverter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftom-james-watson%2Fconverter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c690ee67f878358bce381b9839a4c4c47d42a495 [INFO] linting tom-james-watson/converter against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftom-james-watson%2Fconverter" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tom-james-watson/converter [INFO] finished tweaking git repo https://github.com/tom-james-watson/converter [INFO] tweaked toml for git repo https://github.com/tom-james-watson/converter written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tom-james-watson/converter on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tom-james-watson/converter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded futures-task v0.3.13 [INFO] [stderr] Downloaded futures-macro v0.3.13 [INFO] [stderr] Downloaded futures-core v0.3.13 [INFO] [stderr] Downloaded futures-executor v0.3.13 [INFO] [stderr] Downloaded futures-io v0.3.13 [INFO] [stderr] Downloaded anyhow v1.0.38 [INFO] [stderr] Downloaded futures v0.3.13 [INFO] [stderr] Downloaded futures-util v0.3.13 [INFO] [stderr] Downloaded futures-channel v0.3.13 [INFO] [stderr] Downloaded futures-sink v0.3.13 [INFO] [stderr] Downloaded relm v0.21.0 [INFO] [stderr] Downloaded relm-derive v0.21.0 [INFO] [stderr] Downloaded libc v0.2.87 [INFO] [stderr] Downloaded syn v1.0.61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7773330048f68bc30383c9c3888329f27a0f2ec244b3663635f003433976d74 [INFO] running `Command { std: "docker" "start" "-a" "a7773330048f68bc30383c9c3888329f27a0f2ec244b3663635f003433976d74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7773330048f68bc30383c9c3888329f27a0f2ec244b3663635f003433976d74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7773330048f68bc30383c9c3888329f27a0f2ec244b3663635f003433976d74", kill_on_drop: false }` [INFO] [stdout] a7773330048f68bc30383c9c3888329f27a0f2ec244b3663635f003433976d74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d3865f68703ec670a75785aa0dcaa5324f983bab4a04266c99a0309adadb3f2 [INFO] running `Command { std: "docker" "start" "-a" "9d3865f68703ec670a75785aa0dcaa5324f983bab4a04266c99a0309adadb3f2", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.61 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling strum v0.18.0 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling libc v0.2.87 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking futures-sink v0.3.13 [INFO] [stderr] Checking futures-core v0.3.13 [INFO] [stderr] Checking futures-task v0.3.13 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking memchr v2.3.4 [INFO] [stderr] Checking futures-io v0.3.13 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling gio v0.9.1 [INFO] [stderr] Compiling pango v0.9.1 [INFO] [stderr] Compiling gdk-pixbuf v0.9.0 [INFO] [stderr] Compiling cairo-rs v0.9.1 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Compiling gdk v0.13.2 [INFO] [stderr] Compiling atk v0.9.0 [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Checking futures-channel v0.3.13 [INFO] [stderr] Compiling gtk v0.9.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking quote v0.6.13 [INFO] [stderr] Checking regex v1.4.5 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Compiling futures-macro v0.3.13 [INFO] [stderr] Compiling glib-macros v0.10.1 [INFO] [stderr] Compiling relm-derive v0.21.0 [INFO] [stderr] Checking futures-util v0.3.13 [INFO] [stderr] Compiling thiserror v1.0.24 [INFO] [stderr] Compiling system-deps v1.3.2 [INFO] [stderr] Compiling glib-sys v0.10.1 [INFO] [stderr] Compiling gobject-sys v0.10.0 [INFO] [stderr] Compiling gio-sys v0.10.1 [INFO] [stderr] Compiling cairo-sys-rs v0.10.0 [INFO] [stderr] Compiling pango-sys v0.10.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.10.0 [INFO] [stderr] Compiling gdk-sys v0.10.0 [INFO] [stderr] Compiling atk-sys v0.10.0 [INFO] [stderr] Compiling gtk-sys v0.10.0 [INFO] [stderr] Checking futures-executor v0.3.13 [INFO] [stderr] Checking glib v0.10.3 [INFO] [stderr] Checking futures v0.3.13 [INFO] [stderr] Checking relm v0.21.0 [INFO] [stderr] Checking converter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | if !from_unit_type_idx.is_some() || !from_unit_idx.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_unit_type_idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:53 [INFO] [stdout] | [INFO] [stdout] 93 | if !from_unit_type_idx.is_some() || !from_unit_idx.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_unit_idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 104 | if !to_unit_type_idx.is_some() || !to_unit_idx.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `to_unit_type_idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:104:51 [INFO] [stdout] | [INFO] [stdout] 104 | if !to_unit_type_idx.is_some() || !to_unit_idx.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `to_unit_idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | if !from_unit_type_idx.is_some() || !from_unit_idx.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_unit_type_idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:53 [INFO] [stdout] | [INFO] [stdout] 93 | if !from_unit_type_idx.is_some() || !from_unit_idx.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_unit_idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 104 | if !to_unit_type_idx.is_some() || !to_unit_idx.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `to_unit_type_idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:104:51 [INFO] [stdout] | [INFO] [stdout] 104 | if !to_unit_type_idx.is_some() || !to_unit_idx.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `to_unit_idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:174:44 [INFO] [stdout] | [INFO] [stdout] 174 | self.model.from_value = if from_value.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `from_value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:216:42 [INFO] [stdout] | [INFO] [stdout] 216 | self.model.to_value = if to_value.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `to_value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:426:9 [INFO] [stdout] | [INFO] [stdout] 426 | / match self.model.from_value { [INFO] [stdout] 427 | | Some(Ok(from_value)) => { [INFO] [stdout] 428 | | let units = &self.model.unit_types[self.model.unit_type_idx].units; [INFO] [stdout] 429 | | let cmd_value = format!( [INFO] [stdout] ... | [INFO] [stdout] 441 | | _ => {} [INFO] [stdout] 442 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 426 ~ if let Some(Ok(from_value)) = self.model.from_value { [INFO] [stdout] 427 + let units = &self.model.unit_types[self.model.unit_type_idx].units; [INFO] [stdout] 428 + let cmd_value = format!( [INFO] [stdout] 429 + "{}{} in {}", [INFO] [stdout] 430 + &from_value, [INFO] [stdout] 431 + units[self.model.from_unit_idx].abbreviation, [INFO] [stdout] 432 + units[self.model.to_unit_idx].abbreviation [INFO] [stdout] 433 + ); [INFO] [stdout] 434 + dbg!(&cmd_value); [INFO] [stdout] 435 + dbg!(&self.model.cmd_value); [INFO] [stdout] 436 + if self.model.cmd_value != cmd_value { [INFO] [stdout] 437 + self.cmd_entry.set_text(&cmd_value); [INFO] [stdout] 438 + } [INFO] [stdout] 439 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:454:9 [INFO] [stdout] | [INFO] [stdout] 454 | return (None, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 454 - return (None, None); [INFO] [stdout] 454 + (None, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:174:44 [INFO] [stdout] | [INFO] [stdout] 174 | self.model.from_value = if from_value.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `from_value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:216:42 [INFO] [stdout] | [INFO] [stdout] 216 | self.model.to_value = if to_value.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `to_value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:426:9 [INFO] [stdout] | [INFO] [stdout] 426 | / match self.model.from_value { [INFO] [stdout] 427 | | Some(Ok(from_value)) => { [INFO] [stdout] 428 | | let units = &self.model.unit_types[self.model.unit_type_idx].units; [INFO] [stdout] 429 | | let cmd_value = format!( [INFO] [stdout] ... | [INFO] [stdout] 441 | | _ => {} [INFO] [stdout] 442 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 426 ~ if let Some(Ok(from_value)) = self.model.from_value { [INFO] [stdout] 427 + let units = &self.model.unit_types[self.model.unit_type_idx].units; [INFO] [stdout] 428 + let cmd_value = format!( [INFO] [stdout] 429 + "{}{} in {}", [INFO] [stdout] 430 + &from_value, [INFO] [stdout] 431 + units[self.model.from_unit_idx].abbreviation, [INFO] [stdout] 432 + units[self.model.to_unit_idx].abbreviation [INFO] [stdout] 433 + ); [INFO] [stdout] 434 + dbg!(&cmd_value); [INFO] [stdout] 435 + dbg!(&self.model.cmd_value); [INFO] [stdout] 436 + if self.model.cmd_value != cmd_value { [INFO] [stdout] 437 + self.cmd_entry.set_text(&cmd_value); [INFO] [stdout] 438 + } [INFO] [stdout] 439 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:454:9 [INFO] [stdout] | [INFO] [stdout] 454 | return (None, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 454 - return (None, None); [INFO] [stdout] 454 + (None, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 52.07s [INFO] running `Command { std: "docker" "inspect" "9d3865f68703ec670a75785aa0dcaa5324f983bab4a04266c99a0309adadb3f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d3865f68703ec670a75785aa0dcaa5324f983bab4a04266c99a0309adadb3f2", kill_on_drop: false }` [INFO] [stdout] 9d3865f68703ec670a75785aa0dcaa5324f983bab4a04266c99a0309adadb3f2