[INFO] cloning repository https://github.com/tom-code/rust-sctp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tom-code/rust-sctp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftom-code%2Frust-sctp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftom-code%2Frust-sctp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 935b075de1c4fb61ae493a7aa41ac3a4d0cfc44d [INFO] linting tom-code/rust-sctp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftom-code%2Frust-sctp" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tom-code/rust-sctp [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/tom-code/rust-sctp [INFO] tweaked toml for git repo https://github.com/tom-code/rust-sctp written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tom-code/rust-sctp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tom-code/rust-sctp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Updating libc v0.2.152 -> v0.2.183 [INFO] [stderr] Updating mio v0.8.10 -> v1.1.1 [INFO] [stderr] Updating socket2 v0.5.5 -> v0.6.3 [INFO] [stderr] Updating tokio v1.38.0 -> v1.50.0 [INFO] [stderr] Updating tokio-macros v2.3.0 -> v2.6.1 [INFO] [stderr] Adding windows-link v0.2.1 [INFO] [stderr] Updating windows-sys v0.48.0 -> v0.61.2 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded os_socketaddr v0.2.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0bfad226a986c0c47e0a65b9048473fc519bb12a884ea88d0c032827f2d9f775 [INFO] running `Command { std: "docker" "start" "-a" "0bfad226a986c0c47e0a65b9048473fc519bb12a884ea88d0c032827f2d9f775", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0bfad226a986c0c47e0a65b9048473fc519bb12a884ea88d0c032827f2d9f775", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bfad226a986c0c47e0a65b9048473fc519bb12a884ea88d0c032827f2d9f775", kill_on_drop: false }` [INFO] [stdout] 0bfad226a986c0c47e0a65b9048473fc519bb12a884ea88d0c032827f2d9f775 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2237b1888977ef5572152f044f0e1c00b7e58f2be2aebc6445db75707859c2db [INFO] running `Command { std: "docker" "start" "-a" "2237b1888977ef5572152f044f0e1c00b7e58f2be2aebc6445db75707859c2db", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking os_socketaddr v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking sctp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `addr`, `state`, and `error` are never read [INFO] [stdout] --> src/sctp.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 143 | pub struct NotificationAddress { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] 144 | addr: std::net::SocketAddr, [INFO] [stdout] | ^^^^ [INFO] [stdout] 145 | state: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 146 | error: u32 [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NotificationAddress` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `addr`, `state`, and `error` are never read [INFO] [stdout] --> src/sctp.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 143 | pub struct NotificationAddress { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] 144 | addr: std::net::SocketAddr, [INFO] [stdout] | ^^^^ [INFO] [stdout] 145 | state: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 146 | error: u32 [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NotificationAddress` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/sctp.rs:459:25 [INFO] [stdout] | [INFO] [stdout] 459 | None => Err(Error::new(std::io::ErrorKind::Other, "Invalid socket address")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 459 - None => Err(Error::new(std::io::ErrorKind::Other, "Invalid socket address")), [INFO] [stdout] 459 + None => Err(Error::other("Invalid socket address")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/sctp.rs:475:25 [INFO] [stdout] | [INFO] [stdout] 475 | None => Err(Error::new(std::io::ErrorKind::Other, "Invalid socket address")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 475 - None => Err(Error::new(std::io::ErrorKind::Other, "Invalid socket address")), [INFO] [stdout] 475 + None => Err(Error::other("Invalid socket address")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/sctp.rs:594:6 [INFO] [stdout] | [INFO] [stdout] 594 | impl<'a> std::io::Read for &'a SctpSocket { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 594 - impl<'a> std::io::Read for &'a SctpSocket { [INFO] [stdout] 594 + impl std::io::Read for &SctpSocket { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/sctp.rs:611:6 [INFO] [stdout] | [INFO] [stdout] 611 | impl<'a> std::io::Write for &'a SctpSocket { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 611 - impl<'a> std::io::Write for &'a SctpSocket { [INFO] [stdout] 611 + impl std::io::Write for &SctpSocket { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/split.rs:48:6 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a> AsyncRead for &'a ReadHalfSctp { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 48 - impl<'a> AsyncRead for &'a ReadHalfSctp { [INFO] [stdout] 48 + impl AsyncRead for &ReadHalfSctp { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/asyn.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | impl<'a> AsyncRead for &'a SctpSocketTokio { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 28 - impl<'a> AsyncRead for &'a SctpSocketTokio { [INFO] [stdout] 28 + impl AsyncRead for &SctpSocketTokio { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/asyn.rs:88:16 [INFO] [stdout] | [INFO] [stdout] 88 | if !e.raw_os_error().is_some_and(|e| e == libc::EINPROGRESS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `e.raw_os_error().is_none_or(|e| e != libc::EINPROGRESS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/asyn.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | if !e.raw_os_error().is_some_and(|e| e == libc::EINPROGRESS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `e.raw_os_error().is_none_or(|e| e != libc::EINPROGRESS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/sctp.rs:459:25 [INFO] [stdout] | [INFO] [stdout] 459 | None => Err(Error::new(std::io::ErrorKind::Other, "Invalid socket address")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 459 - None => Err(Error::new(std::io::ErrorKind::Other, "Invalid socket address")), [INFO] [stdout] 459 + None => Err(Error::other("Invalid socket address")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/sctp.rs:475:25 [INFO] [stdout] | [INFO] [stdout] 475 | None => Err(Error::new(std::io::ErrorKind::Other, "Invalid socket address")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 475 - None => Err(Error::new(std::io::ErrorKind::Other, "Invalid socket address")), [INFO] [stdout] 475 + None => Err(Error::other("Invalid socket address")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/sctp.rs:594:6 [INFO] [stdout] | [INFO] [stdout] 594 | impl<'a> std::io::Read for &'a SctpSocket { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 594 - impl<'a> std::io::Read for &'a SctpSocket { [INFO] [stdout] 594 + impl std::io::Read for &SctpSocket { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/sctp.rs:611:6 [INFO] [stdout] | [INFO] [stdout] 611 | impl<'a> std::io::Write for &'a SctpSocket { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 611 - impl<'a> std::io::Write for &'a SctpSocket { [INFO] [stdout] 611 + impl std::io::Write for &SctpSocket { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/split.rs:48:6 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a> AsyncRead for &'a ReadHalfSctp { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 48 - impl<'a> AsyncRead for &'a ReadHalfSctp { [INFO] [stdout] 48 + impl AsyncRead for &ReadHalfSctp { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/asyn.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | impl<'a> AsyncRead for &'a SctpSocketTokio { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 28 - impl<'a> AsyncRead for &'a SctpSocketTokio { [INFO] [stdout] 28 + impl AsyncRead for &SctpSocketTokio { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/asyn.rs:88:16 [INFO] [stdout] | [INFO] [stdout] 88 | if !e.raw_os_error().is_some_and(|e| e == libc::EINPROGRESS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `e.raw_os_error().is_none_or(|e| e != libc::EINPROGRESS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/asyn.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | if !e.raw_os_error().is_some_and(|e| e == libc::EINPROGRESS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `e.raw_os_error().is_none_or(|e| e != libc::EINPROGRESS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.24s [INFO] running `Command { std: "docker" "inspect" "2237b1888977ef5572152f044f0e1c00b7e58f2be2aebc6445db75707859c2db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2237b1888977ef5572152f044f0e1c00b7e58f2be2aebc6445db75707859c2db", kill_on_drop: false }` [INFO] [stdout] 2237b1888977ef5572152f044f0e1c00b7e58f2be2aebc6445db75707859c2db