[INFO] cloning repository https://github.com/tmb5932/chip8-embedded [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tmb5932/chip8-embedded" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftmb5932%2Fchip8-embedded", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftmb5932%2Fchip8-embedded'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 96c255c4b739233d4b3cc2f90b3f3b9ca7d3197a [INFO] linting tmb5932/chip8-embedded against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftmb5932%2Fchip8-embedded" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tmb5932/chip8-embedded [INFO] finished tweaking git repo https://github.com/tmb5932/chip8-embedded [INFO] tweaked toml for git repo https://github.com/tmb5932/chip8-embedded written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tmb5932/chip8-embedded on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tmb5932/chip8-embedded already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rppal v0.22.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ff0eabd236132f491653fa8a73b41f24f5d273584945fca05a8bae54b90a6a2 [INFO] running `Command { std: "docker" "start" "-a" "7ff0eabd236132f491653fa8a73b41f24f5d273584945fca05a8bae54b90a6a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ff0eabd236132f491653fa8a73b41f24f5d273584945fca05a8bae54b90a6a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ff0eabd236132f491653fa8a73b41f24f5d273584945fca05a8bae54b90a6a2", kill_on_drop: false }` [INFO] [stdout] 7ff0eabd236132f491653fa8a73b41f24f5d273584945fca05a8bae54b90a6a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cecb5de2fc6d9d88edc1e116e85133582b934507b1fe90c888413054c4a3c0bc [INFO] running `Command { std: "docker" "start" "-a" "cecb5de2fc6d9d88edc1e116e85133582b934507b1fe90c888413054c4a3c0bc", kill_on_drop: false }` [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking rppal v0.22.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking chip8-embedded-emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/chip8.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | quirks: quirks, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `quirks` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/quirks.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | shift: shift, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `shift` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/quirks.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | jump: jump, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `jump` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/quirks.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | vf_reset: vf_reset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vf_reset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/quirks.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | clip: clip [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `clip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/chip8.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | quirks: quirks, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `quirks` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/quirks.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | shift: shift, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `shift` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/quirks.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | jump: jump, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `jump` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/quirks.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | vf_reset: vf_reset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vf_reset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/quirks.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | clip: clip [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `clip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VERT_START_MASK` is never used [INFO] [stdout] --> src/display.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | const VERT_START_MASK: u8 = 0x3F; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `turn_off`, `turn_on`, `shift_up`, and `fill` are never used [INFO] [stdout] --> src/display.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 52 | impl DisplayInterface { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 110 | pub fn turn_off(&mut self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 114 | pub fn turn_on(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | pub fn shift_up(&mut self, shift_amount: usize, delay: u64) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | pub fn fill(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `array` [INFO] [stdout] --> src/display.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 137 | for row in 0..SOURCE_HEIGHT { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 137 - for row in 0..SOURCE_HEIGHT { [INFO] [stdout] 137 + for (row, ) in array.iter().enumerate().take(SOURCE_HEIGHT) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `array` [INFO] [stdout] --> src/display.rs:138:24 [INFO] [stdout] | [INFO] [stdout] 138 | for col in 0..SOURCE_WIDTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 138 - for col in 0..SOURCE_WIDTH { [INFO] [stdout] 138 + for (col, ) in array.iter().enumerate().take(SOURCE_WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VERT_START_MASK` is never used [INFO] [stdout] --> src/display.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | const VERT_START_MASK: u8 = 0x3F; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `turn_off`, `turn_on`, `shift_up`, and `fill` are never used [INFO] [stdout] --> src/display.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 52 | impl DisplayInterface { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 110 | pub fn turn_off(&mut self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 114 | pub fn turn_on(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | pub fn shift_up(&mut self, shift_amount: usize, delay: u64) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | pub fn fill(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/chip8.rs:154:46 [INFO] [stdout] | [INFO] [stdout] 154 | self.memory[start_location + offset as usize] = ascii_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/chip8.rs:157:42 [INFO] [stdout] | [INFO] [stdout] 157 | self.memory[start_location + offset as usize] = 0x06; // ACK byte at end of each word [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chip8.rs:419:28 [INFO] [stdout] | [INFO] [stdout] 419 | if !self.wait_for_release || (self.wait_for_release && self.keypad[self.wait_key]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 419 - if !self.wait_for_release || (self.wait_for_release && self.keypad[self.wait_key]) { [INFO] [stdout] 419 + if !(self.wait_for_release && !self.keypad[self.wait_key]) { [INFO] [stdout] | [INFO] [stdout] 419 - if !self.wait_for_release || (self.wait_for_release && self.keypad[self.wait_key]) { [INFO] [stdout] 419 + if !self.wait_for_release || self.keypad[self.wait_key] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:254:25 [INFO] [stdout] | [INFO] [stdout] 254 | self.v[inst.x] = self.v[inst.x] | self.v[inst.y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[inst.x] |= self.v[inst.y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `array` [INFO] [stdout] --> src/display.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 137 | for row in 0..SOURCE_HEIGHT { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 137 - for row in 0..SOURCE_HEIGHT { [INFO] [stdout] 137 + for (row, ) in array.iter().enumerate().take(SOURCE_HEIGHT) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `array` [INFO] [stdout] --> src/display.rs:138:24 [INFO] [stdout] | [INFO] [stdout] 138 | for col in 0..SOURCE_WIDTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 138 - for col in 0..SOURCE_WIDTH { [INFO] [stdout] 138 + for (col, ) in array.iter().enumerate().take(SOURCE_WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:261:25 [INFO] [stdout] | [INFO] [stdout] 261 | self.v[inst.x] = self.v[inst.x] & self.v[inst.y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[inst.x] &= self.v[inst.y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:268:25 [INFO] [stdout] | [INFO] [stdout] 268 | self.v[inst.x] = self.v[inst.x] ^ self.v[inst.y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[inst.x] ^= self.v[inst.y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/chip8.rs:154:46 [INFO] [stdout] | [INFO] [stdout] 154 | self.memory[start_location + offset as usize] = ascii_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/chip8.rs:157:42 [INFO] [stdout] | [INFO] [stdout] 157 | self.memory[start_location + offset as usize] = 0x06; // ACK byte at end of each word [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chip8.rs:419:28 [INFO] [stdout] | [INFO] [stdout] 419 | if !self.wait_for_release || (self.wait_for_release && self.keypad[self.wait_key]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 419 - if !self.wait_for_release || (self.wait_for_release && self.keypad[self.wait_key]) { [INFO] [stdout] 419 + if !(self.wait_for_release && !self.keypad[self.wait_key]) { [INFO] [stdout] | [INFO] [stdout] 419 - if !self.wait_for_release || (self.wait_for_release && self.keypad[self.wait_key]) { [INFO] [stdout] 419 + if !self.wait_for_release || self.keypad[self.wait_key] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:254:25 [INFO] [stdout] | [INFO] [stdout] 254 | self.v[inst.x] = self.v[inst.x] | self.v[inst.y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[inst.x] |= self.v[inst.y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:261:25 [INFO] [stdout] | [INFO] [stdout] 261 | self.v[inst.x] = self.v[inst.x] & self.v[inst.y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[inst.x] &= self.v[inst.y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:268:25 [INFO] [stdout] | [INFO] [stdout] 268 | self.v[inst.x] = self.v[inst.x] ^ self.v[inst.y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[inst.x] ^= self.v[inst.y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 122 | if !chip8.debug || (chip8.debug &&!chip8.paused) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 122 - if !chip8.debug || (chip8.debug &&!chip8.paused) { [INFO] [stdout] 122 + if !(chip8.debug && chip8.paused) { [INFO] [stdout] | [INFO] [stdout] 122 - if !chip8.debug || (chip8.debug &&!chip8.paused) { [INFO] [stdout] 122 + if !chip8.debug || !chip8.paused { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | / if col.read() == Level::Low { [INFO] [stdout] 93 | | chip8.keypad[key as usize] = true; [INFO] [stdout] 94 | | } else { [INFO] [stdout] 95 | | chip8.keypad[key as usize] = false; [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `chip8.keypad[key as usize] = col.read() == Level::Low;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 162 | chip8.load_rom(&menu_file.to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `menu_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 122 | if !chip8.debug || (chip8.debug &&!chip8.paused) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 122 - if !chip8.debug || (chip8.debug &&!chip8.paused) { [INFO] [stdout] 122 + if !(chip8.debug && chip8.paused) { [INFO] [stdout] | [INFO] [stdout] 122 - if !chip8.debug || (chip8.debug &&!chip8.paused) { [INFO] [stdout] 122 + if !chip8.debug || !chip8.paused { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | / if col.read() == Level::Low { [INFO] [stdout] 93 | | chip8.keypad[key as usize] = true; [INFO] [stdout] 94 | | } else { [INFO] [stdout] 95 | | chip8.keypad[key as usize] = false; [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `chip8.keypad[key as usize] = col.read() == Level::Low;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 162 | chip8.load_rom(&menu_file.to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `menu_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.71s [INFO] running `Command { std: "docker" "inspect" "cecb5de2fc6d9d88edc1e116e85133582b934507b1fe90c888413054c4a3c0bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cecb5de2fc6d9d88edc1e116e85133582b934507b1fe90c888413054c4a3c0bc", kill_on_drop: false }` [INFO] [stdout] cecb5de2fc6d9d88edc1e116e85133582b934507b1fe90c888413054c4a3c0bc