[INFO] cloning repository https://github.com/tjjfvi/rectdissect [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tjjfvi/rectdissect" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftjjfvi%2Frectdissect", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftjjfvi%2Frectdissect'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 36aa8d23199841821f169675153d8a3d7e682c1a [INFO] linting tjjfvi/rectdissect against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftjjfvi%2Frectdissect" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tjjfvi/rectdissect [INFO] finished tweaking git repo https://github.com/tjjfvi/rectdissect [INFO] tweaked toml for git repo https://github.com/tjjfvi/rectdissect written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tjjfvi/rectdissect on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tjjfvi/rectdissect already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded helper_fn v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d99c802f3c9d1b89d0fb9e3bf97ac358ed318b202d4a37f2f65f246b602ffad8 [INFO] running `Command { std: "docker" "start" "-a" "d99c802f3c9d1b89d0fb9e3bf97ac358ed318b202d4a37f2f65f246b602ffad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d99c802f3c9d1b89d0fb9e3bf97ac358ed318b202d4a37f2f65f246b602ffad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d99c802f3c9d1b89d0fb9e3bf97ac358ed318b202d4a37f2f65f246b602ffad8", kill_on_drop: false }` [INFO] [stdout] d99c802f3c9d1b89d0fb9e3bf97ac358ed318b202d4a37f2f65f246b602ffad8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ee0c770d567d842fc31db3de421aa3a318f9578003df05021598ee8b187184c [INFO] running `Command { std: "docker" "start" "-a" "6ee0c770d567d842fc31db3de421aa3a318f9578003df05021598ee8b187184c", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking chashmap v2.2.2 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking blake2 v0.9.2 [INFO] [stderr] Compiling helper_fn v0.1.0 [INFO] [stderr] Checking rectdissect v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused macro definition: `visit_node` [INFO] [stdout] --> src/hash_division.rs:43:4 [INFO] [stdout] | [INFO] [stdout] 43 | fn visit_node(node: Node, last: Node) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `print_state` [INFO] [stdout] --> src/main.rs:60:6 [INFO] [stdout] | [INFO] [stdout] 60 | fn print_state(i: u8, start: Instant, round_start: Instant) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `add_div` [INFO] [stdout] --> src/main.rs:81:6 [INFO] [stdout] | [INFO] [stdout] 81 | fn add_div(div: Division) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `visit_node` [INFO] [stdout] --> src/hash_division.rs:43:4 [INFO] [stdout] | [INFO] [stdout] 43 | fn visit_node(node: Node, last: Node) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `print_state` [INFO] [stdout] --> src/main.rs:60:6 [INFO] [stdout] | [INFO] [stdout] 60 | fn print_state(i: u8, start: Instant, round_start: Instant) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `add_div` [INFO] [stdout] --> src/main.rs:81:6 [INFO] [stdout] | [INFO] [stdout] 81 | fn add_div(div: Division) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/divide.rs:35:23 [INFO] [stdout] | [INFO] [stdout] 35 | / return Some(_divide( [INFO] [stdout] 36 | | div, [INFO] [stdout] 37 | | connected_nodes, [INFO] [stdout] 38 | | region, [INFO] [stdout] ... | [INFO] [stdout] 44 | | share_1, [INFO] [stdout] 45 | | )); [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ Some(_divide( [INFO] [stdout] 36 + div, [INFO] [stdout] 37 + connected_nodes, [INFO] [stdout] 38 + region, [INFO] [stdout] 39 + cut_0_ind, [INFO] [stdout] 40 + cut_0, [INFO] [stdout] 41 + cut_1_ind, [INFO] [stdout] 42 + cut_1, [INFO] [stdout] 43 + share_0, [INFO] [stdout] 44 + share_1, [INFO] [stdout] 45 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/divide.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | let expand = false [INFO] [stdout] | ________________^ [INFO] [stdout] 68 | | || (share_0 && div[cut_0].len() == div.max_connections()) [INFO] [stdout] 69 | | || (share_1 && div[cut_1].len() == div.max_connections()); [INFO] [stdout] | |_____________________________________________________________^ help: try: `share_0 && div[cut_0].len() == div.max_connections() || share_1 && div[cut_1].len() == div.max_connections()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/divide.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | let expand = false [INFO] [stdout] | ________________^ [INFO] [stdout] 68 | | || (share_0 && div[cut_0].len() == div.max_connections()) [INFO] [stdout] | |_____________________________________________________________^ help: try: `share_0 && div[cut_0].len() == div.max_connections()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/divide.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / fn _divide( [INFO] [stdout] 56 | | div: &Division, [INFO] [stdout] 57 | | connected_nodes: &ConnectedNodes, [INFO] [stdout] 58 | | region: Node, [INFO] [stdout] ... | [INFO] [stdout] 64 | | share_1: bool, [INFO] [stdout] 65 | | ) -> Division { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/generate_layout.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | let axis = root % 2 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `root.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/generate_layout.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 81 | classification.all_true.len() == 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `classification.all_true.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/generate_layout.rs:82:15 [INFO] [stdout] | [INFO] [stdout] 82 | classification.all_false.len() == 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `classification.all_false.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/hash_division.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | return hash; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return hash; [INFO] [stdout] 32 + hash [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/hash_division.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | / #[helper_fn( [INFO] [stdout] 36 | | div: &Division, [INFO] [stdout] 37 | | edge_labels: Option<&EdgeLabels>, [INFO] [stdout] 38 | | start: u8, [INFO] [stdout] ... | [INFO] [stdout] 41 | | &mut node_ids: Vec, [INFO] [stdout] 42 | | )] [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: this warning originates in the attribute macro `helper_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/hash_division.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | .map(|&x| x == (start % 2 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `start.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/label_edges.rs:63:10 [INFO] [stdout] | [INFO] [stdout] 63 | if state.unlabeled_edges.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `state.unlabeled_edges.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/label_edges.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 74 | .or_else(|| state.unlabeled_edges.iter().next().map(|&x| x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `state.unlabeled_edges.iter().next().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/label_edges.rs:155:10 [INFO] [stdout] | [INFO] [stdout] 155 | if all_none.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!all_none.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/label_edges.rs:169:10 [INFO] [stdout] | [INFO] [stdout] 169 | if all_none.len() == 0 && (true_vecs_count != 2 || false_vecs_count != 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `all_none.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/svg.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | let height = (count + max_row_width - 1) / max_row_width; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `count.div_ceil(max_row_width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/divide.rs:35:23 [INFO] [stdout] | [INFO] [stdout] 35 | / return Some(_divide( [INFO] [stdout] 36 | | div, [INFO] [stdout] 37 | | connected_nodes, [INFO] [stdout] 38 | | region, [INFO] [stdout] ... | [INFO] [stdout] 44 | | share_1, [INFO] [stdout] 45 | | )); [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ Some(_divide( [INFO] [stdout] 36 + div, [INFO] [stdout] 37 + connected_nodes, [INFO] [stdout] 38 + region, [INFO] [stdout] 39 + cut_0_ind, [INFO] [stdout] 40 + cut_0, [INFO] [stdout] 41 + cut_1_ind, [INFO] [stdout] 42 + cut_1, [INFO] [stdout] 43 + share_0, [INFO] [stdout] 44 + share_1, [INFO] [stdout] 45 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/divide.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | let expand = false [INFO] [stdout] | ________________^ [INFO] [stdout] 68 | | || (share_0 && div[cut_0].len() == div.max_connections()) [INFO] [stdout] 69 | | || (share_1 && div[cut_1].len() == div.max_connections()); [INFO] [stdout] | |_____________________________________________________________^ help: try: `share_0 && div[cut_0].len() == div.max_connections() || share_1 && div[cut_1].len() == div.max_connections()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/divide.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | let expand = false [INFO] [stdout] | ________________^ [INFO] [stdout] 68 | | || (share_0 && div[cut_0].len() == div.max_connections()) [INFO] [stdout] | |_____________________________________________________________^ help: try: `share_0 && div[cut_0].len() == div.max_connections()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/divide.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / fn _divide( [INFO] [stdout] 56 | | div: &Division, [INFO] [stdout] 57 | | connected_nodes: &ConnectedNodes, [INFO] [stdout] 58 | | region: Node, [INFO] [stdout] ... | [INFO] [stdout] 64 | | share_1: bool, [INFO] [stdout] 65 | | ) -> Division { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/generate_layout.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | let axis = root % 2 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `root.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/generate_layout.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 81 | classification.all_true.len() == 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `classification.all_true.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/generate_layout.rs:82:15 [INFO] [stdout] | [INFO] [stdout] 82 | classification.all_false.len() == 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `classification.all_false.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/hash_division.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | return hash; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return hash; [INFO] [stdout] 32 + hash [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/hash_division.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | / #[helper_fn( [INFO] [stdout] 36 | | div: &Division, [INFO] [stdout] 37 | | edge_labels: Option<&EdgeLabels>, [INFO] [stdout] 38 | | start: u8, [INFO] [stdout] ... | [INFO] [stdout] 41 | | &mut node_ids: Vec, [INFO] [stdout] 42 | | )] [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: this warning originates in the attribute macro `helper_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/hash_division.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | .map(|&x| x == (start % 2 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `start.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/label_edges.rs:63:10 [INFO] [stdout] | [INFO] [stdout] 63 | if state.unlabeled_edges.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `state.unlabeled_edges.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/label_edges.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 74 | .or_else(|| state.unlabeled_edges.iter().next().map(|&x| x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `state.unlabeled_edges.iter().next().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/label_edges.rs:155:10 [INFO] [stdout] | [INFO] [stdout] 155 | if all_none.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!all_none.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/label_edges.rs:169:10 [INFO] [stdout] | [INFO] [stdout] 169 | if all_none.len() == 0 && (true_vecs_count != 2 || false_vecs_count != 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `all_none.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/svg.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | let height = (count + max_row_width - 1) / max_row_width; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `count.div_ceil(max_row_width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.38s [INFO] running `Command { std: "docker" "inspect" "6ee0c770d567d842fc31db3de421aa3a318f9578003df05021598ee8b187184c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ee0c770d567d842fc31db3de421aa3a318f9578003df05021598ee8b187184c", kill_on_drop: false }` [INFO] [stdout] 6ee0c770d567d842fc31db3de421aa3a318f9578003df05021598ee8b187184c