[INFO] cloning repository https://github.com/tiannian/haven [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tiannian/haven" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftiannian%2Fhaven", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftiannian%2Fhaven'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 18a08febfce4fb469bdcf7ac7da17dbb5b8b2b64 [INFO] linting tiannian/haven against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftiannian%2Fhaven" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tiannian/haven [INFO] finished tweaking git repo https://github.com/tiannian/haven [INFO] tweaked toml for git repo https://github.com/tiannian/haven written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tiannian/haven on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tiannian/haven already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded if-addrs v0.14.0 [INFO] [stderr] Downloaded cc v1.2.45 [INFO] [stderr] Downloaded hyper v1.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 302b46597f5d18049542f586f0dbbefe2c07cb75cd552a7be69c4ba7f472cf15 [INFO] running `Command { std: "docker" "start" "-a" "302b46597f5d18049542f586f0dbbefe2c07cb75cd552a7be69c4ba7f472cf15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "302b46597f5d18049542f586f0dbbefe2c07cb75cd552a7be69c4ba7f472cf15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "302b46597f5d18049542f586f0dbbefe2c07cb75cd552a7be69c4ba7f472cf15", kill_on_drop: false }` [INFO] [stdout] 302b46597f5d18049542f586f0dbbefe2c07cb75cd552a7be69c4ba7f472cf15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 339d3400363150639a4b159a18bde54bfb5790b8e63a926abfa559c0ad66627a [INFO] running `Command { std: "docker" "start" "-a" "339d3400363150639a4b159a18bde54bfb5790b8e63a926abfa559c0ad66627a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.4 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling aws-lc-rs v1.15.0 [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking rustls-pki-types v1.13.0 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking clap_builder v4.5.51 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking toml_writer v1.0.4 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling cc v1.2.45 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking if-addrs v0.14.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Checking serde_spanned v1.0.3 [INFO] [stderr] Checking toml_datetime v0.7.3 [INFO] [stderr] Compiling aws-lc-sys v0.33.0 [INFO] [stderr] Checking toml_parser v1.0.4 [INFO] [stderr] Checking toml v0.9.8 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking clap v4.5.51 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking haven-ddns v0.1.0 (/opt/rustwide/workdir/ddns/ddns) [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> ddns/ddns/src/config.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | .zip(other.record_name.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 74 - .zip(other.record_name.into_iter()) [INFO] [stdout] 74 + .zip(other.record_name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> ddns/ddns/src/config.rs:75:18 [INFO] [stdout] | [INFO] [stdout] 75 | .zip(other.record_interface.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 75 - .zip(other.record_interface.into_iter()) [INFO] [stdout] 75 + .zip(other.record_interface) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ddns/ddns/src/service.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | && !(ip.segments()[0] & 0xffc0 == 0xfe80) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ip.segments()[0] & 0xffc0 != 0xfe80)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ddns/ddns/src/service.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 184 | && !(ip.segments()[0] & 0xfe00 == 0xfc00) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ip.segments()[0] & 0xfe00 != 0xfc00)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> ddns/ddns/src/config.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | .zip(other.record_name.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 74 - .zip(other.record_name.into_iter()) [INFO] [stdout] 74 + .zip(other.record_name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> ddns/ddns/src/config.rs:75:18 [INFO] [stdout] | [INFO] [stdout] 75 | .zip(other.record_interface.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 75 - .zip(other.record_interface.into_iter()) [INFO] [stdout] 75 + .zip(other.record_interface) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ddns/ddns/src/service.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | && !(ip.segments()[0] & 0xffc0 == 0xfe80) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ip.segments()[0] & 0xffc0 != 0xfe80)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ddns/ddns/src/service.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 184 | && !(ip.segments()[0] & 0xfe00 == 0xfc00) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ip.segments()[0] & 0xfe00 != 0xfc00)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking hyper v1.8.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking haven-proxy v0.1.0 (/opt/rustwide/workdir/haven-proxy) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> haven-proxy/src/config.rs:65:36 [INFO] [stdout] | [INFO] [stdout] 65 | let cert_file = File::open(&self.cert_path()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `self.cert_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> haven-proxy/src/config.rs:73:35 [INFO] [stdout] | [INFO] [stdout] 73 | let key_file = File::open(&self.key_path()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.key_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> haven-proxy/src/proxy.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | let https_addr = https_addr.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*https_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> haven-proxy/src/proxy.rs:33:25 [INFO] [stdout] | [INFO] [stdout] 33 | let http_addr = http_addr.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*http_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> haven-proxy/src/config.rs:65:36 [INFO] [stdout] | [INFO] [stdout] 65 | let cert_file = File::open(&self.cert_path()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `self.cert_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> haven-proxy/src/config.rs:73:35 [INFO] [stdout] | [INFO] [stdout] 73 | let key_file = File::open(&self.key_path()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.key_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> haven-proxy/src/proxy.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | let https_addr = https_addr.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*https_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> haven-proxy/src/proxy.rs:33:25 [INFO] [stdout] | [INFO] [stdout] 33 | let http_addr = http_addr.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*http_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking haven-cli v0.1.0 (/opt/rustwide/workdir/haven-cli) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.62s [INFO] running `Command { std: "docker" "inspect" "339d3400363150639a4b159a18bde54bfb5790b8e63a926abfa559c0ad66627a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "339d3400363150639a4b159a18bde54bfb5790b8e63a926abfa559c0ad66627a", kill_on_drop: false }` [INFO] [stdout] 339d3400363150639a4b159a18bde54bfb5790b8e63a926abfa559c0ad66627a